November 2022 - Koha-bugs - lists.koha-community.org

[Bug 32161] New: ErmEholdingsPackagesAgreement has wrong koha_object_class
by bugzilla-daemon＠bugs.koha-community.org 11 Nov '22

11 Nov '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32161 Bug ID: 32161 Summary: ErmEholdingsPackagesAgreement has wrong koha_object_class Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart+koha(a)gmail.com Reporter: jonathan.druart+koha(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org Depends on: 32030 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32030 [Bug 32030] Electronic resource management (ERM) -- You are receiving this mail because: You are watching all bug changes.

1 13

[Bug 26114] New: ILL should mark status=RET only if a return happened
by bugzilla-daemon＠bugs.koha-community.org 11 Nov '22

11 Nov '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26114 Bug ID: 26114 Summary: ILL should mark status=RET only if a return happened Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: ILL Assignee: koha-bugs(a)lists.koha-community.org Reporter: tomascohen(a)gmail.com When the C4::Circulation::AddReturn reaches the ILL request update, there are many circumstances under which no return happened, and the ILL code doesn't check that. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 17

[Bug 24461] New: Add to_api_mapping to Koha::Acquisition::BasketGroup
by bugzilla-daemon＠bugs.koha-community.org 11 Nov '22

11 Nov '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24461 Bug ID: 24461 Summary: Add to_api_mapping to Koha::Acquisition::BasketGroup Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: REST API Assignee: koha-bugs(a)lists.koha-community.org Reporter: tomascohen(a)gmail.com We need those mappings for the API. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 14

[Bug 24369] New: Add ability to set CORS header in Koha
by bugzilla-daemon＠bugs.koha-community.org 11 Nov '22

11 Nov '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24369 Bug ID: 24369 Summary: Add ability to set CORS header in Koha Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: kyle(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org The reports API can produce JSON that would be useful on other library related websites, but the use of it appears to be blocked by default via CORS. It would be nice if there were a Koha syspref to set the CORS header rather than mucking about with htaccess files and whatnot. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 30

[Bug 24321] New: Make objects.search use mappings from Koha::Object(s)
by bugzilla-daemon＠bugs.koha-community.org 11 Nov '22

11 Nov '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24321 Bug ID: 24321 Summary: Make objects.search use mappings from Koha::Object(s) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: REST API Assignee: koha-bugs(a)lists.koha-community.org Reporter: tomascohen(a)gmail.com Now Koha::Object(s) implement 'to_api' and 'attributes_from_api' there's no need to implement such mappings on the controllers for simple Koha::Object<->API conversions. The to_api mappings have already been moved to Koha::Object level. It is time for the to_model ones. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 105

[Bug 22280] New: The ILL module assumes every status needs a next/previous status
by bugzilla-daemon＠bugs.koha-community.org 11 Nov '22

11 Nov '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22280 Bug ID: 22280 Summary: The ILL module assumes every status needs a next/previous status Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: ILL Assignee: koha-bugs(a)lists.koha-community.org Reporter: magnus(a)libriotech.no Target Milestone: --- Swedish ILL is very centrally driven, so some status changes are only done by updates from the API. That means that these statuses do not need a prev_actions or a next_actions: IN_NEG => { prev_actions => [ ], id => 'IN_NEG', name => 'Inlån Negativt svar', ui_method_name => 'Negativt svar', method => 'requestitem', next_actions => [ ], ui_method_icon => 'fa-send-o' }, But leaving these blank as above leads to errors, around line 386 of /usr/share/koha/lib/Koha/Illrequest.pm: # Update all core methods' next_actions. foreach my $prev_action ( @{$backend_status->{prev_actions}} ) { if ( grep $prev_action, @core_status_ids ) { my @next_actions = @{$status_graph->{$prev_action}->{next_actions}}; ### ERROR HERE push @next_actions, $backend_status_key; $status_graph->{$prev_action}->{next_actions} = \@next_actions; } } # Update all core methods' prev_actions foreach my $next_action ( @{$backend_status->{next_actions}} ) { if ( grep $next_action, @core_status_ids ) { my @prev_actions = @{$status_graph->{$next_action}->{prev_actions}}; ### AND HERE push @prev_actions, $backend_status_key; $status_graph->{$next_action}->{prev_actions} = \@prev_actions; } } The error is something like "Can't treat an undefined value as an array". Changing those lines to check if an array is defined makes the error go away, and I have not seen any bad side effects: @{$status_graph->{$prev_action}->{next_actions}} if $status_graph->{$prev_action}->{next_actions}; ### NO MORE ERROR HERE @{$status_graph->{$next_action}->{prev_actions}} if $status_graph->{$next_action}->{prev_actions}; ### OR HERE Does that change make sense to others, or am I missing some other way to work around this? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 27

[Bug 22196] New: Clean up Mana KB administration template
by bugzilla-daemon＠bugs.koha-community.org 11 Nov '22

11 Nov '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22196 Bug ID: 22196 Summary: Clean up Mana KB administration template Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org Depends on: 17047 Target Milestone: --- There are some markup and content corrections to be made to the Mana KB administration template. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 [Bug 17047] Mana Knowledge Base : share data -- You are receiving this mail because: You are watching all bug changes.

1 25

[Bug 20260] New: Use CodeMirror for the SQL reports editor
by bugzilla-daemon＠bugs.koha-community.org 11 Nov '22

11 Nov '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20260 Bug ID: 20260 Summary: Use CodeMirror for the SQL reports editor Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Reports Assignee: koha-bugs(a)lists.koha-community.org Reporter: magnus(a)libriotech.no QA Contact: testopia(a)bugs.koha-community.org We are already using CodeMirror (http://codemirror.net) somewhere. I would guess in Rancor, the advanced cataloguing editor. How about also using it for syntax highlighting when editing the SQL of an SQL report? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 28

[Bug 21725] New: Incorrect HAVING in group by in Acquisitions.pm
by bugzilla-daemon＠bugs.koha-community.org 11 Nov '22

11 Nov '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21725 Bug ID: 21725 Summary: Incorrect HAVING in group by in Acquisitions.pm Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Acquisitions Assignee: koha-bugs(a)lists.koha-community.org Reporter: nick(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org prove -v t/db_dependent/Acquisition/GetBasketsInfosByBookseller.t DBD::mysql::st execute failed: Non-grouping field 'expected_items' is used in HAVING clause [for Statement " SELECT aqbasket.basketno, aqbasket.basketname, aqbasket.note, aqbasket.booksellernote, aqbasket.contractnumber, aqbasket.creationdate, aqbasket.closedate, aqbasket.booksellerid, aqbasket.authorisedby, aqbasket.booksellerinvoicenumber, aqbasket.basketgroupid, aqbasket.deliveryplace, aqbasket.billingplace, aqbasket.branch, aqbasket.is_standing, aqbasket.create_items, SUM(aqorders.quantity) AS total_items, SUM( IF ( aqorders.orderstatus = 'cancelled', aqorders.quantity, 0 ) ) AS total_items_cancelled, COUNT(DISTINCT aqorders.biblionumber) AS total_biblios, SUM( IF(aqorders.datereceived IS NULL AND (aqorders.datecancellationprinted IS NULL OR aqorders.datecancellationprinted='0000-00-00') , aqorders.quantity , 0) ) AS expected_items FROM aqbasket LEFT JOIN aqorders ON aqorders.basketno = aqbasket.basketno WHERE booksellerid = ? GROUP BY aqbasket.basketno, aqbasket.basketname, aqbasket.note, aqbasket.booksellernote, aqbasket.contractnumber, aqbasket.creationdate, aqbasket.closedate, aqbasket.booksellerid, aqbasket.authorisedby, aqbasket.booksellerinvoicenumber, aqbasket.basketgroupid, aqbasket.deliveryplace, aqbasket.billingplace, aqbasket.branch, aqbasket.is_standing, aqbasket.create_items HAVING (closedate IS NULL OR (expected_items > 0))" with ParamValues: 0='359'] at /home/vagrant/kohaclone/C4/Acquisition.pm line 719. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 16

[Bug 27927] New: longoverdue cronjob renews items before marking lost when both RenewAccruingItemWhenPaid and WhenLostForgiveFine are enabled
by bugzilla-daemon＠bugs.koha-community.org 11 Nov '22

11 Nov '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27927 Bug ID: 27927 Summary: longoverdue cronjob renews items before marking lost when both RenewAccruingItemWhenPaid and WhenLostForgiveFine are enabled Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Fines and fees Assignee: koha-bugs(a)lists.koha-community.org Reporter: nick(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org longoverdue.pl calls 'LostItem' C4::Circulation::LostItem calls _FixOverduesOnReturn C4::Circulation::_FixOverduesOnReturn create a Koha::Account::Line for the amount of the accruing fine and calls apply passing the existing fine Koha::Account::Line calls renew_item when the fee is paid The item is then renewed, a notice (potentially) sent, and then the item marked lost and charged The sending of a renewal notice is quite confusing to patrons -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 34