November 2022 - Koha-bugs - lists.koha-community.org

[Bug 8948] MARC21 field 787 doesn't display
by bugzilla-daemon＠bugs.koha-community.org 03 Nov '22

03 Nov '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8948 --- Comment #23 from David Nind <david(a)davidnind.com> --- The link for the OPAC results in a 404 error. The link should start with ../cgi-bin/koha/opac-search.pl?.. instead of ../cgi-bin/koha/catalogue/search.pl?.. ? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8948] MARC21 field 787 doesn't display
by bugzilla-daemon＠bugs.koha-community.org 03 Nov '22

03 Nov '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8948 --- Comment #22 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 143084 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143084&action=e… Bug 8948: Changes for OPAC Test with same record, confirm OPAC view is as expected -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8948] MARC21 field 787 doesn't display
by bugzilla-daemon＠bugs.koha-community.org 03 Nov '22

03 Nov '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8948 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142791|0 |1 is obsolete| | --- Comment #21 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 143083 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143083&action=e… Bug 8948: Display MARC 787 relationship field This field is defined similar to 775, as a related work: https://www.loc.gov/marc/bibliographic/bd787.html This patch adds a display of this field, linking to the referenced record as the 775 does It also tests for 580 field, and displays the text there if present, using the 787 a and t subfields otherwise To test: 1 - Edit the default framework to make 787atw and 580a visible in editor 2 - Add a 787 to a record: $tThe ideas behind the chess openings $aFine, Reuben< $w2470231 3 - Confirm there is no display 4 - Apply patch / restart all 5 - 'Other related works' now shows 6 - Link should be using title of record 7 - Set system preference UseControlNumber to Use 8 - Reload details, link should now use control number 9 - Add a 580 to the record: $a This is a friendly work to this one 10 - Confirm the text of the link now displays before the link 11 - Add a second 580, confirm it displays as well - there is no seperator as each should end with a period or other punctuation according to MARC - there is a dpan with a class surrounding each so styling can be added as desired 12 - Add a second 787 - confirm seperator present and wrapped in a span with a class - confirm each 787 is shown with a span/class for styling -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8948] MARC21 field 787 doesn't display
by bugzilla-daemon＠bugs.koha-community.org 03 Nov '22

03 Nov '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8948 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 32084] New: GetMaxPatronHoldsForRecord is incorrect and inefficient
by bugzilla-daemon＠bugs.koha-community.org 03 Nov '22

03 Nov '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32084 Bug ID: 32084 Summary: GetMaxPatronHoldsForRecord is incorrect and inefficient Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Hold requests Assignee: koha-bugs(a)lists.koha-community.org Reporter: nick(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com This routine claims to return the max number of holds a patron can place on a record, however, it does not take into account whether a patron can hold an itemtype or not, so may be inflating the maximum number when the patron cannot in fact hold those items Additionally, the routine makes a call for effective circulation rule per item. We really only need to call once per itemtype and branch combination - if reserves control branch is 'patrons library' then it is really only once per itemtype on the biblio -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 1

[Bug 32083] New: POD for GetMaxPatronHoldsForRecord references ReservesControlBranch
by bugzilla-daemon＠bugs.koha-community.org 03 Nov '22

03 Nov '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32083 Bug ID: 32083 Summary: POD for GetMaxPatronHoldsForRecord references ReservesControlBranch Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Hold requests Assignee: koha-bugs(a)lists.koha-community.org Reporter: nick(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com Example usage names wrong routine 2331 =head2 GetMaxPatronHoldsForRecord 2332 2333 my $holds_per_record = ReservesControlBranch( $borrowernumber, $biblionumber ); -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 1

[Bug 32082] New: CanBookBeReserved with itype option is a different subroutine and should be split out
by bugzilla-daemon＠bugs.koha-community.org 03 Nov '22

03 Nov '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32082 Bug ID: 32082 Summary: CanBookBeReserved with itype option is a different subroutine and should be split out Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Hold requests Assignee: koha-bugs(a)lists.koha-community.org Reporter: nick(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com The call to this routine with param itemtype is self contained code that in fact checks CanItemtypeBeReserved Calling it as CanBookBeReturned passes ReservesControlBranch as pickup_location - it's a bad smell -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 1

[Bug 13600] XSLT: 8xx not showing if there is no 4xx
by bugzilla-daemon＠bugs.koha-community.org 03 Nov '22

03 Nov '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13600 --- Comment #45 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 143069 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143069&action=e… Bug 13600: (follow-up) Add seperator on the OPAC -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 5276] subscription end date shouldn't be required / allow indefinite subscriptions
by bugzilla-daemon＠bugs.koha-community.org 03 Nov '22

03 Nov '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5276 Michaela Sieber <michaela.sieber(a)kit.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |michaela.sieber(a)kit.edu -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13600] XSLT: 8xx not showing if there is no 4xx
by bugzilla-daemon＠bugs.koha-community.org 03 Nov '22

03 Nov '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13600 --- Comment #44 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Do we need the separator (last patch) for the OPAC too? -- You are receiving this mail because: You are watching all bug changes.

1 0