December 2022 - Koha-bugs - lists.koha-community.org

[Bug 7376] Transfer limits should be checked at check-in
by bugzilla-daemon＠bugs.koha-community.org 06 Dec '22

06 Dec '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7376 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120902|0 |1 is obsolete| | --- Comment #118 from Julian Maurice <julian.maurice(a)biblibre.com> --- Created attachment 144440 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144440&action=e… Bug 7376: Clarify tests further We want to prevent returns where the item cannot be transfered 'back to where it came from (be that Homebranch or Holdingbranch as defined respectively in the circulation rules). This patch clarifies the tests further by testing this transfer functionality distinctly from the 'AllowReturnToBranch' preference functionality. Signed-off-by: Julian Maurice <julian.maurice(a)biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7376] Transfer limits should be checked at check-in
by bugzilla-daemon＠bugs.koha-community.org 06 Dec '22

06 Dec '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7376 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120901|0 |1 is obsolete| | --- Comment #117 from Julian Maurice <julian.maurice(a)biblibre.com> --- Created attachment 144439 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144439&action=e… Bug 7376: (follow-up) Fix C4/Circulation.pm This follow-up patch actually fixes the issue. This patch forbids a patron to return a book to a library from where the book may not return to its home or holding library. Signed-off-by: Julian Maurice <julian.maurice(a)biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7376] Transfer limits should be checked at check-in
by bugzilla-daemon＠bugs.koha-community.org 06 Dec '22

06 Dec '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7376 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120900|0 |1 is obsolete| | --- Comment #116 from Julian Maurice <julian.maurice(a)biblibre.com> --- Created attachment 144438 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144438&action=e… Bug 7376: (follow-up) Make extended tests mock the actual desired behaviour Signed-off-by: Julian Maurice <julian.maurice(a)biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7376] Transfer limits should be checked at check-in
by bugzilla-daemon＠bugs.koha-community.org 06 Dec '22

06 Dec '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7376 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120899|0 |1 is obsolete| | --- Comment #115 from Julian Maurice <julian.maurice(a)biblibre.com> --- Created attachment 144437 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144437&action=e… Bug 7376: (follow-up) Extend test coverage and document I'm not sure about the requirements for this bug. This patch extends the tests to cover the new combinations introduced and highlights exactly what changes in the logic.. which appears to be fairly little. Signed-off-by: Julian Maurice <julian.maurice(a)biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7376] Transfer limits should be checked at check-in
by bugzilla-daemon＠bugs.koha-community.org 06 Dec '22

06 Dec '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7376 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120898|0 |1 is obsolete| | --- Comment #114 from Julian Maurice <julian.maurice(a)biblibre.com> --- Created attachment 144436 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144436&action=e… Bug 7376: Unit test Signed-off-by: Julian Maurice <julian.maurice(a)biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7376] Transfer limits should be checked at check-in
by bugzilla-daemon＠bugs.koha-community.org 06 Dec '22

06 Dec '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7376 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120897|0 |1 is obsolete| | --- Comment #113 from Julian Maurice <julian.maurice(a)biblibre.com> --- Created attachment 144435 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144435&action=e… Bug 7376: Transfer limits should be checked at check-in Test case: * UseBranchTransferLimits must be set * define your branch transfer limit. Refuse transfers from libraryA to libraryB * checkout a book owned by libraryB, from libraryB, with a librarian located at libraryB * move the librarian to libraryA ("Set Library" link top/right) * check-in the book => it's possible whatever your setup After the patch, the behaviour respect the branch transfer limit parameter: you can check-in if you accept transfers, you can't if you refuse them. (Note: IndependantBranches must be OFF, otherwise it's not possible to do the checkin whatever the branch transfer limits) Sponsored-by: National Library of Finland Signed-off-by: Arthur Suzuki <arthur.suzuki(a)biblibre.com> Signed-off-by: Julian Maurice <julian.maurice(a)biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7376] Transfer limits should be checked at check-in
by bugzilla-daemon＠bugs.koha-community.org 06 Dec '22

06 Dec '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7376 --- Comment #112 from Julian Maurice <julian.maurice(a)biblibre.com> --- (In reply to Katrin Fischer from comment #96) > Testing this: > > - Activate branch transfers > - Library Centerville DISALLOWS transfer to Fairview > - Library Fairview ALLOWS transfer to Centerville > > Without previous checkout! Just doing a checkin. > > Test A: > Checkin of Fairview item in Centerville > Transfer is allowed, correct. Returning a Fairview item in Centerville should trigger a transfer from Centerville to Fairview, right ? That transfer is forbidden. I don't understand why you expect the transfer to be allowed in that case. > > Test B: > Checkin of Centerville item in Fairview. > Transfer is allowed - that wasn't the result I expected. This makes sense to me, the transfer from Fairview to Centerville is allowed > > This is a Centerville item. Centerville hasn't permitted it's items to go to > Fairview - so should the transfer not be blocked? I think there is a little bit of confusion over two different things: 1) Is it allowed to return item I to library L ? (which is controlled by syspref AllowReturnToBranch) 2) Is item I allowed to be transferred from library L1 to library L2 ? (controlled by transfer limits and related sysprefs) It looks like you are testing 1 whereas the patch is about 2. It worked fine for me. Here's what I did: 1. Set syspref AllowReturnToBranch = "to any library" 2. Set syspref UseBranchTransferLimits = "Enforce" 3. Set syspref BranchTransferLimitsType = "item type" 4. Create an item (itemtype BOOK, homebranch Centerville, holdingbranch Centerville) 5. Disable all transfers for item type BOOK 6. Set library to Fairfield 7. Checkin the item => checkin is blocked (message: "This item must be checked in at following library: Centerville) On master, the checkin is allowed and it starts a transfer from Fairfield to Centerville, which is forbidden) 8. If I enable the transfer from Fairfield to Centerville for BOOK, the checkin is allowed. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11583] Add WYSIWYG editor for HTML notices/letters
by bugzilla-daemon＠bugs.koha-community.org 06 Dec '22

06 Dec '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11583 David Cook <dcook(a)prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |WISHLIST --- Comment #4 from David Cook <dcook(a)prosentient.com.au> --- Closing this due to age. I'm unlikely to work on it again. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12722] bulkmarcimport.pl: Should we move the old 001 to 035 ?
by bugzilla-daemon＠bugs.koha-community.org 06 Dec '22

06 Dec '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12722 David Cook <dcook(a)prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |WISHLIST --- Comment #14 from David Cook <dcook(a)prosentient.com.au> --- Closing this one due to age, but happy for someone else to take it over -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15537] Hide records on Leader 05 = d in OPAC
by bugzilla-daemon＠bugs.koha-community.org 06 Dec '22

06 Dec '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15537 David Cook <dcook(a)prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution|--- |WISHLIST --- Comment #18 from David Cook <dcook(a)prosentient.com.au> --- Closing this due to age -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 0