February 2022 - Koha-bugs - lists.koha-community.org

[Bug 29702] New: all_libraries routine in library groups make a DB call per member of group
by bugzilla-daemon＠bugs.koha-community.org 11 Feb '22

11 Feb '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29702 Bug ID: 29702 Summary: all_libraries routine in library groups make a DB call per member of group Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: nick(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org The current code gets all group members, then loops through and fetches the library if there is a branchcode, or recursivley calls itself if a group. This slows down performance To recreate: 1 - Add 100 items to a biblio 2 - Define a library group as a hold group 3 - Add all libraries to the group 4 - Set 'Default checkout, hold and return policy'->'Hold pickup library match' = 'Any library' 5 - place a hold on the record and note load time after patron is selected 6 - Set 'Default checkout, hold and return policy'->'Hold pickup library match' = 'Patrons hold group' 7 - place a hold, note longer load time after patron selection -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 16

[Bug 29476] New: Earliest renewal date is displayed wrong in circ/renew.pl for issues with auto renewing
by bugzilla-daemon＠bugs.koha-community.org 11 Feb '22

11 Feb '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29476 Bug ID: 29476 Summary: Earliest renewal date is displayed wrong in circ/renew.pl for issues with auto renewing Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs(a)lists.koha-community.org Reporter: joonas.kylmala(a)iki.fi QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com The code in circ/renew.pl uses the code C4::Circulation::GetSoonestRenewDate to check the soonest renewal date and then displays it to the librarian. However, the code called by CanBookBeRenewed() that actually does the final check uses different calculation method for issues with auto renewal enabled. For auto renewed issues without circulation rules defined for soonest renewal date the soonest renewal date is the due date, in normal loans case the soonest renewal date is NOW(). This is not probably a too big annoyance to librarians, I just wanna clean up this so I can refactor some code in CanBookBeRenewed, will attach a patch shortly. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 31

[Bug 29530] New: When NumSavedReports is set, show value in pull down of entries
by bugzilla-daemon＠bugs.koha-community.org 11 Feb '22

11 Feb '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29530 Bug ID: 29530 Summary: When NumSavedReports is set, show value in pull down of entries Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Reports Assignee: koha-bugs(a)lists.koha-community.org Reporter: katrin.fischer(a)bsz-bw.de QA Contact: testopia(a)bugs.koha-community.org When NumSavedReports is set to a value, the list of reports defaults to the set number of reports showing on a page, but the pull down of settings for per page entries will be empty. So after changing the value, you cannot reset it. We should make the entry show up there as well (if it doesn't match one of the existing already). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 23

[Bug 29779] New: selenium/regressions.t fails if Selenium lib is not installed
by bugzilla-daemon＠bugs.koha-community.org 11 Feb '22

11 Feb '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29779 Bug ID: 29779 Summary: selenium/regressions.t fails if Selenium lib is not installed Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: major Priority: P5 - low Component: Test Suite Assignee: jonathan.druart+koha(a)gmail.com Reporter: jonathan.druart+koha(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org t/db_dependent/selenium/regressions.t .. 1/7 Label not found for "last SKIP" at /usr/share/perl/5.28/Test/More.pm line 1370. -- You are receiving this mail because: You are watching all bug changes.

1 10

[Bug 29759] New: Revert credit when cancelling an article request
by bugzilla-daemon＠bugs.koha-community.org 11 Feb '22

11 Feb '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29759 Bug ID: 29759 Summary: Revert credit when cancelling an article request Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Fines and fees Assignee: koha-bugs(a)lists.koha-community.org Reporter: tomascohen(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org Bug 27946 adds the ability to charge a fee when the patron makes an article request. This development will make the fee be reverted. Reversible credits will generate a refund. Methods introduced by bug 29757 will be used. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 42

[Bug 12029] Patrons should be able to delete their patron messages
by bugzilla-daemon＠bugs.koha-community.org 11 Feb '22

11 Feb '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130515|0 |1 is obsolete| | --- Comment #18 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 130516 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130516&action=e… Bug 12029: Patrons should be able to delete their patron messages This patch adds an option for patrons to dismiss OPAC messages sent to them by the staff. The messages remain visible in the staff interface with an indication that the message has been read. To test, apply the patch and run the database update. - View a patron record in the staff interface. - Click "Add message" and select "OPAC" from the "Add a message for..." dropdown. - Add a message. - Log in to the OPAC as that patron. - On the "Your summary" page you should see the message along with a "Dismiss" link." - Clicking the "Dismiss" link should make the message disappear. - Go to the OPAC home page. The "User summary" box in the right sidebar should have the correct count of messages. - View the patron record in the staff interface again. - The list of patron messages should still include the message which was dismissed via the OPAC, but there should be indication that the message was read, e.g. "read 11-2-2022" Signed-off-by: Lisette Scheer <lisetteslatah(a)gmail.com> Signed-off-by: Jason Robb <jrobb(a)sekls.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 29498] New: Remove usage of deprecated Mojolicious::Routes::Route::detour
by bugzilla-daemon＠bugs.koha-community.org 11 Feb '22

11 Feb '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29498 Bug ID: 29498 Summary: Remove usage of deprecated Mojolicious::Routes::Route::detour Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: julian.maurice(a)biblibre.com Reporter: julian.maurice(a)biblibre.com QA Contact: testopia(a)bugs.koha-community.org Mojolicious::Routes::Route::detour was deprecated in Mojolicious 8.67 and removed in Mojolicious 9 The method is used in Koha::App::Plugin::RESTV1 to connect the "REST API" Mojolicious app to the other Mojolicious apps (Koha::App::Intranet and Koha::App::Opac), so it's only a problem when running Koha as a Mojolicious app. -- You are receiving this mail because: You are watching all bug changes.

1 10

[Bug 12029] Patrons should be able to delete their patron messages
by bugzilla-daemon＠bugs.koha-community.org 11 Feb '22

11 Feb '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029 Lisette Scheer <lisetteslatah(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #17 from Lisette Scheer <lisetteslatah(a)gmail.com> --- Worked great. I also ran a report: SELECT * FROM messages WHERE borrowernumber="51" and the patron_read_date was included: 2022-02-11 17:16:58. I know we have plenty of patrons who will be excited about this. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12029] Patrons should be able to delete their patron messages
by bugzilla-daemon＠bugs.koha-community.org 11 Feb '22

11 Feb '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130514|0 |1 is obsolete| | --- Comment #16 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 130515 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130515&action=e… Bug 12029: Patrons should be able to delete their patron messages This patch adds an option for patrons to dismiss OPAC messages sent to them by the staff. The messages remain visible in the staff interface with an indication that the message has been read. To test, apply the patch and run the database update. - View a patron record in the staff interface. - Click "Add message" and select "OPAC" from the "Add a message for..." dropdown. - Add a message. - Log in to the OPAC as that patron. - On the "Your summary" page you should see the message along with a "Dismiss" link." - Clicking the "Dismiss" link should make the message disappear. - Go to the OPAC home page. The "User summary" box in the right sidebar should have the correct count of messages. - View the patron record in the staff interface again. - The list of patron messages should still include the message which was dismissed via the OPAC, but there should be indication that the message was read, e.g. "read 11-2-2022" Signed-off-by: Lisette Scheer <lisetteslatah(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12029] Patrons should be able to delete their patron messages
by bugzilla-daemon＠bugs.koha-community.org 11 Feb '22

11 Feb '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12029 --- Comment #15 from Owen Leonard <oleonard(a)myacpl.org> --- Created attachment 130514 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130514&action=e… Bug 12029: Patrons should be able to delete their patron messages This patch adds an option for patrons to dismiss OPAC messages sent to them by the staff. The messages remain visible in the staff interface with an indication that the message has been read. To test, apply the patch and run the database update. - View a patron record in the staff interface. - Click "Add message" and select "OPAC" from the "Add a message for..." dropdown. - Add a message. - Log in to the OPAC as that patron. - On the "Your summary" page you should see the message along with a "Dismiss" link." - Clicking the "Dismiss" link should make the message disappear. - Go to the OPAC home page. The "User summary" box in the right sidebar should have the correct count of messages. - View the patron record in the staff interface again. - The list of patron messages should still include the message which was dismissed via the OPAC, but there should be indication that the message was read, e.g. "read 11-2-2022" -- You are receiving this mail because: You are watching all bug changes.

1 0