May 2022 - Koha-bugs - lists.koha-community.org

[Bug 30386] New: Prevent search errors if deleted record still remains in search indexes
by bugzilla-daemon＠bugs.koha-community.org 12 May '22

12 May '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30386 Bug ID: 30386 Summary: Prevent search errors if deleted record still remains in search indexes Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: kyle(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org If a bib is deleted, but for some reason doesn't get deleted from the search indexes, any search where that record is a result will produce the error: Can't call method "items" on an undefined value at /usr/share/koha/lib/C4/Search.pm line 2064. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 7

[Bug 30743] New: Adding a library does not update the transport cost matrix
by bugzilla-daemon＠bugs.koha-community.org 12 May '22

12 May '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30743 Bug ID: 30743 Summary: Adding a library does not update the transport cost matrix Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: nick(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org To test: 1 - View the transport cost matrix 2 - Add some values 3 - Add a new library 4 - View the matrix, not new library appears disabled in all columns 5 - Run the holds queue - there is a warning: Use of uninitialized value in numeric ne (!=) at /usr/share/koha/lib/C4/HoldsQueue.pm line 811. 6 - Hit save on the matrix 7 - View the DB and note new library is disabled in all columns 8 - Run holds queue - they don't get any holds IDK the correct default, but this seems problematic, maybe we need to add a warning when adding libraries to system, or disable them by default actually? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 1

[Bug 26378] New: Show SerialIssueDisplayCount syspref values in subscription-add.pl
by bugzilla-daemon＠bugs.koha-community.org 12 May '22

12 May '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26378 Bug ID: 26378 Summary: Show SerialIssueDisplayCount syspref values in subscription-add.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Serials Assignee: koha-bugs(a)lists.koha-community.org Reporter: andrew(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org CC: colin.campbell(a)ptfs-europe.com When setting up a new subscription, one can set values for "Number of issues to display to staff" and "Number of issues to display to the public." If you don't set these in a specific subscription, then they fall back to the values in the system preferences StaffSerialIssueDisplayCount and OPACSerialIssueDisplayCount, respectively. It'd be good to add a note along the lines of "If unset, will default to the value in StaffSerialIssueDisplayCount (X)," where X is the value from the syspref. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 2

[Bug 12446] Enable an adult to have a guarantor
by bugzilla-daemon＠bugs.koha-community.org 12 May '22

12 May '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 --- Comment #195 from Shi Yao Wang <shi-yao.wang(a)inLibro.com> --- Rebased -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12446] Enable an adult to have a guarantor
by bugzilla-daemon＠bugs.koha-community.org 12 May '22

12 May '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 Shi Yao Wang <shi-yao.wang(a)inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #133957|0 |1 is obsolete| | --- Comment #194 from Shi Yao Wang <shi-yao.wang(a)inLibro.com> --- Created attachment 134936 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134936&action=e… Bug 12446: Fixing QA tool's tests This patch fixes tests that fails by the QA test tool. I removed the debug variable, since it is not used. I also got a few spelling check errors when I ran the QA test tool. I corrected them too. To test: 1) Create an Adult AND Child category in Administration/Patron categories 2) Create a child AND adult patron. 3) Go in your child patron's page. 4) Click on "Edit". 5) Notice that you can add a guarantor with "Add guarantor" button. 6) Go in your adult patron's page. 7) Click on "Edit". 8) Notice that there is no "Add guarantor" button. Therefore, you can't add a guarantor for this patron. 9) Apply patch and run updatedatabase.pl 10) Go in Administration/Patron categories and edit one of them. 12) Notice that you can see the new "Can be guarantee" field. 13) Set "Yes" on the "Can be guarantee" field for your Child AND Adult category. 14) Repeat steps 6 to 7. 15) Notice that your adult patron can now add guarantors with the "Add guarantor" button. 16) prove t/db_dependent/Patrons.t => All tests should still pass 17) Run the QA test tool. All tests should say OK Signed-off-by: Owen Leonard <oleonard(a)myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12446] Enable an adult to have a guarantor
by bugzilla-daemon＠bugs.koha-community.org 12 May '22

12 May '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 Shi Yao Wang <shi-yao.wang(a)inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #133956|0 |1 is obsolete| | --- Comment #193 from Shi Yao Wang <shi-yao.wang(a)inLibro.com> --- Created attachment 134935 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134935&action=e… Bug 12446: Any patron categories can have guarantors Rebase of previous patches This patch allows adult patrons to have guarantors. It adds the field "Can be guarantee" to patron categories, so it becomes possible for any category type to have a guarantor. NOTE: Attachment "Bug 12446: Adult can now have guarantors" created a sha1 error. I marked it as obsolete and put it's content into a new commit. To test: 1) Create an Adult AND Child category in Administration/Patron categories 2) Create a child AND adult patron. 3) Go in your child patron's page. 4) Click on "Edit". 5) Notice that you can add a guarantor with "Add guarantor" button. 6) Go in your adult patron's page. 7) Click on "Edit". 8) Notice that there is no "Add guarantor" button. Therefore, you can't add a guarantor for this patron. 9) Apply patch and run updatedatabase.pl 10) Go in Administration/Patron categories and edit one of them. 12) Notice that you can see the new "Can be guarantee" field. 13) Set "Yes" gor the "Can be guarantee" field for your Child AND Adult category. 14) Repeat steps 6 to 7. 15) Notice that your adult patron can now add guarantors with the "Add guarantor" button. 16) prove t/db_dependent/Patrons.t => All tests should still pass Signed-off-by: Owen Leonard <oleonard(a)myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12446] Enable an adult to have a guarantor
by bugzilla-daemon＠bugs.koha-community.org 12 May '22

12 May '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 Shi Yao Wang <shi-yao.wang(a)inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #133955|0 |1 is obsolete| | --- Comment #192 from Shi Yao Wang <shi-yao.wang(a)inLibro.com> --- Created attachment 134934 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134934&action=e… Bug 12446: Add canbeguarantee value to patron categories sample data This patch changes sample data so patron categories of type 'C' or 'P' can be guarantees by default. Signed-off-by: Salman Ali <salman.ali(a)inlibro.com> Signed-off-by: Salman Ali <salman.ali(a)inlibro.com> Signed-off-by: David Nind <david(a)davidnind.com> Signed-off-by: Owen Leonard <oleonard(a)myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12446] Enable an adult to have a guarantor
by bugzilla-daemon＠bugs.koha-community.org 12 May '22

12 May '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 Shi Yao Wang <shi-yao.wang(a)inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #133954|0 |1 is obsolete| | --- Comment #191 from Shi Yao Wang <shi-yao.wang(a)inLibro.com> --- Created attachment 134933 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134933&action=e… Bug 12446: Limit available categories when using "Add guarantee" button Test plan: 1) Have some patron categories that can and cannot be guarantee 2) Visit a patron's account and click the "Add guarantee" button 3) In the "category" dropdown, note that all categories are available 4) Apply this patch 5) Repeat step 2 and 3; the dropdown now only contains the categories for which "can be guarantee" is set to "Yes". Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> Signed-off-by: David Nind <david(a)davidnind.com> Signed-off-by: Owen Leonard <oleonard(a)myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12446] Enable an adult to have a guarantor
by bugzilla-daemon＠bugs.koha-community.org 12 May '22

12 May '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 Shi Yao Wang <shi-yao.wang(a)inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #133953|0 |1 is obsolete| | --- Comment #190 from Shi Yao Wang <shi-yao.wang(a)inLibro.com> --- Created attachment 134932 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134932&action=e… Bug 12446: Schema update Category.pm Signed-off-by: David Nind <david(a)davidnind.com> Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> Signed-off-by: David Nind <david(a)davidnind.com> Signed-off-by: Owen Leonard <oleonard(a)myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12446] Enable an adult to have a guarantor
by bugzilla-daemon＠bugs.koha-community.org 12 May '22

12 May '22

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 Shi Yao Wang <shi-yao.wang(a)inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134930|0 |1 is obsolete| | --- Comment #189 from Shi Yao Wang <shi-yao.wang(a)inLibro.com> --- Created attachment 134931 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134931&action=e… Bug 12446: Ability to allow guarantor relationship for all patron category types This adds a new field "Can be guarantee" to patron categories so it becomes possible for any category type to have a guarantor. To test: 1) Have a patron category of type 'Adult' and one of type 'Child' 2) Confirm, by searching for the "Patron guarantor" fieldset in the edit/create form, that: => a patron of the first category can't have a guarantor => a patron from the second category can 3) Apply patch and run updatedatabase.pl 4) Edit the categories and note the new "Can be guarantee" field 5) It should have been set to "yes" for the "Child" and to "no" for the "Adult" 5) Repeat step 2. It should behave in the same way. 6) Edit the "Can be guarantee" for any of the category and check that the fieldset only appears when "Can be guarantee" is set to "yes" 7) prove t/db_dependent/Patrons.t => tests should still pass Signed-off-by: David Nind <david(a)davidnind.com> Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> Signed-off-by: David Nind <david(a)davidnind.com> Signed-off-by: Owen Leonard <oleonard(a)myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

1 0