January 2023 - Koha-bugs - lists.koha-community.org

[Bug 30825] New: Get rid of GetReservesControlBranch
by bugzilla-daemon＠bugs.koha-community.org 14 Oct '23

14 Oct '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30825 Bug ID: 30825 Summary: Get rid of GetReservesControlBranch Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: tomascohen(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org The method currently requires unblessed objects only to access one attribute on them... and it can certainly be moved to Koha::* -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 59

[Bug 32496] New: Reduce unnecessary unblessings of objects in Circulation.pm
by bugzilla-daemon＠bugs.koha-community.org 14 Oct '23

14 Oct '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32496 Bug ID: 32496 Summary: Reduce unnecessary unblessings of objects in Circulation.pm Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: glasklas(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org There are a lot of instances in of unnecessary unblesssings in Circulation.pm (and also in some other parts of the C4 namespace), for legacy reasons I assume as it was an convenient way not having to adept the code to much after changing to the object oriented interface. This patch builds on Bug 31735 and cleans up a large part, but not all, of these uncalled-for unblessings. I focused mainly on refactoring CanBookBeRenewed and the subroutines it calls as this is run for each checked out item and has on of the highest performance impacts of the circulation related subroutines. The performance gains are pretty modest though, so the main motivation is to clean up the code (and in some instances avoid having to re-fetch the object where a method needs to be called, and an unblessed hashref was passed in). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 62

[Bug 30700] New: Patrons who can log into staff client should be able to change their own password
by bugzilla-daemon＠bugs.koha-community.org 14 Oct '23

14 Oct '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30700 Bug ID: 30700 Summary: Patrons who can log into staff client should be able to change their own password Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs(a)lists.koha-community.org Reporter: aleisha(a)catalyst.net.nz QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com Patrons must have the additional borrowers->edit_borrowers subpermission to change other patron's passwords. This is fine, except if a patron has permission to log into the staff client but doesn't have borrowers permissions, they cannot change their own password via the staff client. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 43

[Bug 32410] New: Don't show AnonymousPatron borrowernumber on checkout history
by bugzilla-daemon＠bugs.koha-community.org 13 Oct '23

13 Oct '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32410 Bug ID: 32410 Summary: Don't show AnonymousPatron borrowernumber on checkout history Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs(a)lists.koha-community.org Reporter: magnus(a)libriotech.no QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com On the "Checkout history" for a record (/cgi-bin/koha/catalogue/issuehistory.pl?biblionumber=85452), there is a column called "Patron", which holds the borrowernumbers of the patrons that have borrowed items connected to the record. If old loans are anonymized, this will show the same borrowernumber as AnonymousPatron. If you do not remember the setting for AnonymousPatron you might not understand that the loans have been anonymized right away. It could be more helpful to display something like "Anonymized" instead of the AnonymousPatron borrowernumber. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 1

[Bug 26902] New: Add ability to flag a patron email address as possibly invalid
by bugzilla-daemon＠bugs.koha-community.org 12 Oct '23

12 Oct '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26902 Bug ID: 26902 Summary: Add ability to flag a patron email address as possibly invalid Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs(a)lists.koha-community.org Reporter: kyle(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com It would be beneficial if there was a way to flag email addresses in Koha as possibly invalid. That way, if a library receives a bounce-back for a given email, Koha could flag that email address as questionable. At that point, Koha could show an alert when checking out to that patron so the librarian can confirm the address is correct with the patron. An API endpoint that would accept an email address, find any instance of that email address in patron records, and flag it as potentially invalid would be very useful to integrate automation of converting bounce-back emails into warning flags in Koha. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 4

[Bug 32484] New: Enable framework plugins when UseACQFrameworkForBiblioRecords is set
by bugzilla-daemon＠bugs.koha-community.org 12 Oct '23

12 Oct '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32484 Bug ID: 32484 Summary: Enable framework plugins when UseACQFrameworkForBiblioRecords is set Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: julian.maurice(a)biblibre.com Reporter: julian.maurice(a)biblibre.com QA Contact: testopia(a)bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes.

1 34

[Bug 32668] New: Automatic updates for debian/control, on 'oldoldstable' branch
by bugzilla-daemon＠bugs.koha-community.org 11 Oct '23

11 Oct '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32668 Bug ID: 32668 Summary: Automatic updates for debian/control, on 'oldoldstable' branch Change sponsored?: --- Product: Koha Version: 21.11 Hardware: All OS: All Status: NEW Severity: blocker Priority: P5 - low Component: Packaging Assignee: koha-bugs(a)lists.koha-community.org Reporter: mtj(a)kohaaloha.com QA Contact: testopia(a)bugs.koha-community.org CC: mtj(a)kohaaloha.com this bug tracks automatic updates for debian/control, on 'oldoldstable' branch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 28

[Bug 29777] New: Fields 580 are wrong displayed in summary column
by bugzilla-daemon＠bugs.koha-community.org 11 Oct '23

11 Oct '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29777 Bug ID: 29777 Summary: Fields 580 are wrong displayed in summary column Change sponsored?: --- Product: Koha Version: 20.11 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: About Assignee: koha-bugs(a)lists.koha-community.org Reporter: jeremy.breuillard(a)biblibre.com QA Contact: testopia(a)bugs.koha-community.org In the results of an Authority searching we can see semicolon appears in 'Summary' column. It should be field 580 instead -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 14

[Bug 28564] New: "The many-to-many relationship * is trying to create a utility method" warning
by bugzilla-daemon＠bugs.koha-community.org 11 Oct '23

11 Oct '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28564 Bug ID: 28564 Summary: "The many-to-many relationship * is trying to create a utility method" warning Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: jonathan.druart+koha(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org I am not sure what triggered this output exactly. To recreate: git checkout this commit (not pushed yet): "Bug 28490: Add DBIx schema changes for testing" qa -c 5 -v 2 --failures It happens when reloading the module in koha-qa.pl: 103 delete $INC{$module}; 104 $module =~ s|/|::|g; 105 $module =~ s|\.pm$||; 106 eval "require $module"; 107 $module->import; During the require, but I cannot recreate in a separate test file. DBIx::Class::Relationship::ManyToMany::many_to_many(): *************************************************************************** The many-to-many relationship 'basketnoes' is trying to create a utility method called add_to_basketnoes. This will completely overwrite one such already existing method on class Koha::Schema::Result::Borrower. You almost certainly want to rename your method or the many-to-many relationship, as the functionality of the original method will not be accessible anymore. To disable this warning set to a true value the environment variable DBIC_OVERWRITE_HELPER_METHODS_OK *************************************************************************** DBIx::Class::Relationship::ManyToMany::many_to_many(): *************************************************************************** The many-to-many relationship 'basketnoes' is trying to create a utility method called remove_from_basketnoes. This will completely overwrite one such already existing method on class Koha::Schema::Result::Borrower. You almost certainly want to rename your method or the many-to-many relationship, as the functionality of the original method will not be accessible anymore. To disable this warning set to a true value the environment variable DBIC_OVERWRITE_HELPER_METHODS_OK *************************************************************************** DBIx::Class::Relationship::ManyToMany::many_to_many(): *************************************************************************** The many-to-many relationship 'basketnoes' is trying to create a utility method called set_basketnoes. This will completely overwrite one such already existing method on class Koha::Schema::Result::Borrower. You almost certainly want to rename your method or the many-to-many relationship, as the functionality of the original method will not be accessible anymore. To disable this warning set to a true value the environment variable DBIC_OVERWRITE_HELPER_METHODS_OK *************************************************************************** DBIx::Class::Relationship::ManyToMany::many_to_many(): *************************************************************************** The many-to-many relationship 'basketnoes' is trying to create a utility method called basketnoes_rs. This will completely overwrite one such already existing method on class Koha::Schema::Result::Borrower. You almost certainly want to rename your method or the many-to-many relationship, as the functionality of the original method will not be accessible anymore. To disable this warning set to a true value the environment variable DBIC_OVERWRITE_HELPER_METHODS_OK *************************************************************************** DBIx::Class::Relationship::ManyToMany::many_to_many(): *************************************************************************** The many-to-many relationship 'budgets' is trying to create a utility method called add_to_budgets. This will completely overwrite one such already existing method on class Koha::Schema::Result::Borrower. You almost certainly want to rename your method or the many-to-many relationship, as the functionality of the original method will not be accessible anymore. To disable this warning set to a true value the environment variable DBIC_OVERWRITE_HELPER_METHODS_OK *************************************************************************** DBIx::Class::Relationship::ManyToMany::many_to_many(): *************************************************************************** The many-to-many relationship 'budgets' is trying to create a utility method called remove_from_budgets. This will completely overwrite one such already existing method on class Koha::Schema::Result::Borrower. You almost certainly want to rename your method or the many-to-many relationship, as the functionality of the original method will not be accessible anymore. To disable this warning set to a true value the environment variable DBIC_OVERWRITE_HELPER_METHODS_OK *************************************************************************** DBIx::Class::Relationship::ManyToMany::many_to_many(): *************************************************************************** The many-to-many relationship 'budgets' is trying to create a utility method called set_budgets. This will completely overwrite one such already existing method on class Koha::Schema::Result::Borrower. You almost certainly want to rename your method or the many-to-many relationship, as the functionality of the original method will not be accessible anymore. To disable this warning set to a true value the environment variable DBIC_OVERWRITE_HELPER_METHODS_OK *************************************************************************** DBIx::Class::Relationship::ManyToMany::many_to_many(): *************************************************************************** The many-to-many relationship 'budgets' is trying to create a utility method called budgets_rs. This will completely overwrite one such already existing method on class Koha::Schema::Result::Borrower. You almost certainly want to rename your method or the many-to-many relationship, as the functionality of the original method will not be accessible anymore. To disable this warning set to a true value the environment variable DBIC_OVERWRITE_HELPER_METHODS_OK *************************************************************************** DBIx::Class::Relationship::ManyToMany::many_to_many(): *************************************************************************** The many-to-many relationship 'courses' is trying to create a utility method called add_to_courses. This will completely overwrite one such already existing method on class Koha::Schema::Result::Borrower. You almost certainly want to rename your method or the many-to-many relationship, as the functionality of the original method will not be accessible anymore. To disable this warning set to a true value the environment variable DBIC_OVERWRITE_HELPER_METHODS_OK *************************************************************************** DBIx::Class::Relationship::ManyToMany::many_to_many(): *************************************************************************** The many-to-many relationship 'courses' is trying to create a utility method called remove_from_courses. This will completely overwrite one such already existing method on class Koha::Schema::Result::Borrower. You almost certainly want to rename your method or the many-to-many relationship, as the functionality of the original method will not be accessible anymore. To disable this warning set to a true value the environment variable DBIC_OVERWRITE_HELPER_METHODS_OK *************************************************************************** DBIx::Class::Relationship::ManyToMany::many_to_many(): *************************************************************************** The many-to-many relationship 'courses' is trying to create a utility method called set_courses. This will completely overwrite one such already existing method on class Koha::Schema::Result::Borrower. You almost certainly want to rename your method or the many-to-many relationship, as the functionality of the original method will not be accessible anymore. To disable this warning set to a true value the environment variable DBIC_OVERWRITE_HELPER_METHODS_OK *************************************************************************** DBIx::Class::Relationship::ManyToMany::many_to_many(): *************************************************************************** The many-to-many relationship 'courses' is trying to create a utility method called courses_rs. This will completely overwrite one such already existing method on class Koha::Schema::Result::Borrower. You almost certainly want to rename your method or the many-to-many relationship, as the functionality of the original method will not be accessible anymore. To disable this warning set to a true value the environment variable DBIC_OVERWRITE_HELPER_METHODS_OK *************************************************************************** DBIx::Class::Relationship::ManyToMany::many_to_many(): *************************************************************************** The many-to-many relationship 'ordernumbers' is trying to create a utility method called add_to_ordernumbers. This will completely overwrite one such already existing method on class Koha::Schema::Result::Borrower. You almost certainly want to rename your method or the many-to-many relationship, as the functionality of the original method will not be accessible anymore. To disable this warning set to a true value the environment variable DBIC_OVERWRITE_HELPER_METHODS_OK *************************************************************************** DBIx::Class::Relationship::ManyToMany::many_to_many(): *************************************************************************** The many-to-many relationship 'ordernumbers' is trying to create a utility method called remove_from_ordernumbers. This will completely overwrite one such already existing method on class Koha::Schema::Result::Borrower. You almost certainly want to rename your method or the many-to-many relationship, as the functionality of the original method will not be accessible anymore. To disable this warning set to a true value the environment variable DBIC_OVERWRITE_HELPER_METHODS_OK *************************************************************************** DBIx::Class::Relationship::ManyToMany::many_to_many(): *************************************************************************** The many-to-many relationship 'ordernumbers' is trying to create a utility method called set_ordernumbers. This will completely overwrite one such already existing method on class Koha::Schema::Result::Borrower. You almost certainly want to rename your method or the many-to-many relationship, as the functionality of the original method will not be accessible anymore. To disable this warning set to a true value the environment variable DBIC_OVERWRITE_HELPER_METHODS_OK *************************************************************************** DBIx::Class::Relationship::ManyToMany::many_to_many(): *************************************************************************** The many-to-many relationship 'ordernumbers' is trying to create a utility method called ordernumbers_rs. This will completely overwrite one such already existing method on class Koha::Schema::Result::Borrower. You almost certainly want to rename your method or the many-to-many relationship, as the functionality of the original method will not be accessible anymore. To disable this warning set to a true value the environment variable DBIC_OVERWRITE_HELPER_METHODS_OK *************************************************************************** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 3

[Bug 29144] New: Make branches.opac_info suitable for multi language use
by bugzilla-daemon＠bugs.koha-community.org 10 Oct '23

10 Oct '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29144 Bug ID: 29144 Summary: Make branches.opac_info suitable for multi language use Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard(a)myacpl.org Reporter: m.de.rooy(a)rijksmuseum.nl QA Contact: testopia(a)bugs.koha-community.org opac-library page shows opac_info Would be nice to have in more than one language. What would be the best way to achieve that? [1] Move opac_info out of branches and add a table with branchcode, language and opac_info. Needs a separate admin page. [2] css/js fiddling: All stuff in opac_info. Show/hide blocks etc. [3] Your solution ? -- You are receiving this mail because: You are watching all bug changes.

1 94