January 2023 - Koha-bugs - lists.koha-community.org

[Bug 10762] Make it possible to adjust the barcode height and width on labels
by bugzilla-daemon＠bugs.koha-community.org 02 Jan '23

02 Jan '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10762 Thibaud Guillot <thibaud.guillot(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|cnighswonger(a)foundations.ed |thibaud.guillot(a)biblibre.co |u |m -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10762] Make it possible to adjust the barcode height and width on labels
by bugzilla-daemon＠bugs.koha-community.org 02 Jan '23

02 Jan '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10762 Thibaud Guillot <thibaud.guillot(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |thibaud.guillot(a)biblibre.co | |m --- Comment #16 from Thibaud Guillot <thibaud.guillot(a)biblibre.com> --- (In reply to Katrin Fischer from comment #13) > 1) QA test tools: > > FAIL installer/data/mysql/atomicupdate/update-BZ_10762.pl > FAIL file permissions > File must have the exec flag > > 2) See comment#11, it looks like the original value was 0.01: > > + scale_height => 0.02, > > - my $barcode_y_scale_factor = 0.01 * $self->{'height'}; # > this scales the barcode height to 10% of the label height > > 3) Defaults > > Just a question, maybe someone else can answer that one too: > > The patch adds the 2 new database columns with defaults 0.02 and 0.8 in the > database and also sets the defaults in new. > > Should we do both or would one option suffice? > > 4) Changes to kohastructure.sql are missing Hello Katrin, Normally I fixed this things on my last 'push' For default value (repeat in sql and view on 'sub new()' I'm not an expert but it like the same than 'layout_name' for example (set to 'DEFAULT' in default sql value and also in the template when we passed vars). I hope this will be okay for everyone :) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10762] Make it possible to adjust the barcode height and width on labels
by bugzilla-daemon＠bugs.koha-community.org 02 Jan '23

02 Jan '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10762 --- Comment #15 from Thibaud Guillot <thibaud.guillot(a)biblibre.com> --- Created attachment 144900 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144900&action=e… Bug 10762: (follow-up) Update test plan, add kohastructure.sql files I also change the default value for scale_height to '0.01' Test plan: 1)Home > Cataloguing > Tools: Label creator > Manage Layout or New Layout 2)Make a new layout or edit an existing one 3)Notice the 2 new fields "Barcode width/Barcode height" 4)Save it like this 5)Create a batch of barcode and export if in PDF 6)Notice the size of barcode 7)Go back to your existing layout 8)Enter some values (Barcode width: 1.6 / Barcode height: 0.02), save 9)Take back your batch of barcode and export it in PDF 10)The barcode should be 2x bigger -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10762] Make it possible to adjust the barcode height and width on labels
by bugzilla-daemon＠bugs.koha-community.org 02 Jan '23

02 Jan '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10762 Thibaud Guillot <thibaud.guillot(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0