October 2023 - Koha-bugs - lists.koha-community.org

[Bug 15504] Track Patron's Last Activity
by bugzilla-daemon＠bugs.koha-community.org 22 Oct '23

22 Oct '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 --- Comment #186 from Andrii Nugged <nugged(a)gmail.com> --- Created attachment 157620 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157620&action=e… Bug 15504: (QA follow-up) Final changes [1] Comment in Patron->is_active sharpened. [2] Patron->update_lastseen return if $cached && $cached eq $now->ymd; Should be return $self if $cached && $cached eq $now->ymd; Consistent return value. [3] Typo if there are not TrackLastPatronActivityTriggers enabled [4] Typo TrackLastPatronActivityTriggers must be contain [5] Typo patron is does .. option => performs an action [6] Tidy on dbrev to fix The file is less tidy than before (bad/messy lines before: 0, now: 4) Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15504] Track Patron's Last Activity
by bugzilla-daemon＠bugs.koha-community.org 22 Oct '23

22 Oct '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 --- Comment #185 from Andrii Nugged <nugged(a)gmail.com> --- Created attachment 157619 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157619&action=e… Bug 15504: (QA follow-up) Fix dbrev Resolve: ERROR - {UNKNOWN}: DBI Exception: DBD::mysql::db do failed: Unknown column 'check_out' in 'field list' at /usr/share/koha/C4/Installer.pm line 741 Test plan: Remove new pref from db. Run dbrev again. Check results. Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15504] Track Patron's Last Activity
by bugzilla-daemon＠bugs.koha-community.org 22 Oct '23

22 Oct '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 --- Comment #184 from Andrii Nugged <nugged(a)gmail.com> --- Created attachment 157618 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157618&action=e… Bug 15504: Remove PatronLastActivity preference This patch removes the older PatronLastActivity preference opting to replace it by the new PatronLastActivityTriggers preference. The feature can now be disabled by simply not selecting any triggers Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15504] Track Patron's Last Activity
by bugzilla-daemon＠bugs.koha-community.org 22 Oct '23

22 Oct '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 --- Comment #183 from Andrii Nugged <nugged(a)gmail.com> --- Created attachment 157617 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157617&action=e… Bug 15504: (follow-up) Clarify --last_seen option in delete_patrons This patch adds clarifications to the last_seen option in delete_patrons to clarify that TrackLastPatronActivity and TrackLastPatronActivityTriggers system preferences act as a couplet. Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15504] Track Patron's Last Activity
by bugzilla-daemon＠bugs.koha-community.org 22 Oct '23

22 Oct '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 --- Comment #182 from Andrii Nugged <nugged(a)gmail.com> --- Created attachment 157616 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157616&action=e… Bug 15504: (follow-up) Update terminology on cleanborrowers This patch updates the terminology on the cleanborrowers form to reflect that 'activity' and not just 'connectivity' is tracked by TrackLastPatronActivity. Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15504] Track Patron's Last Activity
by bugzilla-daemon＠bugs.koha-community.org 22 Oct '23

22 Oct '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 --- Comment #181 from Andrii Nugged <nugged(a)gmail.com> --- Created attachment 157615 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157615&action=e… Bug 15504: (QA follow-up) Terminology This just updates 'Login to OPAC' to 'Login'.. we should squash this Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15504] Track Patron's Last Activity
by bugzilla-daemon＠bugs.koha-community.org 22 Oct '23

22 Oct '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 --- Comment #180 from Andrii Nugged <nugged(a)gmail.com> --- Created attachment 157614 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157614&action=e… Bug 15504: (follow-up) Rename cache key I agree, it's better to use borrowernumber for the cache key and I also take the oportunity to rename it to more clearly reflect the function (it's no longer 'login' only, it's now 'activity') Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15504] Track Patron's Last Activity
by bugzilla-daemon＠bugs.koha-community.org 22 Oct '23

22 Oct '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 --- Comment #179 from Andrii Nugged <nugged(a)gmail.com> --- Created attachment 157613 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157613&action=e… Bug 15504: (follow-up) Respect existing TrackLastPatronActivity This patch updates the database update to set 'check_out,connection,login' as the activity triggers should we find at upgrade time that TrackLastPatronActivity is set to true. This retains the existing functionality. Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15504] Track Patron's Last Activity
by bugzilla-daemon＠bugs.koha-community.org 22 Oct '23

22 Oct '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 --- Comment #178 from Andrii Nugged <nugged(a)gmail.com> --- Created attachment 157612 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157612&action=e… Bug 15504: (follow-up) Fix is_active test Bug 33245 introduced a new is_active patron method and the corresponding tests included calls to the method we depreacte in this patchset Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15504] Track Patron's Last Activity
by bugzilla-daemon＠bugs.koha-community.org 22 Oct '23

22 Oct '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 --- Comment #177 from Andrii Nugged <nugged(a)gmail.com> --- Created attachment 157611 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157611&action=e… Bug 15504: (follow-up) Tidy 'lastseen' section of unit test Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0