October 2023 - Koha-bugs - lists.koha-community.org

[Bug 15504] Track Patron's Last Activity
by bugzilla-daemon＠bugs.koha-community.org 11 Oct '23

11 Oct '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #156606|0 |1 is obsolete| | --- Comment #110 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 156863 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156863&action=e… Bug 15504: (follow-up) Add Triggers mock to unit tests -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15504] Track Patron's Last Activity
by bugzilla-daemon＠bugs.koha-community.org 11 Oct '23

11 Oct '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #156605|0 |1 is obsolete| | --- Comment #109 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 156862 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156862&action=e… Bug 15504: (follow-up) Use borrowernumber in Koha::Patrons->find -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15504] Track Patron's Last Activity
by bugzilla-daemon＠bugs.koha-community.org 11 Oct '23

11 Oct '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #156604|0 |1 is obsolete| | --- Comment #108 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 156861 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156861&action=e… Bug 15504: (follow-up) Migrate to one clear method We were using a series of similarly named methods spread in distinct places around the codebase. This combines the logic of C4::Auth::track_login_daily and Koha::Patron->track_login into a new Koha::Patron->update_lastseen method. Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> Signed-off-by: David Nind <david(a)davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15504] Track Patron's Last Activity
by bugzilla-daemon＠bugs.koha-community.org 11 Oct '23

11 Oct '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #156603|0 |1 is obsolete| | --- Comment #107 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 156860 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156860&action=e… Bug 15504: (follow-up) Unit tests This patch removes, moves and updates the existing unit tests for track_login_daily and track_login to all sit under Koha::Patron and update_lastseen. Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> Signed-off-by: David Nind <david(a)davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15504] Track Patron's Last Activity
by bugzilla-daemon＠bugs.koha-community.org 11 Oct '23

11 Oct '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #156602|0 |1 is obsolete| | --- Comment #106 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 156859 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156859&action=e… Bug 15504: Add unit test prove -v t/db_dependent/Auth.t Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> Signed-off-by: David Nind <david(a)davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15504] Track Patron's Last Activity
by bugzilla-daemon＠bugs.koha-community.org 11 Oct '23

11 Oct '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #156601|0 |1 is obsolete| | --- Comment #105 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 156858 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156858&action=e… Bug 15504: Remove update_lastseen method This patch removes update_lastseen which has been replaced by a call to track_login_daily Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> Signed-off-by: David Nind <david(a)davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15504] Track Patron's Last Activity
by bugzilla-daemon＠bugs.koha-community.org 11 Oct '23

11 Oct '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #156600|0 |1 is obsolete| | --- Comment #104 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 156857 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156857&action=e… Bug 15504: Add triggers to instances of track_login_daily This patch adds a trigger to every instance of track_login_daily Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> Signed-off-by: David Nind <david(a)davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15504] Track Patron's Last Activity
by bugzilla-daemon＠bugs.koha-community.org 11 Oct '23

11 Oct '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #156599|0 |1 is obsolete| | --- Comment #103 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 156856 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156856&action=e… Bug 15504: Update track_login_daily to accept triggers This patch adds triggers to track_login_daily so that it only tracks activity when that trigger is active Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> Signed-off-by: David Nind <david(a)davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15504] Track Patron's Last Activity
by bugzilla-daemon＠bugs.koha-community.org 11 Oct '23

11 Oct '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #156598|0 |1 is obsolete| | --- Comment #102 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 156855 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156855&action=e… Bug 15504: Add new syspref TrackLastPatronActivityTriggers This patch adds a new syspref TrackLastPatronActivityTriggers to determine which actions should update borrowers.lastseen Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> Signed-off-by: David Nind <david(a)davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15504] Track Patron's Last Activity
by bugzilla-daemon＠bugs.koha-community.org 11 Oct '23

11 Oct '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 --- Comment #101 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- (In reply to Marcel de Rooy from comment #96) > dbrev > Blocker > The default should probably be LOGIN IF TrackLastLogin was enabled. > Please adjust. Done, will post patch momentarily.. however, it's actually 'connection,login,check_out' to match the existing behaviour. > Preferences > Clearing all triggers is the same as turning off existing pref? Could we > remove it ? Here or in a follow-up ? I like that, perhaps as a quick follow-up bug.. I'm happy to code that tonight. > my $cache_key = "track_login_" . $self->userid; > No blocker. Would probably be better to cache with borrowernumber. Userid > may change? Totally agree on this one.. though we just used the existing key. I've amended it now as another follow-up anyway.. about to upload. > + Time::Fake->offset( $now->epoch + 5 ); > No blocker, just teasing :) > You might have trouble in case you run the test close to midnight. > Could we cache the epoch value ? Oh, this could be fun.. one for later though in my opinion.. should it crop up. > -sub track_login { > - my ( $self, $params ) = @_; > - return if > - !$params->{force} && > Didnt we use force somewhere before? It was supported before, but never actually used. Matt and I discussed it and decided to remove the functionality for now as it was never called that way. > Login from OPAC => Login > => Staff login counts as well. I think we should just remove OPAC here. Fair, I'll do a follow-up for that too before posting up the current rebase. > This code still needs attention. > Blocker > koha-tmpl/intranet-tmpl/prog/en/modules/tools/cleanborrowers.tt > [% IF Koha.Preference('TrackLastPatronActivity') %] > <li> > <label for="borrower_lastseen">who have not been > connected since:</label> > <input size="10" id="borrower_lastseen" > name="borrower_lastseen" type="text" class="flatpickr" /> > <span class="hint">[% INCLUDE 'date-format.inc' > %]</span> > </li> > [% END %] > AND Similarly: > misc/cronjobs/delete_patrons.pl > =item B<--last_seen> > Delete patrons who have not been connected since this date. > The system preference TrackLastPatronActivity must be enabled to use this > option. Looking at these two now. -- You are receiving this mail because: You are watching all bug changes.

1 0