October 2023 - Koha-bugs - lists.koha-community.org

[Bug 15504] Track Patron's Last Activity
by bugzilla-daemon＠bugs.koha-community.org 06 Oct '23

06 Oct '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 --- Comment #79 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 156606 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156606&action=e… Bug 15504: (follow-up) Add Triggers mock to unit tests -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15504] Track Patron's Last Activity
by bugzilla-daemon＠bugs.koha-community.org 06 Oct '23

06 Oct '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 --- Comment #78 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 156605 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156605&action=e… Bug 15504: (follow-up) Use borrowernumber in Koha::Patrons->find -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15504] Track Patron's Last Activity
by bugzilla-daemon＠bugs.koha-community.org 06 Oct '23

06 Oct '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155540|0 |1 is obsolete| | --- Comment #77 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 156604 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156604&action=e… Bug 15504: (follow-up) Migrate to one clear method We were using a series of similarly named methods spread in distinct places around the codebase. This combines the logic of C4::Auth::track_login_daily and Koha::Patron->track_login into a new Koha::Patron->update_lastseen method. Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> Signed-off-by: David Nind <david(a)davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15504] Track Patron's Last Activity
by bugzilla-daemon＠bugs.koha-community.org 06 Oct '23

06 Oct '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155539|0 |1 is obsolete| | --- Comment #76 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 156603 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156603&action=e… Bug 15504: (follow-up) Unit tests This patch removes, moves and updates the existing unit tests for track_login_daily and track_login to all sit under Koha::Patron and update_lastseen. Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> Signed-off-by: David Nind <david(a)davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15504] Track Patron's Last Activity
by bugzilla-daemon＠bugs.koha-community.org 06 Oct '23

06 Oct '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155538|0 |1 is obsolete| | --- Comment #75 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 156602 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156602&action=e… Bug 15504: Add unit test prove -v t/db_dependent/Auth.t Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> Signed-off-by: David Nind <david(a)davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15504] Track Patron's Last Activity
by bugzilla-daemon＠bugs.koha-community.org 06 Oct '23

06 Oct '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155537|0 |1 is obsolete| | --- Comment #74 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 156601 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156601&action=e… Bug 15504: Remove update_lastseen method This patch removes update_lastseen which has been replaced by a call to track_login_daily Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> Signed-off-by: David Nind <david(a)davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15504] Track Patron's Last Activity
by bugzilla-daemon＠bugs.koha-community.org 06 Oct '23

06 Oct '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155536|0 |1 is obsolete| | --- Comment #73 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 156600 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156600&action=e… Bug 15504: Add triggers to instances of track_login_daily This patch adds a trigger to every instance of track_login_daily Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> Signed-off-by: David Nind <david(a)davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15504] Track Patron's Last Activity
by bugzilla-daemon＠bugs.koha-community.org 06 Oct '23

06 Oct '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155535|0 |1 is obsolete| | --- Comment #72 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 156599 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156599&action=e… Bug 15504: Update track_login_daily to accept triggers This patch adds triggers to track_login_daily so that it only tracks activity when that trigger is active Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> Signed-off-by: David Nind <david(a)davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15504] Track Patron's Last Activity
by bugzilla-daemon＠bugs.koha-community.org 06 Oct '23

06 Oct '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155534|0 |1 is obsolete| | --- Comment #71 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 156598 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156598&action=e… Bug 15504: Add new syspref TrackLastPatronActivityTriggers This patch adds a new syspref TrackLastPatronActivityTriggers to determine which actions should update borrowers.lastseen Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> Signed-off-by: David Nind <david(a)davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15504] Track Patron's Last Activity
by bugzilla-daemon＠bugs.koha-community.org 06 Oct '23

06 Oct '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 --- Comment #70 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Rebasing now bug 33245 is in. I think bug 33245 could be significantly simplified once this is in personally.. -- You are receiving this mail because: You are watching all bug changes.

1 0