October 2023 - Koha-bugs - lists.koha-community.org

[Bug 34897] New: ILL unit tests have lots of 'redefined' warnings
by bugzilla-daemon＠bugs.koha-community.org 03 Oct '23

03 Oct '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34897 Bug ID: 34897 Summary: ILL unit tests have lots of 'redefined' warnings Change sponsored?: --- Product: Koha Version: 22.11 Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: ILL Assignee: koha-bugs(a)lists.koha-community.org Reporter: katrin.fischer(a)bsz-bw.de CC: pedro.amorim(a)ptfs-europe.com prove t/db_dependent/Illrequest* t/db_dependent/Illrequest/Availability.t ............. ok t/db_dependent/Illrequest/Config.t ................... ok t/db_dependent/Illrequest/Logger.t ................... ok t/db_dependent/Illrequest/SupplierUpdate.t ........... ok t/db_dependent/Illrequest/SupplierUpdateProcessor.t .. ok t/db_dependent/Illrequest/TypeDisclaimer.t ........... 1/5 Use of uninitialized value $type in string eq at /kohadevbox/koha/Koha/Illrequest/Workflow/TypeDisclaimer.pm line 156. Use of uninitialized value $type in string eq at /kohadevbox/koha/Koha/Illrequest/Workflow/TypeDisclaimer.pm line 156. t/db_dependent/Illrequest/TypeDisclaimer.t ........... ok t/db_dependent/Illrequestattributes.t ................ ok t/db_dependent/Illrequests.t ......................... 1/15 illrequestattributes is DEPRECATED in favor of extended_attributes at t/db_dependent/Illrequests.t line 101. illrequestattributes is DEPRECATED in favor of extended_attributes at t/db_dependent/Illrequests.t line 111. Subroutine Koha::Illrequest::SUPER::status redefined at /kohadevbox/koha/Koha/Object.pm line 922. Subroutine Koha::Illrequest::SUPER::status_alias redefined at /kohadevbox/koha/Koha/Object.pm line 922. Subroutine Koha::Illrequest::SUPER::status redefined at /kohadevbox/koha/Koha/Object.pm line 922. Subroutine Koha::Illrequest::SUPER::status_alias redefined at /kohadevbox/koha/Koha/Object.pm line 922. Subroutine Koha::Illrequest::SUPER::status redefined at /kohadevbox/koha/Koha/Object.pm line 922. Subroutine Koha::Illrequest::SUPER::status_alias redefined at /kohadevbox/koha/Koha/Object.pm line 922. Subroutine Koha::Illrequest::SUPER::status_alias redefined at /kohadevbox/koha/Koha/Object.pm line 922. Subroutine Koha::Illrequest::SUPER::status redefined at /kohadevbox/koha/Koha/Object.pm line 922. Subroutine Koha::Illrequest::SUPER::status_alias redefined at /kohadevbox/koha/Koha/Object.pm line 922. Subroutine Koha::Illrequest::SUPER::status redefined at /kohadevbox/koha/Koha/Object.pm line 922. Subroutine Koha::Illrequest::SUPER::status_alias redefined at /kohadevbox/koha/Koha/Object.pm line 922. t/db_dependent/Illrequests.t ......................... 4/15 Subroutine Koha::Illrequest::SUPER::status redefined at /kohadevbox/koha/Koha/Object.pm line 922. Subroutine Koha::Illrequest::SUPER::status_alias redefined at /kohadevbox/koha/Koha/Object.pm line 922. Subroutine Koha::Illrequest::SUPER::status redefined at /kohadevbox/koha/Koha/Object.pm line 922. Subroutine Koha::Illrequest::SUPER::status_alias redefined at /kohadevbox/koha/Koha/Object.pm line 922. Subroutine Koha::Illrequest::SUPER::status_alias redefined at /kohadevbox/koha/Koha/Object.pm line 922. Subroutine Koha::Illrequest::SUPER::status redefined at /kohadevbox/koha/Koha/Object.pm line 922. Subroutine Koha::Illrequest::SUPER::status_alias redefined at /kohadevbox/koha/Koha/Object.pm line 922. Subroutine Koha::Illrequest::SUPER::status redefined at /kohadevbox/koha/Koha/Object.pm line 922. Subroutine Koha::Illrequest::SUPER::status_alias redefined at /kohadevbox/koha/Koha/Object.pm line 922. Subroutine Koha::Illrequest::SUPER::status redefined at /kohadevbox/koha/Koha/Object.pm line 922. Subroutine Koha::Illrequest::SUPER::status_alias redefined at /kohadevbox/koha/Koha/Object.pm line 922. Subroutine Koha::Illrequest::SUPER::status redefined at /kohadevbox/koha/Koha/Object.pm line 922. Subroutine Koha::Illrequest::SUPER::status redefined at /kohadevbox/koha/Koha/Object.pm line 922. Subroutine Koha::Illrequest::SUPER::status_alias redefined at /kohadevbox/koha/Koha/Object.pm line 922. Subroutine Koha::Illrequest::SUPER::status redefined at /kohadevbox/koha/Koha/Object.pm line 922. Subroutine Koha::Illrequest::SUPER::status_alias redefined at /kohadevbox/koha/Koha/Object.pm line 922. Subroutine Koha::Illrequest::SUPER::status redefined at /kohadevbox/koha/Koha/Object.pm line 922. Subroutine Koha::Illrequest::SUPER::status redefined at /kohadevbox/koha/Koha/Object.pm line 922. Subroutine Koha::Illrequest::SUPER::status_alias redefined at /kohadevbox/koha/Koha/Object.pm line 922. Subroutine Koha::Illrequest::SUPER::status redefined at /kohadevbox/koha/Koha/Object.pm line 922. illrequestattributes is DEPRECATED in favor of extended_attributes at t/db_dependent/Illrequests.t line 884. illrequestattributes is DEPRECATED in favor of extended_attributes at t/db_dependent/Illrequests.t line 884. illrequestattributes is DEPRECATED in favor of extended_attributes at t/db_dependent/Illrequests.t line 884. Subroutine Koha::Illrequest::SUPER::status redefined at /kohadevbox/koha/Koha/Object.pm line 922. Subroutine Koha::Illrequest::SUPER::status_alias redefined at /kohadevbox/koha/Koha/Object.pm line 922. Subroutine Koha::Illrequest::SUPER::status redefined at /kohadevbox/koha/Koha/Object.pm line 922. Subroutine Koha::Illrequest::SUPER::status_alias redefined at /kohadevbox/koha/Koha/Object.pm line 922. Subroutine Koha::Illrequest::SUPER::status_alias redefined at /kohadevbox/koha/Koha/Object.pm line 922. Subroutine Koha::Illrequest::SUPER::status redefined at /kohadevbox/koha/Koha/Object.pm line 922. Subroutine Koha::Illrequest::SUPER::status_alias redefined at /kohadevbox/koha/Koha/Object.pm line 922. Subroutine Koha::Illrequest::SUPER::status redefined at /kohadevbox/koha/Koha/Object.pm line 922. Subroutine Koha::Illrequest::SUPER::status_alias redefined at /kohadevbox/koha/Koha/Object.pm line 922. Subroutine Koha::Illrequest::SUPER::status redefined at /kohadevbox/koha/Koha/Object.pm line 922. Subroutine Koha::Illrequest::SUPER::status_alias redefined at /kohadevbox/koha/Koha/Object.pm line 922. Subroutine Koha::Illrequest::SUPER::status redefined at /kohadevbox/koha/Koha/Object.pm line 922. Subroutine Koha::Illrequest::SUPER::status redefined at /kohadevbox/koha/Koha/Object.pm line 922. Subroutine Koha::Illrequest::SUPER::status_alias redefined at /kohadevbox/koha/Koha/Object.pm line 922. illrequestattributes is DEPRECATED in favor of extended_attributes at t/db_dependent/Illrequests.t line 1013. illrequestattributes is DEPRECATED in favor of extended_attributes at t/db_dependent/Illrequests.t line 1013. illrequestattributes is DEPRECATED in favor of extended_attributes at t/db_dependent/Illrequests.t line 1013. illrequestattributes is DEPRECATED in favor of extended_attributes at t/db_dependent/Illrequests.t line 1033. illrequestattributes is DEPRECATED in favor of extended_attributes at t/db_dependent/Illrequests.t line 1033. illrequestattributes is DEPRECATED in favor of extended_attributes at t/db_dependent/Illrequests.t line 1033. illrequestattributes is DEPRECATED in favor of extended_attributes at t/db_dependent/Illrequests.t line 1071. illrequestattributes is DEPRECATED in favor of extended_attributes at t/db_dependent/Illrequests.t line 1071. illrequestattributes is DEPRECATED in favor of extended_attributes at t/db_dependent/Illrequests.t line 1071. illrequestattributes is DEPRECATED in favor of extended_attributes at t/db_dependent/Illrequests.t line 1114. illrequestattributes is DEPRECATED in favor of extended_attributes at t/db_dependent/Illrequests.t line 1114. illrequestattributes is DEPRECATED in favor of extended_attributes at t/db_dependent/Illrequests.t line 1114. t/db_dependent/Illrequests.t ......................... 10/15 Subroutine Koha::Illrequest::SUPER::status redefined at /kohadevbox/koha/Koha/Object.pm line 922. Subroutine Koha::Illrequest::SUPER::status_alias redefined at /kohadevbox/koha/Koha/Object.pm line 922. Subroutine Koha::Illrequest::SUPER::status redefined at /kohadevbox/koha/Koha/Object.pm line 922. Subroutine Koha::Illrequest::SUPER::status_alias redefined at /kohadevbox/koha/Koha/Object.pm line 922. Subroutine Koha::Illrequest::SUPER::status_alias redefined at /kohadevbox/koha/Koha/Object.pm line 922. Subroutine Koha::Illrequest::SUPER::status redefined at /kohadevbox/koha/Koha/Object.pm line 922. Subroutine Koha::Illrequest::SUPER::status_alias redefined at /kohadevbox/koha/Koha/Object.pm line 922. Subroutine Koha::Illrequest::SUPER::status redefined at /kohadevbox/koha/Koha/Object.pm line 922. Subroutine Koha::Illrequest::SUPER::status_alias redefined at /kohadevbox/koha/Koha/Object.pm line 922. Subroutine Koha::Illrequest::SUPER::status redefined at /kohadevbox/koha/Koha/Object.pm line 922. Subroutine Koha::Illrequest::SUPER::status_alias redefined at /kohadevbox/koha/Koha/Object.pm line 922. Subroutine Koha::Illrequest::SUPER::status redefined at /kohadevbox/koha/Koha/Object.pm line 922. Subroutine Koha::Illrequest::SUPER::status_alias redefined at /kohadevbox/koha/Koha/Object.pm line 922. Subroutine Koha::Illrequest::SUPER::status_alias redefined at /kohadevbox/koha/Koha/Object.pm line 922. Subroutine Koha::Illrequest::SUPER::status redefined at /kohadevbox/koha/Koha/Object.pm line 922. Subroutine Koha::Illrequest::SUPER::status_alias redefined at /kohadevbox/koha/Koha/Object.pm line 922. Subroutine Koha::Illrequest::SUPER::status_alias redefined at /kohadevbox/koha/Koha/Object.pm line 922. Subroutine Koha::Illrequest::SUPER::status_alias redefined at /kohadevbox/koha/Koha/Object.pm line 922. Subroutine Koha::Illrequest::SUPER::status_alias redefined at /kohadevbox/koha/Koha/Object.pm line 922. Subroutine Koha::Illrequest::SUPER::status redefined at /kohadevbox/koha/Koha/Object.pm line 922. Subroutine Koha::Illrequest::SUPER::status_alias redefined at /kohadevbox/koha/Koha/Object.pm line 922. Subroutine Koha::Illrequest::SUPER::status redefined at /kohadevbox/koha/Koha/Object.pm line 922. Subroutine Koha::Illrequest::SUPER::status_alias redefined at /kohadevbox/koha/Koha/Object.pm line 922. Subroutine Koha::Illrequest::SUPER::status_alias redefined at /kohadevbox/koha/Koha/Object.pm line 922. Subroutine Koha::Illrequest::SUPER::status redefined at /kohadevbox/koha/Koha/Object.pm line 922. Subroutine Koha::Illrequest::SUPER::status_alias redefined at /kohadevbox/koha/Koha/Object.pm line 922. Subroutine Koha::Illrequest::SUPER::status_alias redefined at /kohadevbox/koha/Koha/Object.pm line 922. Subroutine Koha::Illrequest::SUPER::status_alias redefined at /kohadevbox/koha/Koha/Object.pm line 922. Subroutine Koha::Illrequest::SUPER::status redefined at /kohadevbox/koha/Koha/Object.pm line 922. Subroutine Koha::Illrequest::SUPER::status_alias redefined at /kohadevbox/koha/Koha/Object.pm line 922. Subroutine Koha::Illrequest::SUPER::status redefined at /kohadevbox/koha/Koha/Object.pm line 922. Subroutine Koha::Illrequest::SUPER::status_alias redefined at /kohadevbox/koha/Koha/Object.pm line 922. Subroutine Koha::Illrequest::SUPER::status redefined at /kohadevbox/koha/Koha/Object.pm line 922. Subroutine Koha::Illrequest::SUPER::status_alias redefined at /kohadevbox/koha/Koha/Object.pm line 922. Subroutine Koha::Illrequest::SUPER::status_alias redefined at /kohadevbox/koha/Koha/Object.pm line 922. Subroutine Koha::Illrequest::SUPER::status redefined at /kohadevbox/koha/Koha/Object.pm line 922. Subroutine Koha::Illrequest::SUPER::status_alias redefined at /kohadevbox/koha/Koha/Object.pm line 922. Subroutine Koha::Illrequest::SUPER::status redefined at /kohadevbox/koha/Koha/Object.pm line 922. Subroutine Koha::Illrequest::SUPER::status_alias redefined at /kohadevbox/koha/Koha/Object.pm line 922. t/db_dependent/Illrequests.t ......................... ok All tests successful. Files=8, Tests=42, 8 wallclock secs ( 0.04 usr 0.00 sys + 6.18 cusr 0.85 csys = 7.07 CPU) Result: PASS -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 1

[Bug 14092] Order search doesn't allow to search for 'all statuses'
by bugzilla-daemon＠bugs.koha-community.org 03 Oct '23

03 Oct '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14092 --- Comment #13 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Note to myself: instead of note we could use the basketno. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14092] Order search doesn't allow to search for 'all statuses'
by bugzilla-daemon＠bugs.koha-community.org 03 Oct '23

03 Oct '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14092 --- Comment #12 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Patches may be squashed. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14092] Order search doesn't allow to search for 'all statuses'
by bugzilla-daemon＠bugs.koha-community.org 03 Oct '23

03 Oct '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14092 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA QA Contact|testopia(a)bugs.koha-communit |m.de.rooy(a)rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14092] Order search doesn't allow to search for 'all statuses'
by bugzilla-daemon＠bugs.koha-community.org 03 Oct '23

03 Oct '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14092 --- Comment #11 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- diff --git a/t/db_dependent/Acquisition.t b/t/db_dependent/Acquisition.t index d102a343a0..a5a165d777 100755 --- a/t/db_dependent/Acquisition.t +++ b/t/db_dependent/Acquisition.t @@ -995,13 +995,13 @@ subtest 'GetHistory status search' => sub { }; $order = $builder->build( { source => 'Aqorder', value => $orderinfo2 } ); - $orders = GetHistory( order_status => "new", vendornote => 'status search' ); + $orders = GetHistory( basket => $order_basket->{basketno}, order_status => "new", vendornote => 'status search' ); is( scalar(@$orders), 1, 'GetHistory with order status "new" returns 1 order' ); - my $orders = GetHistory( get_canceled_order => 1, order_status => "any", vendornote => 'status search' ); + my $orders = GetHistory( basket => $order_basket->{basketno}, get_canceled_order => 1, order_status => "any", vendornote => 'status search' ); is( scalar(@$orders), 2, 'GetHistory with order status "any" returns all orders' ); - $orders = GetHistory( order_status => "", vendornote => 'status search' ); + $orders = GetHistory( basket => $order_basket->{basketno}, order_status => "", vendornote => 'status search' ); is( scalar(@$orders), 1, 'GetHistory with order status "all except cancelled" returns zero orders' ); }; -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 27519] New: Normalize Show/Don't show vs Display/Don't display in system preferences
by bugzilla-daemon＠bugs.koha-community.org 03 Oct '23

03 Oct '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27519 Bug ID: 27519 Summary: Normalize Show/Don't show vs Display/Don't display in system preferences Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs(a)lists.koha-community.org Reporter: caroline.cyr-la-rose(a)inlibro.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com This is something I came across when translating Koha. Some system preferences use Display/Don't display as their choices and others use Show/Don't show. I propose to normalize the terms, i.e. choose one and stick with it (with the amount in each, I would choose to keep Show/Don't show). Show/Don't show - AdlibrisCoversEnabled - AmazonCoverImages - DisplayClearScreenButton - displayFacetCount - DisplayOPACiconsXSLT - EnhancedMessagingPreferencesOPAC - ExportCircHistory - FRBRizeEditions - hidelostitems - HidePatronName - intranetbookbag - IntranetCatalogSearchPulldown - LibraryThingForLibrariesEnabled - numSearchResultsDropdown - OPACAmazonCoverImages - OpacCloud - OPACItemsResultsDisplay - OpacKohaUrl - OPACnumSearchResultsDropdown - OPACpatronimages - OPACShowCheckoutName - OPACShowMusicalInscripts - OpacShowRecentComments - OpacSuggestionManagedBy - OPACFRBRizeEditions - OpacMaintenance - OPACUserSummary - OpenLibrarySearch - OPACShelfBrowser - OPACShowUnusedAuthorities - OPACViewOthersSuggestions - SelfCheckReceiptPrompt - ShowAllCheckins - showLastPatron - ShowPatronImageInWebBasedSelfCheck - SyndeticsAuthorNotes - SyndeticsAwards - SyndeticsCoverImages - SyndeticsEditions - SyndeticsExcerpt - SyndeticsReviews - SyndeticsSeries - SyndeticsSummary - SyndeticsTOC - UseWYSIWYGinSystemPreferences Display/Don't display - AcquisitionDetails - advancedMARCeditor - AuthDisplayHierarchy - BiblioItemtypeInfo - CustomCoverImages - EasyAnalyticalRecords - hide_marc - LocalCoverImages - OPACAcquisitionDetails - OPACCustomCoverImages - OPACLocalCoverImages - OpacNewsLibrarySelect - OPACPopupAuthorsSearch - SpineLabelShowPrintOnBibDetails While we're at it, I would also change the following : - noItemTypeImages: Yes/No - OpacNoItemTypeImages: Yes/No - ShowReviewerPhoto: Show/Hide - PatronSelfRegistrationPrefillForm: display and prefill/don't display and prefill -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 25

[Bug 14092] Order search doesn't allow to search for 'all statuses'
by bugzilla-daemon＠bugs.koha-community.org 03 Oct '23

03 Oct '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14092 --- Comment #10 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- This is much better! One final thing: + $orders = GetHistory( order_status => "new", vendornote => 'status search' ); + is( scalar(@$orders), 1, 'GetHistory with order status "new" returns 1 order' ); + + my $orders = GetHistory( get_canceled_order => 1, order_status => "any", vendornote => 'status search' ); + is( scalar(@$orders), 2, 'GetHistory with order status "any" returns all orders' ); + + $orders = GetHistory( order_status => "", vendornote => 'status search' ); + is( scalar(@$orders), 1, 'GetHistory with order status "all except cancelled" returns zero orders' ); The last test does not read very well. If orders == 1 then it returns 0 orders?? Please adjust. No big blocker but you assume that there are no orders in the system when you get a count. So your test may very well fail with some orders being there. Since you created a new basket, you could also pass the param basket to GetHistory [my $basket = $params{basket} ]. Which would resolve the issue with other orders. GetHistory( basket => $order_basket->{basketno}, etc. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 30615] New: Wrong URL to OAI-PMH-Tutorial
by bugzilla-daemon＠bugs.koha-community.org 03 Oct '23

03 Oct '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30615 Bug ID: 30615 Summary: Wrong URL to OAI-PMH-Tutorial Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Documentation Assignee: koha-bugs(a)lists.koha-community.org Reporter: michaela.sieber(a)kit.edu QA Contact: testopia(a)bugs.koha-community.org Wrong URL to OAI-PMH-Tutorial in Koha manual https://koha-community.org/manual/21.05/en/html/webservices.html#oai-pmh second paragraph, last sentence: "Visit http://www.oaforum.org/tutorial/english/page3.htm for diagrams of how OAI-PMH works." See official Website: https://www.openarchives.org/documents/ Tutorials and Primers: OAI for Beginners - the Open Archives Forum online tutorial -- No longer live at http://www.oaforum.org/tutorial/ but available from the Internet Archive. New URL: https://web.archive.org/web/20171221103825/http://www.oaforum.org/tutorial/ -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 4

[Bug 27098] New: fines charges
by bugzilla-daemon＠bugs.koha-community.org 03 Oct '23

03 Oct '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27098 Bug ID: 27098 Summary: fines charges Change sponsored?: --- Product: Koha Version: 20.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard(a)myacpl.org Reporter: barbara.johnson(a)bedfordtx.gov QA Contact: testopia(a)bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes.

1 17

[Bug 28431] New: Typo: exsit
by bugzilla-daemon＠bugs.koha-community.org 03 Oct '23

03 Oct '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28431 Bug ID: 28431 Summary: Typo: exsit Change sponsored?: --- Product: Koha Version: 20.11 Hardware: All OS: All Status: NEW Keywords: Academy, Manual Severity: trivial Priority: P5 - low Component: Documentation Assignee: koha-bugs(a)lists.koha-community.org Reporter: katrin.fischer(a)bsz-bw.de QA Contact: testopia(a)bugs.koha-community.org ../../source/tools.rst:3061 (Manual 20.11) 'Record matching rule': choose which rules to use to check your catalog if these records already exsit. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 5