December 2023 - Koha-bugs - lists.koha-community.org

[Bug 31025] New: Reports with too many params can exceed length limit of URI
by bugzilla-daemon＠bugs.koha-community.org 04 Dec '23

04 Dec '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31025 Bug ID: 31025 Summary: Reports with too many params can exceed length limit of URI Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Reports Assignee: koha-bugs(a)lists.koha-community.org Reporter: nick(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org Our reports submit the form as a GET request - this is useful for saving links to report results, however, when using the <<Param|list>> feature, too much data can be submitted to the form and cause a 414 error: Request-URI Too Long The requested URL's length exceeds the capacity limit for this server. Apache/2.4.53 (Debian) Server at kohadev-intra.myDNSname.org Port 80 We should, optionally, submit large requests as 'POST' Dirty sample code: $("#rep_guided_reports_start textarea[id^='sql_params']").change(function(){ console.log('Garsh'); let param_length = 0; $("textarea[id^='sql_params']").each(function(index,value){ param_length += $(this).val().length; }); if( param_length > 900 ){ $("#rep_guided_reports_start form").attr('method','post'); $("#rep_guided_reports_start form input[type='submit']").after('<p>Too much params! Wil submit as post!</p>'); } }); -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 4

[Bug 35470] New: 23.05 button class update
by bugzilla-daemon＠bugs.koha-community.org 04 Dec '23

04 Dec '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35470 Bug ID: 35470 Summary: 23.05 button class update Change sponsored?: --- Product: Koha Version: 23.05 Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Staff interface Assignee: koha-bugs(a)lists.koha-community.org Reporter: ddaghita(a)mckinneytexas.org QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com Created attachment 159478 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159478&action=e… update and sql run button reports I used CSS to change the color of "Update and Run SQL Button" in the reports sections, but it uses a generic button class id. It changes the color of more buttons in different modules like cataloging and circulation. Can I have it be a more specialized button class id ex: .btn.btn-default change it to .btn.btn-default-sqlrunning Below is the CSS code: /* Speed Green Update and Run Sql button */ .btn.btn-default { background-color: #7CFC00; } Maybe I there is a button class id that is there I just choose the wrong one. Let me know what would be a good resolution. Thank you. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 4

[Bug 35159] New: New edit item limitation to library groups also prevents batch modification of items owned by other libraries.
by bugzilla-daemon＠bugs.koha-community.org 04 Dec '23

04 Dec '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35159 Bug ID: 35159 Summary: New edit item limitation to library groups also prevents batch modification of items owned by other libraries. Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: major Priority: P4 Component: Tools Assignee: koha-bugs(a)lists.koha-community.org Reporter: Slodico(a)knoxlib.org QA Contact: testopia(a)bugs.koha-community.org Depends on: 20256 The new feature that restricts editing items to owning or group library is preventing staff from performing batch item modifications to any item, regardless of owning library, something they could do prior to this addition. A new permission, "Edit any item including items that would otherwise be restricted (edit_any_items)", was added to allow users to edit any item regardless of the user and items' home libraries, but an equivalent permission for the Batch Item Modification Tool was not created. Either extend the new edit_any_item permission to include persons with the existing "Perform batch modification of items (items_batchmod)" permission or create a new permission that is the equivalent of "edit_any_item" for the Batch Modification Tool. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 [Bug 20256] Add ability to limit editing of items to home library or library group -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 5

[Bug 35439] New: Large background jobs can create delays
by bugzilla-daemon＠bugs.koha-community.org 04 Dec '23

04 Dec '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35439 Bug ID: 35439 Summary: Large background jobs can create delays Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: nick(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org When a large import or other background job is enqueued it can slow down the processing of other jobs. A novel idea would be to have this job break itself into smaller chunks, and enqueue those jobs - this way the queue could continue to advance and the smaller jobs could be interleaved with incoming jobs. See bug 35438 as well -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 5

[Bug 22384] New: Make the title of an ILL clickable
by bugzilla-daemon＠bugs.koha-community.org 04 Dec '23

04 Dec '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22384 Bug ID: 22384 Summary: Make the title of an ILL clickable Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: ILL Assignee: koha-bugs(a)lists.koha-community.org Reporter: magnus(a)libriotech.no Target Milestone: --- Today we have one column with the unclickable title of an ILL item and one column with the clickable biblionumber. It would be potentially less confusing if the title was clickable. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 5

[Bug 35478] New: When selecting a patron for a suggestion we have undefined fields
by bugzilla-daemon＠bugs.koha-community.org 04 Dec '23

04 Dec '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35478 Bug ID: 35478 Summary: When selecting a patron for a suggestion we have undefined fields Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Acquisitions Assignee: koha-bugs(a)lists.koha-community.org Reporter: nick(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org In the code in suggestion.tt: 1301 function select_suggester(borrowernumber, borrower) { 1302 var suggested = '<input type="hidden" id="suggestedby" name="suggestedby" value="' + borrowernumber + '" />'; 1303 suggested += '<a href="/cgi-bin/koha/members/moremember.pl?borrowernumber=' + borrowernumber + '">'; 1304 suggested += borrower.surname + ', ' + borrower.firstname + ' (' + borrower.cardnumber + ')'; 1305 suggested += '</a> '; 1306 suggested += borrower.branchname + ' (' + borrower.category_description + ')'; 1307 $("#tdsuggestedby").html(suggested); 1308 return 0; 1309 } The borrower json in the search doesn't have branchcode or category description -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 1

[Bug 14156] Add id tags to each MARC note in the display
by bugzilla-daemon＠bugs.koha-community.org 04 Dec '23

04 Dec '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14156 --- Comment #11 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Why only staff interface? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14293] Error in the calculation of the suspension of users per day
by bugzilla-daemon＠bugs.koha-community.org 03 Dec '23

03 Dec '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14293 --- Comment #54 from David Nind <david(a)davidnind.com> --- Testing notes (using koha-testing-docker): 1. Tests pass for me: prove t/db_dependent/Circulation/maxsuspensiondays.t 2. Use the same test plan as in comment#49 Maybe the code changes made need to be tidied using Perltidy? (https://wiki.koha-community.org/wiki/Coding_Guidelines#PERL1:_Perltidy and https://wiki.koha-community.org/wiki/Perltidy) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14293] Error in the calculation of the suspension of users per day
by bugzilla-daemon＠bugs.koha-community.org 03 Dec '23

03 Dec '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14293 David Nind <david(a)davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159277|0 |1 is obsolete| | --- Comment #53 from David Nind <david(a)davidnind.com> --- Created attachment 159504 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159504&action=e… Bug 14293: The suspension should be calculated in days There was a mismatch between bug 13909 and bug 5549. The get_chargeable_units call from _debar_user_on_return should specify that we want a suspension in days. However I don't understand the comment let by the author of bug 5549 f61a9617184ec4b24100c1d99150bfd4ebf13336 1/ > finedays is in days, so hourly loans must multiply by 24 Yes but the suspension is in days, so no need to * 24 2/ And we should have a look on this one too: > grace period is measured in the same units as the loan But the grace period is always in days. On the circ rules the column is "Fine grace period (day)". I think we should replace DateTime::Duration->new( $unit => $issuingrule->{firstremind} ); with DateTime::Duration->new( days => $issuingrule->{firstremind} ); Anyway, we definitelly need more tests in this area! Test plan: 1/ Define an issuing rule with a unit=hour 2/ Set a suspension in days 3/ Check an item out and specify a past due date. 4/ Check the item in 5/ The patron should be debarred correctly Signed-off-by: David Nind <david(a)davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14293] Error in the calculation of the suspension of users per day
by bugzilla-daemon＠bugs.koha-community.org 03 Dec '23

03 Dec '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14293 David Nind <david(a)davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0