February 2023 - Koha-bugs - lists.koha-community.org

[Bug 29129] New: The printclearscreen icon on circulation.tt should be configuarable to print either ISSUESLIP or ISSUEQSLIP
by bugzilla-daemon＠bugs.koha-community.org 01 Sep '23

01 Sep '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29129 Bug ID: 29129 Summary: The printclearscreen icon on circulation.tt should be configuarable to print either ISSUESLIP or ISSUEQSLIP Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs(a)lists.koha-community.org Reporter: lucas(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com The printclearscreen icon which appears when the system preference 'DisplayClearScreenButton' should allow users to choose between printing the ISSUESLIP and ISSUEQSLIP, if that system pref is turned on. I think the 'DisplayClearScreenButton' could have 3 options: -Don't show -Show and print ISSUESLIP -Show and print ISSUEQSLIP -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 30

[Bug 18066] New: Hea - Version 2
by bugzilla-daemon＠bugs.koha-community.org 01 Sep '23

01 Sep '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18066 Bug ID: 18066 Summary: Hea - Version 2 Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: System Administration Assignee: jonathan.druart(a)bugs.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com I plan to submit a big improvement for Hea (https://wiki.koha-community.org/wiki/KohaUsageStat_RFC) The different goals are: 1/ Add more information on how Hea is collecting the data and what we do with them 2/ Collect geolocation to display the Koha installations on a map 3/ Collect data per library instead of per Koha installation -- You are receiving this mail because: You are watching all bug changes.

1 68

[Bug 24359] New: Remove items from Holds Queue when checked in
by bugzilla-daemon＠bugs.koha-community.org 31 Aug '23

31 Aug '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24359 Bug ID: 24359 Summary: Remove items from Holds Queue when checked in Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs(a)lists.koha-community.org Reporter: joy(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com Currently, if an item is checked in and the hold is triggered/captured, the item will not come off the holds queue until the the cronjob runs again. This causes some confusion for multibranch systems when other branches attempt to fill holds that have already been filled. Proposal: Remove bib/items from the Holds Queue after checkin and before the next holds queue cron runs to update the holds queue. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 41

[Bug 31735] New: Circulation optimizations
by bugzilla-daemon＠bugs.koha-community.org 31 Aug '23

31 Aug '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31735 Bug ID: 31735 Summary: Circulation optimizations Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: glasklas(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org We recently had time-out issues and high server loads for patrons with high checkout counts (some patrons have several hundreds, up to about 400). One of the major bottlenecks turned out to be C4::Circulation::CanBookBeRenewed. The primary reason it performed so poorly was constant re-fetching of different database entities which could just as well be passed down directly instead of passing ids which requires re-fetching further down the call stack. After refactoring the most performance critical subroutines to take objects instead of object ids the calls to expensive DBIx-methods has been greatly reduced. In addition some other optimizations and bug fixes related to non working caching resulted in further speedups. The performance gain for a patron with around 400 checkouts is currently about 500%. I made an effort to fix all tests affected by the changes, but I can not guarantee there are absolutely no regressions left in the test-suite. Since many tests seem to fail due to reasons not related to this patch, mainly due to the state of my local instance triggering tests-bugs (for example caused by preferences not being mocked correctly, or relying on database test-entries that are not guaranteed to exist), it was impractical and very time consuming to make sure all tests still run successfully. So subset of tests where the changed subroutines are called directly was selected and these should now pass. The following tests should be effected by the changes and should be run as a part of the test-plan: t/db_dependent/api/v1/biblios.t t/db_dependent/api/v1/checkouts.t t/db_dependent/api/v1/return_claims.t t/db_dependent/Circulation/CalcDateDue.t t/db_dependent/Circulation/CheckIfIssuedToPatron.t t/db_dependent/Circulation/dateexpiry.t t/db_dependent/Circulation/GetPendingOnSiteCheckouts.t t/db_dependent/Circulation/GetTopIssues.t t/db_dependent/Circulation_holdsqueue.t t/db_dependent/Circulation/IsItemIssued.t t/db_dependent/Circulation/issue.t t/db_dependent/Circulation/MarkIssueReturned.t t/db_dependent/Circulation/maxsuspensiondays.t t/db_dependent/Circulation/ReturnClaims.t t/db_dependent/Circulation/Returns.t t/db_dependent/Circulation/SwitchOnSiteCheckouts.t t/db_dependent/Circulation.t t/db_dependent/Circulation/TooMany.t t/db_dependent/Circulation/transferbook.t t/db_dependent/DecreaseLoanHighHolds.t t/db_dependent/Holds/DisallowHoldIfItemsAvailable.t t/db_dependent/HoldsQueue.t t/db_dependent/Holds/RevertWaitingStatus.t t/db_dependent/Illrequests.t t/db_dependent/ILSDI_Services.t t/db_dependent/Items.t t/db_dependent/Koha/Account/Line.t t/db_dependent/Koha/Acquisition/Order.t t/db_dependent/Koha/Biblio.t t/db_dependent/Koha/Holds.t t/db_dependent/Koha/Items.t t/db_dependent/Koha/Item.t t/db_dependent/Koha/Object.t t/db_dependent/Koha/Patrons.t t/db_dependent/Koha/Plugins/Circulation_hooks.t t/db_dependent/Koha/Pseudonymization.t t/db_dependent/Koha/Recalls.t t/db_dependent/Koha/Recall.t t/db_dependent/Koha/Template/Plugin/CirculationRules.t t/db_dependent/Letters/TemplateToolkit.t t/db_dependent/Members/GetAllIssues.t t/db_dependent/Members/IssueSlip.t t/db_dependent/Patron/Borrower_Discharge.t t/db_dependent/Patron/Borrower_PrevCheckout.t t/db_dependent/Reserves/GetReserveFee.t t/db_dependent/Reserves.t t/db_dependent/rollingloans.t t/db_dependent/selenium/regressions.t t/db_dependent/SIP/ILS.t The following still fails for me but should either work on a fresh Koha installation, or fail for unrelated reasons (that is they also fail in Koha master): t/db_dependent/Koha/Plugins/Circulation_hooks.t t/db_dependent/Koha/Items.t t/db_dependent/SIP/ILS.t To be able to run t/db_dependent/Circulation.t in my Koha instance there where some existing bugs that needed fixing, so this patch have a dependency on Bug 31676. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 109

[Bug 15812] New: Checkout search with too many results (single character search) causes poor performance or timeout
by bugzilla-daemon＠bugs.koha-community.org 31 Aug '23

31 Aug '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15812 Bug ID: 15812 Summary: Checkout search with too many results (single character search) causes poor performance or timeout Change sponsored?: --- Product: Koha Version: 3.22 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs(a)lists.koha-community.org Reporter: nick(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com On a system with many patrons a checkout search for a single character (2,X,J) can cause a slow search or timeout from the large number of results returned. Patron search has no problem with the same searches -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 74

[Bug 31453] New: Add ability to skip processing messages in message queue based on message contents
by bugzilla-daemon＠bugs.koha-community.org 30 Aug '23

30 Aug '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31453 Bug ID: 31453 Summary: Add ability to skip processing messages in message queue based on message contents Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Command-line Utilities Assignee: koha-bugs(a)lists.koha-community.org Reporter: kyle(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org CC: robin(a)catalyst.net.nz It would be very useful to be able to tell process_message_queue.pl to skip processing some messages. This is particularly useful where a plugin handles sending some message using the before_send_messages hook, but while that plugin is processing, more messages meant for the plugin might be queued. At that point, control moves back to the script and SendQueuedMessages is called, and those messages end up being processed there instead of by the plugin. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 17

[Bug 32926] New: Cannot expand or collapse some System preference sections after a search
by bugzilla-daemon＠bugs.koha-community.org 30 Aug '23

30 Aug '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32926 Bug ID: 32926 Summary: Cannot expand or collapse some System preference sections after a search Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: a.roussos(a)dataly.gr QA Contact: testopia(a)bugs.koha-community.org If you perform a System preferences search for a common word such as "type" or "log", you then lose the ability to expand or collapse the sections with names that appear more than once in the results page. All sections except the first one in each group of duplicates are affected by this. When you click on the 2nd, 3rd, etc. occurence of a section, the expand/collapse arrow does change, but in reality only the section that appears first in the page is actually toggled. I have created an animated GIF that shows this in action: https://imgur.com/a/NSslIcV This affects Koha 20.11.00 or later; `git bisect` tells me that the relevant commit is 9d890c7636ef1d6ec0a1de2161906fd9f4375e97 from Bug 23410. To reproduce: Perform a System preferences search for a common word such as "type" or "log". In the results page, the "Policy" section will appear more than once. Now try to expand/collapse any "Policy" section but the first one. It won't work, only the first "Policy" section is toggled. -- You are receiving this mail because: You are watching all bug changes.

1 34

[Bug 32894] New: Objects cache methods' result without invalidation
by bugzilla-daemon＠bugs.koha-community.org 30 Aug '23

30 Aug '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32894 Bug ID: 32894 Summary: Objects cache methods' result without invalidation Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: In Discussion Severity: major Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: jonathan.druart+koha(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org CC: m.de.rooy(a)rijksmuseum.nl, martin.renvoize(a)ptfs-europe.com, tomascohen(a)gmail.com In some of our Koha:: objects we have methods that cache their result and return it in subsequent calls. However there is no invalidation of the cache if the object is modified. For instance, in Koha/ArticleRequest.pm sub biblio { my ($self) = @_; $self->{_biblio} ||= Koha::Biblios->find( $self->biblionumber() ); return $self->{_biblio}; } This pattern exists in several places. It can lead to confusion and incorrect results, such as: use Koha::ArticleRequests; my $ar = Koha::ArticleRequest->new({ borrowernumber => 42, biblionumber => 42, })->store; say $ar->biblio->biblionumber; # Display 42, correct $ar->set({ biblionumber => 24 })->store; say $ar->biblio->biblionumber; # Display 42, wrong $ar->discard_changes; say $ar->biblio->biblionumber; # Display 42, wrong $ar->delete; We should remove those caching and rely on DBIC/DBMS caching mechanism instead. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 60

[Bug 15701] New: Port Koha::Contrib::Tamil koha-cloud into Koha code base
by bugzilla-daemon＠bugs.koha-community.org 29 Aug '23

29 Aug '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15701 Bug ID: 15701 Summary: Port Koha::Contrib::Tamil koha-cloud into Koha code base Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Command-line Utilities Assignee: gmcharlt(a)gmail.com Reporter: mtj(a)kohaaloha.com QA Contact: testopia(a)bugs.koha-community.org CC: robin(a)catalyst.net.nz Port Koha::Contrib::Tamil koha-cloud into Koha code base more info to come... -- You are receiving this mail because: You are watching all bug changes.

1 9

[Bug 15957] New: Move AO in Patron Status
by bugzilla-daemon＠bugs.koha-community.org 29 Aug '23

29 Aug '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15957 Bug ID: 15957 Summary: Move AO in Patron Status Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: SIP2 Assignee: koha-bugs(a)lists.koha-community.org Reporter: m.de.rooy(a)rijksmuseum.nl QA Contact: testopia(a)bugs.koha-community.org CC: colin.campbell(a)ptfs-europe.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 3