March 2023 - Koha-bugs - lists.koha-community.org

[Bug 33020] New: Unsupported method history
by bugzilla-daemon＠bugs.koha-community.org 17 Mar '23

17 Mar '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33020 Bug ID: 33020 Summary: Unsupported method history Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: REST API Assignee: koha-bugs(a)lists.koha-community.org Reporter: jonathan.druart+koha(a)gmail.com CC: tomascohen(a)gmail.com I am seeing something weird for a couple of weeks. I've noticed it when working on the REST API but that may be related to something else as well. To recreate: curl -u koha:koha --request GET 'http://localhost:8081/api/v1/acquisition/vendors' Note that this route does not exist, it's acquisition*s* Then the client is receiving: Can't use an undefined value as an ARRAY reference at template mojo/debug.html.ep line 288. and a mojo stacktrace The server is logging: /var/log/koha/kohadev/plack-api-error.log <== [2023/02/21 09:35:02] [ERROR] Can't use an undefined value as an ARRAY reference at template mojo/debug.html.ep line 288. Context: 283: </div> 284: <div class="tap tap-border-top">tap for more</div> 285: </div> 286: </div> 287: <div class="row"> 288: % if (@{app->log->history}) { 289: % my $log = join '', map { scalar app->log->format->(@$_) } @{app->log->history}; 290: <pre class="mojo-terminal"><code class="nohighlight"><%= $log %></code></pre> 291: % } 292: % else { 293: <div class="alert alert-warning wide" role="alert"> Traceback (most recent call first): File "template mojo/debug.html.ep", line 288, in "Mojo::Template::Sandbox::a05f7134cc0618f09495937a2bcc8996" File "/usr/share/perl5/Mojo/Template.pm", line 160, in "Mojo::Template" File "/usr/share/perl5/Mojo/Template.pm", line 160, in "Mojo::Template" File "/usr/share/perl5/Mojo/Template.pm", line 163, in "Mojo::Template" File "/usr/share/perl5/Mojo/Template.pm", line 173, in "Mojo::Template" File "/usr/share/perl5/Mojolicious/Plugin/EPLRenderer.pm", line 40, in "Mojolicious::Plugin::EPLRenderer" File "/usr/share/perl5/Mojolicious/Plugin/EPRenderer.pm", line 39, in "Mojolicious::Plugin::EPRenderer" File "/usr/share/perl5/Mojolicious/Renderer.pm", line 225, in "Mojolicious::Renderer" File "/usr/share/perl5/Mojolicious/Renderer.pm", line 106, in "Mojolicious::Renderer" File "/usr/share/perl5/Mojolicious/Controller.pm", line 147, in "Mojolicious::Controller" File "/usr/share/perl5/Mojolicious/Controller.pm", line 159, in "Mojolicious::Controller" File "/usr/share/perl5/Mojolicious/Plugin/DefaultHelpers.pm", line 131, in "Mojolicious::Plugin::DefaultHelpers" File "/usr/share/perl5/Mojolicious/Plugin/DefaultHelpers.pm", line 112, in "Mojolicious::Plugin::DefaultHelpers" File "/usr/share/perl5/Mojolicious/Plugin/DefaultHelpers.pm", line 52, in "Mojolicious::Plugin::DefaultHelpers" File "/usr/share/perl5/Mojolicious/Renderer.pm", line 74, in "Mojolicious::Renderer" File "/usr/share/perl5/Mojolicious.pm", line 125, in "Mojolicious" File "/usr/share/perl5/Mojolicious.pm", line 134, in "Mojolicious" File "/usr/share/perl5/Mojolicious/Plugins.pm", line 15, in "Mojolicious::Plugins" File "/usr/share/perl5/Mojolicious.pm", line 200, in "Mojolicious" File "/usr/share/perl5/Mojolicious.pm", line 200, in "Mojolicious" File "/usr/share/perl5/Mojolicious/Plugins.pm", line 15, in "Mojolicious::Plugins" File "/usr/share/perl5/Mojolicious/Plugins.pm", line 18, in "Mojolicious::Plugins" File "/usr/share/perl5/Mojolicious.pm", line 139, in "Mojolicious" File "/usr/share/perl5/Mojo/Server.pm", line 70, in "Mojo::Server" File "/usr/share/perl5/Mojo/EventEmitter.pm", line 15, in "Mojo::EventEmitter" File "/usr/share/perl5/Mojo/Server/PSGI.pm", line 20, in "Mojo::Server::PSGI" File "/usr/share/perl5/Mojo/Server/PSGI.pm", line 38, in "Mojo::Server::PSGI" File "/usr/share/perl5/Plack/Middleware/LogWarn.pm", line 22, in "Plack::Middleware::LogWarn" File "/usr/share/perl5/Plack/Component.pm", line 50, in "Plack::Component" File "/usr/share/perl5/Plack/Middleware/Log4perl.pm", line 30, in "Plack::Middleware::Log4perl" File "/usr/share/perl5/Plack/Component.pm", line 50, in "Plack::Component" File "/usr/share/perl5/Plack/App/URLMap.pm", line 71, in "Plack::App::URLMap" File "/usr/share/perl5/Plack/Component.pm", line 50, in "Plack::Component" File "/kohadevbox/koha/Koha/Middleware/RealIP.pm", line 64, in "Koha::Middleware::RealIP" File "/usr/share/perl5/Plack/Component.pm", line 50, in "Plack::Component" File "/kohadevbox/koha/Koha/Middleware/SetEnv.pm", line 105, in "Koha::Middleware::SetEnv" File "/usr/share/perl5/Plack/Component.pm", line 50, in "Plack::Component" File "/usr/share/perl5/Plack/Middleware/Static.pm", line 18, in "Plack::Middleware::Static" File "/usr/share/perl5/Plack/Component.pm", line 50, in "Plack::Component" File "/usr/share/perl5/Plack/Middleware/ReverseProxy.pm", line 68, in "Plack::Middleware::ReverseProxy" File "/usr/share/perl5/Plack/Component.pm", line 50, in "Plack::Component" File "/usr/share/perl5/Plack/Middleware/Lint.pm", line 24, in "Plack::Middleware::Lint" File "/usr/share/perl5/Plack/Component.pm", line 50, in "Plack::Component" File "/usr/share/perl5/Plack/Middleware/StackTrace.pm", line 38, in "Plack::Middleware::StackTrace" File "/usr/share/perl5/Try/Tiny.pm", line 100, in "Try::Tiny" File "/usr/share/perl5/Try/Tiny.pm", line 93, in "Try::Tiny" File "/usr/share/perl5/Plack/Middleware/StackTrace.pm", line 42, in "Plack::Middleware::StackTrace" File "/usr/share/perl5/Plack/Component.pm", line 50, in "Plack::Component" File "/usr/share/perl5/Plack/Middleware/AccessLog.pm", line 27, in "Plack::Middleware::AccessLog" File "/usr/share/perl5/Plack/Component.pm", line 50, in "Plack::Component" File "/usr/share/perl5/Plack/Util.pm", line 145, in "Plack::Util" File "/usr/share/perl5/Plack/Util.pm", line 145, in "Plack::Util" File "/usr/share/perl5/Starman/Server.pm", line 195, in "Starman::Server" File "/usr/share/perl5/Starman/Server.pm", line 298, in "Starman::Server" File "/usr/share/perl5/Net/Server.pm", line 72, in "Net::Server" File "/usr/share/perl5/Net/Server/PreFork.pm", line 225, in "Net::Server::PreFork" File "/usr/share/perl5/Net/Server/PreFork.pm", line 225, in "Net::Server::PreFork" File "/usr/share/perl5/Net/Server/PreFork.pm", line 183, in "Net::Server::PreFork" File "/usr/share/perl5/Net/Server/PreFork.pm", line 373, in "Net::Server::PreFork" File "/usr/share/perl5/Net/Server/PreFork.pm", line 292, in "Net::Server::PreFork" File "/usr/share/perl5/Starman/Server.pm", line 164, in "Starman::Server" File "/usr/share/perl5/Net/Server/PreFork.pm", line 109, in "Net::Server::PreFork" File "/usr/share/perl5/Net/Server.pm", line 58, in "Net::Server" File "/usr/share/perl5/Starman/Server.pm", line 106, in "Starman::Server" File "/usr/share/perl5/Plack/Handler/Starman.pm", line 25, in "Plack::Handler::Starman" File "/usr/share/perl5/Plack/Loader/Delayed.pm", line 20, in "Plack::Loader::Delayed" File "/usr/share/perl5/Plack/Runner.pm", line 279, in "Plack::Runner" File "/usr/bin/starman", line 38, in "main" ==> /var/log/koha/kohadev/plack-error.log <== ERROR: Unsupported method history at /kohadevbox/koha/Koha/Logger.pm line 139. ERROR: Unsupported method history at /kohadevbox/koha/Koha/Logger.pm line 139. ==> /var/log/koha/kohadev/plack.log <== 172.18.0.1 - - [21/Feb/2023:09:35:02 +0000] "GET /api/v1/app.pl/api/v1/acquisition/vendors HTTP/1.1" 500 5645 "-" "curl/7.68.0" -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 42

[Bug 10869] Can't cancel order line if title deleted
by bugzilla-daemon＠bugs.koha-community.org 17 Mar '23

17 Mar '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10869 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |33262 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33262 [Bug 33262] When an ordered record is deleted, we lose all information on what was ordered -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0

[Bug 10758] Show bibliographic information of deleted records in acquisitions
by bugzilla-daemon＠bugs.koha-community.org 17 Mar '23

17 Mar '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10758 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |33262 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33262 [Bug 33262] When an ordered record is deleted, we lose all information on what was ordered -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 0

[Bug 23923] New: OpacHiddenItems displays incorrect 'No results found' when all results on first page are hidden
by bugzilla-daemon＠bugs.koha-community.org 16 Mar '23

16 Mar '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23923 Bug ID: 23923 Summary: OpacHiddenItems displays incorrect 'No results found' when all results on first page are hidden Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Searching Assignee: koha-bugs(a)lists.koha-community.org Reporter: nick(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org To recreate you will need to hide a large portion of the catalog - essentially you need to perform a search where the first 20 or more records are hidden, you get a 'No results found' - then add offset=20 (or more) and see that the second page has results. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 7

[Bug 33256] New: Allowing overriding of holds during checkout in a batch transaction
by bugzilla-daemon＠bugs.koha-community.org 16 Mar '23

16 Mar '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33256 Bug ID: 33256 Summary: Allowing overriding of holds during checkout in a batch transaction Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs(a)lists.koha-community.org Reporter: kelly(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com When a staff member has several override transactions specifically hold overrides, it would be more convenient to allow staff to make one override decision and this override decision would apply to the whole transaction. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0

[Bug 8179] Receiving multiple order lines at once
by bugzilla-daemon＠bugs.koha-community.org 16 Mar '23

16 Mar '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8179 --- Comment #100 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- Thanks for taking the time to rebase, Agustin. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8179] Receiving multiple order lines at once
by bugzilla-daemon＠bugs.koha-community.org 16 Mar '23

16 Mar '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8179 --- Comment #99 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- Minor tidy and a simple follow-up to avoid minor QA issues. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8179] Receiving multiple order lines at once
by bugzilla-daemon＠bugs.koha-community.org 16 Mar '23

16 Mar '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8179 --- Comment #98 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- Created attachment 148288 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148288&action=e… Bug 8179: Modernize atomic update Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8179] Receiving multiple order lines at once
by bugzilla-daemon＠bugs.koha-community.org 16 Mar '23

16 Mar '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8179 --- Comment #97 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- Created attachment 148287 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148287&action=e… Bug 8179: Receive multiple orders This patch implements the code to allow a patron to receive multiple orders at the same time in /cgi-bin/koha/acqui/orderreceive.pl page To test: 1. apply all patches 2. updatedatabase 3. Go to system preferences and allow AcqReceiveMultipleOrderLines 4. In acquisitions module, create a vendor if you don't have one and add 3 baskets.. one with create items on ordering, one with create items on receiving and finally one with create items when cataloguing 5. Fill baskets with orders (There should be at least 15 orders in total). There should be a mix of orders created by suggestions, others by subscriptions and others by neither of those methods. 6. Close all baskets and receive shipment. CHECK => in /cgi-bin/koha/acqui/parcel.pl page, in top table there is a column with checkboxes, and a button that says "Receive selected" 7. If all orders from all baskets are shown in the table, set the rows per page to 10, so table has more than one page 8. Check some of the checkboxes CHECK => "Receive selected" button shows how many rows are selected 9. Go to the next page and select some more rows CHECK => Changing page does not modify how many rows where selected 10. Go back to previous page CHECK => Previously selected rows are still selected 11. Reload the page to deselect all rows 12. Select only one row and click on "Receive selected" button CHECK => the page /cgi-bin/koha/acqui/orderreceive.pl behaves just the same as if the "receive" link in the selected row would have been clicked. 13. Click on cancel to go back to parcel.pl page 14. Select all rows (even the ones from the next page of the table) and click on "Receive selected" CHECH => In orderreceive.pl page there is a table with all selected rows 15. Ensure table has more than one page, as in step 7 16. Click on the "edit" link in the last row of the current page CHECK => A modal window is displayed with 4 tabs within: Info, Accounting, Receipt history and Items CHECK => Modal has 4 buttons at the bottom, 'Previous' to go to previos order, 'Cancel' to close the modal without keeping modifications, 'Save' to close modal keeping modifications and 'Next' to go to the next order CHECK => Even that we are at the end of the current page, 'Next' button is still available 17. Click on 'Next' button CHECK => The table behind the modal now displays the next page, and the modal was not closed 18. Click on 'Previous' CHECK => The table behind the modal went back to the first page, and the modal was not closed 19. Click on 'Previous' button till you reach the first row of the first page CHECK => Only when you reach the first row of the first page 'Previous' button gets disabled 20. Click on 'Next' button till you reach the last row of the last page CHECK => Only when you reach the last button of the last page 'Next' button gets disabled 21. Check that behaviour for the different types of order are still the same a. For orders that where created through suggestion, check that the suggestion info is present in Info tab. If when suggestion was accepted you set a reason, a dropdown to change the reason shoul display also. b. For orders that where created through subscriptions, check that the Items tab is disabled, and the Receipt history is enabled. On accounting tab you should be able to change quantity ordered. If there were less items received than ordered, the next time you receive this order the child order generated from this one shoul appear in receipt history. c. For orders that don't come from subscription and creates there items on ordering, Receipt history should be disabled, and a table with prefilled items shold appear in the Items tab. You can edit them and the changes should appear in the item's row. d. For orders that don't come from subscription and creates there items on receiving, Receipt history should be disabled, and a form to create the items should appear in Items tab. When you add an item a table should appear. e. For orders that don't come from subscription and creates there ites on cataloguing, Receipt history and Items tabs should be disabled. f. Any changes made in quantity (received or ordered) or funds in the modal should be reflected in the table if you click save from the modal. 22. Once you've done all you checking and verifications click save 23. While saving a progress bar should appear 24. If no error was detected, you should be redirected back to parcel.pl page 25. If an error or warning was detected (like there is an order with 0 items to receive) the save button should be disabled and warnings are dispayed. 26. prove t/db_dependent/Koha/Acquisition/Fund.t t/db_dependent/Koha/Acquisitoin/Order.t t/db_dependent/Koha/Item.t Sponsored-by: Virginia Polytechnic Institute and State University Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8179] Receiving multiple order lines at once
by bugzilla-daemon＠bugs.koha-community.org 16 Mar '23

16 Mar '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8179 --- Comment #96 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- Created attachment 148286 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148286&action=e… Bug 8179: Add AcqReceiveMultipleOrderLines syspref to preference configuration This patch adds AcqReceiveMultipleOrderLines to koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/acquisitions.pref Sponsored-by: Virginia Polytechnic Institute and State University Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> -- You are receiving this mail because: You are watching all bug changes.

1 0