May 2023 - Koha-bugs - lists.koha-community.org

[Bug 11844] Additional fields for order lines
by bugzilla-daemon＠bugs.koha-community.org 15 May '23

15 May '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 --- Comment #110 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- I can fix the test. I think what happens is: If the field is a repeatable one, we are only looking at the first occurence. The test was using 999, but this field is already present in the created biblio, before another 999 is added with $Z. So when trying to set the field, no $Z was found and the additional_field was not set. This can be fixed by: 1) Using another field than 999 that doesn't already exist in the record. 2) appending Z to the already existing 999 3) Making sure that set_additional_fields loops through repeatable subfields, using the first subfield found. 1) is done easily, 3) is harder. I tried to determine how it worked before this patch set, as the 'set' functionality was already there: https://git.koha-community.org/Koha-community/Koha/src/commit/f891156f424a4… my $value = $query->param('additional_field_' . $field->id); if ($field->marcfield) { my ($field, $subfield) = split /\$/, $field->marcfield; if ( $record and $field and $subfield ) { $value = $record->subfield( $field, $subfield ); } } It appears it never dealt 'cleverly' with repeated subfields. So we might move this to a separate bug and go with 1) for now. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 26628] New: Clubs permissions should grant access to Tools page
by bugzilla-daemon＠bugs.koha-community.org 15 May '23

15 May '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26628 Bug ID: 26628 Summary: Clubs permissions should grant access to Tools page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Tools Assignee: koha-bugs(a)lists.koha-community.org Reporter: andrew(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org To recreate: - create a patron with only the catalogue, borrowers, and clubs permissions - log in to the staff client as that patron - navigate to a patron record, confirm you can see the Clubs tab in the patron account, can add patrons to and remove patrons from clubs - confirm you don't have a link to the Tools module either on the Koha homepage or in the More menu - enter the clubs url manually (/cgi-bin/koha/clubs/clubs.pl), confirm you are allowed to open the page We should give a Tools link to anyone with clubs, edit_clubs, or edit_templates permissions. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 19

[Bug 27546] New: Add option to search within results on the staff client
by bugzilla-daemon＠bugs.koha-community.org 15 May '23

15 May '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27546 Bug ID: 27546 Summary: Add option to search within results on the staff client Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching Assignee: koha-bugs(a)lists.koha-community.org Reporter: nick(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org This enhancement will add a new box above the search results allowing one to search within the previous search results -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 48

[Bug 33097] New: Is message for staff or OPAC on circulation.pl?
by bugzilla-daemon＠bugs.koha-community.org 15 May '23

15 May '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33097 Bug ID: 33097 Summary: Is message for staff or OPAC on circulation.pl? Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs(a)lists.koha-community.org Reporter: cbrannon(a)cdalibrary.org QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com When looking at patron messages (not notices) on circulation.pl, it is impossible to tell if a message was posted to staff or to the OPAC. They display differently, with one red and the other not. But that doesn't tell the staff member which is which. We should have some kind of indicator to differentiate the two types. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 2

[Bug 12029] Patrons should be able to delete their patron messages
by bugzilla-daemon＠bugs.koha-community.org 15 May '23

15 May '23

1 0

[Bug 31245] New: Job detail view for batch mod explode if job not started
by bugzilla-daemon＠bugs.koha-community.org 15 May '23

15 May '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31245 Bug ID: 31245 Summary: Job detail view for batch mod explode if job not started Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart+koha(a)gmail.com Reporter: jonathan.druart+koha(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org If the job has failed to start (status=new), the job detail view is exploding with Can't use an undefined value as an ARRAY reference at /kohadevbox/koha/Koha/BackgroundJob/BatchUpdateItem.pm line 175 Koha::BackgroundJob::BatchUpdateItem::additional_report('Koha::BackgroundJob::BatchUpdateItem=HASH(0x5592c6c6ced8)') called at /kohadevbox/koha/Koha/BackgroundJob.pm line 339 Koha::BackgroundJob::additional_report('Koha::BackgroundJob=HASH(0x5592c6df3268)') called at /kohadevbox/koha/admin/background_jobs.pl line 55 -- You are receiving this mail because: You are watching all bug changes.

1 33

[Bug 33191] New: AutoEmailPrimaryAddress options don't match labels in memberentry
by bugzilla-daemon＠bugs.koha-community.org 15 May '23

15 May '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33191 Bug ID: 33191 Summary: AutoEmailPrimaryAddress options don't match labels in memberentry Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff interface Assignee: koha-bugs(a)lists.koha-community.org Reporter: martin.renvoize(a)ptfs-europe.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com This preference is confusing as the options it contains don't all match the labels for the corresponding fields in the member entry forms. * 'work'.. this corresponds to 'Secondary email' * 'home'.. this corresponds to 'Primary email' * 'alternate'.. ? We should either hint what these fields 'mean' on the form or update the systempreference options to match the existing form field label? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 31

[Bug 32546] New: Move ILL system preferences to their own tab in administration
by bugzilla-daemon＠bugs.koha-community.org 15 May '23

15 May '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32546 Bug ID: 32546 Summary: Move ILL system preferences to their own tab in administration Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: ILL Assignee: koha-bugs(a)lists.koha-community.org Reporter: katrin.fischer(a)bsz-bw.de At the moment the ILL related system preference appear on the Circulation tab, which is already very long. As ILL is a module, it should have its own tab. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 16

[Bug 11844] Additional fields for order lines
by bugzilla-daemon＠bugs.koha-community.org 15 May '23

15 May '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 Tomás Cohen Arazi <tomascohen(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen(a)gmail.com Status|Passed QA |Failed QA Keywords| |rel_23_05_candidate --- Comment #109 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- Hi Julian et al, there's a failing test. Please fix against this branch: https://gitlab.com/thekesolutions/Koha/-/commits/qa_11844 # Failed test 'No tests run for subtest "set_additional_fields with marcfield_mode = "get""' # at /kohadevbox/koha/t/db_dependent/Koha/Object/Mixin/AdditionalFields.t line 54. Can't call method "value" on an undefined value at /kohadevbox/koha/t/db_dependent/Koha/Object/Mixin/AdditionalFields.t line 51. # Looks like your test exited with 255 just after 1. /kohadevbox/koha/t/db_dependent/Koha/Object/Mixin/AdditionalFields.t .. Dubious, test returned 255 (wstat 65280, 0xff00) Failed 2/2 subtests Test Summary Report ------------------- /kohadevbox/koha/t/db_dependent/Koha/Object/Mixin/AdditionalFields.t (Wstat: 65280 Tests: 1 Failed: 1) Failed test: 1 Non-zero exit status: 255 Parse errors: Bad plan. You planned 2 tests but ran 1. Files=1, Tests=1, 3 wallclock secs ( 0.03 usr 0.01 sys + 1.66 cusr 0.38 csys = 2.08 CPU) Result: FAIL -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8179] Receiving multiple order lines at once
by bugzilla-daemon＠bugs.koha-community.org 15 May '23

15 May '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8179 --- Comment #147 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- (In reply to Katrin Fischer from comment #146) > Can we get an updated test plan? It looks like for example that the system > preference in step 3 got lost. It is enabled, and no action required to use the feature. -- You are receiving this mail because: You are watching all bug changes.

1 0