June 2023 - Koha-bugs - lists.koha-community.org

[Bug 32894] New: Objects cache methods' result without invalidation
by bugzilla-daemon＠bugs.koha-community.org 30 Aug '23

30 Aug '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32894 Bug ID: 32894 Summary: Objects cache methods' result without invalidation Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: In Discussion Severity: major Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: jonathan.druart+koha(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org CC: m.de.rooy(a)rijksmuseum.nl, martin.renvoize(a)ptfs-europe.com, tomascohen(a)gmail.com In some of our Koha:: objects we have methods that cache their result and return it in subsequent calls. However there is no invalidation of the cache if the object is modified. For instance, in Koha/ArticleRequest.pm sub biblio { my ($self) = @_; $self->{_biblio} ||= Koha::Biblios->find( $self->biblionumber() ); return $self->{_biblio}; } This pattern exists in several places. It can lead to confusion and incorrect results, such as: use Koha::ArticleRequests; my $ar = Koha::ArticleRequest->new({ borrowernumber => 42, biblionumber => 42, })->store; say $ar->biblio->biblionumber; # Display 42, correct $ar->set({ biblionumber => 24 })->store; say $ar->biblio->biblionumber; # Display 42, wrong $ar->discard_changes; say $ar->biblio->biblionumber; # Display 42, wrong $ar->delete; We should remove those caching and rely on DBIC/DBMS caching mechanism instead. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 60

[Bug 34072] New: Holds queue search interface hidden on small screens
by bugzilla-daemon＠bugs.koha-community.org 30 Aug '23

30 Aug '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34072 Bug ID: 34072 Summary: Holds queue search interface hidden on small screens Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs(a)lists.koha-community.org Reporter: andrewfh(a)dubcolib.org QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com The search interface for the holds queue (view_holdsqueue.pl) is hidden on small/narrow screens. To recreate in Chrome: - go to /cgi-bin/koha/circ/view_holdsqueue.pl - inspect something within the page to open the dev tools - press ctrl-shift-m to show the device toolbar - use the device toolbar to reduce the resolution of your window - observe that the search controls are lost at smaller resolutions -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 16

[Bug 15701] New: Port Koha::Contrib::Tamil koha-cloud into Koha code base
by bugzilla-daemon＠bugs.koha-community.org 30 Aug '23

30 Aug '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15701 Bug ID: 15701 Summary: Port Koha::Contrib::Tamil koha-cloud into Koha code base Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Command-line Utilities Assignee: gmcharlt(a)gmail.com Reporter: mtj(a)kohaaloha.com QA Contact: testopia(a)bugs.koha-community.org CC: robin(a)catalyst.net.nz Port Koha::Contrib::Tamil koha-cloud into Koha code base more info to come... -- You are receiving this mail because: You are watching all bug changes.

1 9

[Bug 15957] New: Move AO in Patron Status
by bugzilla-daemon＠bugs.koha-community.org 30 Aug '23

30 Aug '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15957 Bug ID: 15957 Summary: Move AO in Patron Status Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: SIP2 Assignee: koha-bugs(a)lists.koha-community.org Reporter: m.de.rooy(a)rijksmuseum.nl QA Contact: testopia(a)bugs.koha-community.org CC: colin.campbell(a)ptfs-europe.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 3

[Bug 27881] New: Markup error in masthead-langmenu.inc
by bugzilla-daemon＠bugs.koha-community.org 29 Aug '23

29 Aug '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27881 Bug ID: 27881 Summary: Markup error in masthead-langmenu.inc Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: OPAC Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org Depends on: 20168 masthead-langmenu.inc has a few instances of this error: <a class="dropdown-item"<a href="#" tabindex="-1" class="menu-inactive" role="menuitem"> Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20168 [Bug 20168] Update of the OPAC bootstrap template to bootstrap v4 -- You are receiving this mail because: You are watching all bug changes.

1 15

[Bug 33700] New: Allow setting for CircConfirmItemParts to checkout via self check
by bugzilla-daemon＠bugs.koha-community.org 29 Aug '23

29 Aug '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33700 Bug ID: 33700 Summary: Allow setting for CircConfirmItemParts to checkout via self check Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs(a)lists.koha-community.org Reporter: lisette.scheer(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com It would be great if we could add an option to either allow checking out without confirmation or set up a way to confirm, like maybe scanning the barcode again to confirm items are present. Lisette -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 2

[Bug 15695] New: koha-plack script does not enable plack when plack has never been enabled
by bugzilla-daemon＠bugs.koha-community.org 29 Aug '23

29 Aug '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15695 Bug ID: 15695 Summary: koha-plack script does not enable plack when plack has never been enabled Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Command-line Utilities Assignee: gmcharlt(a)gmail.com Reporter: wwwretive(a)yahoo.fr QA Contact: testopia(a)bugs.koha-community.org CC: robin(a)catalyst.net.nz Created attachment 47401 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47401&action=ed… the patch for koha-plack script hello, When running koha-plack --enable, the script assumes that there is already a commented line that includes the plack configuration in the apache virtual host's config of the instance. The script would comment out the line : (from /usr/sbin/koha-plack line 148) : sed -i 's:^\s*#$\s*Include /etc/koha/apache-shared-opac-plack.conf$$:\1:' "$instancefile" sed -i 's:^\s*#$\s*Include /etc/koha/apache-shared-intranet-plack.conf$$:\1:' "$instancefile" For old fashioned installs there is no commented line that includes plack configuration, so the regular expression doesn't match and the script doesn't enable plack. In my config (we've set up koha 3 years ago) i had to add the plack-related line directly in the apache virtual host config. Since the included files use the ${instance} variable, i had to define that variable as well in my vhost config : Define instance myinstancename (the "Define" keyword is not well documented in the apache docs ; i used it because SetEnv didn't work). Instead of commenting out the (possibibly non-existent) plack related lines, it is possible to find where the "/etc/koha/apache-shared-{opac,intranet}.conf" files are included and add the two relevant lines. -- You are receiving this mail because: You are watching all bug changes.

1 6

[Bug 15882] New: refactor C4::Log::GetLogs to accept DateTime
by bugzilla-daemon＠bugs.koha-community.org 29 Aug '23

29 Aug '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15882 Bug ID: 15882 Summary: refactor C4::Log::GetLogs to accept DateTime Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt(a)gmail.com Reporter: olli-antti.kivilahti(a)jns.fi QA Contact: testopia(a)bugs.koha-community.org C4::Log::GetLogs accepts dates in the user interface format, which is bad for an internal module. Refactored to accept DateTimes so it can be used internally more easily. -- You are receiving this mail because: You are watching all bug changes.

1 7

[Bug 15875] New: Refactor DB accessors from "z39.50 admin setup / z3950servers.pl" to C4::Breeding
by bugzilla-daemon＠bugs.koha-community.org 29 Aug '23

29 Aug '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15875 Bug ID: 15875 Summary: Refactor DB accessors from "z39.50 admin setup / z3950servers.pl" to C4::Breeding Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Z39.50 / SRU / OpenSearch Servers Assignee: gmcharlt(a)gmail.com Reporter: olli-antti.kivilahti(a)jns.fi QA Contact: testopia(a)bugs.koha-community.org CC: m.de.rooy(a)rijksmuseum.nl z3950servers.pl is a horrible mess of hard SQL in the perl script/Controller-layer. Also a lack of proper internal API for mutating Z3950servers makes writing tests much harder. This patch refactors z3950servers.pl by moving SQL to C4::Breeding under proper accessors. -- You are receiving this mail because: You are watching all bug changes.

1 5

[Bug 15779] New: Remove unnecessary parts of C4::Koha
by bugzilla-daemon＠bugs.koha-community.org 29 Aug '23

29 Aug '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15779 Bug ID: 15779 Summary: Remove unnecessary parts of C4::Koha Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart(a)bugs.koha-community.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org Some subroutines of C4::Koha has been put there because of a lack of other good places or of anticipation. It is used as a catch-all module and a lot of its subroutines can be moved somewhere else. -- You are receiving this mail because: You are watching all bug changes.

1 24