July 2023 - Koha-bugs - lists.koha-community.org

[Bug 12802] Send notices using several email addresses
by bugzilla-daemon＠bugs.koha-community.org 17 Jul '23

17 Jul '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12802 --- Comment #109 from mathieu saby <mathsabypro(a)gmail.com> --- Hi I am trying to test on a sandbox. Is it possible to purge pending messages without completely recreating the sandbox ? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13325] Add logs for budgets and funds
by bugzilla-daemon＠bugs.koha-community.org 17 Jul '23

17 Jul '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13325 --- Comment #14 from mathieu saby <mathsabypro(a)gmail.com> --- Hi you marked https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34049 as a duplicate, but I am not sure of that. By "logs", do you mean logs visible in /tools/viewlog.pl ? What I meant in 34049 was not to "log" modifications that way, because logs are often disabled in production Koha for performance issues, and not easy to consult for the average librarian. I was thinking of a real "feature" permitting any fund owner/user to see the modifications of their fund. It means at least (very quick draft) - creating a new column inital_amount in aqbudgets - creating a new SQL table like aqbudgets_changes - each new line aqbudgets_changes would add or substract money (with an optional comment) to aqbudgets.budget_amount, without altering aqbudgets.inital_amount and of course some substantial modifications to the templates -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0

[Bug 34297] New: When merging invoices, amounts are not correctly formatted
by bugzilla-daemon＠bugs.koha-community.org 17 Jul '23

17 Jul '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34297 Bug ID: 34297 Summary: When merging invoices, amounts are not correctly formatted Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Acquisitions Assignee: koha-bugs(a)lists.koha-community.org Reporter: katrin.fischer(a)bsz-bw.de QA Contact: testopia(a)bugs.koha-community.org When merging 2 invoices from the invoices table, the amounts in the table and the amount in the form are not formatted correctly appearing as 1.0000. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0

[Bug 34049] New: Keep track of fund amount modification
by bugzilla-daemon＠bugs.koha-community.org 17 Jul '23

17 Jul '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34049 Bug ID: 34049 Summary: Keep track of fund amount modification Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs(a)lists.koha-community.org Reporter: mathsabypro(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org It would be interesting to add a function to historicize funds amount, keeping track of their modification. Some other ILS have this feature. Ex : A fund is created with an amount of 10000. After X months, the head librarian decides to reduce it to 8000, with a note explaining why ; and an email is automatically send to the owner and users of the fund In my library this kind of modification is not rare, and it is hard to keep track of these changes. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 1

[Bug 13325] Add logs for budgets and funds
by bugzilla-daemon＠bugs.koha-community.org 17 Jul '23

17 Jul '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13325 Lisette Scheer <lisette.scheer(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mathsabypro(a)gmail.com --- Comment #13 from Lisette Scheer <lisette.scheer(a)bywatersolutions.com> --- *** Bug 34049 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0

[Bug 12421] No way to get back to search results from overdrive results
by bugzilla-daemon＠bugs.koha-community.org 17 Jul '23

17 Jul '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12421 Owen Leonard <oleonard(a)myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle(a)bywatersolutions.com, | |nick(a)bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12802] Send notices using several email addresses
by bugzilla-daemon＠bugs.koha-community.org 17 Jul '23

17 Jul '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12802 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|matthias.meusburger@biblibr |julian.maurice(a)biblibre.com |e.com | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12802] Send notices using several email addresses
by bugzilla-daemon＠bugs.koha-community.org 17 Jul '23

17 Jul '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12802 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #108 from Julian Maurice <julian.maurice(a)biblibre.com> --- Patch rebased on master. Ready to be tested again -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12802] Send notices using several email addresses
by bugzilla-daemon＠bugs.koha-community.org 17 Jul '23

17 Jul '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12802 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149232|0 |1 is obsolete| | --- Comment #107 from Julian Maurice <julian.maurice(a)biblibre.com> --- Created attachment 153540 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153540&action=e… Bug 12802: Sent notices using several email addresses Currently it is not possible to select several email addresses to notify a patron. The only place where the mechanism exists is in the overdue_notices.pl script. This patch reuses the AutoEmailPrimaryAddress syspref and changes its type to "multiple". Like that it is now possible to select several email addresses. Note that there is no sense to select OFF and another value for this pref. So if the 'OFF' (first valid) value exist, it takes the priority. It will add the ability to choose the email addresses to use to notify patrons. The option is "email", "emailpro" and "B_email". If "OFF" is selected, the first valid address will be returned (same behavior as before this patch). Note for the QA step: I found a possible regression, but IMO it's not a big deal: Before this patch if a letter did not contain a "to_address", the C4::Letters::_send_message_by_email subroutine retrieve the email from the given borrowernumber. This is now done in the EnqueueMessage subroutine. What it means: If a borrower didn't have an email address when the notice was sent to the queue, the email address won't be check again when the notice will really sent to the patron. This change permits to sent a letter to the queue (EnqueueLetter) without any information (from_address, to_address), only the borrowernumber is mandatory to retrieve them. The _send_message_by_email subroutine should not contain any useful code, only sent the letter we ask it to sent. What this patch does: The Koha::Patron::notice_email_address subroutine has been renamed to Koha::Patron::notice_email_addresses (plural). It only gets the patron emails defined in the AutoEmailPrimaryAddress pref. If no 'to_address' parameter is given to EnqueueMessage, the emails will be retrieved at this moment. In C4::Message: An old form was found. The AutoEmailPrimaryAddress was not check. The smsalertnumber was sent for the to_address param, which is wrong. C4::Reserves: AddReserve and _koha_notify_reserve: The from address is built in the QueueLetter. It is useless to do it here. overdue_notices.pl: The script could be cleaned a little bit if we remove the --email parameter. Indeed it is redundant with this new enhancement. I can propose another patch with a die statement and a message: "you should use the pref AutoEmailPrimaryAddress" if the --email is provided. opac/opac-shareshelf.pl and opac/opac-memberentry.pl: just remove the from and to address. They will be filled on sending to the queue (because of the borrowernumber). Test plan: 1. Apply this patch without updating the pref AutoEmailPrimaryAddress (or fill it with a single value if it is not done yet). 2. Try the different way to sent notices to a patron (check the following letter code: HOLD, CHECKIN, CHECKOUT, PREDUE, RENEW, DUE). 3. Verify the email is correctly sent to the message_queue. 4. Fill the pref with email and emailpro (for instance) 5. Verify that 2 notices are sent to the message_queue: 1 with the email and 1 with the emailpro. 6. You can also verify that only 1 notice is generated if the emailpro is empty. Important note for testers: Pending messages must be removed each time you change the value of AutoEmailPrimaryAddress. When there are already existing pending messages for a borrower, Koha tries to update them rather than enqueuing new ones, but it will not update the recipient's email address, nor add/remove messages depending on the new value of AutoEmailPrimaryAddress; not sure if this is a bug or not. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 33963] New: Remove C4::BackgroundJob
by bugzilla-daemon＠bugs.koha-community.org 17 Jul '23

17 Jul '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33963 Bug ID: 33963 Summary: Remove C4::BackgroundJob Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart+koha(a)gmail.com Reporter: jonathan.druart+koha(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org Depends on: 33962 No more occurrences! Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33962 [Bug 33962] Remove C4::BackgroundJob from process_koc -- You are receiving this mail because: You are watching all bug changes.

1 13