August 2023 - Koha-bugs - lists.koha-community.org

[Bug 29716] New: [DOCS] Automated screenshots
by bugzilla-daemon＠bugs.koha-community.org 27 Sep '23

27 Sep '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29716 Bug ID: 29716 Summary: [DOCS] Automated screenshots Change sponsored?: --- Product: Koha Version: master Hardware: All URL: https://gitlab.com/davidnind/koha-automated-screenshot s OS: All Status: ASSIGNED Severity: enhancement Priority: P4 Component: Documentation Assignee: david(a)davidnind.com Reporter: david(a)davidnind.com QA Contact: testopia(a)bugs.koha-community.org See if we can automate the capture of as many screenshots as possible for the Koha documentation, in as many languages as possible. -- You are receiving this mail because: You are watching all bug changes.

1 8

[Bug 29992] New: Default Apache config should contain CGIPassAuth directive
by bugzilla-daemon＠bugs.koha-community.org 27 Sep '23

27 Sep '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29992 Bug ID: 29992 Summary: Default Apache config should contain CGIPassAuth directive Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: andrew.isherwood(a)ptfs-europe.com QA Contact: testopia(a)bugs.koha-community.org By default, authorization headers are stripped out by Apache and therefore do not reach the underlying CGI script. This causes problems when Koha is receiving API requests that contain them as the client just receives a 401 response, even if a valid token was provided. I propose we add the CGIPassAuth directive to the API Directory blocks. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 6

[Bug 25948] New: Clean up apache protocols and ciphers
by bugzilla-daemon＠bugs.koha-community.org 27 Sep '23

27 Sep '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25948 Bug ID: 25948 Summary: Clean up apache protocols and ciphers Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Installation and upgrade (command-line installer) Assignee: koha-bugs(a)lists.koha-community.org Reporter: mtompset(a)hotmail.com QA Contact: testopia(a)bugs.koha-community.org SSLCipherSuite was truncated and different between the OPAC and Intranet sections. While cleaning that up, removed TLSv1 as it is supposed to be deprecated already. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 7

[Bug 19014] New: Limit auto-renewal notice to item due immediately. Template Toolkit change ?
by bugzilla-daemon＠bugs.koha-community.org 26 Sep '23

26 Sep '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19014 Bug ID: 19014 Summary: Limit auto-renewal notice to item due immediately. Template Toolkit change? Change sponsored?: --- Product: Koha Version: 17.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Notices Assignee: koha-bugs(a)lists.koha-community.org Reporter: r.delahunty(a)arts.ac.uk QA Contact: testopia(a)bugs.koha-community.org Current functionality in 17.05: All copies of an item with auto-renewal enabled, reserved at the title level. Due dates of copies on loan include today, and various dates into the future, some many weeks ahead. When the auto-renewal job runs, Koha is sending an AUTO_RENEWAL email to ALL the users warning them ALL of renewal failure, using the [% ELSIF checkout.auto_renew_error == 'on_reserve' %] Desired functionality in 17.05: When the auto-renewal job runs, Koha should only send an AUTO_RENEWAL email to the user (or possibly users) whose copy is due back today, on the day the auto-renewal job runs. Other people who have copies on loan but which are not yet due back yet should not be contacted by the AUTO_RENEWAL email. Users contacted in this way are being very puzzled and confused. Could this be achieved by an edit to the condition in the template toolkit? So rather this: [% ELSIF checkout.auto_renew_error == 'on_reserve' %] This item has been reserved by another reader. … we have something like this: [% ELSIF checkout.auto_renew_error == 'on_reserve' && checkout.date_due %==today %] This item has been reserved by another reader. Would that work? Is a second condition permissible? How should it be worded? Ray Delahunty University of the Arts London -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 121

[Bug 32603] New: Suggester category in Suggestions management
by bugzilla-daemon＠bugs.koha-community.org 26 Sep '23

26 Sep '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32603 Bug ID: 32603 Summary: Suggester category in Suggestions management Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Acquisitions Assignee: koha-bugs(a)lists.koha-community.org Reporter: frederic(a)tamil.fr QA Contact: testopia(a)bugs.koha-community.org In Suggestions management, it would be intersting to know the suggester category. This way, it would be possible for example for the librarian managing suggestions rather to prioritize suggestions coming from teachers than those coming from students. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 19

[Bug 34319] New: Upgrade Cypress
by bugzilla-daemon＠bugs.koha-community.org 26 Sep '23

26 Sep '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34319 Bug ID: 34319 Summary: Upgrade Cypress Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Test Suite Assignee: jonathan.druart+koha(a)gmail.com Reporter: jonathan.druart+koha(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org We are currently using 9.7.0. Since 10 the config file structure changed, and has been renamed cypress.json to cypress.config.ts https://docs.cypress.io/guides/references/migration-guide#Migrating-to-Cypr… Also cypress-studio (used for bug 34076) is not working on 9.7.0. -- You are receiving this mail because: You are watching all bug changes.

1 29

[Bug 28010] New: add plugin to modify record in "opac-detail.pl"
by bugzilla-daemon＠bugs.koha-community.org 26 Sep '23

26 Sep '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28010 Bug ID: 28010 Summary: add plugin to modify record in "opac-detail.pl" Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Plugin architecture Assignee: koha-bugs(a)lists.koha-community.org Reporter: koha(a)trust-box.at QA Contact: testopia(a)bugs.koha-community.org Created attachment 118560 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118560&action=e… patch to opac-detail.pl I (guess I) need the abiltiy to change how records are beeing display in in opac-detail.pl Specifically I want to change the content of a record depending if a user is logged in or not for ebook renting So it would be great to have the ability to have a plugin hook there, something like 1 diff --git a/opac-detail.pl.orig b/opac-detail.pl 2 index e74cf4b..b46eb90 100755 3 --- a/opac-detail.pl.orig 4 +++ b/opac-detail.pl 5 @@ -217,6 +217,16 @@ if ( $xslfile ) { 6 $variables = { %$variables, %$plugin_variables }; 7 } 8 9 + $record = Koha::Plugins->call_apply( 10 + 'munge_record', 11 + $record, 12 + { 13 + patron => $patron, 14 + interface => 'opac', 15 + caller => 'opac-detail', 16 + } 17 + ); 18 + additionally I have a proposal to extend/modify the plugin system a little bit: I don't like the idea very much that the caller of a plugin has to take care of merging the results so the first step would be to add the ability that a plugin works recursively on a variable diff --git a/Plugins.pm.orig b/Plugins.pm index 11d44dc..71461de 100644 --- a/Plugins.pm.orig +++ b/Plugins.pm @@ -82,6 +82,35 @@ sub call { return @responses; } +=head2 call_apply + +Calls a plugin method for all enabled plugins, reworking on the same input and returning it. +ideally the caller of a plugin must not know how to merge the results +so maybe also implement a "merge" method in the plugin + + @responses = Koha::Plugins->call_apply($method, $work_var, @args) + +=cut + +sub call_apply { + my ($class, $method, $work_var, @args) = @_; + + if (C4::Context->config('enable_plugins')) { + my @plugins = $class->new({ enable_plugins => 1 })->GetPlugins({ method => $method }); + @plugins = grep { $_->can($method) } @plugins; + foreach my $plugin (@plugins) { + my $work_var = eval { $plugin->$method($work_var, @args) }; + if ($@) { + warn sprintf("Plugin error (%s): %s", $plugin->get_metadata->{name}, $@); + next; + } + } + + } + return $work_var; +} + + =head2 GetPlugins In another my idea would be to have an optional "merge" method for a certain type of plugins to avoid code like 206 207 my @plugin_responses = Koha::Plugins->call( 208 'opac_detail_xslt_variables', 209 { 210 biblio_id => $biblionumber, 211 lang => $lang, 212 patron_id => $borrowernumber 213 214 } 215 ); 216 for my $plugin_variables ( @plugin_responses ) { 217 $variables = { %$variables, %$plugin_variables }; 218 } 219 and be able to write something along the lines of 206 207 my $variables = Koha::Plugins->call( 208 'opac_detail_xslt_variables', + $variables, 209 { 210 biblio_id => $biblionumber, 211 lang => $lang, 212 patron_id => $borrowernumber 213 214 } 215 ); I hope I haven't packed to much into one issue, thanks a lot -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 10

[Bug 26288] New: Update the Select2 JS lib to version 4.1.0
by bugzilla-daemon＠bugs.koha-community.org 26 Sep '23

26 Sep '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26288 Bug ID: 26288 Summary: Update the Select2 JS lib to version 4.1.0 Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: jonathan.druart(a)bugs.koha-community.org QA Contact: testopia(a)bugs.koha-community.org Bug 25727 updated Select2 to the latest stable release (4.0.13). We found some glitches about the width (see bug 25727 comment 19 for instance). It seems that the next 4.1 is going to fix it, but still beta. -- You are receiving this mail because: You are watching all bug changes.

1 6

[Bug 32352] New: xt/check_makefile.t failing on node_modules
by bugzilla-daemon＠bugs.koha-community.org 26 Sep '23

26 Sep '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32352 Bug ID: 32352 Summary: xt/check_makefile.t failing on node_modules Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Test Suite Assignee: chris(a)bigballofwax.co.nz Reporter: jonathan.druart+koha(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org 21:55:20 koha_1 | # Failed test 'All directories must be listed in Makefile.PL' 21:55:20 koha_1 | # at xt/check_makefile.t line 39. 21:55:20 koha_1 | # got: '1' 21:55:20 koha_1 | # expected: '0' 21:55:20 koha_1 | # $VAR1 = [ 21:55:20 koha_1 | # './node_modules' 21:55:20 koha_1 | # ]; -- You are receiving this mail because: You are watching all bug changes.

1 16

[Bug 33918] New: Improve translation of title tags: Patron card creator
by bugzilla-daemon＠bugs.koha-community.org 25 Sep '23

25 Sep '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33918 Bug ID: 33918 Summary: Improve translation of title tags: Patron card creator Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org CC: testopia(a)bugs.koha-community.org Blocks: 33906 This patch will modify patron card creator templates in the staff client so that translatable strings in the <title> tag are wrapped in the correct translation function, e.g. [% t('Translate me') %] Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33906 [Bug 33906] [OMNIBUS] Improve translation of title tags -- You are receiving this mail because: You are watching all bug changes.

1 11