September 2023 - Koha-bugs - lists.koha-community.org

[Bug 34765] New: Display list of Packages for an Agreement as paginated table
by bugzilla-daemon＠bugs.koha-community.org 12 Sep '23

12 Sep '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34765 Bug ID: 34765 Summary: Display list of Packages for an Agreement as paginated table Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: ERM Assignee: jonathan.druart+koha(a)gmail.com Reporter: ian(a)bywatersolutions.com CC: jonathan.druart+koha(a)gmail.com, jonathan.field(a)ptfs-europe.com, martin.renvoize(a)ptfs-europe.com, matt.blenkinsop(a)ptfs-europe.com, pedro.amorim(a)ptfs-europe.com For Agreements that have a large number of associated Packages, the UI bogs down when fetching the page. Moving to a paginated data table, similar to how Titles are displayed on Packages, would alleviate this slowness, and also provide searchability of Packages from the Agreement details page. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 27849] New: Koha::Token may access undefined C4::Context->userenv
by bugzilla-daemon＠bugs.koha-community.org 12 Sep '23

12 Sep '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27849 Bug ID: 27849 Summary: Koha::Token may access undefined C4::Context->userenv Change sponsored?: --- Product: Koha Version: 20.11 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: mjr(a)software.coop QA Contact: testopia(a)bugs.koha-community.org The _add_default_csrf_params internal function accesses C4::Context->userenv without checking that it has been defined. I think not all of the potential callers of it declare that they require a defined userenv, so we should test and provide defaults for required values if it is not defined, to avoid some "Can't use an undefined value as a HASH reference" HTTP 500 Internal Server Errors. Step to Reproduce: write some code that results in that function being used before a set_userenv call Actual Result: error logged, code exits Expected Result: code runs to completion Additional Information: I am not sure whether this is currently triggered by any released core koha code, or only a few plugins and mods. It looks to me like a bug waiting to happen, based on the documentation, which can be avoided simply. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 21

[Bug 15504] Track Patron's Last Activity
by bugzilla-daemon＠bugs.koha-community.org 12 Sep '23

12 Sep '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 Eric Bégin <eric.begin(a)inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|maksim.sen(a)inlibro.com | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15504] Track Patron's Last Activity
by bugzilla-daemon＠bugs.koha-community.org 12 Sep '23

12 Sep '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard(a)myacpl.org -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15504] Track Patron's Last Activity
by bugzilla-daemon＠bugs.koha-community.org 12 Sep '23

12 Sep '23

1 0

[Bug 15504] Track Patron's Last Activity
by bugzilla-daemon＠bugs.koha-community.org 12 Sep '23

12 Sep '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 David Nind <david(a)davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155296|0 |1 is obsolete| | --- Comment #63 from David Nind <david(a)davidnind.com> --- Created attachment 155540 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155540&action=e… Bug 15504: (follow-up) Migrate to one clear method We were using a series of similarly named methods spread in distinct places around the codebase. This combines the logic of C4::Auth::track_login_daily and Koha::Patron->track_login into a new Koha::Patron->update_lastseen method. Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> Signed-off-by: David Nind <david(a)davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15504] Track Patron's Last Activity
by bugzilla-daemon＠bugs.koha-community.org 12 Sep '23

12 Sep '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 David Nind <david(a)davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155295|0 |1 is obsolete| | --- Comment #62 from David Nind <david(a)davidnind.com> --- Created attachment 155539 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155539&action=e… Bug 15504: (follow-up) Unit tests This patch removes, moves and updates the existing unit tests for track_login_daily and track_login to all sit under Koha::Patron and update_lastseen. Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> Signed-off-by: David Nind <david(a)davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15504] Track Patron's Last Activity
by bugzilla-daemon＠bugs.koha-community.org 12 Sep '23

12 Sep '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 David Nind <david(a)davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155294|0 |1 is obsolete| | --- Comment #61 from David Nind <david(a)davidnind.com> --- Created attachment 155538 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155538&action=e… Bug 15504: Add unit test prove -v t/db_dependent/Auth.t Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> Signed-off-by: David Nind <david(a)davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15504] Track Patron's Last Activity
by bugzilla-daemon＠bugs.koha-community.org 12 Sep '23

12 Sep '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 David Nind <david(a)davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155293|0 |1 is obsolete| | --- Comment #60 from David Nind <david(a)davidnind.com> --- Created attachment 155537 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155537&action=e… Bug 15504: Remove update_lastseen method This patch removes update_lastseen which has been replaced by a call to track_login_daily Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> Signed-off-by: David Nind <david(a)davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15504] Track Patron's Last Activity
by bugzilla-daemon＠bugs.koha-community.org 12 Sep '23

12 Sep '23

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 David Nind <david(a)davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155292|0 |1 is obsolete| | --- Comment #59 from David Nind <david(a)davidnind.com> --- Created attachment 155536 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155536&action=e… Bug 15504: Add triggers to instances of track_login_daily This patch adds a trigger to every instance of track_login_daily Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> Signed-off-by: David Nind <david(a)davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

1 0