January 2024 - Koha-bugs - lists.koha-community.org

[Bug 14293] Error in the calculation of the suspension of users per day
by bugzilla-daemon＠bugs.koha-community.org 12 Jan '24

12 Jan '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14293 --- Comment #57 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 160925 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160925&action=e… Bug 14293: (QA follow-up) Remove copy and paste test The comment is in contradiction with the code. The test has been copied. Not needed to repeat it. Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14293] Error in the calculation of the suspension of users per day
by bugzilla-daemon＠bugs.koha-community.org 12 Jan '24

12 Jan '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14293 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159504|0 |1 is obsolete| | --- Comment #56 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 160924 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160924&action=e… Bug 14293: The suspension should be calculated in days There was a mismatch between bug 13909 and bug 5549. The get_chargeable_units call from _debar_user_on_return should specify that we want a suspension in days. However I don't understand the comment let by the author of bug 5549 f61a9617184ec4b24100c1d99150bfd4ebf13336 1/ > finedays is in days, so hourly loans must multiply by 24 Yes but the suspension is in days, so no need to * 24 2/ And we should have a look on this one too: > grace period is measured in the same units as the loan But the grace period is always in days. On the circ rules the column is "Fine grace period (day)". I think we should replace DateTime::Duration->new( $unit => $issuingrule->{firstremind} ); with DateTime::Duration->new( days => $issuingrule->{firstremind} ); Anyway, we definitelly need more tests in this area! Test plan: 1/ Define an issuing rule with a unit=hour 2/ Set a suspension in days 3/ Check an item out and specify a past due date. 4/ Check the item in 5/ The patron should be debarred correctly Signed-off-by: David Nind <david(a)davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14293] Error in the calculation of the suspension of users per day
by bugzilla-daemon＠bugs.koha-community.org 12 Jan '24

12 Jan '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14293 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|Medium patch |Small patch -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 34412] New: Inconsistencies in System preferences page titles, breadcrumbs, and header
by bugzilla-daemon＠bugs.koha-community.org 12 Jan '24

12 Jan '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34412 Bug ID: 34412 Summary: Inconsistencies in System preferences page titles, breadcrumbs, and header Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: caroline.cyr-la-rose(a)inlibro.com QA Contact: testopia(a)bugs.koha-community.org While testing bug 33909, I had to look at all the pages in the administration module. In doing so, I found some inconsistencies between the various pages. For the System preferences (local use preferences) page, here is what should be changed to make it consistent with the other pages in the module: Page title - Change 'Add a system preference' to 'New system preference' - Change "Confirm deletion of parameter 'variable'" to "Confirm deletion of system preference 'variable'" - Change 'Parameter deleted' to 'System preference deleted' Breadcrumb - Change 'Add a system preference' to 'New system preference' - Change "Confirm deletion of parameter 'variable'" to "Confirm deletion of system preference 'variable'" - In Confirm deletion, remove variable level - Change 'Parameter deleted' to 'System preference deleted' Page header - Change 'Add a system preference' to 'New system preference' - Styling of 'Add a system preference' header different than usual - Change 'Modify a system preference' to "Modify system preference 'variable'" - Styling of 'Modify a system preference' header different than usual - Change "Confirm deletion of 'variable'?" to "Confirm deletion of system preference 'variable'" - Change 'Data deleted' to 'System preference deleted' Styling of the Confirm deletion page is different than usual. It's usually a warning (yellow background) centered on the page. The buttons are white with a green checkmark for 'Yes, delete' and white with a red cross for 'No, do not delete' -- You are receiving this mail because: You are watching all bug changes.

1 23

[Bug 14293] Error in the calculation of the suspension of users per day
by bugzilla-daemon＠bugs.koha-community.org 12 Jan '24

12 Jan '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14293 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia(a)bugs.koha-communit |m.de.rooy(a)rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14293] Error in the calculation of the suspension of users per day
by bugzilla-daemon＠bugs.koha-community.org 12 Jan '24

12 Jan '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14293 --- Comment #55 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Looking here now -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13345] Choose the format when sending a basket/list by email
by bugzilla-daemon＠bugs.koha-community.org 12 Jan '24

12 Jan '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13345 Mathieu Saby <mathsabypro(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mathsabypro(a)gmail.com -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 35372] New: Support for empty AdvancedSearchTypes
by bugzilla-daemon＠bugs.koha-community.org 12 Jan '24

12 Jan '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35372 Bug ID: 35372 Summary: Support for empty AdvancedSearchTypes Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching Assignee: koha-bugs(a)lists.koha-community.org Reporter: aleisha(a)catalyst.net.nz QA Contact: testopia(a)bugs.koha-community.org Some organisations using Koha do not have holdings/items, and would like to be able to hide the advanced search 'items' panels, controlled by the AdvancedSearchTypes system preference. However if this is left empty, item types filters still show by default. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 9

[Bug 35732] New: No translation is required
by bugzilla-daemon＠bugs.koha-community.org 12 Jan '24

12 Jan '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35732 Bug ID: 35732 Summary: No translation is required Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: translate.koha-community.org Assignee: koha-bugs(a)lists.koha-community.org Reporter: Igor.A.Sychev(a)mail.ru QA Contact: testopia(a)bugs.koha-community.org %sURL: %s%s%s -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 3

[Bug 35780] New: HoldsAutoFill allows both a hold and a recall to be filled simultaneously by the same item
by bugzilla-daemon＠bugs.koha-community.org 11 Jan '24

11 Jan '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35780 Bug ID: 35780 Summary: HoldsAutoFill allows both a hold and a recall to be filled simultaneously by the same item Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Hold requests Assignee: koha-bugs(a)lists.koha-community.org Reporter: emily.lamancusa(a)montgomerycountymd.gov QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com To replicate: 1. Configure sysprefs: HoldsAutoFill to Do HoldsAutoFillPrintSlip to Do (optional but makes behavior very obvious) UseRecalls to Use 2. Edit the default circ rule to set a nonzero value for max recalls allowed and recalls per record allowed 3. Check out an item to Patron A 4. Place a hold on that title for Patron B 5. Place a recall on that title for Patron C 6. Check in Patron A's item --> Patron B's hold autofills --> Note that you still get a modal to confirm Patron C's recall 7. Confirm Patron C's recall --> Note that the hold and the recall are both set to "Waiting" with the same item -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 0