April 2024 - Koha-bugs - lists.koha-community.org

[Bug 6796] Overnight checkouts taking into account opening and closing hours
by bugzilla-daemon＠bugs.koha-community.org 09 Apr '24

09 Apr '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6796 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #164516|0 |1 is obsolete| | --- Comment #139 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 164543 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164543&action=e… Bug 6796: Don't add a day if hourly loan period pushes due date If ConsiderLibraryHoursWhenIssuing is set to shorten the loan period to the closing time, if the loan period initially pushes the due date to the following day, the day still gets added when calculating the due date. We simply need to hardcode the due time here as the due day is the same as the issue day. We only need to calculate a due date if ConsiderLibraryHoursWhenIssuing is set to extend the loan period to the next opening day, as we'll need to consider holidays/closed days. Sponsored-by: Catalyst IT Sponsored-by: Auckland University of Technology Signed-off-by: Sam Lau <samalau(a)gmail.com> Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 6796] Overnight checkouts taking into account opening and closing hours
by bugzilla-daemon＠bugs.koha-community.org 09 Apr '24

09 Apr '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6796 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #164515|0 |1 is obsolete| | --- Comment #138 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 164542 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164542&action=e… Bug 6796: Fix saving of libraries and tests Sponsored-by: Catalyst IT Sponsored-by: Auckland University of Technology Signed-off-by: Sam Lau <samalau(a)gmail.com> Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 6796] Overnight checkouts taking into account opening and closing hours
by bugzilla-daemon＠bugs.koha-community.org 09 Apr '24

09 Apr '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6796 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #164514|0 |1 is obsolete| | --- Comment #137 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 164541 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164541&action=e… Bug 6796: (follow-up) Fix logic for calculating following day's open hours Since days for branch hours are stored as 0-6 in the database, when it's a Saturday (6) incrementing the date leads to an error when issuing an hourly loan because no opening hours are found for the non-existent day (7). This patch fixes this by calculating the tomorrow day and setting it to 0 if it's greater than 6. This patch also corrects the mappings for days, where local_day_of_week caluclates the date with Sunday first, which put it out of sync with the database opening hours days. Sponsored-by: Catalyst IT Sponsored-by: Auckland University of Technology Signed-off-by: Sam Lau <samalau(a)gmail.com> Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 6796] Overnight checkouts taking into account opening and closing hours
by bugzilla-daemon＠bugs.koha-community.org 09 Apr '24

09 Apr '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6796 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #164513|0 |1 is obsolete| | --- Comment #136 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 164540 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164540&action=e… Bug 6796: Consider library hours when calculating due date + tests This feature adds the ability to set opening and closing hours for your library and for these hours to be considered when calculating due dates for hourly loans. If the due date for an hourly loan falls after the library closes, the library can choose for the due date to be shortened to meet the close time, or extended to meet the open time the next day. This feature adds a new table 'branch_hours' for storing the open and close times per day for each library, and a new system preference 'ConsiderLibraryHoursInCirculation' to choose which behaviour should be followed when calculating due dates. To test: 1. Apply patches and update database. Upgrade schema if not applying patch with schema changes. Restart services. 2. Go to Administration -> Libraries. Edit a library and scroll to the bottom to find the 'opening hours' section. Test adding and removing open and close times on various days. Confirm saving works as expected. 3. Add a new library and test adding open and close times works as expected. 4. Edit your default library and save open and close times for each day. 5. Go to Administration -> Circulation and fine rules. Edit a rule, set the unit to 'hours' and set the loan period to a number that would cause a checkout to be due after the close time you just set, i.e. if you set your close time to be 5pm and your system time is currently 1pm, set the loan period to be 5 (5 hours) so the calculated due date would be 6pm. 6. Go to Administration -> system preferences. Search for ConsiderLibraryHoursInCirculation. It should be under 'Checkout policy' in the Circulation system preferences. Confirm the pre-selected option is 'ignore'. Keep this tab open. 6. In a new tab, get the barcode for an item that has an itemtype matching the circulation rule you just set. 7. Go to the checkouts for a patron that has a categorycode matching the circulation rule you just set. 8. Check out your item. Confirm that the checkout is due at the end of the loan period, not taking closing hours into consideration. Return the item. 9. Back in your other tab, set ConsiderLibraryHoursInCirculation to 'close', so the due date should be shortened to meet the close time. 10. Check out your item. Confirm the checkout is due when the library closes. Return the item. 11. Back in your other tab, set ConsiderLibraryHoursInCirculation to 'open', so the due date should be extended to meet the opening time. 12. Check out your item. Confirm the checkout is due the next day when the library opens. 13. Confirm tests pass t/db_dependent/Circulation/CalcDateDue.t Sponsored-by: Catalyst IT Signed-off-by: Sam Lau <samalau(a)gmail.com> Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 6796] Overnight checkouts taking into account opening and closing hours
by bugzilla-daemon＠bugs.koha-community.org 09 Apr '24

09 Apr '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6796 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #164512|0 |1 is obsolete| | --- Comment #135 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 164539 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164539&action=e… Bug 6796: ConsiderLibraryHoursInCirculation system preference Sponsored-by: Catalyst IT Signed-off-by: Sam Lau <samalau(a)gmail.com> Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 6796] Overnight checkouts taking into account opening and closing hours
by bugzilla-daemon＠bugs.koha-community.org 09 Apr '24

09 Apr '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6796 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #164511|0 |1 is obsolete| | --- Comment #134 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 164538 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164538&action=e… Bug 6796: Add library_hours table and set opening hours for library Sponsored-by: Catalyst IT Signed-off-by: Sam Lau <samalau(a)gmail.com> Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 6796] Overnight checkouts taking into account opening and closing hours
by bugzilla-daemon＠bugs.koha-community.org 09 Apr '24

09 Apr '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6796 --- Comment #133 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- CSRF has somehow broken this, but I'm struggling to work out why. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13706] Deduping authorities script (dedup_authorities.pl)
by bugzilla-daemon＠bugs.koha-community.org 09 Apr '24

09 Apr '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13706 --- Comment #22 from David Cook <dcook(a)prosentient.com.au> --- Ohhh I kept meaning to look at this. I wrote an authority de-duplicator years ago, and I'm planning on reviewing it soon. Maybe I can replace my local one with this one. I'll have to take a look... -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 30260] New: Script which checks index should also check if the zebraqueue has uncommitted records
by bugzilla-daemon＠bugs.koha-community.org 09 Apr '24

09 Apr '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30260 Bug ID: 30260 Summary: Script which checks index should also check if the zebraqueue has uncommitted records Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: aleisha(a)catalyst.net.nz QA Contact: testopia(a)bugs.koha-community.org currently our monitoring checks if the indexer is running, and sends an alert if it it isn't. however we've found that sometimes the indexer looks like it is running but the process may not have started fully, and the indexer isn't working. new records and modified records don't show in search results. when we view the zebraqueue in the database, there are rows that have not been committed, i.e. `zebraqueue.done` == 0. checkindex.sh should check if there are rows in the zebraqueue that have not been committed. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 13

[Bug 8137] Checkout limit for all libraries
by bugzilla-daemon＠bugs.koha-community.org 08 Apr '24

08 Apr '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8137 Brendan Lawlor <blawlor(a)clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |blawlor(a)clamsnet.org -- You are receiving this mail because: You are watching all bug changes.

1 0