August 2024 - Koha-bugs - lists.koha-community.org

[Bug 2486] Show user comments in staff interface
by bugzilla-daemon＠bugs.koha-community.org 06 Aug '24

06 Aug '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2486 Laura Escamilla <Laura.escamilla(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #167703|0 |1 is obsolete| | --- Comment #10 from Laura Escamilla <Laura.escamilla(a)bywatersolutions.com> --- Created attachment 170093 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170093&action=e… Bug 2486: Show user comments in staff interface This patch the staff interface's bibliographic detail page, adding a tab that shows comments submitted by users from the OPAC. To test, apply the patch and restart services. - If necessary, enable the "OPACComments" system preference and submit some comments in the OPAC. - In the staff interface, locate the title you submitted comments on. - The bibliographic detail page should show a "Comments" tab with a count of the number of all comments (approved and unapproved). Sponsored-By: Athens County Public Libraries Signed-off-by: Lucas Gass <lucas(a)bywatersolutions.com> Signed-off-by: Laura_Escamilla <laura.escamilla(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 28122] New: Remove old syslog config from SIPconfig.xml
by bugzilla-daemon＠bugs.koha-community.org 06 Aug '24

06 Aug '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28122 Bug ID: 28122 Summary: Remove old syslog config from SIPconfig.xml Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: SIP2 Assignee: koha-bugs(a)lists.koha-community.org Reporter: magnus(a)libriotech.no QA Contact: testopia(a)bugs.koha-community.org It used to be that logging for the SIP2 server was configured in SIPconfig.xml: <server-params min_servers='1' min_spare_servers='0' log_file='Sys::Syslog' syslog_ident='koha_sip' syslog_facility='local6' /> The last 3 lines are the relevant ones. These lines are still present in the template file for Debian packages: https://git.koha-community.org/Koha-community/Koha/src/branch/master/debian… Then "Bug 15253: Add Koha::Logger based logging for SIP2" added logging based on log4perl for SIP2. But as far as I can see, the remnants of syslog config makes the SIP2 server not run properly. To reproduce: If you are on a dev setup (e.g. kohadevbox), copy the log4perl template to the standard location: $ sudo cp kohaclone/debian/templates/log4perl-site.conf.in /etc/koha/log4perl-site.conf.in Create a new site, called siptest: $ sudo koha-create --create-db siptest Verify that /etc/koha/sites/siptest/log4perl.conf has a section for SIP: log4perl.logger.sip = DEBUG, SIP log4perl.appender.SIP=Log::Log4perl::Appender::File log4perl.appender.SIP.filename=/var/log/koha/siptest/sip.log log4perl.appender.SIP.mode=append log4perl.appender.SIP.layout=PatternLayout log4perl.appender.SIP.layout.ConversionPattern=[%d] [%p] %m %l %n log4perl.appender.SIP.utf8=1 Enable and start the SIP2 server: $ sudo koha-sip --enable siptest Enabling SIP server for siptest - edit /etc/koha/sites/siptest/SIPconfig.xml to configure $ sudo koha-sip --start siptest Use ps to check if the SIP server is actually running: $ ps aux | grep SIPServer siptest+ 20084 0.0 0.0 18708 1732 ? S 15:40 0:00 daemon --name=siptest-koha-sip --errlog=/var/log/koha/siptest/sip-error.log --stdout=/var/log/koha/siptest/sip.log --output=/var/log/koha/siptest/sip-output.log --verbose=1 --respawn --delay=30 --pidfiles=/var/run/koha/siptest --user=siptest-koha.siptest-koha -- perl /home/vagrant/kohaclone/lib/C4/SIP/SIPServer.pm /etc/koha/sites/siptest/SIPconfig.xml vagrant 20294 0.0 0.0 12780 968 pts/0 R+ 15:44 0:00 grep SIPServer This output means the daemon is running, but not the SIP-server itself. Edit /etc/koha/sites/siptest/SIPconfig.xml and remove these three lines: log_file='Sys::Syslog' syslog_ident='koha_sip' syslog_facility='local6' Then restarte the SIP2 server: $ sudo koha-sip --restart siptest Then run ps again: $ ps aux | grep SIPServer siptest+ 20383 0.0 0.0 18708 196 ? S 15:44 0:00 daemon --name=siptest-koha-sip --errlog=/var/log/koha/siptest/sip-error.log --stdout=/var/log/koha/siptest/sip.log --output=/var/log/koha/siptest/sip-output.log --verbose=1 --respawn --delay=30 --pidfiles=/var/run/koha/siptest --user=siptest-koha.siptest-koha -- perl /usr/share/koha/lib/C4/SIP/SIPServer.pm /etc/koha/sites/siptest/SIPconfig.xml siptest+ 20385 42.0 8.2 382120 169104 ? S 15:44 0:01 perl /usr/share/koha/lib/C4/SIP/SIPServer.pm /etc/koha/sites/siptest/SIPconfig.xml siptest+ 20390 0.0 7.6 382120 156460 ? S 15:44 0:00 perl /usr/share/koha/lib/C4/SIP/SIPServer.pm /etc/koha/sites/siptest/SIPconfig.xml vagrant 20392 0.0 0.0 12780 968 pts/0 S+ 15:44 0:00 grep SIPServer Lines that contain "perl /usr/share/koha/lib/C4/SIP/SIPServer.pm /etc/koha/sites/siptest/SIPconfig.xml" indicate the actual SIP2 server is running. I think what needs to be done is: - Remove the 3 syslog-related lines from etc/SIPconfig.xml and debian/templates/SIPconfig.xml - Add a note to the release notes that the 3 lines need to be removed from SIPconfig.xml fles that are in active use PS! I have not looked deeply at *why* those three config lines makes the SIPserver fail to run, just that removing them fixes the problem. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 20

[Bug 9504] URL escape in OPAC more searches
by bugzilla-daemon＠bugs.koha-community.org 06 Aug '24

06 Aug '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9504 Michał <schodkowy.omegi-0r(a)icloud.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=37573 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 35228] REST API: Restricted staff users can see patron extended attributes (not exposed via UI)
by bugzilla-daemon＠bugs.koha-community.org 06 Aug '24

06 Aug '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35228 --- Comment #3 from David Cook <dcook(a)prosentient.com.au> --- I feel like there is a different bug report for this one too... -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 0

[Bug 35227] REST API: Restricted staff users can see patron info (not exposed via UI)
by bugzilla-daemon＠bugs.koha-community.org 06 Aug '24

06 Aug '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35227 --- Comment #7 from David Cook <dcook(a)prosentient.com.au> --- I think this one might not be valid anymore. I think bug 29509 may have fixed it? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0

[Bug 33305] New: Standing orders: Allow to link received item to another bibliographic record on receive
by bugzilla-daemon＠bugs.koha-community.org 05 Aug '24

05 Aug '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33305 Bug ID: 33305 Summary: Standing orders: Allow to link received item to another bibliographic record on receive Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs(a)lists.koha-community.org Reporter: katrin.fischer(a)bsz-bw.de QA Contact: testopia(a)bugs.koha-community.org CC: michaela.sieber(a)kit.edu At the moment we use standing orders for multi-volume and series ordering mostly. The order is placed on the set or traced series record. When a part of the series is delivered and received, the order line will still be linked to the set records. This makes all acquisition information appear on the set record, instead of the parts. If you are using items, you can use the "attach item" feature, to change it to the record of the part, but this means a lot of additional clicks. It will also not work if you are not creating items in acq. It would be nice, if you could link the received order line to the correct part as part of the receiving process. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 1

[Bug 36216] New: Hide Show checkouts/charges to guarantor when not necessary
by bugzilla-daemon＠bugs.koha-community.org 05 Aug '24

05 Aug '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36216 Bug ID: 36216 Summary: Hide Show checkouts/charges to guarantor when not necessary Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs(a)lists.koha-community.org Reporter: caroline.cyr-la-rose(a)inlibro.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com In the patron file (moremember.pl), there is always "Show checkouts to guarantor" and "Show charges to guarantor", even if the library doesn't use the guarantor feature. If AllowStaffToSetCheckoutsVisibilityForGuarantor and AllowPatronToSetCheckoutsVisibilityForGuarantor are both set to "Don't allow", or if the patron has no guarantor, I think the "Show checkouts to guarantor" field should be hidden. Same for AllowStaffToSetFinesVisibilityForGuarantor and AllowPatronToSetFinesVisibilityForGuarantor. If both are set to "Don't allow" or if the patron has no guarantor, the "Show charges to guarantor" should be hidden. I'm thinking especially of academic libraries and special libraries, this is useless information that shows in the patron file. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 2

[Bug 37571] New: Redirect from Privacy policy after consent registered
by bugzilla-daemon＠bugs.koha-community.org 05 Aug '24

05 Aug '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37571 Bug ID: 37571 Summary: Redirect from Privacy policy after consent registered Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard(a)myacpl.org Reporter: aude.charillon(a)ptfs-europe.com QA Contact: testopia(a)bugs.koha-community.org When using the PrivacyPolicyConsent preference, the page opac-patron-consent.pl appears when patrons first login to the OPAC. Once they have saved their consent, the message "Your consent was registered on YYYY-MM-DDT00:00:00." appears above the Save button and that Save button is disabled. This is confusing for some patrons, who expect to be redirected to their account summary after seeing the confirmation message. If redirecting is not an option, clarifying the message would be helpful - e.g., "Your consent was registered on YYYY-MM-DDT00:00:00 - you may now use the website." -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 37565] New: bulkmarcimport should have an option to prevent record indexing
by bugzilla-daemon＠bugs.koha-community.org 05 Aug '24

05 Aug '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37565 Bug ID: 37565 Summary: bulkmarcimport should have an option to prevent record indexing Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Command-line Utilities Assignee: koha-bugs(a)lists.koha-community.org Reporter: nick(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org CC: robin(a)catalyst.net.nz When loading large files we sometimes want to have speed emphasized over completeness - it would be nice to be able to skip indexing and manually reindex after a large record load -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 1

[Bug 37018] SQL injection using q under api/
by bugzilla-daemon＠bugs.koha-community.org 05 Aug '24

05 Aug '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37018 --- Comment #159 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Similarly just wondering if + if ( ref $element eq 'ARRAY' && $element->[0] eq '-and' ) { + _validate_query( $element->[1] ); this catches everything ? -- You are receiving this mail because: You are watching all bug changes.

1 0