August 2024 - Koha-bugs - lists.koha-community.org

[Bug 14322] Can't link to an item search
by bugzilla-daemon＠bugs.koha-community.org 01 Aug '24

01 Aug '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14322 --- Comment #24 from Brendan Lawlor <blawlor(a)clamsnet.org> --- (In reply to David Nind from comment #18) > It looked like everything was all working as expected, however I came across > a situation using the + New field: > - Home library is: Centerville > - Barcode is 39999% > - AND Title is %perl% > - Search (6 results) > - Copy shareable link > - Paste the link in a new tab > - Get 321 results > - When you edit the search the AND is changed to an OR Thanks, David, for testing and spotting that bug! This was caused because of assuming getting the 'c' param would return an array. When there is only a single 'c' param it's just a string, so I added a check for that too. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 36532] Any authenticated OPAC user can run opac-dismiss-message.pl for any user/any message
by bugzilla-daemon＠bugs.koha-community.org 01 Aug '24

01 Aug '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36532 --- Comment #15 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- (In reply to Fridolin Somers from comment #14) > I've done a message to @fredericdemians in chat Seeing that it was reverted in 22.11.x -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14322] Can't link to an item search
by bugzilla-daemon＠bugs.koha-community.org 01 Aug '24

01 Aug '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14322 --- Comment #23 from Brendan Lawlor <blawlor(a)clamsnet.org> --- Created attachment 169952 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169952&action=e… Bug 14322: (follow-up) Perl tidy -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14322] Can't link to an item search
by bugzilla-daemon＠bugs.koha-community.org 01 Aug '24

01 Aug '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14322 --- Comment #22 from Brendan Lawlor <blawlor(a)clamsnet.org> --- Created attachment 169951 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169951&action=e… Bug 14322: (follow-up) add check for single logical operator param -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14322] Can't link to an item search
by bugzilla-daemon＠bugs.koha-community.org 01 Aug '24

01 Aug '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14322 --- Comment #21 from Brendan Lawlor <blawlor(a)clamsnet.org> --- Created attachment 169950 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169950&action=e… Bug 14322: (follow-up) make shareable link load results immediately -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14322] Can't link to an item search
by bugzilla-daemon＠bugs.koha-community.org 01 Aug '24

01 Aug '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14322 --- Comment #20 from Brendan Lawlor <blawlor(a)clamsnet.org> --- Created attachment 169949 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169949&action=e… Bug 14322: (follow-up) update shareable link button style -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14322] Can't link to an item search
by bugzilla-daemon＠bugs.koha-community.org 01 Aug '24

01 Aug '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14322 Brendan Lawlor <blawlor(a)clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #169304|0 |1 is obsolete| | Attachment #169305|0 |1 is obsolete| | Attachment #169306|0 |1 is obsolete| | --- Comment #19 from Brendan Lawlor <blawlor(a)clamsnet.org> --- Created attachment 169948 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169948&action=e… Bug 14322: Add shareable link button to item search This patch adds a 'Copy shareable link' button to the item search results page. When pasted into the browser the item search form will be prefilled. The item search form submission still gets it's parameters from the form. Test plan: 1. Apply patch 2. Try some item searches (try searches using the '+ New field' button too) 3. On the results page click the 'Copy shareable link' button 4. Paste the link into the browser and hit enter 5. Notice the item search form is filled out exactly as you did earlier 6. Click 'Search' and confirm the results are as you would expect 7. Click 'Edit search', modify the search and search again 8. Test the 'Copy shareable link' button again 9. Test pasting the example link below 10. With default ktd data the search will return one result for: Intermediate Perl / Schwartz, Randal L. http://localhost:8081/cgi-bin/koha/catalogue/itemsearch.pl?homebranch_op=%3…'Reilly%2C&c=and&f=publicationyear&op=like&q=2006&c=and&f=title&op=not%20like&q=Javascript%20%3A&c=and&f=author&op=not%20like&q=Carlson%2C%20Lucas.&itemcallnumber_from=&itemcallnumber_to=&issues_op=%3E&issues=&datelastborrowed_op=%3E&datelastborrowed=&format=shareable Sponsored-by: CLAMS -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14322] Can't link to an item search
by bugzilla-daemon＠bugs.koha-community.org 01 Aug '24

01 Aug '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14322 Brendan Lawlor <blawlor(a)clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 34478] Full CSRF protection
by bugzilla-daemon＠bugs.koha-community.org 01 Aug '24

01 Aug '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34478 Koha collecto <koha(a)collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |koha(a)collecto.ca -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 24007] New: Koha::Account::non_issues_charges is badly named
by bugzilla-daemon＠bugs.koha-community.org 01 Aug '24

01 Aug '24

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24007 Bug ID: 24007 Summary: Koha::Account::non_issues_charges is badly named Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs(a)lists.koha-community.org Reporter: martin.renvoize(a)ptfs-europe.com QA Contact: testopia(a)bugs.koha-community.org The non_issues_charges method name suggests you will be returned a set of charges (Account::Lines) which would block a patrons ability to check out items. In fact, it returns a 'balance' of such charges but includes outstanding credits in the calculation. We should either rename the method to clarify it's use or update the method to return the expectation given it's naming. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 10