April 2025 - Koha-bugs - lists.koha-community.org

[Bug 14250] Don't allow to generate discharges for patrons with fines
by bugzilla-daemon＠bugs.koha-community.org 18 Apr '25

18 Apr '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14250 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181154|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14250] Don't allow to generate discharges for patrons with fines
by bugzilla-daemon＠bugs.koha-community.org 18 Apr '25

18 Apr '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14250 --- Comment #55 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 181157 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181157&action=e… Bug 14250: (QA follow-up) Small changes Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> [EDIT] Changed commit title. Tidied opac script. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14250] Don't allow to generate discharges for patrons with fines
by bugzilla-daemon＠bugs.koha-community.org 18 Apr '25

18 Apr '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14250 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181150|0 |1 is obsolete| | --- Comment #54 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 181156 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181156&action=e… Bug 14250: Patron with fines cannot be discharged anymore TEST PLAN: 1 - In the intranet add fines to a client and ensure they have no checkout 2 - Set syspref useDischarge to 'Allow' 3 - On client profile click on "Discharge", see it is possible 4 - On the opac, go to the tab "Ask for discharge", see it is possible 5 - Apply patch 6 - Click on the button "Ask for discharge" -> it will not be possible and you will be propperly messaged 7 - Return to the tab "Ask for a discharge", there will be no button anymore 8 - On the intranet page, there will be no button anymore 9 - Check out a book 10 - Repeat 7 and 8 and see the message include issue with checkout 11 - Remove fine and repeat 7 & 8 Bug 14250: (QA follow-up) Deduplicate checks Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> Bug 14250: (follow-up) Update messages Update the text for the reasons the patron cannot be discharged. Bug 14250: (follow-up) Refacto the algorithm for discharge messages TEST PLAN: 1 - In the intranet add fines to a client and ensure they have no checkout 2 - Set syspref useDischarge to 'Allow' 3 - On client profile click on "Discharge", see it is possible 4 - On the opac, go to the tab "Ask for discharge", see it is possible 5 - Apply patch 6 - Click on the button "Ask for discharge" -> it will not be possible and you will be propperly messaged 7 - Return to the tab "Ask for a discharge", there will be no button anymore 8 - On the intranet page, there will be no button anymore 9 - Check out a book 10 - Repeat 7 and 8 and see the message include issue with checkout 11 - Remove fine and repeat 7 & 8 Note: removing the useless has_checkout and has_debt Bug 14250: (follow-up) Refacto discharge messages display The script that determines if one should display messages to the user, informing him whether they are allowed or not to ask for a discharge is quite hard to understand. For sake of readability, transforming the unless to an if since the error behaviour was in the unless and the success in the else. Changing to success behaviour in the if and failure in the else. Bug 14250: Tidy Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 39407] New: Having no active currency defined breaks SIP silently
by bugzilla-daemon＠bugs.koha-community.org 18 Apr '25

18 Apr '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39407 Bug ID: 39407 Summary: Having no active currency defined breaks SIP silently Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: SIP2 Assignee: koha-bugs(a)lists.koha-community.org Reporter: kyle(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org In the staff interface, in most areas of Koha that require an active currency to be defined, a large info box appears to let the user know there is no active currency defined. Our SIP code presumes an active currency and if one is not defined, any SIP messages utilizing C4::SIP::ILS::Patron will crash with no errors such that a response is never transmitted for the request. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 12

[Bug 14250] Don't allow to generate discharges for patrons with fines
by bugzilla-daemon＠bugs.koha-community.org 18 Apr '25

18 Apr '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14250 --- Comment #53 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski(a)biblibre.com> --- Created attachment 181154 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181154&action=e… Bug 14250: (qa-followup) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14250] Don't allow to generate discharges for patrons with fines
by bugzilla-daemon＠bugs.koha-community.org 18 Apr '25

18 Apr '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14250 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14250] Don't allow to generate discharges for patrons with fines
by bugzilla-daemon＠bugs.koha-community.org 18 Apr '25

18 Apr '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14250 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia(a)bugs.koha-communit |m.de.rooy(a)rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14250] Don't allow to generate discharges for patrons with fines
by bugzilla-daemon＠bugs.koha-community.org 18 Apr '25

18 Apr '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14250 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #52 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Comment49 needs feedback. opac/opac-discharge.pl +my $has_pending_checkouts = $patron->checkouts->count; This line is a remnant of older code, I guess? Not used anymore. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14250] Don't allow to generate discharges for patrons with fines
by bugzilla-daemon＠bugs.koha-community.org 18 Apr '25

18 Apr '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14250 --- Comment #51 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- (In reply to Baptiste Wojtkowski (bwoj) from comment #47) > Note for QA/RM, there are a lot of little commits here, feel free to squash > every patch I'm authoring Done -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14250] Don't allow to generate discharges for patrons with fines
by bugzilla-daemon＠bugs.koha-community.org 18 Apr '25

18 Apr '25

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14250 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179618|0 |1 is obsolete| | Attachment #179619|0 |1 is obsolete| | Attachment #179620|0 |1 is obsolete| | Attachment #179621|0 |1 is obsolete| | Attachment #179622|0 |1 is obsolete| | Attachment #181149|0 |1 is obsolete| | --- Comment #50 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 181150 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181150&action=e… Bug 14250: Patron with fines cannot be discharged anymore TEST PLAN: 1 - In the intranet add fines to a client and ensure they have no checkout 2 - Set syspref useDischarge to 'Allow' 3 - On client profile click on "Discharge", see it is possible 4 - On the opac, go to the tab "Ask for discharge", see it is possible 5 - Apply patch 6 - Click on the button "Ask for discharge" -> it will not be possible and you will be propperly messaged 7 - Return to the tab "Ask for a discharge", there will be no button anymore 8 - On the intranet page, there will be no button anymore 9 - Check out a book 10 - Repeat 7 and 8 and see the message include issue with checkout 11 - Remove fine and repeat 7 & 8 Bug 14250: (QA follow-up) Deduplicate checks Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> Bug 14250: (follow-up) Update messages Update the text for the reasons the patron cannot be discharged. Bug 14250: (follow-up) Refacto the algorithm for discharge messages TEST PLAN: 1 - In the intranet add fines to a client and ensure they have no checkout 2 - Set syspref useDischarge to 'Allow' 3 - On client profile click on "Discharge", see it is possible 4 - On the opac, go to the tab "Ask for discharge", see it is possible 5 - Apply patch 6 - Click on the button "Ask for discharge" -> it will not be possible and you will be propperly messaged 7 - Return to the tab "Ask for a discharge", there will be no button anymore 8 - On the intranet page, there will be no button anymore 9 - Check out a book 10 - Repeat 7 and 8 and see the message include issue with checkout 11 - Remove fine and repeat 7 & 8 Note: removing the useless has_checkout and has_debt Bug 14250: (follow-up) Refacto discharge messages display The script that determines if one should display messages to the user, informing him whether they are allowed or not to ask for a discharge is quite hard to understand. For sake of readability, transforming the unless to an if since the error behaviour was in the unless and the success in the else. Changing to success behaviour in the if and failure in the else. Bug 14250: Tidy -- You are receiving this mail because: You are watching all bug changes.

1 0