October 2026 - Koha-bugs - lists.koha-community.org

[Bug 43391] Add POD to all private subroutines/methods
by bugzilla-daemon＠bugs.koha-community.org 18 Oct '26

18 Oct '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43391 Tomás Cohen Arazi (tcohen) <tomascohen(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #204336|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 43391] Add POD to all private subroutines/methods
by bugzilla-daemon＠bugs.koha-community.org 18 Oct '26

18 Oct '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43391 Tomás Cohen Arazi (tcohen) <tomascohen(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #204335|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 43391] Add POD to all private subroutines/methods
by bugzilla-daemon＠bugs.koha-community.org 18 Oct '26

18 Oct '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43391 Tomás Cohen Arazi (tcohen) <tomascohen(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #204334|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 43391] Add POD to all private subroutines/methods
by bugzilla-daemon＠bugs.koha-community.org 18 Oct '26

18 Oct '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43391 Tomás Cohen Arazi (tcohen) <tomascohen(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #204333|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 43391] Add POD to all private subroutines/methods
by bugzilla-daemon＠bugs.koha-community.org 18 Oct '26

18 Oct '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43391 Tomás Cohen Arazi (tcohen) <tomascohen(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff --- Comment #21 from Tomás Cohen Arazi (tcohen) <tomascohen(a)gmail.com> --- I'm proposing a counter patchset that replaces the generated placeholder POD with real POD, while keeping the goal of this bug. - Jonathan's xt patch is kept unchanged (it is still his, with David's sign-off). I only added a test plan to the commit message. - The 382 'Missing POD for <sub>.' placeholders are not needed anymore: - 232 private subs get a real description (what they do, parameters, return value, side effects). - _type and object_class get one standard, class-agnostic POD in all Koha::Object(s) classes (452 + 227). Koha::Object and Koha::Objects show it as the form to copy into new classes. - The generated patch also left 139 empty '=head3 type' headings (a typo for '_type' the script did not recognise) and used =head2 everywhere. This is fixed too. - Code is unchanged once POD is stripped, except that in 5 files the constant _type/object_class subs are moved after the last method. IMPORTANT: The new POD is LLM-generated and human-curated. It still needs other human eyes. The commit message lists the entries with complex or surprising behaviour that deserve a careful review. Some possible bugs in the existing code were spotted while writing the POD. The patches describe the current behaviour as-is; the bugs will be reported separately. Back to Needs Signoff, as the content changed. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 43391] Add POD to all private subroutines/methods
by bugzilla-daemon＠bugs.koha-community.org 18 Oct '26

18 Oct '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43391 --- Comment #20 from Tomás Cohen Arazi (tcohen) <tomascohen(a)gmail.com> --- Created attachment 208446 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=208446&action=e… Bug 43391: Add POD to private subroutines/methods This patch adds POD for the 232 private subs in C4/, Koha/ and t/lib/ that had none, as now required by xt/author/pod_coverage.t. Each entry describes what the sub does, its parameters, return value and non-obvious side effects. Only POD changes; the code is identical once POD is stripped. It also keeps a few POD structure fixes from Jonathan Druart's original patch on this bug (missing NAME section, misplaced headings). IMPORTANT: The POD in this patch is LLM-generated and human-curated. Each entry was written after reading the sub and its callers, but it still needs other human eyes before it can be trusted. Wrong POD is worse than no POD, so please review it critically. Most entries are trivial. The entries below involve non-trivial logic or behaviour that is easy to misdescribe, and deserve a careful review against the code: Complex: - C4/Acquisition.pm: _cancel_items_receipt - C4/Auth_with_cas.pm: _get_cas_and_service (authentication) - C4/Breeding.pm: _add_custom_field_rowdata, _handle_one_result - C4/Budgets.pm: _recursiveAdd (recursive fund totals) - C4/Creators/Lib.pm: _build_query, _SELECT (dynamic SQL) - C4/ImportExportFramework.pm: _import_table (deletes rows) - C4/Labels/Label.pm: _get_barcode_data (format string parser) - C4/Reports/Guided.pm: _build_query (dynamic SQL) - C4/Search.pm: _build_weighted_query - C4/Serials.pm: _can_do_on_subscription (permissions), _delta_units, _get_next_date_week - C4/SIP/ILS/Transaction/Checkin.pm: _get_sort_bin - Koha/BackgroundJob/CreateEHoldingsFromBiblios.pm: _get_unimarc_mapping - Koha/Cache/Object.pm: FETCH - Koha/Edifact/Line.pm: _parse_lines - Koha/FrameworkPlugin.pm: _load - Koha/Token.pm: _add_default_csrf_params, _chk_csrf (CSRF) - Koha/Uploader.pm: _create_file - t/lib/TestBuilder.pm: _buildColumnValue Requires care (behaviour differs from what the name suggests, or depends on caller assumptions): - C4/Auth_with_cas.pm: _url_with_get_params - C4/Auth_with_shibboleth.pm: _sync - C4/Budgets.pm: _round (truncates, does not round) - C4/ImportExportFramework.pm: _getDataFields, _openODS - C4/Search.pm: _build_stemmed_operand - C4/Serials.pm: _handle_seqno - C4/Service.pm: _output - C4/Tags.pm: _set_weight, _set_weight_total - Koha/Authority/ControlledIndicators.pm: _load_pref - Koha/BackgroundJob/CreateEHoldingsFromBiblios.pm: _get_marc21_mapping - Koha/Cache/Object.pm: CLEAR - Koha/CookieManager.pm: _should_be_removed - Koha/Database.pm: _new_schema - Koha/Notice/Util.pm: _convert_unit, _get_domain_count - Koha/Token.pm: _chk_jwt - Koha/Uploader.pm: _hook While writing this, several possible bugs were spotted in the existing code. They are documented as-is here (no behaviour change) and will be reported separately. Test plan: 1. Apply this patch 2. Run: $ ktd --shell k$ prove xt/author/pod_coverage.t xt/author/pod_checker.t => SUCCESS: Tests pass! 3. Confirm no placeholder POD is added: k$ git diff origin/main | grep -c '^+Missing POD for ' => SUCCESS: 0 4. Review the POD, paying special attention to the entries listed above 5. Sign off :-D Assisted-by: Opus 5.5 (Anthropic) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 43391] Add POD to all private subroutines/methods
by bugzilla-daemon＠bugs.koha-community.org 18 Oct '26

18 Oct '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43391 --- Comment #19 from Tomás Cohen Arazi (tcohen) <tomascohen(a)gmail.com> --- Created attachment 208445 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=208445&action=e… Bug 43391: Harmonize _type and object_class POD This patch makes the POD of every _type and object_class method in the Koha::Object(s) subclasses identical. Each one is documented under an '=head2 Internal methods' section with one class-agnostic sentence, so it can be copied into new classes unchanged: =head2 Internal methods =head3 _type Returns the name of the DBIx::Class result source this class maps to. =cut =head3 object_class Returns the name of the Koha::Object class this set is made of. =cut Koha::Object and Koha::Objects now show this as the form to use. Changes: - 452 _type and 227 object_class subs use the standard POD. The object_class in Koha::File::Transports is computed, so it keeps its own POD. - The previous variants are removed: empty headings, hand-written descriptions, 49 placeholders from bug 39367, and 140 '=head3 type' headings (a typo for '_type'). - An '=head2 Internal methods' section is added to the 242 files that had none, and 11 'Internal Methods' headings are lower-cased. - 132 '=head2 Class Methods' headings whose only content was _type are removed, as they would be left empty. - In Koha/Report.pm, Koha/StockRotationItem.pm, Koha/StockRotationItems.pm, Koha/StockRotationStage.pm and Koha/Suggestion.pm public methods followed _type, so the constant _type/object_class subs are moved after the last method. This keeps public methods out of the new section. No functional changes. The patch was generated with a script. Apart from the subs moved in those 5 files, the code is identical once POD is stripped. Test plan: 1. Apply this patch 2. Run: $ ktd --shell k$ prove xt/author/pod_checker.t => SUCCESS: Tests pass! 3. Check the POD of a few classes, e.g.: k$ perldoc Koha::Cities k$ perldoc Koha::Objects => SUCCESS: _type and object_class are listed under 'Internal methods' with the standard text, and Koha::Objects shows it as the form to use in new classes 4. Sign off :-D Assisted-by: Opus 5.5 (Anthropic) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 43391] Add POD to all private subroutines/methods
by bugzilla-daemon＠bugs.koha-community.org 18 Oct '26

18 Oct '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43391 --- Comment #18 from Tomás Cohen Arazi (tcohen) <tomascohen(a)gmail.com> --- Created attachment 208444 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=208444&action=e… Bug 43391: Adjust xt test to catch missing POD for private methods This patch makes xt/author/pod_coverage.t check private methods too, by passing 'private => []' to Pod::Coverage. Without it, subs starting with an underscore are skipped, so the QA script and the xt test disagree and new private subs can land without POD. Test plan: 1. Apply only this patch 2. Run: $ ktd --shell k$ prove xt/author/pod_coverage.t => FAIL: Private methods without POD are reported 3. Apply the remaining patches 4. Repeat step 2 => SUCCESS: Tests pass! 5. Sign off :-D Signed-off-by: David Nind <david(a)davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 43391] Add POD to all private subroutines/methods
by bugzilla-daemon＠bugs.koha-community.org 18 Oct '26

18 Oct '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43391 Tomás Cohen Arazi (tcohen) <tomascohen(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #204337|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 42602] New: Patron search performance is poor if there are many patrons
by bugzilla-daemon＠bugs.koha-community.org 18 Oct '26

18 Oct '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42602 Bug ID: 42602 Summary: Patron search performance is poor if there are many patrons Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs(a)lists.koha-community.org Reporter: pedro.amorim(a)openfifth.co.uk QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle(a)bywatersolutions.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 11