March 2026 - Koha-bugs - lists.koha-community.org

[Bug 14962] Temp Shelving Location / On Display Module
by bugzilla-daemon＠bugs.koha-community.org 02 Mar '26

02 Mar '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14962 --- Comment #118 from Martin Renvoize (ashimema) <martin.renvoize(a)openfifth.co.uk> --- Created attachment 194320 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194320&action=e… Bug 14962: (QA follow-up) Use dt_from_string instead of DateTime->today in Displays->active DateTime->today uses the system timezone rather than the Koha-configured timezone, which can cause incorrect date comparisons for libraries that configure a timezone different from the server's local time. Use Koha::DateUtils::dt_from_string, which is the standard Koha convention and is consistent with every other date comparison in this feature. Sponsored-by: ByWater Solutions Signed-of-by: Martin Renvoize <martin.renvoize(a)openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14962] Temp Shelving Location / On Display Module
by bugzilla-daemon＠bugs.koha-community.org 02 Mar '26

02 Mar '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14962 --- Comment #117 from Martin Renvoize (ashimema) <martin.renvoize(a)openfifth.co.uk> --- Created attachment 194318 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194318&action=e… Bug 14962: (QA follow-up) Use correct displays permission flag in API tests All 'authorized librarian' test users in displays.t and displayitems.t were created with flags => 1 (superlibrarian), which bypasses all permission checks. The comment said "displays permission" but bit 0 is the superlibrarian flag. The displays module is userflags bit 33, so use flags => 2**33 to actually test that the displays flag grants access. Sponsored-by: ByWater Solutions Signed-of-by: Martin Renvoize <martin.renvoize(a)openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14962] Temp Shelving Location / On Display Module
by bugzilla-daemon＠bugs.koha-community.org 02 Mar '26

02 Mar '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14962 --- Comment #116 from Martin Renvoize (ashimema) <martin.renvoize(a)openfifth.co.uk> --- Created attachment 194317 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194317&action=e… Bug 14962: (QA follow-up) Fix display_name type and required mismatch in OpenAPI definition The database defines display_name as varchar(255) DEFAULT NULL (nullable), but the OpenAPI definition declared it as a non-nullable string and listed it in the required array. This contradicted the schema. Allow null for display_name and remove it from required to match the actual database column definition. Sponsored-by: ByWater Solutions Signed-of-by: Martin Renvoize <martin.renvoize(a)openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14962] Temp Shelving Location / On Display Module
by bugzilla-daemon＠bugs.koha-community.org 02 Mar '26

02 Mar '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14962 --- Comment #115 from Martin Renvoize (ashimema) <martin.renvoize(a)openfifth.co.uk> --- Created attachment 194316 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194316&action=e… Bug 14962: (QA follow-up) Change branch/itype FK on displays to ON DELETE SET NULL The foreign keys from displays.display_branch, display_holding_branch, and display_itype used ON DELETE CASCADE, which would silently delete entire displays when an admin removes a branch or item type. These columns are optional configuration references, not ownership relationships (all are nullable DEFAULT NULL). Use ON DELETE SET NULL so the display is preserved and the reference is simply cleared, which is consistent with how items.homebranch references branches. Update atomicupdate, kohastructure.sql, and the DBIC schema to match. Sponsored-by: ByWater Solutions Signed-of-by: Martin Renvoize <martin.renvoize(a)openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14962] Temp Shelving Location / On Display Module
by bugzilla-daemon＠bugs.koha-community.org 02 Mar '26

02 Mar '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14962 --- Comment #114 from Martin Renvoize (ashimema) <martin.renvoize(a)openfifth.co.uk> --- Created attachment 194315 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194315&action=e… Bug 14962: (QA follow-up) Set bug_number in atomicupdate script The bug_number field was left as an empty string. The Koha installer framework uses this field to track which database updates have been applied and to report status. Set it to 14962. Sponsored-by: ByWater Solutions Signed-of-by: Martin Renvoize <martin.renvoize(a)openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14962] Temp Shelving Location / On Display Module
by bugzilla-daemon＠bugs.koha-community.org 02 Mar '26

02 Mar '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14962 --- Comment #113 from Martin Renvoize (ashimema) <martin.renvoize(a)openfifth.co.uk> --- Created attachment 194314 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194314&action=e… Bug 14962: (QA follow-up) Remove display_type filter parameter with no backing field The display_type query parameter was declared on both GET /displays and GET /public/displays but there is no display_type column in the displays table, no such property in the schema definition, and no accessor in the DBIC schema. Remove the parameter to avoid confusing API consumers. Sponsored-by: ByWater Solutions Signed-of-by: Martin Renvoize <martin.renvoize(a)openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14962] Temp Shelving Location / On Display Module
by bugzilla-daemon＠bugs.koha-community.org 02 Mar '26

02 Mar '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14962 --- Comment #112 from Martin Renvoize (ashimema) <martin.renvoize(a)openfifth.co.uk> --- Created attachment 194313 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194313&action=e… Bug 14962: (QA follow-up) Eliminate N+1 Koha::Items->find in search result rendering Five display-aware helper closures in C4::Search each independently called Koha::Items->find($item->{itemnumber}). For a search page with 20 results and 5 items each, this produced up to 500 extra DB queries per page when UseDisplayModule was enabled. Introduce a shared $item_obj_cache keyed by itemnumber so the item object is fetched at most once per item across all five closures. Sponsored-by: ByWater Solutions Signed-of-by: Martin Renvoize <martin.renvoize(a)openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14962] Temp Shelving Location / On Display Module
by bugzilla-daemon＠bugs.koha-community.org 02 Mar '26

02 Mar '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14962 --- Comment #111 from Martin Renvoize (ashimema) <martin.renvoize(a)openfifth.co.uk> --- Created attachment 194312 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194312&action=e… Bug 14962: (QA follow-up) Add date_remove filter to active_display_item active_display_item() was missing a date_remove check, unlike active_display() which correctly excludes expired display items. This method is called from C4::Circulation::AddReturn to decide whether to apply display_return_over logic. Without the filter, items past their date_remove date would still trigger removal logic even though every other part of the system treats them as no longer on display. Sponsored-by: ByWater Solutions Signed-of-by: Martin Renvoize <martin.renvoize(a)openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14962] Temp Shelving Location / On Display Module
by bugzilla-daemon＠bugs.koha-community.org 02 Mar '26

02 Mar '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14962 --- Comment #110 from Martin Renvoize (ashimema) <martin.renvoize(a)openfifth.co.uk> --- Created attachment 194311 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194311&action=e… Bug 14962: (QA follow-up) Apply full active-display filter in get_public get_public only checked end_date, allowing disabled displays and displays not yet started to be retrieved by unauthenticated OPAC users. Apply the same criteria used by Koha::Displays->active: enabled must be true, start_date must be null or in the past, and end_date must be null or in the future. Sponsored-by: ByWater Solutions Signed-of-by: Martin Renvoize <martin.renvoize(a)openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14962] Temp Shelving Location / On Display Module
by bugzilla-daemon＠bugs.koha-community.org 02 Mar '26

02 Mar '26

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14962 --- Comment #109 from Martin Renvoize (ashimema) <martin.renvoize(a)openfifth.co.uk> --- Created attachment 194310 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194310&action=e… Bug 14962: (QA follow-up) Fix barcode handling and async form reset in batch components Two bugs in both batch add and batch remove Vue components: 1. Barcodes were coerced to Number via .map(n => Number(n)), which converts alphanumeric barcodes (e.g. BC-00012345) to NaN and strips leading zeros from numeric ones. Replace with trim+filter to keep barcodes as strings. 2. clearForm() was called synchronously after registering the .then() callback, so the form was always cleared before the API response arrived. On error the user lost all entered barcodes. Move clearForm() inside the success callback. Also clean up DisplaysBatchRemoveItems: remove unused useTemplateRef, storeToRefs, config, and setWarning; link success message to the specific background job ID. Sponsored-by: ByWater Solutions Signed-of-by: Martin Renvoize <martin.renvoize(a)openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.

1 0