January 2010 - Koha-bugs - lists.koha-community.org

[Bug 3361] New: Option to choose the number of titles to display in a list page.
by bugzilla-daemon＠liblime.com 14 May '10

14 May '10

http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=3361 Summary: Option to choose the number of titles to display in a list page. Product: Koha Version: rel_3_0 Platform: PC OS/Version: All Status: NEW Severity: enhancement Priority: P5 Component: OPAC AssignedTo: jmf(a)liblime.com ReportedBy: gcollum(a)gmail.com Estimated Hours: 0.0 Change sponsored?: --- An opac-shelves.pl list of titles is hard coded to paginate after 20 titles. I propose that this value be a system preference. Also the ability for the user to choose from a drop-down list of values (ie. 20, 50, 100, all) for the number of titles to display in a page, would be a nice feature, especially for those who like to print their lists. -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.

2 1

[Bug 3337] New: RSS link is not correct
by bugzilla-daemon＠liblime.com 14 May '10

14 May '10

http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=3337 Summary: RSS link is not correct Product: Koha Version: rel_3_0 Platform: PC OS/Version: Windows 2000 Status: NEW Severity: enhancement Priority: P5 Component: Searching AssignedTo: jmf(a)liblime.com ReportedBy: palani(a)orizin.net Estimated Hours: 0.0 Change sponsored?: --- 1. search for a item which is not in database ( say 'lalalililulu' ), so that the search generates zero results. 2. Lets say, the user want to subsribe to the rss link ( user want to get updates on his rss reader , about book 'lalalililulu' ) 3. but the RSS link on search page (with zero results) is wrong, it don't have any http GET parameter 'q=lalalililulu' -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.

2 1

[Bug 3280] New: opac/opac-sendbasket.pl security leaky
by bugzilla-daemon＠liblime.com 14 May '10

14 May '10

http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=3280 Summary: opac/opac-sendbasket.pl security leaky Product: Koha Version: HEAD Platform: Other OS/Version: Linux - Debian Status: NEW Severity: normal Priority: P3 Component: OPAC AssignedTo: jmf(a)liblime.com ReportedBy: dbavousett(a)ptfs.com Estimated Hours: 0.0 Change sponsored?: --- It is possible for a clever user who has access to the source to spot that opac-sendbasket.pl has a security leak, and use a Koha server as a spam relay. opac-sendbasket.pl uses CGI's param() method to fetch in parameters. This functions fine, but it doesn't *care* if the parameters come in via GET or POST methods. Thus, you can: http://server/cgi-bin/koha/opac-sendbasket. pl?&email_add=user(a)domain.xn--com&comment=blahblahblah-cg9nma This will send a message with the cart header as defined elsewhere, plus the comments from the "comment" param, to user(a)domain.com. A moderately-clever geek could easily work out a script to use this as a spamming tool. My suggestion would be to either use CGI_Lite, which allows for control over passing method, or manually fetching in the parameters "the hard way", which would allow you to explicitly disallow GET params in (at a minimum) email_add and comment. -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.

2 6

[Bug 3262] New: OPAC needs syspref to show homebranch instead of current location on detail page
by bugzilla-daemon＠liblime.com 14 May '10

14 May '10

http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=3262 Summary: OPAC needs syspref to show homebranch instead of current location on detail page Product: Koha Version: unspecified Platform: All OS/Version: All Status: NEW Severity: enhancement Priority: P5 Component: OPAC AssignedTo: jmf(a)liblime.com ReportedBy: wizzyrea(a)gmail.com Estimated Hours: 0.0 Change sponsored?: --- In a library system where individual libraries have different call numbers, the display on the detail page is weird and misleading. Example: The location field shows an item is currently at Wellsville Library, with a Call Number of YA F MEY. A Wellsville patron consults the OPAC and asks a staff member "where is this item?" and staff member looks and says "This is not in our library, we don't have this call number" and has to look up the item in the staff interface (we have modified our staff interface to show homebranch on the detail page instead of the current location) to determine where Wellsville's copy is located in the library. /example In my opinion, the information of current location is largely redundant, because the status field shows whether the item is in/out/on hold/in transit/etc. Lots of times, patrons only want to know if the library they are standing in actually owns the item they want. I believe this should be a syspref so home location vs. current location column can be chosen (as well as the similar column in the staff interface) by the librarian without editing templates directly. -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.

2 5

[Bug 3228] New: Default XSLT doesn't properly test for existence of fixed fields
by bugzilla-daemon＠liblime.com 14 May '10

14 May '10

http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=3228 Summary: Default XSLT doesn't properly test for existence of fixed fields Product: Koha Version: HEAD Platform: PC OS/Version: All Status: NEW Severity: minor Priority: P5 Component: OPAC AssignedTo: jmf(a)liblime.com ReportedBy: rch(a)liblime.com Estimated Hours: 0.0 Change sponsored?: --- The label for 'Type' displays in the OPAC even if there is no 006/008 present in the record. If there is no data, the label should not display. -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.

2 2

[Bug 3208] New: Inactivity "timeout" for OPAC - enhancement idea
by bugzilla-daemon＠liblime.com 14 May '10

14 May '10

http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=3208 Summary: Inactivity "timeout" for OPAC - enhancement idea Product: Koha Version: rel_3_0 Platform: PC OS/Version: Windows 2000 Status: NEW Severity: enhancement Priority: P5 Component: OPAC AssignedTo: jmf(a)liblime.com ReportedBy: adrea(a)moablibrary.org Estimated Hours: 0.0 Change sponsored?: --- Notes below are copied from the KOHA mailing list... >From Adrea... "We have computers in our library which are only used as OPACs - we would like to set up these OPAC computers to clear search history/login info/cart contents etc. after a certain period of inactivity (perhaps 2-3 minutes). So that when you sit down at an OPAC in the library you are not already logged into someone else's account. Does anyone have a solution for how to set this up? We have already experimented with the "timeout" admin system preference. It does not do the trick, because we do not want staff to be logged out of our staff module after a period of inactivity, and we do not want folks accessing their account from home to get logged out of their account automatically. We just need a solution for the OPAC computers in the library. Thanks for your help!" 1st response... from Owen Leonard "I think it'd be a great idea to create an OPAC timeout feature, and I suspect it would be fairly easy to implement. I would think you could embed a meta refresh tag on each page with the timeout set via a system preference. When the timeout was reached, the page would redirect to the logout script. Unfortunately, logging out of the OPAC doesn't empty the cart. I consider that a bug. Maybe we can get both fixed at the same time. The system I'm thinking of would necessarily apply to all OPAC sessions whether they were inside the library or out. Perhaps that means we need to build in some kind of warning message ("You are about to be logged out. Click OK to continue your session"). I'm not sure how you'd set up the feature so that it only timed out specific workstations." Adrea - see the KOHA list archives from May 2009 for more comments... my library understands that there are issues with being able to clear the search history, but our library would like to see the following... cart is cleared, account is logged out, and browser page is redirected to the catalog home page. Thanks! -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.

2 4

[Bug 3191] New: Bug in NonZebra search functions SimpleSearch() and NZOrder()
by bugzilla-daemon＠liblime.com 14 May '10

14 May '10

http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=3191 Summary: Bug in NonZebra search functions SimpleSearch() and NZOrder() Product: Koha Version: rel_3_0 Platform: PC OS/Version: All Status: NEW Severity: normal Priority: P5 Component: Searching AssignedTo: jmf(a)liblime.com ReportedBy: abcendzone(a)yahoo.com Estimated Hours: 0.0 Bug 1) The NonZebra SimpleSearch() function in C4::Search.pm has the following two inputs: - $offset: is the offset when displaying e.g. page 2 of the search results - $max_results: is the maximal number of results per page Bug: These two input parameters are NOT passed on to the NZorder() funtion on line 223 when using nonzebra search: Instead of: my $result = NZorder( NZanalyse($query) )->{'biblioserver'}; this line should pass $offset and $max_results like this: my $result = NZorder( NZanalyse($query),,$max_results,$offset )->{'biblioserver'}; Bug 2) The NonZebra NZOrder() function is supposed to order the search results and return ($results_per_page) entries starting from ($offset). The code that is supposed to do this (starting at around line 2059 in Search.pm) looks like this: # for ( # my $counter = $offset ; # $counter <= $offset + $results_per_page ; # $counter++ # ) # { # $result_hash->{'RECORDS'}[$counter] = # GetMarcBiblio( $result_hash->{'RECORDS'}[$counter] )->as_usmarc; # #if $result_hash->{'RECORDS'}[$counter]; # } # my $finalresult = (); # $result_hash->{'hits'} = $numbers; # $finalresult->{'biblioserver'} = $result_hash; # return $finalresult; But this code actually returns an array of size ($numbers), which is the TOTAL number of search results and within this array, it ONLY populates the entries from ($offset) up to ($offset + $results_per_page). So, 1. the array is way too big, 2. t has mostly empty elements 3. it returns one results too much, because from ($offset) up to ($offset+ $results_per_page) are a total of ($results_per_page+1) elements What is SHOULD do is return an array of size ($results_per_page), containing exactly ($results_per_page) search results from ($offset) up to ($offset + $results_per_page - 1). The correct code would be something like this: my $finalresult = (); #create output array $finalresult->{'biblioserver'}->{'hits'} = $numbers; #save total number of search results $numbers=0; #reset counter for ( my $counter = $offset ; $counter < $offset + $results_per_page ; #changed <= to < to return correct number of elements $counter++ ) { $finalresult->{'biblioserver'}->{'RECORDS'}[$numbers++] = GetMarcBiblio( $result_hash->{'RECORDS'}[$counter] )->as_usmarc; #populate the array from 0 to ($results_per_page-1) with the search results from ($offset) to ($offset+$results_per_page-1) } return $finalresult; The buggy code is used TWICE in NZOrder() in Search.pm, so it has to be replaced starting from line 2059 and starting from line 2113. Best regards... -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.

2 1

[Bug 3194] New: setting "hidelostitems" to ON no longer prevent a bib from displaying in OPAC if all items are lost
by bugzilla-daemon＠liblime.com 14 May '10

14 May '10

http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=3194 Summary: setting "hidelostitems" to ON no longer prevent a bib from displaying in OPAC if all items are lost Product: Koha Version: rel_3_0 Platform: All OS/Version: All Status: NEW Severity: major Priority: P5 Component: OPAC AssignedTo: jmf(a)liblime.com ReportedBy: beverly.church(a)liblime.com Estimated Hours: 0.0 There also seems to be a change in the way "hidelostitems" preference works. In the past, setting this preference to "ON" prevented bibliographic records from appearing in search results if all the bib's attached items had "lost" values greater than 0. These records are now appearing in the search results. If you go to the detail window, you get the message "No physical items for this record". -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.

2 5

[Bug 3164] New: OPAC-placed holds broken in SingleBranchMode
by bugzilla-daemon＠liblime.com 14 May '10

14 May '10

http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=3164 Summary: OPAC-placed holds broken in SingleBranchMode Product: Koha Version: HEAD Platform: PC OS/Version: All Status: NEW Severity: major Priority: P5 Component: OPAC AssignedTo: oleonard(a)myacpl.org ReportedBy: rch(a)liblime.com CC: sedwards(a)alloycomputing.com Estimated Hours: 0.0 Patrons cannot place holds on titles if SingleBranchMode is ON because the template does not supply the branchcode to opac-reserve.pl. The script returns the error 'bad_data', which displays as "ERROR: Internal error: incomplete hold request." Offending code is around line 196 of opac/opac-reserve.pl, but would be fixed by just keeping the branchcode as a param in the tmpl even if singlebranchmode is on. -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.

2 12

[Bug 3150] New: Verbiage of any email sent from Koha should be editable from web interface
by bugzilla-daemon＠liblime.com 14 May '10

14 May '10

http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=3150 Summary: Verbiage of any email sent from Koha should be editable from web interface Product: Koha Version: unspecified Platform: All OS/Version: All Status: NEW Severity: enhancement Priority: P5 Component: OPAC AssignedTo: jmf(a)liblime.com ReportedBy: wizzyrea(a)gmail.com Estimated Hours: 0.0 This is currently uneven in application. Holds notifications are editable through the web interface, but cart/list/shelf/suggestion response emails are governed by templates. -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.

2 2