October 2011 - Koha-bugs - lists.koha-community.org

[Bug 4161] When adding Vendor default to active currencies
by bugzilla-daemon＠bugs.koha-community.org 28 Oct '11

28 Oct '11

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4161 --- Comment #4 from Liz Rea <wizzyrea(a)gmail.com> 2011-10-28 16:58:20 UTC --- Created attachment 6096 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6096 Bug 4161: Preselect active currency for new vendors Currently when creating a new vendor in acquisitions the alphabetical first currency will be preselected. For better usability and less mistakes the active curency should be preselected. To test: Check your currency settings in administration. Your active currency should not be the first in the list. 1) Create a new vendor Verify the active currency is selected for list and invoice prices. 2) Check vendor summary page Verify the correct currencies from the vendor record are shown here. 3) Edit vendor Verify the correct currencies from the vendor record are shown here. Signed-off-by: Liz Rea <lrea(a)nekls.org> Verified with tests 1, 2, and 3. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

1 0

[Bug 3184] Show creator and budget receiving a document
by bugzilla-daemon＠bugs.koha-community.org 28 Oct '11

28 Oct '11

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3184 Liz Rea <wizzyrea(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #6091|0 |1 is obsolete| | -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

1 0

[Bug 3184] Show creator and budget receiving a document
by bugzilla-daemon＠bugs.koha-community.org 28 Oct '11

28 Oct '11

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3184 Liz Rea <wizzyrea(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wizzyrea(a)gmail.com Patch Status|Needs Signoff |Signed Off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

1 0

[Bug 3184] Show creator and budget receiving a document
by bugzilla-daemon＠bugs.koha-community.org 28 Oct '11

28 Oct '11

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3184 --- Comment #5 from Liz Rea <wizzyrea(a)gmail.com> 2011-10-28 16:51:47 UTC --- Created attachment 6095 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6095 Bug 3184: Show creator and budget on order receive page Reimplementing 3.0.x patch from Nahuel ANGELINETTI <nahuel.angelinetti(a)biblibre.com> To test: 1) Create basket 2) Order something, note your fund 3) Receive title > Verify your name and selected fund display correctly Previous patch had wrong bug number! Signed-off-by: Liz Rea <lrea(a)nekls.org> I verify that with this patch, the name and fund are displayed on the order receive display. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

1 0

[Bug 3624] Basket group delivery place
by bugzilla-daemon＠bugs.koha-community.org 28 Oct '11

28 Oct '11

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3624 --- Comment #24 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> 2011-10-28 16:32:14 UTC --- Ok, some things got mixed up down here: "NEW INSTALLATIONS CREATED WHILE FIELDS WHERE MISSING I have removed the 3 columns from my database and added the code below as 3.06.00.001 to my updatedatabase. The updatedatabase reported no errors, but the columns were NOT added to my database" This didn't work, because the database update was also checking for the version number - so I went back and created a real old database to test it correctly. And this WORKED. :) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

1 0

[Bug 3624] Basket group delivery place
by bugzilla-daemon＠bugs.koha-community.org 28 Oct '11

28 Oct '11

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3624 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |RESOLVED Resolution| |FIXED --- Comment #23 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> 2011-10-28 16:30:30 UTC --- Ok, I have looked into this: NEW INSTALLATIONS kohastructure.sql seems correct now. I also checked a new database, all fields are there. DROP TABLE IF EXISTS `aqbasketgroups`; CREATE TABLE `aqbasketgroups` ( `id` int(11) NOT NULL auto_increment, `name` varchar(50) default NULL, `closed` tinyint(1) default NULL, `booksellerid` int(11) NOT NULL, `deliveryplace` varchar(10) default NULL, `freedeliveryplace` text default NULL, `deliverycomment` varchar(255) default NULL, `billingplace` varchar(10) default NULL, PRIMARY KEY (`id`), KEY `booksellerid` (`booksellerid`), CONSTRAINT `aqbasketgroups_ibfk_1` FOREIGN KEY (`booksellerid`) REFERENCES `aqbooksellers` (`id`) ON UPDATE CASCADE ON DELETE CASCADE ) ENGINE=InnoDB DEFAULT CHARSET=utf8; UPDATED INSTALLATIONS Installations updating from a version number below 3.01.00.94 should be ok. I checked the sql statements are correct. First update in updatedatabase.pl: $DBversion = "3.01.00.094"; if (C4::Context->preference("Version") < TransformToNum($DBversion)) { $dbh->do(qq{ALTER TABLE aqbasketgroups ADD deliveryplace VARCHAR(10) default NULL, ADD deliverycomment VARCHAR(255) default NULL;}); $DBversion = "3.01.00.097"; if (C4::Context->preference("Version") < TransformToNum($DBversion)) { $dbh->do(qq{ALTER TABLE aqbasketgroups ADD billingplace VARCHAR(10) NOT NULL AFTER deliverycomment;}); NEW INSTALLATIONS CREATED WHILE FIELDS WHERE MISSING I have removed the 3 columns from my database and added the code below as 3.06.00.001 to my updatedatabase. The updatedatabase reported no errors, but the columns were NOT added to my databse. $DBversion = '3.03.00.023'; I created a branch for an old version of Koha (3.02.04.000) and recreated my database from scratch. The 3 columns are missing from aqbasketgroups. I checked out back to master and ran the web installer. Got some complaints about privacy and: Upgrade to 3.03.00.023 done (Reconcile aqbasketgroups) Confirmed that columns were correctly added to the datebase. if (C4::Context->preference("Version") < TransformToNum($DBversion) && $original_version < TransformToNum("3.02.05.002")) { my $sth = $dbh->prepare("SELECT * FROM INFORMATION_SCHEMA.COLUMNS WHERE TABLE_NAME = 'aqbasketgroups' AND COLUMN_NAME = 'billingplace'"); $sth->execute; $dbh->do("ALTER TABLE aqbasketgroups ADD billingplace VARCHAR(10)") if ! $sth->fetchrow_hashref; $sth = $dbh->prepare("SELECT * FROM INFORMATION_SCHEMA.COLUMNS WHERE TABLE_NAME = 'aqbasketgroups' AND COLUMN_NAME = 'deliveryplace'"); $sth->execute; $dbh->do("ALTER TABLE aqbasketgroups ADD deliveryplace VARCHAR(10)") if ! $sth->fetchrow_hashref; $sth = $dbh->prepare("SELECT * FROM INFORMATION_SCHEMA.COLUMNS WHERE TABLE_NAME = 'aqbasketgroups' AND COLUMN_NAME = 'deliverycomment'"); $sth->execute; $dbh->do("ALTER TABLE aqbasketgroups ADD deliverycomment VARCHAR(255)") if ! $sth->fetchrow_hashref; print "Upgrade to $DBversion done (Reconcile aqbasketgroups)\n"; SetVersion ($DBversion); } XHTML VALIDITY Checked on current master. Ok. I am marking this closed, please reopen if I missed something. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

1 0

[Bug 3623] acquisition, PDF printing
by bugzilla-daemon＠bugs.koha-community.org 28 Oct '11

28 Oct '11

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3623 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution| |FIXED --- Comment #3 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> 2011-10-28 15:41:43 UTC --- I am marking this fixed as PDF print of orders has been in Koha for quite a while now. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

1 0

[Bug 3388] Add a Vendor page does not have field for accountnumber
by bugzilla-daemon＠bugs.koha-community.org 28 Oct '11

28 Oct '11

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3388 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 |PATCH-Sent Patch Status|--- |Needs Signoff AssignedTo|henridamien(a)koha-fr.org |katrin.fischer(a)bsz-bw.de -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

1 0

[Bug 3388] Add a Vendor page does not have field for accountnumber
by bugzilla-daemon＠bugs.koha-community.org 28 Oct '11

28 Oct '11

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3388 --- Comment #2 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> 2011-10-28 15:38:09 UTC --- Created attachment 6093 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6093 Bug 3388: Restore account number on vendor page This patch makes it possible to add the account number to the vendor information. The used field aqbookseller.accountnumber was already existent in the database. To test: 1) Add a new vendor with accountnumber > Verify form has a field for accountnumber > Verify accountnumber does show up on vendor summary page 2) Edit this vendor, change accountnumber > Verify change was correctly saved and new number is displayed on vendor summary page 3) Delete accountnumber -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

1 0

[Bug 3184] Show creator and budget receiving a document
by bugzilla-daemon＠bugs.koha-community.org 28 Oct '11

28 Oct '11

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3184 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|henridamien(a)koha-fr.org |katrin.fischer(a)bsz-bw.de -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

1 0