December 2011 - Koha-bugs - lists.koha-community.org

[Bug 1633] Add ability to take book cover images from local img db
by bugzilla-daemon＠bugs.koha-community.org 30 Dec '11

30 Dec '11

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1633 Magnus Enger <magnus(a)enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Failed QA |Signed Off --- Comment #48 from Magnus Enger <magnus(a)enger.priv.no> 2011-12-30 16:46:08 UTC --- I have signed off all the current patches. The blockers mentioned in comment 35 have all been fixed, as well as some of the enhancements. I have tested uploading large and small jpg and png images to specific records. Upload and display works as expected. When AllowMultipleCovers = "Don't allow" new images for a record with old images automatically overwrite the old ones. I have also tested with a zip-file containing 3 images and a comma separated file called datalink.txt. I hve tested attaching all 3 images to the same record, as well as different images to different records. We can probably think of improvements to this, but it looks like the base functionality is OK, so I think we should get this in now and then we can enhance it later. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.

1 0

[Bug 1633] Add ability to take book cover images from local img db
by bugzilla-daemon＠bugs.koha-community.org 30 Dec '11

30 Dec '11

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1633 Magnus Enger <magnus(a)enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #6977|0 |1 is obsolete| | --- Comment #47 from Magnus Enger <magnus(a)enger.priv.no> 2011-12-30 16:39:10 UTC --- Created attachment 6983 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6983 [SIGNED-OFF] Bug 1633 - Interface revisions for the staff client -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.

1 0

[Bug 1633] Add ability to take book cover images from local img db
by bugzilla-daemon＠bugs.koha-community.org 30 Dec '11

30 Dec '11

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1633 Magnus Enger <magnus(a)enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #6976|0 |1 is obsolete| | --- Comment #46 from Magnus Enger <magnus(a)enger.priv.no> 2011-12-30 16:38:38 UTC --- Created attachment 6982 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6982 [SIGNED-OFF] Bug 1633: Don't show image tab when inappropriate -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.

1 0

[Bug 1633] Add ability to take book cover images from local img db
by bugzilla-daemon＠bugs.koha-community.org 30 Dec '11

30 Dec '11

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1633 Magnus Enger <magnus(a)enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #6975|0 |1 is obsolete| | --- Comment #45 from Magnus Enger <magnus(a)enger.priv.no> 2011-12-30 16:38:10 UTC --- Created attachment 6981 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6981 [SIGNED-OFF] Bug 1633 - Add ability to take book cover images from local img db -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.

1 0

[Bug 1633] Add ability to take book cover images from local img db
by bugzilla-daemon＠bugs.koha-community.org 30 Dec '11

30 Dec '11

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1633 Magnus Enger <magnus(a)enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #6979|0 |1 is obsolete| | --- Comment #44 from Magnus Enger <magnus(a)enger.priv.no> 2011-12-30 16:37:38 UTC --- Created attachment 6980 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6980 [SIGNED-OFF] Bug 1633: Display local cover images -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.

1 0

[Bug 1633] Add ability to take book cover images from local img db
by bugzilla-daemon＠bugs.koha-community.org 30 Dec '11

30 Dec '11

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1633 Magnus Enger <magnus(a)enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #6974|0 |1 is obsolete| | --- Comment #43 from Magnus Enger <magnus(a)enger.priv.no> 2011-12-30 16:34:23 UTC --- Created attachment 6979 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6979 Bug 1633: Display local cover images -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.

1 0

[Bug 1633] Add ability to take book cover images from local img db
by bugzilla-daemon＠bugs.koha-community.org 30 Dec '11

30 Dec '11

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1633 Magnus Enger <magnus(a)enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #6973|0 |1 is obsolete| | --- Comment #42 from Magnus Enger <magnus(a)enger.priv.no> 2011-12-30 16:29:19 UTC --- Created attachment 6978 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6978 Signed-off patch -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.

1 0

[Bug 1633] Add ability to take book cover images from local img db
by bugzilla-daemon＠bugs.koha-community.org 30 Dec '11

30 Dec '11

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1633 Jared Camins-Esakov <jcamins(a)cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #6823|0 |1 is obsolete| | --- Comment #41 from Jared Camins-Esakov <jcamins(a)cpbibliography.com> 2011-12-30 13:58:40 UTC --- Created attachment 6977 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6977 Bug 1633 - Interface revisions for the staff client This patch revises the image viewer page to match other biblio detail pages: a toolbar, a sidebar menu, etc. Additional data is now pulled by imageviewer.pl in order to provide information necessary for the proper functioning of the toolbar and menus: item counts, hold availability, biblio view options. Other changes have been made to match the changes in the OPAC interface like styling of the images and no-javascript compatibility Signed-off-by: Jared Camins-Esakov <jcamins(a)cpbibliography.com> -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.

1 0

[Bug 1633] Add ability to take book cover images from local img db
by bugzilla-daemon＠bugs.koha-community.org 30 Dec '11

30 Dec '11

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1633 Jared Camins-Esakov <jcamins(a)cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #6788|0 |1 is obsolete| | --- Comment #40 from Jared Camins-Esakov <jcamins(a)cpbibliography.com> 2011-12-30 13:58:26 UTC --- Created attachment 6976 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6976 Bug 1633: Don't show image tab when inappropriate This patch corrects the bug spotted by Owen Leonard where the Images tab was showing up even for records that didn't have local cover images attached to them. The tab is now hidden on the OPAC for records that don't have any images. In the Intranet, an Images tab will show for staff with permission to upload images, suggesting that they do so. For staff without that permission, the tab is not shown. This permission also disables returning images via the opac-image.pl and catalogue/image.pl scripts when local cover images have been disabled. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.

1 0

[Bug 1633] Add ability to take book cover images from local img db
by bugzilla-daemon＠bugs.koha-community.org 30 Dec '11

30 Dec '11

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1633 Jared Camins-Esakov <jcamins(a)cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #6787|0 |1 is obsolete| | --- Comment #39 from Jared Camins-Esakov <jcamins(a)cpbibliography.com> 2011-12-30 13:58:10 UTC --- Created attachment 6975 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6975 Bug 1633 - Add ability to take book cover images from local img db OPAC Template revisions: - Revised OPAC imageviewer template to match structure of other OPAC pages (with masthead search, footer, etc) - Added link back to detail page (controlled by BiblioDefaultView preference) - Added link style to thumbnails on opac-detail to add a sense of "clickability" to them - Revised OPAC imageviewer template to allow it to function with JavaScript turned off. Now even without JS main image will load, thumbnails will be properly styled, and thumbnail links will work. - Changes to the script are only to pass missing variables to the template TODO: Corresponding changes for the staff client Signed-off-by: Jared Camins-Esakov <jcamins(a)cpbibliography.com> -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.

1 0