December 2011 - Koha-bugs - lists.koha-community.org

[Bug 1633] Add ability to take book cover images from local img db
by bugzilla-daemon＠bugs.koha-community.org 30 Dec '11

30 Dec '11

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1633 Jared Camins-Esakov <jcamins(a)cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #6786|0 |1 is obsolete| | --- Comment #38 from Jared Camins-Esakov <jcamins(a)cpbibliography.com> 2011-12-30 13:57:50 UTC --- Created attachment 6974 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6974 Bug 1633: Display local cover images This patch adds display of local cover images in the following places: 1. OPAC Results page 2. OPAC Details page 3. Separate image viewer page for the OPAC 4. Intranet Details page 5. Separate image viewer page for the Intranet Display in the Details and (OPAC) Results pages is handled via Javascript rather than via direct embedding, to better handle the situation where most records have local cover images, but a few do not. Local cover images do not currently display in the Intranet Results page How to use/test : Assign user permission to the user Tools > (upload_local_cover_images Upload local cover images). In order to upload local images, login to the staff client. Go to Home > Tools > Upload Cover Images. Here you can upload cover images either singly or in bulk in the form of a zip file. If uploading singly, click on image file, browse the image from your local disk, type in the biblio number of the catalogue entry and press upload. If uploading in bulk as a zip file, the zip file must contain (in addition to cover images) one text file named either datalink.txt OR idlink.txt. This file should have mapping of biblionumber to image file name in the zip one per line with comma or tab as delimiters. For example: 1, scanned_cover_image_of_bib_no_1.jpg 2, scanned_cover_image_of_bib_no_1.jpg Cover images will be resized to a large image of 800x600 and a thumbnail of 200x140. Depending on the setting of AllowMultipleCovers, it is possible to upload multiple images for a single bibliographic record. However, even if multiple covers are permitted, you have the option of replacing the existing covers by checking the "Replace existing covers" option on the upload screen. 1. The patch adds a menu link in Tools from where you can upload local cover images 2. It adds a user permission to enable access control to this menu item under Tools 3. It adds a system preference OPACLocalCoverImages under Enhanced Content. This needs to be turned on to show local cover images in OPAC. Once you have uploaded local images, if you search for the biblio, the local cover should show up in search as well as search detail pages in the OPAC, and the details view in the Intranet. Koustubha Kale is working on another patch which will allow us to set a cover image source priority in system preferences, and which will then gracefully fail over to the next source if image is not available from the first choice source. Signed-off-by: Jared Camins-Esakov <jcamins(a)cpbibliography.com> -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.

1 0

[Bug 1633] Add ability to take book cover images from local img db
by bugzilla-daemon＠bugs.koha-community.org 30 Dec '11

30 Dec '11

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1633 Jared Camins-Esakov <jcamins(a)cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #6785|0 |1 is obsolete| | --- Comment #37 from Jared Camins-Esakov <jcamins(a)cpbibliography.com> 2011-12-30 13:57:32 UTC --- Created attachment 6973 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6973 Bug 1633: Add support for uploading images to Koha A frequently-requested feature for Koha, especially by special libraries, is the ability to upload local cover images into Koha. This patch adds a bibliocoverimage table, and image handling code in the C4::Images module. Key features of the implementation include: 1. The ability to have multiple cover images for a biblio 2. Handling for "full size" (800x600) and thumbnail-size (200x140) images 3. Uploading images directly from the record view The image display functionality by Koustubha Kale of Anant Corporation will follow in a second patch. Special thanks to Koustubha Kale and Anant Corporation for the initial implementation of local cover images, and to Chris Nighswonger of Foundation Bible College for his prior work on patron images. Signed-off-by: Jared Camins-Esakov <jcamins(a)cpbibliography.com> -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.

1 0

[Bug 1633] Add ability to take book cover images from local img db
by bugzilla-daemon＠bugs.koha-community.org 30 Dec '11

30 Dec '11

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1633 --- Comment #36 from Jared Camins-Esakov <jcamins(a)cpbibliography.com> 2011-12-30 13:56:16 UTC --- Magnus, Thanks for testing. I have five revised patches coming up that fix your blockers, and a few of your enhancements. Hot off the keyboard! (In reply to comment #35) > * No image shown when there is just one > > LocalCoverImages = On > > Uploaded one image and attached it to biblionumber = 1. > > Image shows OK here: /cgi-bin/koha/catalogue/detail.pl?biblionumber=1 > But: "There are no images for this record." at > /cgi-bin/koha/catalogue/imageviewer.pl?biblionumber=1&imagenumber=1 > > Changing line 68 of > koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/imageviewer.tt from this: > [% IF ( images.size > 1 ) %] > to this: > [% IF ( images.size > 0 ) %] > makes the image display. > > Uploading a second image makes both of them display correctly. Fixed > * AllowMultipleCovers does not stop multiple covers > > With AllowMultipleCovers = "Don't", /cgi-bin/koha/tools/upload-cover-image.pl > was automatically set to "Replace existing covers", but I had no problem adding > multiple covers to one record. Fixed > * Always "Click on an image..." > > On records that have no associated images I always see this: "Click on an image > to view it in the image viewer", not this: "No images have been uploaded for > this bibliographic record yet. Please upload one.". > > Changing line 522 in > koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt from > [% IF ( localimages ) %] > to > [% IF ( localimages.0 ) %] > seems to solve this. > > I'm not sure, but I think that when there are no images, localimages is an > array where the first element is undef, not an array that is undefined - or > something like that... Fixed > *** Enhancements > > * How can images be deleted? Good point. It is not yet possible. I will put that on my to-do list. > * Thumbnails have empty alt > > Thumbnails displayed on the right hand side in the image viewer (both OPAC and > Intranet) have empty alt attributes: > > <img alt="" > src="/cgi-bin/koha/catalogue/image.pl?imagenumber=3&thumbnail=1" id="3" > class="thumbnail"> > > It could perhaps say alt="Thumbnail" or something similar? Done! > * Still possible to see images when OPACLocalCoverImages is off > > OPACLocalCoverImages = Don't display > > I can still see the image at /cgi-bin/koha/opac-image.pl?imagenumber=1 Not anymore. ;) > * Wrong POD in tools/upload-cover-image.pl? > > The POD on line 33 of tools/upload-cover-image.pl says: "Files greater than > 100K will be refused. Images should be 140x200 pixels. If they are larger they > will be auto-resized to comply." > > I was able to upload an image of 1.3MB without any trouble, and it was resized > correctly. > > The last part of this has perhaps not been updated to take into account the > 600x800 pixel max size of the "large" view? There was incorrect POD, but I changed it. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.

1 0

[Bug 4274] Cart now requires login before emailing contents
by bugzilla-daemon＠bugs.koha-community.org 30 Dec '11

30 Dec '11

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4274 Nicole C. Engard <nengard(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard(a)gmail.com --- Comment #3 from Nicole C. Engard <nengard(a)gmail.com> 2011-12-30 13:42:51 UTC --- I personally don't think we should require login to mail a cart. What if I'm in the library at a public terminal and want to email a list of titles to myself, making me log in means I have to remember to log out of the public computer. Also Captcha is not accessibility friendly. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 1633] Add ability to take book cover images from local img db
by bugzilla-daemon＠bugs.koha-community.org 30 Dec '11

30 Dec '11

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1633 Magnus Enger <magnus(a)enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Needs Signoff |Failed QA --- Comment #35 from Magnus Enger <magnus(a)enger.priv.no> 2011-12-30 11:26:01 UTC --- I applied all the patches attached, in the order they are listed, so git log gives me this: $ git log --pretty=oneline --abbrev-commit 23c90fb Bug 1633 - Interface revisions for the staff client 6a652ec Bug 1633: Don't show image tab when inappropriate 7abbc66 Bug 1633 - Add ability to take book cover images from local img db 57eda8a Bug 1633: Display local cover images 38762dd Bug 1633: Add support for uploading images to Koha f99601e Bug 7375 - Update minimum version of Perl to 5.10 I'm marking this failed QA because of the following three blockers. The enhancements would be nice to have, but can be left for later. *** Blockers * No image shown when there is just one LocalCoverImages = On Uploaded one image and attached it to biblionumber = 1. Image shows OK here: /cgi-bin/koha/catalogue/detail.pl?biblionumber=1 But: "There are no images for this record." at /cgi-bin/koha/catalogue/imageviewer.pl?biblionumber=1&imagenumber=1 Changing line 68 of koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/imageviewer.tt from this: [% IF ( images.size > 1 ) %] to this: [% IF ( images.size > 0 ) %] makes the image display. Uploading a second image makes both of them display correctly. * AllowMultipleCovers does not stop multiple covers With AllowMultipleCovers = "Don't", /cgi-bin/koha/tools/upload-cover-image.pl was automatically set to "Replace existing covers", but I had no problem adding multiple covers to one record. * Always "Click on an image..." On records that have no associated images I always see this: "Click on an image to view it in the image viewer", not this: "No images have been uploaded for this bibliographic record yet. Please upload one.". Changing line 522 in koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt from [% IF ( localimages ) %] to [% IF ( localimages.0 ) %] seems to solve this. I'm not sure, but I think that when there are no images, localimages is an array where the first element is undef, not an array that is undefined - or something like that... *** Enhancements * How can images be deleted? * Thumbnails have empty alt Thumbnails displayed on the right hand side in the image viewer (both OPAC and Intranet) have empty alt attributes: <img alt="" src="/cgi-bin/koha/catalogue/image.pl?imagenumber=3&thumbnail=1" id="3" class="thumbnail"> It could perhaps say alt="Thumbnail" or something similar? * Still possible to see images when OPACLocalCoverImages is off OPACLocalCoverImages = Don't display I can still see the image at /cgi-bin/koha/opac-image.pl?imagenumber=1 * Wrong POD in tools/upload-cover-image.pl? The POD on line 33 of tools/upload-cover-image.pl says: "Files greater than 100K will be refused. Images should be 140x200 pixels. If they are larger they will be auto-resized to comply." I was able to upload an image of 1.3MB without any trouble, and it was resized correctly. The last part of this has perhaps not been updated to take into account the 600x800 pixel max size of the "large" view? * Images in the modification log? When I look at /cgi-bin/koha/tools/viewlog.pl?do_it=1&modules=CATALOGUING&action=MODIFY&object=1 there is no mention of the images there. Perhaps that would be a nice addition, so you could see when images were added, removed etc? * Make it possible to select "main" image when there is more than one Looks like the first image to be uploaded is the one that is displayed in the result list and at the top of a record in detail view. Might be nice if it was possible to select which image should be the "main" one. * Make it possible to replace one specific image among several -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.

1 0

[Bug 3651] Require patron login to send shelves and baskets
by bugzilla-daemon＠bugs.koha-community.org 30 Dec '11

30 Dec '11

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3651 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer(a)bsz-bw.de Patch Status|Needs Signoff |Signed Off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.

1 0

[Bug 3651] Require patron login to send shelves and baskets
by bugzilla-daemon＠bugs.koha-community.org 30 Dec '11

30 Dec '11

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3651 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #6955|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> 2011-12-30 08:26:05 UTC --- Created attachment 6968 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6968 [SIGNED-OFF] Bug 3651 Follow-up, Require patron login to send shelves and baskets The fix for Bug 4289, "Add a syspref 'OpacPublic', to hide OPAC search-bar and force authentication on all OPAC pages" incorrectly made some page permissions dependent on the value of the OpacPublic setting. Some pages should require authentication no matter what. This patch returns opac-sendbasket.pl to the state it was in before Bug 4289, Bug 4274 notwithstanding. I have added the authentication requirement to opac-sendshelf.pl to match. Signed-off-by: Katrin Fischer <Katrin.Fischer.83(a)web.de> 1) sending cart requires login 2) sending shelf requires login 3) updating personal details requires login -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.

1 0

[Bug 929] See details of a budget
by bugzilla-daemon＠bugs.koha-community.org 29 Dec '11

29 Dec '11

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=929 Chris Cormack <chris(a)bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |7387 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 929] See details of a budget
by bugzilla-daemon＠bugs.koha-community.org 29 Dec '11

29 Dec '11

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=929 Chris Cormack <chris(a)bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Needs Signoff |Signed Off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 929] See details of a budget
by bugzilla-daemon＠bugs.koha-community.org 29 Dec '11

29 Dec '11

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=929 Chris Cormack <chris(a)bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #6953|0 |1 is obsolete| | --- Comment #15 from Chris Cormack <chris(a)bigballofwax.co.nz> 2011-12-29 19:11:47 UTC --- Created attachment 6958 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6958 Bug 929: Follow up - showing fund code instead of internal number Signed-off-by: Chris Cormack <chrisc(a)catalyst.net.nz> -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.

1 0