August 2011 - Koha-bugs - lists.koha-community.org

[Bug 4415] child record only using parent's info
by bugzilla-daemon＠bugs.koha-community.org 03 Aug '11

03 Aug '11

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4415 Chris Cormack <chris(a)bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Passed QA |Patch Pushed --- Comment #27 from Chris Cormack <chris(a)bigballofwax.co.nz> 2011-08-03 10:23:17 UTC --- Pushed to master, please test -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

1 0

[Bug 4518] Enhance 2.2 to 3.0 scripts
by bugzilla-daemon＠bugs.koha-community.org 03 Aug '11

03 Aug '11

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4518 Paul Poulain <paul.poulain(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ian.walls@bywatersolutions. | |com, | |paul.poulain(a)biblibre.com --- Comment #3 from Paul Poulain <paul.poulain(a)biblibre.com> 2011-08-03 10:21:38 UTC --- QA comment: mmm... frankly, do we have to care with this ? is there anyone/ppl needing to move from 2.2 ? I hope no ! I'll ask on koha mailing list immediatly. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

1 0

[Bug 4415] child record only using parent's info
by bugzilla-daemon＠bugs.koha-community.org 03 Aug '11

03 Aug '11

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4415 Chris Cormack <chris(a)bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #4816|0 |1 is obsolete| | --- Comment #26 from Chris Cormack <chris(a)bigballofwax.co.nz> 2011-08-03 10:20:42 UTC --- Created attachment 4817 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4817 bug_4415: Copy parent contact details to child when adding Let child details be managed separately Signed-off-by: Nicole Engard <nengard(a)bywatersolutions.com> Signed-off-by: Paul Poulain <paul.poulain(a)biblibre.com> Signed-off-by: Chris Cormack <chrisc(a)catalyst.net.nz> -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

1 0

[Bug 4415] child record only using parent's info
by bugzilla-daemon＠bugs.koha-community.org 03 Aug '11

03 Aug '11

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4415 Paul Poulain <paul.poulain(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.poulain(a)biblibre.com Patch Status|Signed Off |Passed QA -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

1 0

[Bug 4415] child record only using parent's info
by bugzilla-daemon＠bugs.koha-community.org 03 Aug '11

03 Aug '11

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4415 Paul Poulain <paul.poulain(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #4750|0 |1 is obsolete| | --- Comment #25 from Paul Poulain <paul.poulain(a)biblibre.com> 2011-08-03 10:08:20 UTC --- Created attachment 4816 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4816 proposed patch (passed QA) Nicole has signed-off the bug, but forgot to upload the signed-off patch. I've added her in my own signed-off again patch Nothing to note from a QA point of view, it's a simple patch, and works as advertised, although there's many comments, the one who helped me to understand is the comment 14 (forget comment 1, it was an initial suggestion from Ian, not done this way) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

1 0

[Bug 4222] Nonpublic note not appearing in the staff client
by bugzilla-daemon＠bugs.koha-community.org 03 Aug '11

03 Aug '11

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4222 --- Comment #19 from Paul Poulain <paul.poulain(a)biblibre.com> 2011-08-03 09:51:06 UTC --- (2nd point being more important than the 1st one I think) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

1 0

[Bug 4222] Nonpublic note not appearing in the staff client
by bugzilla-daemon＠bugs.koha-community.org 03 Aug '11

03 Aug '11

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4222 Paul Poulain <paul.poulain(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ian.walls@bywatersolutions. | |com, | |paul.poulain(a)biblibre.com --- Comment #18 from Paul Poulain <paul.poulain(a)biblibre.com> 2011-08-03 09:46:55 UTC --- Some QA comments : The database update says : + $dbh->do("ALTER TABLE items ADD COLUMN nonpublicnote MEDIUMTEXT"); + $dbh->do("ALTER TABLE deleteditems ADD COLUMN nonpublicnote MEDIUMTEXT"); and the mySQL adds the field at the end of the items table : `stocknumber` varchar(32) default NULL, + `nonpublicnote` mediumtext default NULL, There is already a field called itemnotes in the items table. For consistency/clarity I would prefer to have the nonpublicnote next to the itemnotes, so : + $dbh->do("ALTER TABLE items ADD COLUMN nonpublicnote MEDIUMTEXT AFTER itemnotes"); + $dbh->do("ALTER TABLE deleteditems ADD COLUMN nonpublicnote MEDIUMTEXT AFTER itemnotes"); and kohastructure modified accordingly. 2nd topic : + $dbh->do("UPDATE marc_subfield_structure SET kohafield='items.nonpublicnote' WHERE (kohafield IS NULL OR kohafield = '') AND tagfield='952' AND tagsubfield='x'"); => in UNIMARC, there is non-public note, so nothing specific to do here. => I feel the UPDATE can be dangerous = if someone has items mapped to something different than 952, or 952$x used for something else (i've seen the kohafield IS NULL OR kohafield = '', ++ for this security), there may be side effect. I would prefer to have : * nothing done in the database * a clear warning in the "print "Upgrade to $DBversion done (...)", like "Upgrade to $DBversion done (<b>New field : items.nonpublicnotes. Please go to admin > frameworks > and map this field to your MARC non public note. It will appear on circ desc</b>)" * a visible explanation in the release notes Ian/chris/Srdjan your opinion ? -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

1 0

[Bug 4002] Issues with borrowernumber set as NULL
by bugzilla-daemon＠bugs.koha-community.org 03 Aug '11

03 Aug '11

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4002 Paul Poulain <paul.poulain(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #4814|0 |1 is obsolete| | --- Comment #11 from Paul Poulain <paul.poulain(a)biblibre.com> 2011-08-03 09:30:11 UTC --- Created attachment 4815 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4815 proposed fix signed-off oups, uploaded a wrong patch, sorry. This one is correct $dbh->do("ALTER TABLE issues DROP FOREIGN KEY `issues_ibfk_1`"); $dbh->do("ALTER TABLE issues DROP FOREIGN KEY `issues_ibfk_2`"); now before : $dbh->do("ALTER TABLE issues ALTER COLUMN borrowernumber DROP DEFAULT"); $dbh->do("ALTER TABLE issues ALTER COLUMN itemnumber DROP DEFAULT"); $dbh->do("ALTER TABLE issues MODIFY COLUMN borrowernumber int(11) NOT NULL"); $dbh->do("ALTER TABLE issues MODIFY COLUMN itemnumber int(11) NOT NULL"); -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

1 0

[Bug 4002] Issues with borrowernumber set as NULL
by bugzilla-daemon＠bugs.koha-community.org 03 Aug '11

03 Aug '11

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4002 Paul Poulain <paul.poulain(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Signed Off |Passed QA -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

1 0

[Bug 4002] Issues with borrowernumber set as NULL
by bugzilla-daemon＠bugs.koha-community.org 03 Aug '11

03 Aug '11

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4002 Paul Poulain <paul.poulain(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #4454|0 |1 is obsolete| | --- Comment #10 from Paul Poulain <paul.poulain(a)biblibre.com> 2011-08-03 09:24:22 UTC --- Created attachment 4814 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4814 proposed fix signed-off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

1 0