January 2012 - Koha-bugs - lists.koha-community.org

[Bug 1633] Add ability to take book cover images from local img db
by bugzilla-daemon＠bugs.koha-community.org 24 Jan '12

24 Jan '12

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1633 Chris Cormack <chris(a)bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #7270|0 |1 is obsolete| | Attachment #7271|0 |1 is obsolete| | Attachment #7272|0 |1 is obsolete| | Attachment #7273|0 |1 is obsolete| | Attachment #7274|0 |1 is obsolete| | Attachment #7275|0 |1 is obsolete| | Attachment #7320|0 |1 is obsolete| | Attachment #7324|0 |1 is obsolete| | --- Comment #80 from Chris Cormack <chris(a)bigballofwax.co.nz> 2012-01-24 19:30:48 UTC --- Created attachment 7325 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7325 Bug 1633 follow-up: Fix jenkins tests The previous patches missed adding the upload_local_cover_images permission to languages other than en, and used a forbidden TT construct, giving jenkins agitas and indigestion. This patch adds the permission to other languages and corrects the syntax. Signed-off-by: Chris Cormack <chrisc(a)catalyst.net.nz> -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.

1 0

[Bug 1633] Add ability to take book cover images from local img db
by bugzilla-daemon＠bugs.koha-community.org 24 Jan '12

24 Jan '12

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1633 --- Comment #79 from Chris Cormack <chris(a)bigballofwax.co.nz> 2012-01-24 19:30:22 UTC --- Created attachment 7324 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7324 Bug 1633 follow-up: Fix jenkins tests The previous patches missed adding the upload_local_cover_images permission to languages other than en, and used a forbidden TT construct, giving jenkins agitas and indigestion. This patch adds the permission to other languages and corrects the syntax. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.

1 0

[Bug 1633] Add ability to take book cover images from local img db
by bugzilla-daemon＠bugs.koha-community.org 24 Jan '12

24 Jan '12

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1633 Chris Cormack <chris(a)bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #78 from Chris Cormack <chris(a)bigballofwax.co.nz> 2012-01-24 19:30:04 UTC --- Tests now pass perl xt/permissions.t unable to locate Koha configuration file koha-conf.xml at C4/Context.pm line 333. ok 1 - Open reference user permissions file installer/data/mysql/en/mandatory/userpermissions.sql ok 2 - Found 48 user permissions ok 3 - Open translated user permissions file installer/data/mysql/de-DE/mandatory/userpermissions.sql ok 4 - Found 48 perms ok 5 - No user permissions to add ok 6 - No user permissions to delete ok 7 - Open translated user permissions file installer/data/mysql/it-IT/necessari/userpermissions.sql ok 8 - Found 48 perms ok 9 - No user permissions to add ok 10 - No user permissions to delete ok 11 - Open translated user permissions file installer/data/mysql/fr-FR/1-Obligatoire/userpermissions.sql ok 12 - Found 48 perms ok 13 - No user permissions to add ok 14 - No user permissions to delete ok 15 - Open translated user permissions file installer/data/mysql/uk-UA/mandatory/permissions_and_user_flags.sql ok 16 - Found 48 perms ok 17 - No user permissions to add ok 18 - No user permissions to delete ok 19 - Open translated user permissions file installer/data/mysql/ru-RU/mandatory/permissions_and_user_flags.sql ok 20 - Found 48 perms ok 21 - No user permissions to add ok 22 - No user permissions to delete ok 23 - Open translated user permissions file installer/data/mysql/pl-PL/mandatory/userpermissions.sql ok 24 - Found 48 perms ok 25 - No user permissions to add ok 26 - No user permissions to delete 1..26 perl xt/tt_valid.t 1..1 ok 1 - TT syntax: not using TT directive within HTML tag -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.

1 0

[Bug 1633] Add ability to take book cover images from local img db
by bugzilla-daemon＠bugs.koha-community.org 24 Jan '12

24 Jan '12

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1633 Chris Cormack <chris(a)bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.

1 0

[Bug 1633] Add ability to take book cover images from local img db
by bugzilla-daemon＠bugs.koha-community.org 24 Jan '12

24 Jan '12

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1633 Chris Cormack <chris(a)bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |ASSIGNED -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.

1 0

[Bug 1633] Add ability to take book cover images from local img db
by bugzilla-daemon＠bugs.koha-community.org 24 Jan '12

24 Jan '12

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1633 Jared Camins-Esakov <jcamins(a)cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #7315|0 |1 is obsolete| | --- Comment #77 from Jared Camins-Esakov <jcamins(a)cpbibliography.com> 2012-01-24 15:40:14 UTC --- Created attachment 7320 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7320 Bug 1633 follow-up: Fix jenkins tests The previous patches missed adding the upload_local_cover_images permission to languages other than en, and used a forbidden TT construct, giving jenkins agitas and indigestion. This patch adds the permission to other languages and corrects the syntax. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.

1 0

[Bug 1633] Add ability to take book cover images from local img db
by bugzilla-daemon＠bugs.koha-community.org 24 Jan '12

24 Jan '12

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1633 Jared Camins-Esakov <jcamins(a)cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #7312|0 |1 is obsolete| | --- Comment #76 from Jared Camins-Esakov <jcamins(a)cpbibliography.com> 2012-01-24 14:23:19 UTC --- Created attachment 7315 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7315 Bug 1633 follow-up: Fix jenkins tests The previous patches missed adding the upload_local_cover_images permission to languages other than en, and used a forbidden TT construct, giving jenkins agitas and indigestion. This patch adds the permission to other languages and corrects the syntax. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.

1 0

[Bug 1633] Add ability to take book cover images from local img db
by bugzilla-daemon＠bugs.koha-community.org 24 Jan '12

24 Jan '12

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1633 --- Comment #75 from Jared Camins-Esakov <jcamins(a)cpbibliography.com> 2012-01-24 13:43:08 UTC --- Created attachment 7312 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7312 Bug 1633: Add missing permissions The previous patches missed adding the upload_local_cover_images permission to languages other than en, giving jenkins agitas and indigestion. This patch adds the permission to other languages. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.

1 0

[Bug 1633] Add ability to take book cover images from local img db
by bugzilla-daemon＠bugs.koha-community.org 24 Jan '12

24 Jan '12

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1633 Paul Poulain <paul.poulain(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master Version|master |rel_3_8 --- Comment #74 from Paul Poulain <paul.poulain(a)biblibre.com> 2012-01-24 11:01:28 UTC --- Congrats everybody ! -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.

1 0

[Bug 1633] Add ability to take book cover images from local img db
by bugzilla-daemon＠bugs.koha-community.org 24 Jan '12

24 Jan '12

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1633 Paul Poulain <paul.poulain(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #73 from Paul Poulain <paul.poulain(a)biblibre.com> 2012-01-24 10:59:47 UTC --- QA comment : * I made a lot of tests, everything work: - uploading more than 1 image - replacing 2 images by 1 image - uploading the same image on 2 different biblios, removing one - uploading different images on different biblios - displaying on OPAC. There is a glitch on the display, but removing a local css fixes the problem. It means local CSS will have to be updated probably. - tried to upload a file that is not an image. I got a nice: "Cannot process file as an image. Please ensure you only upload GIF, JPEG, PNG, or XPM images." All my comment 60 and comment 61 point have been fixed About comment 61 : I can't see a use case where the library would have OPAClocalcoverimages but not localcoverimages. It would result in something strange, as the librarian could upload his images, but not see the result in the staff. But maybe that will please some libraries, so I'll continue to live with my question ;-) Passed QA, -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.

1 0