January 2012 - Koha-bugs - lists.koha-community.org

[Bug 4300] Display 866z summary holdings public note in OPAC
by bugzilla-daemon＠bugs.koha-community.org 16 Jan '12

16 Jan '12

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4300 --- Comment #2 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> 2012-01-16 07:16:07 UTC --- Also only first $z of each 866 will be displayed, but subfield is repeatable. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 4300] Display 866z summary holdings public note in OPAC
by bugzilla-daemon＠bugs.koha-community.org 16 Jan '12

16 Jan '12

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4300 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED CC| |katrin.fischer(a)bsz-bw.de Resolution|FIXED | --- Comment #1 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> 2012-01-16 07:13:55 UTC --- Only subfield 866$z is displayed, but ; is added for each 866 field. This does only work correctly, when each 866 has a public note in $z. Example: 866 $a1-86 (1941-1987)$xbound in 2 v. per year$zSome issues missing 866 $a1-86 (1941-1987) Shows up as: Holdings Note: Some issues missing; . 866 - Textual Holdings-Basic Bibliographic Unit (R) $a - Textual holdings (NR) $x - Nonpublic note (R) $z - Public note (R) Holdings note is also only shown in OPAC, not in staff.  <xsl:if test="marc:datafield[@tag=866]"> <span class="results_summary holdings_note"><span class="label">Holdings Note: </span> <xsl:for-each select="marc:datafield[@tag=866]"> <xsl:value-of select="marc:subfield[@code='z']"/> <xsl:choose><xsl:when test="position()=last()"><xsl:text>.</xsl:text></xsl:when><xsl:otherwise><xsl:text>; </xsl:text></xsl:otherwise></xsl:choose> </xsl:for-each> </span> </xsl:if> -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 4438] incorrect "Budget total exceeds period allocation" error when editing fund
by bugzilla-daemon＠bugs.koha-community.org 15 Jan '12

15 Jan '12

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4438 --- Comment #11 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> 2012-01-15 19:02:46 UTC --- Hi Fred, can you give me a test plan to reproduce the problem? I checked the lines you mention on current master and they seem unchanged. But I am not sure the problem is still there. 99 if ( $parent_id) { 100 if ( ($total > $sub_unalloc ) && $sub_unalloc ) { 101 $returncode = 1; 102 } 103 } elsif ( ( $total > $budget_period_unalloc ) && $budget_period_unalloc ) { 104 $returncode = 2; 105 106 } else { 107 $returncode = 0; 108 } -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 1633] Add ability to take book cover images from local img db
by bugzilla-daemon＠bugs.koha-community.org 14 Jan '12

14 Jan '12

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1633 --- Comment #59 from Jared Camins-Esakov <jcamins(a)cpbibliography.com> 2012-01-14 13:31:48 UTC --- Fixed double content encoding and git-bz's hatred of Unicode subjects. For future reference, the double content encoding appears when there is Unicode in the body or subject of the commit message. In this case, the problem was the subject. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.

1 0

[Bug 1633] Add ability to take book cover images from local img db
by bugzilla-daemon＠bugs.koha-community.org 14 Jan '12

14 Jan '12

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1633 Jared Camins-Esakov <jcamins(a)cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #7153|0 |1 is obsolete| | -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.

1 0

[Bug 1633] Add ability to take book cover images from local img db
by bugzilla-daemon＠bugs.koha-community.org 14 Jan '12

14 Jan '12

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1633 --- Comment #58 from Jared Camins-Esakov <jcamins(a)cpbibliography.com> 2012-01-14 13:28:49 UTC --- Created attachment 7156 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7156 Bug 1633 - Interface revisions for the staff client This patch revises the image viewer page to match other biblio detail pages: a toolbar, a sidebar menu, etc. Additional data is now pulled by imageviewer.pl in order to provide information necessary for the proper functioning of the toolbar and menus: item counts, hold availability, biblio view options. Other changes have been made to match the changes in the OPAC interface like styling of the images and no-javascript compatibility Signed-off-by: Jared Camins-Esakov <jcamins(a)cpbibliography.com> Signed-off-by: Magnus Enger <magnus(a)enger.priv.no> Patch failed to apply because of multiple Content-Type lines in the patch. Corrected the same with this new patch. http://bugs.koha-community.org/show_bug.cgi?id=6473 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.

1 0

[Bug 1633] Add ability to take book cover images from local img db
by bugzilla-daemon＠bugs.koha-community.org 14 Jan '12

14 Jan '12

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1633 --- Comment #57 from Koustubha Kale <kmkale(a)anantcorp.com> 2012-01-14 09:24:56 UTC --- (In reply to comment #56) > Created attachment 7153 [details] > Bug 1633 - [SIGNED-OFF] Interface revisions for the staff client > > This patch revises the image viewer page to match other > biblio detail pages: a toolbar, a sidebar menu, etc. > > Additional data is now pulled by imageviewer.pl in order > to provide information necessary for the proper functioning > of the toolbar and menus: item counts, hold availability, > biblio view options. > > Other changes have been made to match the changes in the > OPAC interface like styling of the images and no-javascript > compatibility > > Signed-off-by: Jared Camins-Esakov <jcamins(a)cpbibliography.com> > Signed-off-by: Magnus Enger <magnus(a)enger.priv.no> > > Patch failed to apply because of multiple Content-Type lines in the patch. > Corrected the same with this new patch. The attachment still has the double content-type lines. Tried amending the patch after it failed to apply during a git bz apply, but could not get rid of the double content-type lines. Any help in this matter is much appreciated. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.

1 0

[Bug 1633] Add ability to take book cover images from local img db
by bugzilla-daemon＠bugs.koha-community.org 14 Jan '12

14 Jan '12

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1633 --- Comment #56 from Koustubha Kale <kmkale(a)anantcorp.com> 2012-01-14 08:59:22 UTC --- Created attachment 7153 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7153 Bug 1633 - [SIGNED-OFF] Interface revisions for the staff client This patch revises the image viewer page to match other biblio detail pages: a toolbar, a sidebar menu, etc. Additional data is now pulled by imageviewer.pl in order to provide information necessary for the proper functioning of the toolbar and menus: item counts, hold availability, biblio view options. Other changes have been made to match the changes in the OPAC interface like styling of the images and no-javascript compatibility Signed-off-by: Jared Camins-Esakov <jcamins(a)cpbibliography.com> Signed-off-by: Magnus Enger <magnus(a)enger.priv.no> Patch failed to apply because of multiple Content-Type lines in the patch. Corrected the same with this new patch. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.

1 0

[Bug 1633] Add ability to take book cover images from local img db
by bugzilla-daemon＠bugs.koha-community.org 14 Jan '12

14 Jan '12

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1633 --- Comment #55 from Koustubha Kale <kmkale(a)anantcorp.com> 2012-01-14 08:58:59 UTC --- Created attachment 7152 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7152 Bug 1633: [SIGNED-OFF] Don't show image tab when inappropriate This patch corrects the bug spotted by Owen Leonard where the Images tab was showing up even for records that didn't have local cover images attached to them. The tab is now hidden on the OPAC for records that don't have any images. In the Intranet, an Images tab will show for staff with permission to upload images, suggesting that they do so. For staff without that permission, the tab is not shown. This permission also disables returning images via the opac-image.pl and catalogue/image.pl scripts when local cover images have been disabled. Signed-off-by: Magnus Enger <magnus(a)enger.priv.no> Signed-off-by: Koustubha Kale <kmkale(a)anantcorp.com> -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.

1 0

[Bug 1633] Add ability to take book cover images from local img db
by bugzilla-daemon＠bugs.koha-community.org 14 Jan '12

14 Jan '12

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1633 --- Comment #54 from Koustubha Kale <kmkale(a)anantcorp.com> 2012-01-14 08:58:20 UTC --- Created attachment 7151 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7151 Bug 1633 - [SIGNED-OFF] Add ability to take book cover images from local img db OPAC Template revisions: - Revised OPAC imageviewer template to match structure of other OPAC pages (with masthead search, footer, etc) - Added link back to detail page (controlled by BiblioDefaultView preference) - Added link style to thumbnails on opac-detail to add a sense of "clickability" to them - Revised OPAC imageviewer template to allow it to function with JavaScript turned off. Now even without JS main image will load, thumbnails will be properly styled, and thumbnail links will work. - Changes to the script are only to pass missing variables to the template TODO: Corresponding changes for the staff client Signed-off-by: Jared Camins-Esakov <jcamins(a)cpbibliography.com> Signed-off-by: Magnus Enger <magnus(a)enger.priv.no> Signed-off-by: Koustubha Kale <kmkale(a)anantcorp.com> -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.

1 0