January 2012 - Koha-bugs - lists.koha-community.org

[Bug 929] See details of a budget
by bugzilla-daemon＠bugs.koha-community.org 13 Jan '12

13 Jan '12

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=929 --- Comment #27 from Paul Poulain <paul.poulain(a)biblibre.com> 2012-01-13 16:50:10 UTC --- QA comment: I was about to push this nice feature, but there is SQL in the .pl, and that's something we don't want. For example, in ordered.pl : +SELECT + aqorders.basketno, aqorders.ordernumber, + quantity-quantityreceived AS tleft, + ecost, budgetdate, + aqbasket.booksellerid, + itype, + title +FROM (aqorders, aqbasket) +LEFT JOIN biblio ON + biblio.biblionumber=aqorders.biblionumber +LEFT JOIN aqorders_items ON + aqorders.ordernumber=aqorders_items.ordernumber +LEFT JOIN items ON + items.itemnumber=aqorders_items.itemnumber +WHERE + aqorders.basketno=aqbasket.basketno AND + budget_id=? AND + (datecancellationprinted IS NULL OR + datecancellationprinted='0000-00-00') AND + (quantity > quantityreceived OR quantityreceived IS NULL) I also noticed that the POD is wrong: +=head1 NAME + +committed.pl I discussed of point #1 with kf on the channel, and she pointed this commit reinstate a script that was here, with SQL inside. So I won't mark failed QA, will add a follow-up for the small committed.pl mistake in the POD. BUT i'd like to have a follow-up to fix this SQL that should really not be here. patch pushed, please test -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.

1 0

[Bug 929] See details of a budget
by bugzilla-daemon＠bugs.koha-community.org 13 Jan '12

13 Jan '12

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=929 Magnus Enger <magnus(a)enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus(a)enger.priv.no See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=3080 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.

1 0

[Bug 929] See details of a budget
by bugzilla-daemon＠bugs.koha-community.org 13 Jan '12

13 Jan '12

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=929 Paul Poulain <paul.poulain(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QAContact|koha-bugs(a)lists.koha-commun |paul.poulain(a)biblibre.com |ity.org | -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 5344] New: Invoice management improvements
by bugzilla-daemon＠bugs.koha-community.org 13 Jan '12

13 Jan '12

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5344 Summary: Invoice management improvements Change sponsored?: Sponsored Product: Koha Version: rel_3_4 Platform: All URL: http://wiki.koha-community.org/wiki/Invoice_management _RFC OS/Version: All Status: NEW Severity: enhancement Priority: P5 Component: Acquisitions AssignedTo: henridamien(a)koha-fr.org ReportedBy: paul.poulain(a)biblibre.com QAContact: koha-bugs(a)lists.koha-community.org Estimated Hours: 0.0 In Koha 3.2, the amount of the items in the parcel is deduced from the budget. We will add 3 fields and a form to let the librarian add additional fees to the parcel, a description of the added fees and a budget. Those fees will be deduced from a selected budget. May overlap with http://wiki.koha-community.org/wiki/Capturing_information_on_handling,_post…. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.

1 4

[Bug 7356] New: FIx various typos and mis-spellings
by bugzilla-daemon＠bugs.koha-community.org 13 Jan '12

13 Jan '12

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7356 Bug #: 7356 Summary: FIx various typos and mis-spellings Classification: Unclassified Change sponsored?: --- Product: Koha Version: unspecified Platform: All OS/Version: All Status: NEW Severity: normal Priority: P5 - low Component: Developer documentation AssignedTo: gmcharlt(a)gmail.com ReportedBy: marc(a)msys.ch QAContact: ian.walls(a)bywatersolutions.com Created attachment 6777 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6777 functionnal -> functional The attached patches fix various typos and mis-spellings, NB that the Component Documentation is probably not adequate. The patches need to be applied in order. 0001 functionnal -> functional 0002 wether -> whether 0003 developper -> developer 0004 'the the ' - > 'the ' -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.

1 22

[Bug 6482] New: koha-create makes assumptions about the mysql username
by bugzilla-daemon＠bugs.koha-community.org 13 Jan '12

13 Jan '12

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6482 Bug #: 6482 Summary: koha-create makes assumptions about the mysql username Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Platform: All OS/Version: All Status: NEW Severity: enhancement Priority: P5 Component: Packaging AssignedTo: robin(a)catalyst.net.nz ReportedBy: robin(a)catalyst.net.nz QAContact: koha-bugs(a)lists.koha-community.org If you do koha-create --request-db, need to change the user or db name, and then later do koha-create --populate-db, it doesn't work as it makes up the name from the command line, rather than referencing the config files. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

1 9

[Bug 4438] incorrect "Budget total exceeds period allocation" error when editing fund
by bugzilla-daemon＠bugs.koha-community.org 13 Jan '12

13 Jan '12

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4438 Fred P <fred.pierre(a)smfpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED CC| |fred.pierre(a)smfpl.org Resolution|FIXED | --- Comment #10 from Fred P <fred.pierre(a)smfpl.org> 2012-01-12 21:35:10 UTC --- This bug remained unresolved for us, and we traced the problem to an error in the floating point calculation. We are using Koha 3.5. The process is the same as that described in the initial filing: We edit a fund, in our case, changing the fund name. Even though we did not change the fund total, we get a "budget total exceeds period allocation" error. aqbudgets.pl pulls totals from the acq.js script, that in turn calls on the check_parent_total.pl script. check_parent_total.pl runs a comparison between the fund total that is submitted in the aqbudgets.pl edit screen, and the unallocated amount left from the budget_period_total. They will usually be equivalent. However somewhere in the process a floating point error is being generated, making the total a tiny bit greater than the unallocated amount, locking the budget fund for editing by generating the error (returncode=2), as listed above. A simple solution is to multiply the values on both sides of the comparison by 100, and truncate the decimal places. Here is our suggested solution that solves the problem: File: check_parent_total.pl Line around 103 if ( $parent_id) { if ( ($total > $sub_unalloc ) && $sub_unalloc ) { $returncode = 1; } } elsif ( ( floor($total*100) > floor($budget_period_unalloc*100)) && $budget_period_unalloc ) { $returncode = 2; } else { $returncode = 0; } -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 6227] New: deprecate NoZebra for 3.4.0
by bugzilla-daemon＠bugs.koha-community.org 12 Jan '12

12 Jan '12

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6227 Bug #: 6227 Summary: deprecate NoZebra for 3.4.0 Classification: Unclassified Change sponsored?: --- Product: Koha Version: rel_3_4 Platform: All OS/Version: All Status: NEW Severity: enhancement Priority: P5 Component: Searching AssignedTo: gmcharlt(a)gmail.com ReportedBy: gmcharlt(a)gmail.com QAContact: koha-bugs(a)lists.koha-community.org This is a last minute thing, but I propose that we deprecate NoZebra for 3.4.0. Specifically, * Remove the installer query asking to set Zebra or NoZebra * Update the description of the system preference to express that it's not recommended. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

1 5

[Bug 6084] New: Missing translation markers in javascript alert messages
by bugzilla-daemon＠bugs.koha-community.org 12 Jan '12

12 Jan '12

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6084 Bug #: 6084 Summary: Missing translation markers in javascript alert messages Classification: Unclassified Change sponsored?: --- Product: Koha Version: rel_3_4 Platform: All OS/Version: All Status: NEW Severity: normal Priority: P5 Component: I18N/L10N AssignedTo: frederic(a)tamil.fr ReportedBy: katrin.fischer(a)bsz-bw.de QAContact: koha-bugs(a)lists.koha-community.org It seems the translation tool is not picking up alert messages for translations when they are not properly formatted: Bad: alert("Your text will stay English forever!"); Good: alert(_("Your text will be translatable!")); A quick look at the code reveals a lot of translation problems in this area. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

1 10

[Bug 4389] Trigger quick slip print on empty checkout submit
by bugzilla-daemon＠bugs.koha-community.org 12 Jan '12

12 Jan '12

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4389 Tomás Cohen Arazi <tomascohen(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution| |FIXED -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.

1 0