April 2013 - Koha-bugs - lists.koha-community.org

[Bug 9703] New: Add optional parameter "as_string" to GetRecordValue subroutine
by bugzilla-daemon＠bugs.koha-community.org 26 Jun '14

26 Jun '14

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9703 Bug ID: 9703 Summary: Add optional parameter "as_string" to GetRecordValue subroutine Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt(a)gmail.com Reporter: dcook(a)prosentient.com.au Currently, the GetRecordValue subroutine returns an array of hashes, which must be looped through to retrieve results. On the template, you write the following code [% FOREACH subtitle %][% subfield %][% END %]. The problem with this is when you're trying to use the Keyword to MARC Mapping to over-write a field in the template that is already written as a single variable (e.g. [% author %]). Of course, you can loop through the array of hashes on the Perl side and pass a string to the template (i.e. opac-detail.tt or detail.tt). However, you're going to have to reproduce this iterator code every time you want to use GetRecordValue to produce a string. So, I figured that it made sense to add an optional parameter to the sub to trigger a condition so as to return a string of concatenated values rather than an array of hashes. --- Note: My ideal goal is to make it so that one can use the Keyword to MARC Mapping to specify any (or almost any) field on the detail pages. At the moment, I'm focusing on author, but I figure physical description will be another good one, as the template shows a bare minimum of the 3xx fields/subfields (in the incorrect order last I looked), --- Note, adding this optional parameter does NOT at all change the existing use of the GetRecordValue sub. The idea is hopefully to eliminate boilerplate by centralizing the "as string" code in this sub. -- You are receiving this mail because: You are watching all bug changes.

1 4

[Bug 8560] New: renewing lost items
by bugzilla-daemon＠bugs.koha-community.org 25 Jun '14

25 Jun '14

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8560 Priority: P5 - low Change sponsored?: --- Bug ID: 8560 CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com Assignee: koha-bugs(a)lists.koha-community.org Summary: renewing lost items Severity: major Classification: Unclassified OS: All Reporter: nengard(a)gmail.com Hardware: All Status: NEW Version: master Component: Circulation Product: Koha I got this report from a library: When items age to long overdue lost, they assess a fee equivalent to the replacement price of the item. That makes sense. When those items are checked in, the fee is removed and the titles no longer display as checked out. The overdue does remain in the patron's history under fines. That also makes sense. However, if we renew one of those items, it assigns a new due date, but does not remove the fee or the long overdue lost designation. And, if we take payment on the item, it balances out the fee, reducing the amount due accordingly, but the title continues to display in the list of items out as long overdue lost. The result of this is that our staff members continue to mention these overdue items to the patron even after they've been taken care of. Other categories of lost - those that are manually set - remove the title from the list of items out. Renewing an item should also remove the fees and the long overdue designation. And paying for the item should remove it from items out and show it only in payment history. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 2

[Bug 9826] New: Missing fields in MARC21 authority framework
by bugzilla-daemon＠bugs.koha-community.org 25 Jun '14

25 Jun '14

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9826 Bug ID: 9826 Summary: Missing fields in MARC21 authority framework Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: bgkriegel(a)gmail.com Reporter: bgkriegel(a)gmail.com CC: m.de.rooy(a)rijksmuseum.nl The default Authority frameworks for MARC21 are missing many tags. -- You are receiving this mail because: You are watching all bug changes.

1 18

[Bug 7058] New: GetMemberDetails must die!
by bugzilla-daemon＠bugs.koha-community.org 25 Jun '14

25 Jun '14

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7058 Bug #: 7058 Summary: GetMemberDetails must die! Classification: Unclassified Change sponsored?: --- Product: Koha Version: unspecified Platform: All OS/Version: All Status: NEW Severity: enhancement Priority: P5 Component: Architecture, internals, and plumbing AssignedTo: ian.walls(a)bywatersolutions.com ReportedBy: ian.walls(a)bywatersolutions.com QAContact: koha-bugs(a)lists.koha-community.org The GetMemberDetails subroutine is insanely inefficient, and is used throughout Koha's code. In many cases, GetMember is more than sufficient (please see my rant on bug 5179). This report shall serve as the meta-report for all attempts to eliminate unnecessary calls get GetMemberDetails. Please file separate bug reports for specific instances, and list them as "blocking" this report. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

1 5

[Bug 5179] New: GetMember and GetMemberDetails should be combined
by bugzilla-daemon＠bugs.koha-community.org 25 Jun '14

25 Jun '14

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5179 Summary: GetMember and GetMemberDetails should be combined Change sponsored?: --- Product: Koha Version: rel_3_4 Platform: All OS/Version: All Status: NEW Severity: enhancement Priority: P5 Component: Architecture, internals, and plumbing AssignedTo: gmcharlt(a)gmail.com ReportedBy: robin(a)catalyst.net.nz QAContact: koha-bugs(a)lists.koha-community.org Estimated Hours: 0.0 In Members.pm, GetMember and GetMemberDetails do almost the same thing. This common behaviour should be combined so that changes to this kind of thing don't have to happen in multiple places. Aiming for 3.4. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.

1 2

[Bug 7572] New: Add Clubs & Services Feature
by bugzilla-daemon＠bugs.koha-community.org 23 Jun '14

23 Jun '14

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7572 Bug #: 7572 Summary: Add Clubs & Services Feature Classification: Unclassified Change sponsored?: --- Product: Koha Version: rel_3_8 Platform: All OS/Version: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons AssignedTo: kyle.m.hall(a)gmail.com ReportedBy: kyle.m.hall(a)gmail.com QAContact: koha.sekjal(a)gmail.com CC: gmcharlt(a)gmail.com Add the clubs and services feature to Koha. This feature has been in production at the Crawford County Federated Library system for a number of years now. This features adds the ability to create clubs and services which patrons may be enrolled in. It is particularly useful for tracking summer reading programs, book clubs and other such clubs. It includes 2 built-in service archetypes: Bestsellers Club : Batch generate a holds list which shuffles the holds queue when new items matching a given title or author are catalogued. New Items Weekly Mailing Lists : Create custom mailing lists to alert subscribers to new items in your library. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.

1 58

[Bug 9820] New: Missing space between 100/700 $a and $c (MARC21/XSLT)
by bugzilla-daemon＠bugs.koha-community.org 22 Jun '14

22 Jun '14

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9820 Bug ID: 9820 Summary: Missing space between 100/700 $a and $c (MARC21/XSLT) Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: MARC Bibliographic data support Assignee: gmcharlt(a)gmail.com Reporter: katrin.fischer(a)bsz-bw.de For names consisting of 100/700 $a and $c there is no space between $a and $c in OPAC MARC21 detail page and result list using XSLT. -- You are receiving this mail because: You are watching all bug changes.

1 20

[Bug 6617] New: table of contents not printing right if entered right
by bugzilla-daemon＠bugs.koha-community.org 22 Jun '14

22 Jun '14

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6617 Bug #: 6617 Summary: table of contents not printing right if entered right Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Platform: All OS/Version: All Status: NEW Severity: normal Priority: P5 Component: Templates AssignedTo: oleonard(a)myacpl.org ReportedBy: nengard(a)gmail.com QAContact: koha-bugs(a)lists.koha-community.org Created attachment 4682 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4682 table of contents in 505$a If you're entering the table of contents in a series of $t and $r subfields (in the 505) then it doesn't print the table of contents to the OPAC or staff client right. A formatted table of contents looks like this (505$a): What is a mashup? / Darlene Fichter -- Behind the scenes : some technical details on mashups / Bonaria Biancu -- Making your data available to be mashed up / Ross Singer -- Mashing up with librarian knowledge / Thomas Brevik A slash after the title and before the author and a double dash in between the chapters. See the screenshots to see what I mean. The / should probably be entered by the cataloger, but the double dash should be entered by the template and the contents should show with XSLT turned on even if it's not in the $a only. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

1 48

[Bug 6918] New: can't place holds on 'on order' items with AllowOnShelfHolds off
by bugzilla-daemon＠bugs.koha-community.org 20 Jun '14

20 Jun '14

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6918 Bug #: 6918 Summary: can't place holds on 'on order' items with AllowOnShelfHolds off Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Platform: All OS/Version: All Status: NEW Severity: major Priority: P5 Component: Circulation AssignedTo: kyle.m.hall(a)gmail.com ReportedBy: nengard(a)gmail.com QAContact: koha-bugs(a)lists.koha-community.org CC: gmcharlt(a)gmail.com I don't think this was always the case (but I might be wrong). If AllowOnShelfHolds is set to 'don't allow' then patrons cannot place holds on items that are marked 'on order' (not for loan=-1). Technically items on order are not on the shelf and should be allowed to be placed on hold. This may require a preference for people to say whether they want to allow holds on 'on order' items and/or what the not for loan value is for 'on order' since there is nothing stopping the user from changing the value from -1 to something else. The easy fix is just to make the system allow holds on items with -1 for notforloan like I think it was before. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

1 29

[Bug 6374] New: Use "size" as names/hash keys leads to an unexpected results when using Template::Toolkit (name of a virtual method there)
by bugzilla-daemon＠bugs.koha-community.org 19 Jun '14

19 Jun '14

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6374 Bug #: 6374 Summary: Use "size" as names/hash keys leads to an unexpected results when using Template::Toolkit (name of a virtual method there) Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Platform: All OS/Version: All Status: NEW Severity: normal Priority: P5 Component: Templates AssignedTo: oleonard(a)myacpl.org ReportedBy: januszop(a)gmail.com QAContact: koha-bugs(a)lists.koha-community.org In many places the name "size" is used as hash key when the hash is passed to the template system for display. So, for example, since "size" is used as a name of a column of bibioitems table, it appears (or not, depending on if it was defined or not) in elements of SEARCH_RESULTS (in catalogue/search.pl or opac-search.pl) and is passed to the template results.tt/opac-results.tt. Then, in [opac-]results.tt a test is being done: [% IF ( SEARCH_RESULT.size ) %] Now: if "size" was defined, everything is OK and the size will be displayed (e.g. 21 cm), BUT if it was not defined, then a "random" number appears. This is because "size" is one of the virtual methods defined in Template::Toolkit for every data type (cf. http://search.cpan.org/~abw/Template-Toolkit-2.22/lib/Template/Manual/VMeth…) So, if "size" was defined by Koha, it will overload the method, but if it was not, then 1) XXX.size exists anyway, 2) the virtual method size() is called -- and it returns the number of elements in the hash or loop etc., depending on what is referred. The number of suspicious similar spots is ca. 20: git grep "IF.*\.size" called in koha-tmpl The issue does not seem to me to be straightforward to resolve, so I am not proposing any patch at the time. Since it seems that in most of the cases it rooted in biblioitems.size column, maybe it would be the simplest to rename that column to 'format' (and make appropriate changes in the code)? Any other ideas? -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

1 27