September 2013 - Koha-bugs - lists.koha-community.org

[Bug 2629] Diacritics not being ignored when searching
by bugzilla-daemon＠bugs.koha-community.org 24 Sep '13

24 Sep '13

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2629 Fridolyn SOMERS <fridolyn.somers(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10939 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9681] New: Add some indexes in database
by bugzilla-daemon＠bugs.koha-community.org 24 Sep '13

24 Sep '13

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9681 Bug ID: 9681 Summary: Add some indexes in database Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Database Assignee: gmcharlt(a)gmail.com Reporter: fridolyn.somers(a)biblibre.com Some table columns should have an index to speed SQL queries : - statistics table has only one index (used to make heavy queries for reports) - itemtype should have an index in items and biblioitems (this is used in circulation to check the number of existing issues of a specific item type) - issue.branchcode and issue.issuingbranch Note that the fact that an index is automatically created for foreign keys in InnoBD seems to be in discussion, so better create it explicitly. -- You are receiving this mail because: You are watching all bug changes.

1 9

[Bug 2720] Overdues which debar automatically should undebar automatically when returned
by bugzilla-daemon＠bugs.koha-community.org 24 Sep '13

24 Sep '13

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2720 --- Comment #47 from Jonathan Druart <jonathan.druart(a)biblibre.com> --- Created attachment 21410 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21410&action=edit Bug 2720: FIX the "remove" links If there are more than one restriction, the "remove" links don't display the js alert. Signed-off-by: Jonathan Druart <jonathan.druart(a)biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 2720] Overdues which debar automatically should undebar automatically when returned
by bugzilla-daemon＠bugs.koha-community.org 24 Sep '13

24 Sep '13

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2720 --- Comment #46 from Jonathan Druart <jonathan.druart(a)biblibre.com> --- Created attachment 21409 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21409&action=edit Bug 2720: QA followup - change license version to GPLv3+ Signed-off-by: Jonathan Druart <jonathan.druart(a)biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 2720] Overdues which debar automatically should undebar automatically when returned
by bugzilla-daemon＠bugs.koha-community.org 24 Sep '13

24 Sep '13

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2720 --- Comment #45 from Jonathan Druart <jonathan.druart(a)biblibre.com> --- Created attachment 21408 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21408&action=edit Bug 2720 - QA Followup 2 Signed-off-by: Jonathan Druart <jonathan.druart(a)biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 2720] Overdues which debar automatically should undebar automatically when returned
by bugzilla-daemon＠bugs.koha-community.org 24 Sep '13

24 Sep '13

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2720 --- Comment #44 from Jonathan Druart <jonathan.druart(a)biblibre.com> --- Created attachment 21407 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21407&action=edit Bug 2720: Unit tests improvements Create the patron. Use a transaction. Signed-off-by: Jonathan Druart <jonathan.druart(a)biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 2720] Overdues which debar automatically should undebar automatically when returned
by bugzilla-daemon＠bugs.koha-community.org 24 Sep '13

24 Sep '13

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2720 --- Comment #43 from Jonathan Druart <jonathan.druart(a)biblibre.com> --- Created attachment 21406 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21406&action=edit Bug 2720 [FOLLOW-UP] Overdues which debar automatically should undebar automatically This follow-up to Bug 2720 makes some template changes which I think make the interface a little more consistent and streamlined. Instead of incorporating the manual entry form into the table it is broken out and follows standard form structure. This lets the table be hidden altogether if there are no existing restrictions. The manual entry form is hidden by default and shown when you click a link to add a manual restriction. These changes have been applied to both the include file used for circulation and patron detail and to the patron entry form template. To test, add and remove manual restrictions from the circulation page, the patron detail page, and the patron edit page. All operations should work correctly. Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart(a)biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 2720] Overdues which debar automatically should undebar automatically when returned
by bugzilla-daemon＠bugs.koha-community.org 24 Sep '13

24 Sep '13

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2720 Jonathan Druart <jonathan.druart(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21366|0 |1 is obsolete| | Attachment #21367|0 |1 is obsolete| | Attachment #21368|0 |1 is obsolete| | Attachment #21369|0 |1 is obsolete| | --- Comment #42 from Jonathan Druart <jonathan.druart(a)biblibre.com> --- Created attachment 21405 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21405&action=edit Bug 2720 - Overdues which debar automatically should undebar automatically when returned This patch adds a more extensible and flexible debarments system to Koha. The fields borrowers.debarred and borrowers.debarredcomment are retained for compatibility and speed. This system supports having debarments for multiple reasons. There are currently three types of debarments: OVERDUES - Generated by overdue_notices.pl if the notice should debar a patron SUSPENSION - A punative debarment generated on checkin via an issuing rule MANUAL - A debarment created manually by a librarian OVERDUE debarments are cleared automatically when all overdue items have been returned, if the new system preference AutoRemoveOverduesRestrictions is enabled. It is disabled by default to retain current default functionality. Whenever a borrowers debarments are modified, the system updates the borrowers debarment fields with the highest expiration from all the borrowers debarments, and concatenates the comments from the debarments together. Test plan: 1) Apply patch 2) Run updatedatabase.pl 3) Verify the borrower_debarments table has been created and populated with the pre-existing debarments 4) Run t/db_dependent/Borrower_Debarments.t 5) Manually debar a patron, with an expiration date 6) Verify the patron cannot be issued to 7) Add another manual debarment with a different expiration date 8) Verify the 'restricted' message lists the date farthest into the future 9) Add another manual debarment with no expiration date 10) Verify the borrower is now debarred indefinitely 11) Delete the indefinite debarment 12) Verify the debarment message lists an expiration date dagain 13) Enable the new system preference AutoRemoveOverduesRestrictions 14) Set an overdue notice to debar after 1 day of being overdue 15) Check out an item to a patron and backdate the due date to yesterday 16) Run overdue_notices.pl 17) Verify the OVERDUES debarment was created 18) Return the item 19) Verify the OVERDUES debarment was removed 20) Disable AutoRemoveOverduesRestrictions 21) Repeat steps 15 though 18, verify the OVERDUES debarment was *not* removed 22) Add issuing rules so that an overdue item causes a temporary debarment 23) Check out an item to a patron and backdate the due date by a year 24) Return the item 25) Verify the SUSPENSION debarment was added to the patron Signed-off-by: Owen Leonard <oleonard(a)myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart(a)biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 2720] Overdues which debar automatically should undebar automatically when returned
by bugzilla-daemon＠bugs.koha-community.org 24 Sep '13

24 Sep '13

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2720 Jonathan Druart <jonathan.druart(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Large patch QA Contact|koha-bugs(a)lists.koha-commun |jonathan.druart(a)biblibre.co |ity.org |m --- Comment #41 from Jonathan Druart <jonathan.druart(a)biblibre.com> --- QA comment: The feature works as expected. I will provide 2 followups: - fix GPL license - fix a minor issue on the "remove" links Note: I think fields debarred and debarredcomment should be removed later. Marked as Passed QA. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 4045] No check for maximum number of allowed holds.
by bugzilla-daemon＠bugs.koha-community.org 24 Sep '13

24 Sep '13

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4045 I'm just a bot <gitbot(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gitbot(a)bugs.koha-community. | |org When did the bot| |2013-09-24 last check this| | --- Comment #46 from I'm just a bot <gitbot(a)bugs.koha-community.org> --- Patch applied cleanly, go forth and signoff -- You are receiving this mail because: You are watching all bug changes.

1 0