December 2014 - Koha-bugs - lists.koha-community.org

[Bug 1861] Unique patrons logins not (totally) enforced
by bugzilla-daemon＠bugs.koha-community.org 30 Dec '14

30 Dec '14

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1861 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34820|0 |1 is obsolete| | --- Comment #29 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Created attachment 34821 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34821&action=edit Bug 1861 [SIGNED OFF]: There is a problem introduced with an earlier patch, on this patchset - $data{'userid'} = Generate_Userid($data{'borrowernumber'}, $data{'firstname'}, $data{'surname'}) if $data{'userid'} eq ''; + $data{'userid'} = Generate_Userid( $data{'borrowernumber'}, $data{'firstname'}, $data{'surname'} ) + if ( $data{'userid'} eq '' || Check_Userid( $data{'userid'} ) ); Check_Userid returns 1 if it is unique. So this means unique userids will always be discarded and new ones created. This is why all the tests depending on a userid are now failing To test 1/ run perl t/db_dependent/Serials_2.t 2/ Notice lots of tests fail 3/ OR Add a borrower with a userid set, notice the userid is ignored and one is generated instead 4/ Apply patch 5/ Add a new borrower, notice the userid sticks (if it is unique) 6/ Run perl t/db_dependent/Serials_2.t notice tests pass 7/ Run perl t/db_dependent/Members.t notice tests still pass Signed-off-by: Martin Renvoize <martin.renvoize(a)ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 1861] Unique patrons logins not (totally) enforced
by bugzilla-daemon＠bugs.koha-community.org 30 Dec '14

30 Dec '14

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1861 Martin Renvoize <martin.renvoize(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 1861] Unique patrons logins not (totally) enforced
by bugzilla-daemon＠bugs.koha-community.org 30 Dec '14

30 Dec '14

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1861 --- Comment #28 from Martin Renvoize <martin.renvoize(a)ptfs-europe.com> --- Pants, how did I miss this. Good catch Chris! -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 1861] Unique patrons logins not (totally) enforced
by bugzilla-daemon＠bugs.koha-community.org 30 Dec '14

30 Dec '14

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1861 --- Comment #27 from Chris Cormack <chris(a)bigballofwax.co.nz> --- Created attachment 34820 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34820&action=edit BUg 1861 : There is a problem introduced with an earlier patch, on this patchset - $data{'userid'} = Generate_Userid($data{'borrowernumber'}, $data{'firstname'}, $data{'surname'}) if $data{'userid'} eq ''; + $data{'userid'} = Generate_Userid( $data{'borrowernumber'}, $data{'firstname'}, $data{'surname'} ) + if ( $data{'userid'} eq '' || Check_Userid( $data{'userid'} ) ); Check_Userid returns 1 if it is unique. So this means unique userids will always be discarded and new ones created. This is why all the tests depending on a userid are now failing To test 1/ run perl t/db_dependent/Serials_2.t 2/ Notice lots of tests fail 3/ OR Add a borrower with a userid set, notice the userid is ignored and one is generated instead 4/ Apply patch 5/ Add a new borrower, notice the userid sticks (if it is unique) 6/ Run perl t/db_dependent/Serials_2.t notice tests pass 7/ Run perl t/db_dependent/Members.t notice tests still pass -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 1861] Unique patrons logins not (totally) enforced
by bugzilla-daemon＠bugs.koha-community.org 30 Dec '14

30 Dec '14

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1861 Chris Cormack <chris(a)bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 1861] Unique patrons logins not (totally) enforced
by bugzilla-daemon＠bugs.koha-community.org 30 Dec '14

30 Dec '14

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1861 --- Comment #26 from Chris Cormack <chris(a)bigballofwax.co.nz> --- There is massive issue with this Specifically the Fix Check_Userid sub Check_Userid { - my ($uid,$member) = @_; - my $dbh = C4::Context->dbh; - my $sth = - $dbh->prepare( - "SELECT * FROM borrowers WHERE userid=? AND borrowernumber != ?"); - $sth->execute( $uid, $member ); - if ( (( $uid ne '' ) && ( my $row = $sth->fetchrow_hashref )) or - (( $uid ne '' ) && ( $uid eq C4::Context->config('user') )) ) { - return 0; - } - else { - return 1; - } + my ( $uid, $borrowernumber ) = @_; + + return 1 unless ($uid); + + return 0 if ( $uid eq C4::Context->config('user') ); + + my $rs = Koha::Database->new()->schema()->resultset('Borrower'); + + my $params; + $params->{userid} = $uid; + $params->{borrowernumber} = { '!=' => $borrowernumber } if ($borrowernumber); + + my $count = $rs->count( $params ); + + return $count ? 0 : 1; } So we return 1 if it's unique. Then we did this - $data{'userid'} = Generate_Userid($data{'borrowernumber'}, $data{'firstname'}, $data{'surname'}) if $data{'userid'} eq ''; + $data{'userid'} = Generate_Userid( $data{'borrowernumber'}, $data{'firstname'}, $data{'surname'} ) + if ( $data{'userid'} eq '' || Check_Userid( $data{'userid'} ) ); Which says essentially, if it is unique .. don't use it, if it isn't unique .. then use it. (and the db insert then fails). So we can insert borrowers who have a unique userid, but it will never use that userid it will generate one. Quite broken. Patch to follow -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 1861] Unique patrons logins not (totally) enforced
by bugzilla-daemon＠bugs.koha-community.org 30 Dec '14

30 Dec '14

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1861 Chris Cormack <chris(a)bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 1861] Unique patrons logins not (totally) enforced
by bugzilla-daemon＠bugs.koha-community.org 29 Dec '14

29 Dec '14

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1861 Chris Cormack <chris(a)bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #25 from Chris Cormack <chris(a)bigballofwax.co.nz> --- Pushed to 3.18.x will be in 3.18.3 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12596] New: Backdating returns with SpecifiyReturnDate causes fines for items not overdue!
by bugzilla-daemon＠bugs.koha-community.org 29 Dec '14

29 Dec '14

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12596 Bug ID: 12596 Summary: Backdating returns with SpecifiyReturnDate causes fines for items not overdue! Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: Circulation Assignee: koha-bugs(a)lists.koha-community.org Reporter: kyle(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com When using the backdating of returns feature, an item that is not overdue is treated as being as many days overdue as it is *not* overdue. This is due to the fact that _get_chargeable_units appears to return the difference between the return date and the due date without consideration the return date being earlier than the due date. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 18

[Bug 12315] New: MTT FIX: Advanced notices are not duplicated and not sent to the right patron
by bugzilla-daemon＠bugs.koha-community.org 29 Dec '14

29 Dec '14

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12315 Bug ID: 12315 Summary: MTT FIX: Advanced notices are not duplicated and not sent to the right patron Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: Tools Assignee: gmcharlt(a)gmail.com Reporter: jonathan.druart(a)biblibre.com QA Contact: testopia(a)bugs.koha-community.org Bug 10833 introduced a variable loop but does not reset it every iteration. So the first patron receives correct letters, but the followings received all the previous ones AND his letters. Very bad... -- You are receiving this mail because: You are watching all bug changes.

1 15