May 2014 - Koha-bugs - lists.koha-community.org

[Bug 3050] Add an option to upload scanned invoices.
by bugzilla-daemon＠bugs.koha-community.org 09 May '14

09 May '14

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3050 --- Comment #9 from Jacek Ablewicz <ablewicz(a)gmail.com> --- Created attachment 28124 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28124&action=edit Bug 3050 - Add an option to upload scanned invoices #2/3 (part #2: changes to existing acqui scripts & templates) -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 3050] Add an option to upload scanned invoices.
by bugzilla-daemon＠bugs.koha-community.org 09 May '14

09 May '14

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3050 Jacek Ablewicz <ablewicz(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25306|0 |1 is obsolete| | Attachment #26724|0 |1 is obsolete| | --- Comment #8 from Jacek Ablewicz <ablewicz(a)gmail.com> --- Created attachment 28123 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28123&action=edit Bug 3050 - Add an option to upload scanned invoices #1/3 (part #1: new module w/ UT + script + template) New feature, adds an ability to attach arbitrary files to acquisition records (currently: to the invoices - but it can be extended to baskets, basketgroups, budgets etc.). Note: this code is (heavily) based on "Bug 8130 - attach PDF files to a patron record" by Kale M Hall, main difference being that new table (misc_files) and new module (Koha/Misc/Files.pm) are intended to be a little more generic solution - they allow to store and manage files associated with great many kinds of records, from arbitrary tables. Test plan: 1) Apply patch[es] 2) Run installer/data/mysql/updatedatabase.pl 3) Enable system preference 'AcqEnableFiles' in acquisition 4) New option 'Manage invoice files' appears in the invoice detail page 5) Upload/view/download/delete some files for some invoices 6) Try to delete invoice with files attached (files should get deleted as well) 7) Try to merge 2+ invoices with files attached; after merge, all files previously attached to individual invoices being merged should be attached to resulting invoice (merge destination) 8) prove t/db_dependent/Koha_Misc_Files.t 9) Ensure there are no regressions of any kind in invoice detail page (acqui/invoice.pl). -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 12221] New: Remove TT statement placeholders from translatable strings
by bugzilla-daemon＠bugs.koha-community.org 09 May '14

09 May '14

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12221 Bug ID: 12221 Summary: Remove TT statement placeholders from translatable strings Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: I18N/L10N Assignee: pasi.kallinen(a)pttk.fi Reporter: pasi.kallinen(a)pttk.fi QA Contact: testopia(a)bugs.koha-community.org CC: frederic(a)tamil.fr The translation message catalogs contain a lot of Template Toolkit statements in the messages. They bloat the message lengths, and add unnecessary complications for translators, making errors far more likely. For example, there's no need to have "INCLUDE 'opac-bottom.inc'" show up as a placeholder in the messages. Using the following incantation: grep -E '^#\. %[0-9]+\$s: ' po/xx-YY-*.po | cut -d':' -f 3- | sed -e 's/^ *$IF\|ELSIF\|CASE\|SWITCH\|INCLUDE\|USE\|SET\|PROCESS\|BLOCK\|FOREACH\|UNLESS$ *.*$/ \1 /g' | sort | uniq -c | sort -rn we get a list of all placeholders, sorted by # of uses. The top-5 is: 1750 END 1429 IF 647 ELSE 263 ELSIF 252 INCLUDE -- You are receiving this mail because: You are watching all bug changes.

1 2

[Bug 12219] New: Purchase Suggestions branch level permissions
by bugzilla-daemon＠bugs.koha-community.org 08 May '14

08 May '14

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12219 Bug ID: 12219 Summary: Purchase Suggestions branch level permissions Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs(a)lists.koha-community.org Reporter: cbrannon(a)cdalibrary.org QA Contact: testopia(a)bugs.koha-community.org We would like to see branch level permission for responding to or deleting purchase suggestions. We have had data from one library removed by another library on multiple occasions, and would like to have better control over this. Christopher -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0

[Bug 12218] New: show patrons the notices log
by bugzilla-daemon＠bugs.koha-community.org 08 May '14

08 May '14

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12218 Bug ID: 12218 Summary: show patrons the notices log Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs(a)lists.koha-community.org Reporter: nengard(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com It would be nice to have the option to show patrons the notices that have been sent to them - like you can see in the staff client. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0

[Bug 4068] Accepting a suggestion hides 'pending' tab
by bugzilla-daemon＠bugs.koha-community.org 08 May '14

08 May '14

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4068 Galen Charlton <gmcharlt(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt(a)gmail.com --- Comment #8 from Galen Charlton <gmcharlt(a)gmail.com> --- Pushed to master, along with a follow-up that adds the use of URI::Escape. Thanks, Kyle! -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 12195] New: Remove duplicated plugin jquery.dataTables.min.js
by bugzilla-daemon＠bugs.koha-community.org 08 May '14

08 May '14

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12195 Bug ID: 12195 Summary: Remove duplicated plugin jquery.dataTables.min.js Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org Now that all staff client templates use the new datatables include file the datatables plugin located in prog/en/lib/jquery/plugins can be removed. -- You are receiving this mail because: You are watching all bug changes.

1 8

[Bug 12196] New: Remove unused jquery.qtip.js plugin
by bugzilla-daemon＠bugs.koha-community.org 08 May '14

08 May '14

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12196 Bug ID: 12196 Summary: Remove unused jquery.qtip.js plugin Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org The last usage instance of the jquery.qtip.js plugin was removed by Bug 11578. The plugin can now be removed. -- You are receiving this mail because: You are watching all bug changes.

1 10

[Bug 12198] New: Guarantor search makes incorrect and unnecessary call to GetMemberIssuesAndFines
by bugzilla-daemon＠bugs.koha-community.org 08 May '14

08 May '14

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12198 Bug ID: 12198 Summary: Guarantor search makes incorrect and unnecessary call to GetMemberIssuesAndFines Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Patrons Assignee: koha-bugs(a)lists.koha-community.org Reporter: kyle(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com The script members/guarantor_search.pl makes the following call: my ($od,$issue,$fines)=GetMemberIssuesAndFines($results->[$i]{'borrowerid'}); Not only does this call always fail because borrowerid is not a valid key, but the results are never even used in the template! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 13

[Bug 9048] New: Quote editor does not work under Plack
by bugzilla-daemon＠bugs.koha-community.org 08 May '14

08 May '14

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9048 Priority: P5 - low Change sponsored?: --- Bug ID: 9048 Assignee: gmcharlt(a)gmail.com Summary: Quote editor does not work under Plack Severity: major Classification: Unclassified OS: All Reporter: jcamins(a)cpbibliography.com Hardware: All Status: NEW Version: master Component: Tools Product: Koha Because the return values in tools/quotes/quotes_ajax.pl are backwards -- I think -- Plack returns a 500 server error after successfully editing quotes. >From the logs: exited nonzero: 1 at /home/jcamins/kohaclone/tools/quotes/quotes_ajax.pl line 121 CGI::Compile::ROOT::home_jcamins_kohaclone_tools_quotes_quotes_ajax_2epl::__ANON__ at /usr/share/perl5/CGI/Emulate/PSGI.pm line 28 CGI::Emulate::PSGI::__ANON__('HASH(0x542f808)') called at /usr/share/perl5/Plack/App/WrapCGI.pm line 83 Plack::App::WrapCGI::call('Plack::App::WrapCGI=HASH(0x5aecdc8)', 'HASH(0x542f808)') called at /usr/share/perl5/Plack/Component.pm line 39 Plack::Component::__ANON__('HASH(0x542f808)') called at /usr/share/perl5/Plack/App/CGIBin.pm line 50 Plack::App::CGIBin::serve_path('Plack::App::CGIBin=HASH(0x50d7a08)', 'HASH(0x542f808)', '/home/jcamins/kohaclone/tools/quotes/quotes_ajax.pl') called at /usr/share/perl5/Plack/App/File.pm line 34 Plack::App::File::call('Plack::App::CGIBin=HASH(0x50d7a08)', 'HASH(0x542f808)') called at /usr/share/perl5/Plack/Component.pm line 39 Plack::Component::__ANON__('HASH(0x542f808)') called at /usr/share/perl5/Plack/App/URLMap.pm line 71 Plack::App::URLMap::call('Plack::App::URLMap=HASH(0x4e16750)', 'HASH(0x542f808)') called at /usr/share/perl5/Plack/Component.pm line 39 Plack::Middleware::StackTrace::__ANON__ at /usr/share/perl5/Try/Tiny.pm line 71 eval {...} at /usr/share/perl5/Try/Tiny.pm line 67 Plack::Middleware::StackTrace::call('Plack::Middleware::StackTrace=HASH(0x5133138)', 'HASH(0x542f808)') called at /usr/share/perl5/Plack/Component.pm line 39 Plack::Component::__ANON__('HASH(0x542f808)') called at /usr/share/perl5/Plack/Middleware/Static.pm line 18 Plack::Middleware::Static::call('Plack::Middleware::Static=HASH(0x5133330)', 'HASH(0x542f808)') called at /usr/share/perl5/Plack/Component.pm line 39 Plack::Component::__ANON__('HASH(0x542f808)') called at /home/jcamins/perl5/lib/perl5/Plack/Middleware/Debug/Base.pm line 23 Plack::Middleware::Debug::Base::call('Plack::Middleware::Debug::Memory=HASH(0x51cdb80)', 'HASH(0x542f808)') called at /usr/share/perl5/Plack/Component.pm line 39 Plack::Component::__ANON__('HASH(0x542f808)') called at /home/jcamins/perl5/lib/perl5/Plack/Middleware/Debug/Base.pm line 23 Plack::Middleware::Debug::Base::call('Plack::Middleware::Debug::Timer=HASH(0x51cdd78)', 'HASH(0x542f808)') called at /usr/share/perl5/Plack/Component.pm line 39 Plack::Component::__ANON__('HASH(0x542f808)') called at /home/jcamins/perl5/lib/perl5/Plack/Middleware/Debug/Base.pm line 23 Plack::Middleware::Debug::Base::call('Plack::Middleware::Debug::Response=HASH(0x51cdf10)', 'HASH(0x542f808)') called at /usr/share/perl5/Plack/Component.pm line 39 Plack::Component::__ANON__('HASH(0x542f808)') called at /home/jcamins/perl5/lib/perl5/Plack/Middleware/Debug/Base.pm line 23 Plack::Middleware::Debug::Base::call('Plack::Middleware::Debug::Environment=HASH(0x51ce0a8)', 'HASH(0x542f808)') called at /usr/share/perl5/Plack/Component.pm line 39 Plack::Component::__ANON__('HASH(0x542f808)') called at /home/jcamins/perl5/lib/perl5/Plack/Middleware/Debug.pm line 138 Plack::Middleware::Debug::call('Plack::Middleware::Debug=HASH(0x5133528)', 'HASH(0x542f808)') called at /usr/share/perl5/Plack/Component.pm line 39 Plack::Component::__ANON__('HASH(0x542f808)') called at /usr/share/perl5/Plack/Middleware/AccessLog.pm line 21 Plack::Middleware::AccessLog::call('Plack::Middleware::AccessLog=HASH(0x26e1500)', 'HASH(0x542f808)') called at /usr/share/perl5/Plack/Component.pm line 39 Plack::Component::__ANON__('HASH(0x542f808)') called at /usr/share/perl5/Plack/Util.pm line 165 eval {...} at /usr/share/perl5/Plack/Util.pm line 165 Plack::Util::run_app('CODE(0x26e1428)', 'HASH(0x542f808)') called at /usr/share/perl5/Starman/Server.pm line 223 Starman::Server::process_request('Starman::Server=HASH(0x26e1728)') called at /usr/share/perl5/Net/Server.pm line 142 Net::Server::run_client_connection('Starman::Server=HASH(0x26e1728)') called at /usr/share/perl5/Net/Server/PreFork.pm line 273 eval {...} at /usr/share/perl5/Net/Server/PreFork.pm line 273 Net::Server::PreFork::run_child('Starman::Server=HASH(0x26e1728)') called at /usr/share/perl5/Net/Server/PreFork.pm line 229 Net::Server::PreFork::run_n_children('Starman::Server=HASH(0x26e1728)', 2) called at /usr/share/perl5/Net/Server/PreFork.pm line 144 Net::Server::PreFork::loop('Starman::Server=HASH(0x26e1728)') called at /usr/share/perl5/Net/Server.pm line 117 Net::Server::run('Starman::Server=HASH(0x26e1728)', 'port', 'ARRAY(0x4e16b40)', 'host', 'ARRAY(0x4e166a8)', 'proto', 'ARRAY(0x53f21d8)', 'serialize', 'flock', 'log_level', 2, 'log_file', '/home/jcamins/koha-dev/var/log/koha-error.log', 'min_servers', 2, 'min_spare_servers', 1, 'max_spare_servers', 1, 'max_servers', 2, 'max_requests', 50, 'user', 1001, 'group', '1003 33 999 1003', 'listen', 1024, 'leave_children_open_on_hup', 1, 'no_client_stdout', 1, 'pid_file', '/home/jcamins/koha-dev/var/run/plack.pid', 'setsid', 1, 'background', 1) called at /usr/share/perl5/Starman/Server.pm line 61 Starman::Server::run('Starman::Server=HASH(0x26e1728)', 'CODE(0x26e1428)', 'HASH(0x50d79d8)') called at /usr/share/perl5/Plack/Handler/Starman.pm line 18 Plack::Handler::Starman::run('Plack::Handler::Starman=HASH(0x50d76f0)', 'CODE(0x26e1428)') called at /usr/share/perl5/Plack/Loader.pm line 88 Plack::Loader::run('Plack::Loader=HASH(0x265ba98)', 'Plack::Handler::Starman=HASH(0x50d76f0)') called at /usr/share/perl5/Plack/Runner.pm line 263 Plack::Runner::run('Plack::Runner=HASH(0x23d09a0)') called at /usr/bin/starman line 31 -- You are receiving this mail because: You are watching all bug changes.

1 12