August 2014 - Koha-bugs - lists.koha-community.org

[Bug 12080] New: Superserials permission appears to be broken
by bugzilla-daemon＠bugs.koha-community.org 07 Aug '14

07 Aug '14

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12080 Bug ID: 12080 Summary: Superserials permission appears to be broken Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Serials Assignee: koha-bugs(a)lists.koha-community.org Reporter: katrin.fischer(a)bsz-bw.de QA Contact: testopia(a)bugs.koha-community.org CC: colin.campbell(a)ptfs-europe.com 1) IndependentBranches needs to be activated - 'Prevent' 2) Make sure you have some subscriptions, set to different branches 3) Search for all subscriptions with an empty search Problem 1: If the user has the superserials permission, the search doesn't show all subscriptions. Problem 2: If the user doesn't have the superserials permission, you can still edit a subscription accessing the subsscription detail page through the serial collection page (for records with multiple subscriptions) or accessing the detail page directly. Hope I tested this correctly - would be happy if someone could confirm the bug. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 28

[Bug 12048] New: Doesn't display other libraries subscriptions when superlibrarian user
by bugzilla-daemon＠bugs.koha-community.org 07 Aug '14

07 Aug '14

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12048 Bug ID: 12048 Summary: Doesn't display other libraries subscriptions when superlibrarian user Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Serials Assignee: koha-bugs(a)lists.koha-community.org Reporter: frederic(a)tamil.fr QA Contact: testopia(a)bugs.koha-community.org CC: colin.campbell(a)ptfs-europe.com This is a regression in master and 3.14. When a user has superlibrian permissions, a search on serials subscriptions must display other libraries subscriptions even when IndependantBranch syspref is enabled. To reproduce/test the bug/patch: 1. Enable IndependanBranch 2. Login as a user not having superlibrarian permission 3. Search for a serial subscription on: /cgi-bin/koha/serials/serials-search.pl 4. Search a title which has at least 2 subscriptions: one in the user branch, and one in another branch 5. On the result page, just 1 subscription is displayed: the one attached to the userbranch => this is normal 6. Login as a user having superlibrarian permission 7. Repeat step 3-5. 8. You get the same result as 5. You should have seen all subscriptions. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 17

[Bug 11587] New: IsSuperLibrarian generates warnings
by bugzilla-daemon＠bugs.koha-community.org 07 Aug '14

07 Aug '14

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11587 Bug ID: 11587 Summary: IsSuperLibrarian generates warnings Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt(a)gmail.com Reporter: mtompset(a)hotmail.com QA Contact: testopia(a)bugs.koha-community.org If userenv->{flags} is undefined, the modulus 2 generates floody entries. -- You are receiving this mail because: You are watching all bug changes.

1 19

[Bug 7002] New: Inaccurate checks for borrower flags == 1
by bugzilla-daemon＠bugs.koha-community.org 07 Aug '14

07 Aug '14

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7002 Bug #: 7002 Summary: Inaccurate checks for borrower flags == 1 Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Platform: All OS/Version: All Status: NEW Severity: normal Priority: P5 Component: Authentication AssignedTo: gmcharlt(a)gmail.com ReportedBy: oleonard(a)myacpl.org QAContact: koha-bugs(a)lists.koha-community.org CC: dpavlin(a)rot13.org There are a few instances in the code which I can find which use this to check whether someone has superlibrarian privileges in the context of IndependandBranches: unless (($userenv->{'flags'} == 1) or ($userenv->{'branch'} eq $item->{'homebranch'})) { This check fails if the logged in user has any other privilege checked in addition to superlibrarian. In other words, the user must *only* have superlibrarian checked in order to qualify to perform these operations. catalogue\moredetail.pl line 136 cataloguing\additem.pl line 548 tools\batchMod.pl line 460 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

1 15

[Bug 10277] New: Add C4::Context->IsSuperLibrarian()
by bugzilla-daemon＠bugs.koha-community.org 07 Aug '14

07 Aug '14

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10277 Bug ID: 10277 Summary: Add C4::Context->IsSuperLibrarian() Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt(a)gmail.com Reporter: kyle.m.hall(a)gmail.com The method of checking the logged in user for superlibrarian privileges is obtuse ( $userenv && $userenv->{flags} % 2 != 1 ) to say the least. The codebase is littered with these lines, with no explanation given. It would be much better if we had one subroutine that returned a boolean value to tell us if the logged in user is a superlibrarian or not. -- You are receiving this mail because: You are watching all bug changes.

1 59

[Bug 1861] Unique patrons logins not (totally) enforced
by bugzilla-daemon＠bugs.koha-community.org 06 Aug '14

06 Aug '14

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1861 Bernardo Gonzalez Kriegel <bgkriegel(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |bgkriegel(a)gmail.com -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 1861] Unique patrons logins not (totally) enforced
by bugzilla-daemon＠bugs.koha-community.org 06 Aug '14

06 Aug '14

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1861 Bernardo Gonzalez Kriegel <bgkriegel(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29616|0 |1 is obsolete| | --- Comment #5 from Bernardo Gonzalez Kriegel <bgkriegel(a)gmail.com> --- Created attachment 30561 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30561&action=edit [SIGNED-OFF] Bug 1861 - Unique patrons logins not (totally) enforced The Koha 3.0 patron admin page will prevent you from creating a user who has an identical OPAC login as someone else (though I would change the error message from "Login/password already exists." to "Login already exists.", since it's not the password that's the problem). However, there's nothing enforced in the MySQL database to prevent patrons from being imported or manually inserted with duplicate logins. Would it be better to change the MySQL spec from this: KEY `userid` (`userid`) to this: UNIQUE KEY `userid` (`userid`) Test plan: 1) Enter mysql console 2) Attempt to create two borrowers with identical user id's 3) Note you are able to do so 4) Delete these bororwers 5) Apply this patch 6) Run updatedatabase.pl 7) Repeat step 2 8) Note you are now unable to do so Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel(a)gmail.com> Work as described, no koha-qa errors -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 4319] waiting items cannot be reserved
by bugzilla-daemon＠bugs.koha-community.org 06 Aug '14

06 Aug '14

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4319 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=9774 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 4319] waiting items cannot be reserved
by bugzilla-daemon＠bugs.koha-community.org 06 Aug '14

06 Aug '14

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4319 --- Comment #20 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Copying the test plan from the duplicate bug report: When holds on items available items are not allowed (allowonshelfholds = don't allow), it's impossible to place holds on items that are 'on hold' (awaiting pickup). The item is not checked out yet, but unavailable to the patron. I think holds should be allowed in this case. To test: Set allowonshelfholds to don't allow 0) Search for a record with 1 available item Opac status: available No hold can be placed. 1) Check out item to user A Opac status: checked out 'Place hold' button is shown and holds can be placed. 2) Place a title level hold for user B Opac status: checked out 'Place hold' button is shown and holds can be placed. 3) Return item and confirm hold Opac status: on hold No hold can be placed. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 4319] waiting items cannot be reserved
by bugzilla-daemon＠bugs.koha-community.org 06 Aug '14

06 Aug '14

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4319 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |Susanne.Jerger(a)bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.

1 0