August 2014 - Koha-bugs - lists.koha-community.org

[Bug 12688] New: Better IntranetNav
by bugzilla-daemon＠bugs.koha-community.org 01 Aug '14

01 Aug '14

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12688 Bug ID: 12688 Summary: Better IntranetNav Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs(a)lists.koha-community.org Reporter: cbrannon(a)cdalibrary.org QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com Created attachment 30440 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30440&action=edit Cleaned up IntranetNav I've noticed that if you just throw some links into IntranetNav, it just makes the nav line wrap after just a couple additions. Plus the added links don't look good, and don't line up well. I've managed to mimic the More menu by stealing the code and pasting it into IntranetNav, then updating the labels and links. Here is the code I put into our IntranetNav: <li class="dropdown"> <a class="dropdown-toggle" data-toggle="dropdown" href="#"> Resources <b class="caret"></b> </a> <ul class="dropdown-menu"> <li> <a href="http://worldcat.org/" target="_blank">WorldCat</a> </li> <li> <a href="http://www.goodreads.com/" target="_blank">goodreads</a> </li> <li> <a href="http://www.cinlibraries.org/" target="_blank">CIN Website</a> </li> </ul> </li> It would be great if this structure was somehow built into the IntranetNav preference. It is much cleaner and behaves better. Christopher -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 6

[Bug 11734] New: Use new DataTables include in batch modification templates
by bugzilla-daemon＠bugs.koha-community.org 01 Aug '14

01 Aug '14

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11734 Bug ID: 11734 Summary: Use new DataTables include in batch modification templates Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/tools/batchMod.pl OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org Blocks: 11720 The batch modification and batch deletion templates should be updated to use the new DataTables include file introduced by Bug 10649. -- You are receiving this mail because: You are watching all bug changes.

1 12

[Bug 11711] New: Use new DataTables include in circ templates
by bugzilla-daemon＠bugs.koha-community.org 01 Aug '14

01 Aug '14

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11711 Bug ID: 11711 Summary: Use new DataTables include in circ templates Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org Circulation templates which use the DataTables plugin should be updated to use the new DataTables include file introduced by Bug 10649. -- You are receiving this mail because: You are watching all bug changes.

1 16

[Bug 11947] New: Hold priorities not re-calculated when hold is confirmed on checkin.
by bugzilla-daemon＠bugs.koha-community.org 01 Aug '14

01 Aug '14

1 42

[Bug 4045] No check for maximum number of allowed holds from OPAC.
by bugzilla-daemon＠bugs.koha-community.org 01 Aug '14

01 Aug '14

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4045 M. de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30051|0 |1 is obsolete| | --- Comment #73 from M. de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 30448 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30448&action=edit Bug 4045 - No check for maximum number of allowed holds. Re-add the system preference maxreserves. All the code using maxreserves is still in place. Though it is not used in the Reserves module, it is used in all the scripts where holds are placed. Also adds a check so that a borrower cannot exceed the maximum number of allowed holds by using the multi-hold feature via the opac. Test Plan: 1) Apply this patch 2) Run updatedatabase 3) Set maxreserves to 3, set opactheme to bootstrap 4) Log into the opac as a patron 5) Place 3 holds 6) Attempt to place a 4th hold 7) Note you get an error message and cannot place a forth hold 8) Delete two of those holds 9) Attempt to place 3 or more holds as a multi-hold 10) You should see a warning that you cannot place this many holds 11) Try to anyway 12) You should see an alert to tell you to reduce the number of holds you are placing. 13) Reduce the number for holds you are placing to 2 14) Your holds should now be placed Signed-off-by: Chris Cormack <chrisc(a)catalyst.net.nz> Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 4045] No check for maximum number of allowed holds from OPAC.
by bugzilla-daemon＠bugs.koha-community.org 01 Aug '14

01 Aug '14

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4045 M. de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #72 from M. de Rooy <m.de.rooy(a)rijksmuseum.nl> --- QA Comment If maxreserves would have been a new development and Holds was a perfect module, this should have failed QA :) But we are in another situation. The missing maxreserves for long time already is really bad. My test results show me that there are still some discrepancies and points to resolve. We could see this patch as the starting point for that. Since this report already has quite a history, I am passing QA on it in the perspective noted. Leaving final judgement to RM or perhaps a second QA opinion? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 4045] No check for maximum number of allowed holds from OPAC.
by bugzilla-daemon＠bugs.koha-community.org 01 Aug '14

01 Aug '14

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4045 --- Comment #71 from M. de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Still another test after deleting the reserves from the fourth run: I select four biblios and place hold. I get a warning to uncheck. I uncheck one biblio and select three items (BK) with a hold limit on BK=2. Without a warning I had two holds placed. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 4045] No check for maximum number of allowed holds from OPAC.
by bugzilla-daemon＠bugs.koha-community.org 01 Aug '14

01 Aug '14

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4045 --- Comment #70 from M. de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Test results: Hopefully understandable enough (bl=bib level; il=item level; numbers are bibs) Will refer to this in my QA comment. First test (biblevel maxreserves=3 issuingrules=10 on all itypes) bl 668 OK bl 1178 OK req on two biblios: get warning when submitting: ERROR: Internal error: incomplete hold request. So both holds are blocked. But the error message is kind of vague. Result of bad_data flag in opac-reserve.pl No blocker, but this could still be improved. bl 1234 on third OK try no 4 (1235) message fine OK try 4 via staff warning, but hold is placed [staff overrules: design??] Note that I had AllowHoldPolicyOverride=Do not allow override! try 5 via opac: You cannot place more than 4 holds. (Oops: actually more than 3 should not be allowed..) Second test (itemlevel maxres=3 issu=2 on all itypes) il 668 il 1178 req on two: Funny: Four warnings: None can be placed on hold (Fine). Sorry, you can only place 1 more holds (Small spelling issue too! But it is not true! I have gone above the number of 2 in issuingrules. Please uncheck boxes (Impossible: there are no boxes to uncheck..) Per biblio a warning: No available items. il 1234 None can be placed on hold (OK) Changing issu=2 to issu=3: repeat il 1234 (OK) try no 4 (1235): You cannot place more than 3 holds (OK) try 4 via staff Cannot place hold on some items (No items are available) So, this time I cannot overrule it. Third test (item level maxres=3 issu=2 on BK only) il 668 BK il 1178 BK try il 1234 BK None can be placed (OK) try il 1331 CF Sorry none can be placed (Not true: I just have 2 holds; For itype CF I should have one to go?) try il 1331 CF on staff: Cannot place a hold. No items av. (Not true?) delete two reserves, try il 1331 CF: Still impossible. Fourth test (item level issu BK=2 issu CF=4) il 668 BK il 1178 BK try il 1234 BK None placed: OK try il 1331 CF Can be done: OK retry il 1331 CF No more than 3: OK (maxreserves overrules the CF=4 rule here.. Debatable?) try il 1235 BK You cannot place more than 3: OK -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 4045] No check for maximum number of allowed holds from OPAC.
by bugzilla-daemon＠bugs.koha-community.org 01 Aug '14

01 Aug '14

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4045 M. de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|mtj(a)kohaaloha.com |m.de.rooy(a)rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 4045] No check for maximum number of allowed holds from OPAC.
by bugzilla-daemon＠bugs.koha-community.org 01 Aug '14

01 Aug '14

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4045 M. de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.

1 0