December 2015 - Koha-bugs - lists.koha-community.org

[Bug 14964] New: Email notices will be queued for patrons with no email address
by bugzilla-daemon＠bugs.koha-community.org 23 Dec '15

23 Dec '15

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14964 Bug ID: 14964 Summary: Email notices will be queued for patrons with no email address Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Notices Assignee: koha-bugs(a)lists.koha-community.org Reporter: kyle.m.hall(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org If a patron has email messaging preferences set but no email address, a message will be added to the message queue anyway, but will always end up 'failed'. This could be resolved by modifying C4::Letters::enqueue to not enqueue call EnqueueLetter if the transport is email or sms and no to address is returned. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 9

[Bug 15421] New: Show all available actions in reports toolbar
by bugzilla-daemon＠bugs.koha-community.org 23 Dec '15

23 Dec '15

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15421 Bug ID: 15421 Summary: Show all available actions in reports toolbar Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/reports/guided_reports.pl OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: Reports Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org The "Actions" dropdown on the main list of saved reports has a few actions which are not available in the reports toolbar: Duplicate, Schedule, and Delete. These should be available as toolbar buttons on saved reports pages. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15420] New: MARC21: Place of publication - Index 751$a with $4pup like 260$c
by bugzilla-daemon＠bugs.koha-community.org 23 Dec '15

23 Dec '15

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15420 Bug ID: 15420 Summary: MARC21: Place of publication - Index 751$a with $4pup like 260$c Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching Assignee: gmcharlt(a)gmail.com Reporter: katrin.fischer(a)bsz-bw.de QA Contact: testopia(a)bugs.koha-community.org 751$a can contain the place of publication, if $4 is set to pup. In some cases this can be important information and should be searchable. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 4078] Display active currency symbol on currency output and input
by bugzilla-daemon＠bugs.koha-community.org 23 Dec '15

23 Dec '15

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4078 Marc Véron <veron(a)veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|veron(a)veron.ch |oleonard(a)myacpl.org --- Comment #22 from Marc Véron <veron(a)veron.ch> --- (In reply to Jonathan Druart from comment #20) > Comment on attachment 45888 [details] [review] > (...) should be done at the currency level (currency table), not the syspref. > Actually the syspref should be removed. > (...) Hi Jonathan, your approach will be better, for sure. I remove assignement from this long outstanding bug and will be happy to sign-off your solution. I simply hope that we soon have the possibility to display currency symbols and more currency formatting than the US and French ones only, e.g. 360'000.00 for Switzerland. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15419] New: Sipserver problem with stale db handles
by bugzilla-daemon＠bugs.koha-community.org 23 Dec '15

23 Dec '15

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15419 Bug ID: 15419 Summary: Sipserver problem with stale db handles Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: SIP2 Assignee: koha-bugs(a)lists.koha-community.org Reporter: colin.campbell(a)ptfs-europe.com QA Contact: testopia(a)bugs.koha-community.org CC: colin.campbell(a)ptfs-europe.com This is a very intermittent problem which appears to manifest in two ways and to date from when C4::Context->dbh stopped using ping way back in commit 4ae3665ad8afb5d283d989c4622a91690e1c4f8a Stale dbh remains active. This was seen on clients which are up for 24 hours, when after 12hours or so of only sending status requests (which do require db access) a real request comes in the database handle which should be refreshed is not but is treated as valid. e.g. a valid patron is entered but the sip server returns it as invalid (the undef returned from the invalid dbh is indistinguishable from returning 0 rows) - In practice I've circumvented this by getting the sepserver to restart all persistent connections at e.g. 6 or 7 am so that the reconnecting devices get a fresh db connection. Another possible solution may be to force a dbh connect in processing a status request. Second manifestation is in authentication I found that intermittently a login was being rejected with 'maintenence' or 'failure' this being the status return from check_api_auth unjustified in both cases. This may be a single occurence, a cluster of occurences and seems to then correct itself I've installed a kludge that does a ping using the dbh returned by context before calling check_api_auth, so far so good, but the intermittent nature of the prob means that I need to continue monitoring -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0

[Bug 11870] New: Add more informations to histsearch.pl results
by bugzilla-daemon＠bugs.koha-community.org 23 Dec '15

23 Dec '15

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11870 Bug ID: 11870 Summary: Add more informations to histsearch.pl results Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: julian.maurice(a)biblibre.com Reporter: julian.maurice(a)biblibre.com QA Contact: testopia(a)bugs.koha-community.org Depends on: 11708, 11844 Add more informations to histsearch.pl results - Basket group closed date and delivery place (in basketgroup column) - Additional order fields (one column for each additional field) -- You are receiving this mail because: You are watching all bug changes.

1 7

[Bug 15418] New: Switch Net::Server personality in sipserver to Fork
by bugzilla-daemon＠bugs.koha-community.org 23 Dec '15

23 Dec '15

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15418 Bug ID: 15418 Summary: Switch Net::Server personality in sipserver to Fork Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: SIP2 Assignee: koha-bugs(a)lists.koha-community.org Reporter: colin.campbell(a)ptfs-europe.com QA Contact: testopia(a)bugs.koha-community.org CC: colin.campbell(a)ptfs-europe.com Experience showed that using the pre-fork personality of Net::Server was using up resources for no benefit and that configuring the numbers in the config could be confusing. For the past year I've been running a a version using the Fork personality at our sites which use sipserver heavily both for self check and user authentication. Results seem more stable running for months and freeing resourses when connections close, with only sendig a SIGHUP to the controlling process to reread config and close active children. This merges the version we've been running back into the standard. Testing : As opposed to the pre-fork behaviour this will start up a single controlling instance to listem on the specified ports. Child processs will be created to handle handle sip connections and shutdown when the client closes the socket -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 1

[Bug 4078] Display active currency symbol on currency output and input
by bugzilla-daemon＠bugs.koha-community.org 23 Dec '15

23 Dec '15

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4078 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 4078] Display active currency symbol on currency output and input
by bugzilla-daemon＠bugs.koha-community.org 23 Dec '15

23 Dec '15

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4078 --- Comment #21 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- (In reply to Jonathan Druart from comment #20) > You do you remove this default value, it does not look mandatory. s/You/Why -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 4078] Display active currency symbol on currency output and input
by bugzilla-daemon＠bugs.koha-community.org 23 Dec '15

23 Dec '15

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4078 --- Comment #20 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Comment on attachment 45888 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45888 Bug 4078 - Display active currency symbol on currency output and input Review of attachment 45888: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=4078…) ----------------------------------------------------------------- You will have to write tests. I don't think it's the good approach. What about the other cases? For instance : "-£127.54" vs "-127,54 €", you will have to add 3 values. I think that what you are trying to add with this patch should be done at the currency level (currency table), not the syspref. Actually the syspref should be removed. ::: Koha/Number/Price.pm @@ +79,4 @@ > > sub _format_params { > my ( $self, $params ) = @_; > + my $with_symbol = $params->{with_symbol}; You do you remove this default value, it does not look mandatory. @@ +96,5 @@ > + $p_cs_precedes = 1 unless ( defined $p_cs_precedes ); > + } > + > + if ( $currency_format =~ m/(_TRAIL)/ ) { > + $p_cs_precedes = 0 unless ( defined $p_cs_precedes ); You are mixing ternary operator in the conditions, it does not make the code easy to read. -- You are receiving this mail because: You are watching all bug changes.

1 0