June 2015 - Koha-bugs - lists.koha-community.org

[Bug 1368] Use of FOREIGN_KEY_CHECKS = 0
by bugzilla-daemon＠bugs.koha-community.org 08 Jun '15

08 Jun '15

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1368 --- Comment #6 from Paul Poulain <paul.poulain(a)biblibre.com> --- I think we can wontfix it. There are some lines that are valid : the foreign_key_check=0 is necessary when you restore a dump : you don't want koha to check fk, because 1- sometimes you're temporary setting invalid data and 2- it slows the dump restore. Maybe there are some that are non necessary, but they're harmless. So wontfix is fair (and thanks for reviving those oldies !!!) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. You are the QA Contact for the bug.

1 0

[Bug 12320] New: $.cookie('foo', null) deprecated
by bugzilla-daemon＠bugs.koha-community.org 08 Jun '15

08 Jun '15

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12320 Bug ID: 12320 Summary: $.cookie('foo', null) deprecated Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt(a)gmail.com Reporter: gmcharlt(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org With the upgrade of jquery-cookie to the latest version (see bug 11369), the following construct to delete a cookie is no longer supported: $.cookie('foo', null) Instead, per https://github.com/carhartl/jquery-cookie/blob/master/CHANGELOG.md, it should now be $.removeCookie('foo'); There is at least one direct use of the deprecated construct: koha-tmpl/intranet-tmpl/prog/en/js/pages/batchMod.js: $.cookie("showColumns",null); and possibly others: koha-tmpl/intranet-tmpl/prog/en/js/staff-global.js: $.cookie("holdfor",null, { path: "/", expires: 0 }); koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt: $.cookie("holdfor",null, { path: "/", expires: 0 }); koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt:[% IF ( borrowernumber ) %]if($.cookie("holdfor") != [% borrowernumber %]){ $.cookie("holdfor",null, { path: "/", expires: 0 }); }[% ELSE %]$.cookie("holdfor",null, { path: "/", expires: 0 });[% END %] -- You are receiving this mail because: You are watching all bug changes.

1 15

[Bug 10286] New: Syspref auto-populator broken in French
by bugzilla-daemon＠bugs.koha-community.org 08 Jun '15

08 Jun '15

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10286 Bug ID: 10286 Summary: Syspref auto-populator broken in French Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: System Administration Assignee: koha-bugs(a)lists.koha-community.org Reporter: jcamins(a)cpbibliography.com CC: gmcharlt(a)gmail.com When viewing the staff client in French, the syspref auto-populated for the XSLT configuration is broken: if you click one of the links in OPACXSLTResultsDisplay, the value of OPACXSLTDetailsDisplay is changed. This is not an issue in nb-NO or de-DE. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 2

[Bug 14318] New: iDreamBooks doesn't work when Koha is using https
by bugzilla-daemon＠bugs.koha-community.org 08 Jun '15

08 Jun '15

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14318 Bug ID: 14318 Summary: iDreamBooks doesn't work when Koha is using https Change sponsored?: --- Product: Koha Version: 3.18 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard(a)myacpl.org Reporter: kyle(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org If a Koha server is configured to run over SSL, all iDreamBooks content is blocked due to the fact that a secure page is requesting an insecure endpoint. This is due to the fact that the urls for iDreamBooks use http and not https. A simple fix would be to switch them to https since browsers have to qualms about loading a secure data endpoint from an insecure one. -- You are receiving this mail because: You are watching all bug changes.

1 13

[Bug 14342] New: Unit tests in t/db_dependent/Context.t failing due to Bug 13967
by bugzilla-daemon＠bugs.koha-community.org 08 Jun '15

08 Jun '15

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14342 Bug ID: 14342 Summary: Unit tests in t/db_dependent/Context.t failing due to Bug 13967 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt(a)gmail.com Reporter: kyle(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org The introduction of system preference objects in bug 13967 has caused the current testing regimen to fail do to the mixing of DBI mocking and DBIx::Class. -- You are receiving this mail because: You are watching all bug changes.

1 10

[Bug 14346] New: t/Biblio.t fails because of new warning
by bugzilla-daemon＠bugs.koha-community.org 07 Jun '15

07 Jun '15

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14346 Bug ID: 14346 Summary: t/Biblio.t fails because of new warning Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Test Suite Assignee: chris(a)bigballofwax.co.nz Reporter: tomascohen(a)gmail.com QA Contact: gmcharlt(a)gmail.com Running $ prove t/Biblio.t fails because of us now using DBIx to retrieve sysprefs. Then our mocked DBI is not "supported" by DBIx hence a warning that makes our test fail (there is one more warning now). The cool thing about this, is that it actually helped spot a situation where GetMarcBiblio is doing wrong things because is not checking its parameters are undefined, so we have the chance to fix it. -- You are receiving this mail because: You are watching all bug changes.

1 11

[Bug 1368] Use of FOREIGN_KEY_CHECKS = 0
by bugzilla-daemon＠bugs.koha-community.org 07 Jun '15

07 Jun '15

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1368 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart(a)biblibre.co | |m, | |kyle(a)bywatersolutions.com, | |tomascohen(a)gmail.com --- Comment #5 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- This is currently the oldest open bug report, filed in May 2010. A quick git grep for "SET FOREIGN_KEY_CHECKS" reveals a lot of occurrences (see below) - Do we intend on fixing those? Or should this be a WONTFIX? - What is the goal here? Should we move some of the ideas from here to new more specific bug reports? installer/data/mysql/de-DE/optional/sample_creator_data.sql:/*!40014 SET FOREIGN_KEY_CHECKS=@OLD_FOREIGN_KEY_CHECKS */; installer/data/mysql/en/optional/sample_creator_data.sql:/*!40014 SET FOREIGN_KEY_CHECKS=@OLD_FOREIGN_KEY_CHECKS */; installer/data/mysql/es-ES/optional/sample_creator_data.sql:/*!40014 SET FOREIGN_KEY_CHECKS=@OLD_FOREIGN_KEY_CHECKS */; installer/data/mysql/it-IT/marcflavour/unimarc/necessari/authority_framework.sql:SET FOREIGN_KEY_CHECKS=0; installer/data/mysql/it-IT/marcflavour/unimarc/necessari/authority_framework.sql:SET FOREIGN_KEY_CHECKS=1; installer/data/mysql/it-IT/marcflavour/unimarc/necessari/unimarc_framework.sql:SET FOREIGN_KEY_CHECKS=0; installer/data/mysql/it-IT/marcflavour/unimarc/necessari/unimarc_framework.sql:SET FOREIGN_KEY_CHECKS=1; installer/data/mysql/it-IT/necessari/auth_val.sql:SET FOREIGN_KEY_CHECKS=0; installer/data/mysql/it-IT/necessari/auth_val.sql:SET FOREIGN_KEY_CHECKS=1; installer/data/mysql/it-IT/necessari/class_sources.sql:SET FOREIGN_KEY_CHECKS=0; installer/data/mysql/it-IT/necessari/class_sources.sql:SET FOREIGN_KEY_CHECKS=1; installer/data/mysql/it-IT/necessari/message_transport_types.sql:SET FOREIGN_KEY_CHECKS=0; installer/data/mysql/it-IT/necessari/message_transport_types.sql:SET FOREIGN_KEY_CHECKS=1; installer/data/mysql/it-IT/necessari/sample_creator_data.sql:/*!40014 SET FOREIGN_KEY_CHECKS=@OLD_FOREIGN_KEY_CHECKS */; installer/data/mysql/it-IT/necessari/sample_holidays.sql:SET FOREIGN_KEY_CHECKS=0; installer/data/mysql/it-IT/necessari/sample_holidays.sql:SET FOREIGN_KEY_CHECKS=1; installer/data/mysql/it-IT/necessari/sample_itemtypes.sql:SET FOREIGN_KEY_CHECKS=0; installer/data/mysql/it-IT/necessari/sample_itemtypes.sql:SET FOREIGN_KEY_CHECKS=1; installer/data/mysql/it-IT/necessari/sample_notices_message_attributes.sql:SET FOREIGN_KEY_CHECKS=0; installer/data/mysql/it-IT/necessari/sample_notices_message_attributes.sql:SET FOREIGN_KEY_CHECKS=1; installer/data/mysql/it-IT/necessari/sample_notices_message_transports.sql:SET FOREIGN_KEY_CHECKS=0; installer/data/mysql/it-IT/necessari/sample_notices_message_transports.sql:SET FOREIGN_KEY_CHECKS=1; installer/data/mysql/it-IT/necessari/stopwords.sql:SET FOREIGN_KEY_CHECKS=0; installer/data/mysql/it-IT/necessari/stopwords.sql:SET FOREIGN_KEY_CHECKS=1; installer/data/mysql/it-IT/necessari/userflags.sql:SET FOREIGN_KEY_CHECKS=0; installer/data/mysql/it-IT/necessari/userflags.sql:SET FOREIGN_KEY_CHECKS=1; installer/data/mysql/kohastructure.sql:/*!40014 SET FOREIGN_KEY_CHECKS=@OLD_FOREIGN_KEY_CHECKS */; installer/data/mysql/labels_upgrade.pl: SET FOREIGN_KEY_CHECKS = 0; installer/data/mysql/nb-NO/2-Valgfritt/sample_creator_data.sql:/*!40014 SET FOREIGN_KEY_CHECKS=@OLD_FOREIGN_KEY_CHECKS */; installer/data/mysql/patroncards_upgrade.pl: SET FOREIGN_KEY_CHECKS = 0; installer/data/mysql/updatedatabase.pl: $dbh->do('SET FOREIGN_KEY_CHECKS=0 '); installer/data/mysql/updatedatabase.pl: $dbh->do('SET FOREIGN_KEY_CHECKS=1 '); installer/data/mysql/updatedatabase.pl: $dbh->do('SET FOREIGN_KEY_CHECKS=0 '); installer/data/mysql/updatedatabase.pl: $dbh->do('SET FOREIGN_KEY_CHECKS=1 '); installer/data/mysql/updatedatabase.pl: $dbh->do("SET FOREIGN_KEY_CHECKS=0 "); installer/data/mysql/updatedatabase.pl: $dbh->do("SET FOREIGN_KEY_CHECKS=1 "); misc/maintenance/fix_mysql_constraints.pl: $dbh->do("SET FOREIGN_KEY_CHECKS=0"); misc/migration_tools/22_to_30/phrase_log.sql:/*!40014 SET FOREIGN_KEY_CHECKS=@OLD_FOREIGN_KEY_CHECKS */; misc/migration_tools/bulkmarcimport.pl: $dbh->do("SET FOREIGN_KEY_CHECKS = 0"); misc/migration_tools/bulkmarcimport.pl: $dbh->do("SET FOREIGN_KEY_CHECKS = 1"); -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug. You are watching all bug changes.

1 0

[Bug 11922] New: Add SHOW_BCODE patron attribute for Norwegian web installer
by bugzilla-daemon＠bugs.koha-community.org 07 Jun '15

07 Jun '15

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11922 Bug ID: 11922 Summary: Add SHOW_BCODE patron attribute for Norwegian web installer Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Installation and upgrade (web-based installer) Assignee: magnus(a)enger.priv.no Reporter: magnus(a)enger.priv.no QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com The Norwegian web installer needs nb-NO/optional/patron_atributes.sql and .txt to stay in sync with other languages. -- You are receiving this mail because: You are watching all bug changes.

1 1

[Bug 11720] New: Use new DataTables include in tools templates
by bugzilla-daemon＠bugs.koha-community.org 07 Jun '15

07 Jun '15

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11720 Bug ID: 11720 Summary: Use new DataTables include in tools templates Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org Various templates in /tools/ which use the DataTables plugin should be updated to use the new DataTables include file introduced by Bug 10649. -- You are receiving this mail because: You are watching all bug changes.

1 9

[Bug 11318] New: Overdues won't send if first trigger lacks a delay value
by bugzilla-daemon＠bugs.koha-community.org 07 Jun '15

07 Jun '15

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11318 Bug ID: 11318 Summary: Overdues won't send if first trigger lacks a delay value Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Notices Assignee: koha-bugs(a)lists.koha-community.org Reporter: dcook(a)prosentient.com.au QA Contact: testopia(a)bugs.koha-community.org Overdue notices will not send if the first overdue trigger lacks a delay value (i.e. if the delay1 field in the overduerules table table is null). It doesn't matter if your second and third triggers are set with notices and values. If you have a notice and no value for the first, that's it - nothing. This behaviour has a certain logic to it, I suppose, but as Katrin has pointed out, it could perhaps fail nicer and print a message saying there are other triggers set but they can't be reached since the first one is null. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 1