July 2015 - Koha-bugs - lists.koha-community.org

[Bug 14526] New: MoveReserve should look at future holds too
by bugzilla-daemon＠bugs.koha-community.org 07 Sep '15

07 Sep '15

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14526 Bug ID: 14526 Summary: MoveReserve should look at future holds too Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Hold requests Assignee: koha-bugs(a)lists.koha-community.org Reporter: m.de.rooy(a)rijksmuseum.nl QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com MoveReserve is called when checking out a book (AddIssue). When filling a hold, it moves a reserve to old_reserves (with ModReserveFill). But if the hold is a future one (say tomorrow), and it is confirmed today and waiting for pickup, and the patron comes a day sooner, it should be moved too when checking out. Small patch forthcoming. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 35

[Bug 9593] New: Prices not imported correctly from a staged file
by bugzilla-daemon＠bugs.koha-community.org 07 Sep '15

07 Sep '15

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9593 Bug ID: 9593 Summary: Prices not imported correctly from a staged file Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Acquisitions Assignee: koha-bugs(a)lists.koha-community.org Reporter: koha(a)univ-lyon3.fr Created attachment 15269 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15269&action=edit Prices not imported correctly from a staged file When importing a record from a staged file, sometimes, the price is set to 0 in the Vendor price field (Accounting details block) even if initially present. it occurs when the price is written without decimals : example : 19 EUR. In this case it's not captured by the regular expression in MungeMarcPrice routine (Biblio.pm) : ( $price ) = $price =~ m/([\d\,\.]+[[\,\.]\d\d]?)/; Same thing if the currency symbol was used after the digits, the result would be the same because of this : $price = $parts[1]; If I got it well, seems that the whole routine can be replaced by 2 regular expressions (may be we could even go up to a single one) integrated in GetMarcprice : the first part (symbol treatment) is unusefull as it can be treated directly by the regular expression that's following it. The part concerning groups of more than 2 digits ( if I got it, it 's come out to delete the eventual separator between thousands and hundreds) can be replaced by another regular expression. Test Plan : 1) get on your pc, the joined example file (testfile.elc). That's the kind of file most currently used in France for our acquisitions. Most of the prices in it match the pattern '[digit][digit] EUR' except 2 titles out of them : La méthodologie appliquée du commentaire de texte (14,20 EUR) Le tournant artiste de la littérature française (54,80 EUR) 2) Go to Tools/Stage MARC records for import and stage it in koha. 3) Go to Acquisition module, and an open basket of your choice and click on 'From a staged file' 4) Choose testfile.elc and add it to the basket 5) Click on the first individual 'add order' link : the price might beeing set to 00.00 in the 'Vendor price' field of Accounting details block. 6) Now go back with go back function of your browser : 7) Apply the patch 8) Click again on the same link 9) The price is now present (I hope so) 10 Sign off (I hope so again) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 105

[Bug 7957] New: Routing lists: manage several routing list for each subscription, and export them as CSV
by bugzilla-daemon＠bugs.koha-community.org 07 Sep '15

07 Sep '15

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7957 Priority: P5 - low Change sponsored?: Sponsored Bug ID: 7957 Assignee: julian.maurice(a)biblibre.com Summary: Routing lists: manage several routing list for each subscription, and export them as CSV QA Contact: koha.sekjal(a)gmail.com Severity: enhancement Classification: Unclassified OS: All Reporter: julian.maurice(a)biblibre.com Hardware: All Status: ASSIGNED Version: master Component: Serials Product: Koha This development will allow to create more than one routing list for each subscription. There will be a new page for managing them (create, edit, delete), printing them, and exporting them as CSV. -- You are receiving this mail because: You are watching all bug changes.

1 64

[Bug 14539] New: castToObject(), aka. make a Koha::Object from various input types
by bugzilla-daemon＠bugs.koha-community.org 07 Sep '15

07 Sep '15

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14539 Bug ID: 14539 Summary: castToObject(), aka. make a Koha::Object from various input types Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt(a)gmail.com Reporter: olli-antti.kivilahti(a)jns.fi QA Contact: testopia(a)bugs.koha-community.org Currently Koha is like an archeological dig site, we have different layers of dealing with various business objects. We started with DBI and numerous ways of passing an HASH around. There is no telling if it will be a List of column => values, or a reference to HASH, or a HASH or just any of the business object's (eg. Borrower's) unique identifiers (userid, cardnumber, borrowernumber). Then DBIx came to the rescue and now we are need to learn DBI and DBIx and SQL to do DB operatons in Koha. Migration to DBIx is on the way. Finally we have Koha::Object and subclasses, which include and use the DBIx, but those are not directly compatible, since Koha::Object is not a subclass of DBIx::Class making life occasionally miserable. Now we need to know 3 methods of DB accession. I am really frustrated with all of those different layers of history, and making things work nicely across all different programming patterns, I have had great success in using a casting system, where we take any value and try to make a Koha::Object-subclass out of it. So we try to cast a Scalar or a reference of Koha::Object-implementation or DBIx::ResultSet or HASH, to the desired Koha::Object-implementation. This is a nice validation/entry function in any subroutine dealing with business objects, making sure that we always have the "correct" implementation of the same business object. An example: #Does this look familiar? my $borrower = 1042; #A borrowernumber? my $user = '121A0321312'; #A cardnumber? or userid? my $borrower = {borrowernumber => 1043, cardnumber => '121A0321312', ...}; #HASH my $borrower = Koha::Borrowers->find({borrowernumber => 1024}); my $borrower = $schema->resultset('Borrower')->find({borrowernumber => 1024}); #So when I call my subroutine with the $borrower I got using some function, makeBorrowerHappy($borrower); #Bad things most often happen. #But if my makeBorrowerHappy()-function would cast its parameters to the #correct type, there would be only merriment and fun! sub makeBorrowerHappy { my ($borrower) = @_; $borrower = Koha::Borrowers::castToBorrower($borrower); ... #Do fun stuff! } #Whatever we throw at the subroutine, things just work (in theory)! Even better, if the $borrower already is a DBIx-derivative or Koha::Borrower, we don't even do anything, other than simple if statements. So minimally expensive, maximally productive. -- You are receiving this mail because: You are watching all bug changes.

1 16

[Bug 14012] New: Koha::FTP, a happy FTP-library to supercharge FTP operations.
by bugzilla-daemon＠bugs.koha-community.org 07 Sep '15

07 Sep '15

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14012 Bug ID: 14012 Summary: Koha::FTP, a happy FTP-library to supercharge FTP operations. Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt(a)gmail.com Reporter: olli-antti.kivilahti(a)jns.fi QA Contact: testopia(a)bugs.koha-community.org When dealing with FTP-connections, we need to prepare for all kinds of remote connection failures. This library simply wraps exception handling and connection creation into a one nice package. -- You are receiving this mail because: You are watching all bug changes.

1 4

[Bug 14369] New: don't allow labels on staged records
by bugzilla-daemon＠bugs.koha-community.org 06 Sep '15

06 Sep '15

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14369 Bug ID: 14369 Summary: don't allow labels on staged records Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Label/patron card printing Assignee: cnighswonger(a)foundations.edu Reporter: nengard(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org Created attachment 40040 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40040&action=edit error If you click the create label batch from manage-marc-import.pl on a file that's staged and not imported you get an error asking you to talk to the sys admin. The problem is simple - it's a staged file - not imported. I think that the option to create a label batch shouldn't show in this case. -- You are receiving this mail because: You are watching all bug changes.

1 6

[Bug 12020] New: label-edit-batch has hardcoded error messages
by bugzilla-daemon＠bugs.koha-community.org 06 Sep '15

06 Sep '15

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12020 Bug ID: 12020 Summary: label-edit-batch has hardcoded error messages Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs(a)lists.koha-community.org Reporter: pasi.kallinen(a)pttk.fi QA Contact: testopia(a)bugs.koha-community.org CC: frederic(a)tamil.fr $ grep errstr labels/label-edit-batch.pl koha-tmpl/intranet-tmpl/prog/en/modules/labels/* labels/label-edit-batch.pl:my $errstr = undef; labels/label-edit-batch.pl: $errstr = "item(s) not removed from batch $batch_id." if $err; labels/label-edit-batch.pl: $errstr = "batch $batch_id was not deleted." if $err; labels/label-edit-batch.pl: $errstr = "item(s) not added to batch $batch_id." if $err; labels/label-edit-batch.pl: $errstr = "items(s) not added, the error was: Branch is not set, you please set your branch before adding items to a batch"; labels/label-edit-batch.pl: $errstr = "batch $batch_id not fully de-duplicated." if $duplicate_count == -1; labels/label-edit-batch.pl: errstr => $errstr, koha-tmpl/intranet-tmpl/prog/en/modules/labels/label-edit-batch.tt: <strong>WARNING:</strong> An error was encountered and [% errstr %] Please have your system administrator check the error log for details. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 1

[Bug 8754] New: Cardnumber/accession number range when creating print batches in tools
by bugzilla-daemon＠bugs.koha-community.org 06 Sep '15

06 Sep '15

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8754 Priority: P5 - low Change sponsored?: --- Bug ID: 8754 Assignee: gmcharlt(a)gmail.com Summary: Cardnumber/accession number range when creating print batches in tools Severity: enhancement Classification: Unclassified OS: All Reporter: amit.gupta(a)osslabs.biz Hardware: All Status: NEW Version: rel_3_10 Component: Tools Product: Koha Give ability to generate print batches on the basis of barcode range. for example barcode range: 100001-100099 -- You are receiving this mail because: You are watching all bug changes.

1 4

[Bug 14379] New: Batch item modification tool - Can't change custom subfields
by bugzilla-daemon＠bugs.koha-community.org 05 Sep '15

05 Sep '15

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14379 Bug ID: 14379 Summary: Batch item modification tool - Can't change custom subfields Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Tools Assignee: gmcharlt(a)gmail.com Reporter: pablo.bianchi(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org On a framework a librarian create custom item subfields, like withdrawn date or date when item was sent to bookbinding sector ("$D", uppercase). Batch item modification tool (batchMod.pl) doesn't let you change this new item subfields (saved on more_subfields_xml). -- You are receiving this mail because: You are watching all bug changes.

1 3

[Bug 10895] New: Tests for C4::Items GetHiddenItems
by bugzilla-daemon＠bugs.koha-community.org 04 Sep '15

04 Sep '15

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10895 Bug ID: 10895 Summary: Tests for C4::Items GetHiddenItems Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Test Suite Assignee: gmcharlt(a)gmail.com Reporter: mtompset(a)hotmail.com QA Contact: testopia(a)bugs.koha-community.org There were no tests for GetHiddenItems, and given that I have been working on tweaking this function (bug 10589, bug 10872), I thought some test modules might be in order. t/db_dependent/GetHiddenItems.t - Generic toggling of OpacHiddenItems system preference to test if NULL, blank, whitespace, and a rule all work. t/db_dependent/GetHiddenItems_PatronCategory.t - Setting of OpacHiddenItems, and then toggling a dummy patron's category code to see if visibility is correct. -- You are receiving this mail because: You are watching all bug changes.

1 48