September 2015 - Koha-bugs - lists.koha-community.org

[Bug 14486] New: C4/Accountlines.pm needs better documentation and removal of stale code
by bugzilla-daemon＠bugs.koha-community.org 21 Oct '15

21 Oct '15

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14486 Bug ID: 14486 Summary: C4/Accountlines.pm needs better documentation and removal of stale code Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs(a)lists.koha-community.org Reporter: barton(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com The documentation in C4/Accountlines.pm is confusing. There is no clear statement of what the module is for, and some poor programmer has sprinkled the code with 'FIXME' comments to the effect of "I don't understand what this function does." The intent and proper use of these functions should be documented, and the FIXME comments should be removed. fixaccounts() is entirely commented out. This should be removed. The following functions are not documented: chargelostitem() getcharges() ModNote() getcredits() getrefunds() ReversePayment() makepartialpayment() These should have at least minimal documentation saying "It does what you think it does", and any functions which modify the accountlines need a complete explanation of what they're changing in the database and why. The weakness of the accountlines table is that there is no link between fines and issues/old_issues which is a perennial source of bugs. This needs to be explicitly documented as a gotcha. Obviously work on documentation will be obsoleted by Bug 6427 - Rewrite of the accounts system, but in some sense, because the re-write is supposed to work with legacy code, I feel that the lack of clear documentation in the old code is an impediment to the testing of the new. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 1

[Bug 14900] New: Add ability to pay all fees at once from circulation screen
by bugzilla-daemon＠bugs.koha-community.org 21 Oct '15

21 Oct '15

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14900 Bug ID: 14900 Summary: Add ability to pay all fees at once from circulation screen Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs(a)lists.koha-community.org Reporter: josef.moravec(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com It could be fine to have link for collectiong whole amount of all charges at once in information about fees and charges on circulation screen. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 9

[Bug 13589] New: add --mark-returned as a longoverdue sys pref
by bugzilla-daemon＠bugs.koha-community.org 21 Oct '15

21 Oct '15

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13589 Bug ID: 13589 Summary: add --mark-returned as a longoverdue sys pref Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs(a)lists.koha-community.org Reporter: nengard(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com Depends on: 8337 It makes sense to add --mark-returned as a system preference like the other longoverdue settings. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 7

[Bug 13402] New: Can't tab to barcode field when adding item to serial
by bugzilla-daemon＠bugs.koha-community.org 21 Oct '15

21 Oct '15

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13402 Bug ID: 13402 Summary: Can't tab to barcode field when adding item to serial Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Serials Assignee: koha-bugs(a)lists.koha-community.org Reporter: p.thrasher(a)dover.nh.gov QA Contact: testopia(a)bugs.koha-community.org CC: colin.campbell(a)ptfs-europe.com When receiving a serial we have an item record added. When I fill in the fields of the item record, I tab down the fields. Tabbing doesn't go into the barcode field, so I can't get to that field that way. I have to use the mouse to click in the barcode field to fill it in. We would like to tab to the barcode field. Thanks. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 3

[Bug 10890] New: Autobarcode "<branch>yymm00001" Fails in Acquisitions When Receiving Item
by bugzilla-daemon＠bugs.koha-community.org 21 Oct '15

21 Oct '15

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10890 Bug ID: 10890 Summary: Autobarcode "<branch>yymm00001" Fails in Acquisitions When Receiving Item Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Acquisitions Assignee: koha-bugs(a)lists.koha-community.org Reporter: dcook(a)prosentient.com.au QA Contact: testopia(a)bugs.koha-community.org Currently, if autobarcode is set to "<branch>yymm00001", the barcode won't be created. Depending on your browser, you should receive a Javascript alert saying something like "Uncaught TypeError: Cannot read property 'field_value' of undefined". This looks like it's due to the form containing elements with a 'field_value' property missing the name "f". The easiest fix is to add a name of "f" to the form. That eliminates the problem and allows the barcode to be created. However, as Jared and Robin have pointed out, "f" is a really poor choice of names for a form. We should probably be using descriptive names for our forms. We should probably also be populating the barcode field in a way that doesn't rely on looping through the inputs of a form. Maybe we could just look for the branch code by doing $('#outeritemblock #subfielda') or something like that. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 10

[Bug 13699] New: DBD::mysql mysql_auto_reconnect attribute ceases to function after DBIx call[s]
by bugzilla-daemon＠bugs.koha-community.org 21 Oct '15

21 Oct '15

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13699 Bug ID: 13699 Summary: DBD::mysql mysql_auto_reconnect attribute ceases to function after DBIx call[s] Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt(a)gmail.com Reporter: abl(a)biblos.pk.edu.pl QA Contact: testopia(a)bugs.koha-community.org While testing Bug 13645 patch #2, I noticed that DBIx calls apparently do interfere with DBD::mysql mysql_auto_reconnect attribute. We have mysql auto reconnect enabled since Bug 10611, and it works fine as long as there are no DBIx calls being made - but if there is such a call in the given code, this attribute gets reseted to 0 as a side affect, disabling auto reconnect feature for all further DBI or DBIx calls being made from the same process and/or thread. E.g.: use Modern::Perl; use C4::Context; use Koha::Acquisition::Bookseller; my $dbh = C4::Context->dbh; print "Auto reconnect: ".$dbh->{mysql_auto_reconnect}."\n"; my @booksellers = Koha::Acquisition::Bookseller->search(); print "Auto reconnect: ".$dbh->{mysql_auto_reconnect}."\n"; ## $dbh->{mysql_auto_reconnect}=1; sleep(15); ## mysqld to be reloaded in the meanwhile @booksellers = Koha::Acquisition::Bookseller->search(); Auto reconnect: 1 Auto reconnect: 0 DBD::mysql::st execute failed: MySQL server has gone away at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1593. At first I assumed that it may be caused by 'Bug 13645: Use DBIx::Connector', but nope, it turns out that this issue is also present in unpatched master. Probably not such a big problem for the plain CGI setups in most typical circumstances, but lack of working auto reconnect may be quite a nuisance under plack/mod_perl. -- You are receiving this mail because: You are watching all bug changes.

1 4

[Bug 10598] New: self check shouldn't link out to catalog
by bugzilla-daemon＠bugs.koha-community.org 20 Oct '15

20 Oct '15

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10598 Bug ID: 10598 Summary: self check shouldn't link out to catalog Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: nengard(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org When you use self check the titles you check out are linked to the opac, the problem here is that most libraries set their self check machines to not allow visiting pages outside of the self check. If you click a title and get in to the opac then you might not be able to get back to the self check if those safeguards are in place. -- You are receiving this mail because: You are watching all bug changes.

1 5

[Bug 8417] New: date acquired is shipping date
by bugzilla-daemon＠bugs.koha-community.org 20 Oct '15

20 Oct '15

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8417 Priority: P5 - low Change sponsored?: --- Bug ID: 8417 Assignee: koha-bugs(a)lists.koha-community.org Summary: date acquired is shipping date Severity: normal Classification: Unclassified OS: All Reporter: nengard(a)gmail.com Hardware: All Status: NEW Version: master Component: Acquisitions Product: Koha When receiving orders, Koha is using the shipping date as the date acquired but it should probably be using the date you're actually adding the items (which might be after the shipping date). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 22

[Bug 8970] New: MARC import gives error under Starman/Plack
by bugzilla-daemon＠bugs.koha-community.org 20 Oct '15

20 Oct '15

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8970 Priority: P5 - low Change sponsored?: --- Bug ID: 8970 Assignee: gmcharlt(a)gmail.com Summary: MARC import gives error under Starman/Plack Severity: major Classification: Unclassified OS: All Reporter: jcamins(a)cpbibliography.com Hardware: All Status: NEW Version: master Component: MARC Bibliographic record staging/import Product: Koha When trying to import records under Starman/Plack (this probably does not happen with Plack alone), one gets an error "Failed to submit form: parsererror" with the following in the error log: Subroutine redo_matching redefined at /home/jcamins/kohaclone/tools/manage-marc-import.pl line 142. Subroutine create_labelbatch_from_importbatch redefined at /home/jcamins/kohaclone/tools/manage-marc-import.pl line 186. Subroutine import_batches_list redefined at /home/jcamins/kohaclone/tools/manage-marc-import.pl line 206.Subroutine commit_batch redefined at /home/jcamins/kohaclone/tools/manage-marc-import.pl line 234.Subroutine revert_batch redefined at /home/jcamins/kohaclone/tools/manage-marc-import.pl line 263.Subroutine put_in_background redefined at /home/jcamins/kohaclone/tools/manage-marc-import.pl line 292. Subroutine progress_callback redefined at /home/jcamins/kohaclone/tools/manage-marc-import.pl line 327. Subroutine add_results_to_template redefined at /home/jcamins/kohaclone/tools/manage-marc-import.pl line 337. Subroutine add_saved_job_results_to_template redefined at /home/jcamins/kohaclone/tools/manage-marc-import.pl line 343. Subroutine import_records_list redefined at /home/jcamins/kohaclone/tools/manage-marc-import.pl line 351. Subroutine batch_info redefined at /home/jcamins/kohaclone/tools/manage-marc-import.pl line 413. Subroutine add_matcher_list redefined at /home/jcamins/kohaclone/tools/manage-marc-import.pl line 445. Subroutine add_page_numbers redefined at /home/jcamins/kohaclone/tools/manage-marc-import.pl line 458. -- You are receiving this mail because: You are watching all bug changes.

1 33

[Bug 6146] New: In Auth.pm the var OPACBaseURL ignores the syspref OPACBaseURL
by bugzilla-daemon＠bugs.koha-community.org 20 Oct '15

20 Oct '15

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6146 Bug #: 6146 Summary: In Auth.pm the var OPACBaseURL ignores the syspref OPACBaseURL Classification: Unclassified Change sponsored?: --- Product: Koha Version: rel_3_4 Platform: All OS/Version: All Status: ASSIGNED Severity: normal Priority: PATCH-Sent Component: Authentication AssignedTo: juan.sieira(a)xercode.es ReportedBy: juan.sieira(a)xercode.es QAContact: koha-bugs(a)lists.koha-community.org CC: dpavlin(a)rot13.org Created attachment 3839 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3839 proposed patch In Auth.pm the var OPACBaseURL ignores the syspref OPACBaseURL. If this syspref is set, its value must be included in this param. A patch was submitted -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

1 7