January 2016 - Koha-bugs - lists.koha-community.org

[Bug 12051] add renew tab to top on staff client
by bugzilla-daemon＠bugs.koha-community.org 29 Jan '16

29 Jan '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12051 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle(a)bywatersolutions.com --- Comment #14 from Kyle M Hall <kyle(a)bywatersolutions.com> --- > I was going to pass QA on this patch, but I am wondering if the permission > should not be CAN_user_circulate_circulate_remaining_permissions instead of > CAN_user_circulate. Indeed the circ/renew.pl script needs only this subperm. I think the issue at hand is that this is really just repeating an existing bug. For instance, in cat-search.inc, the checkin box is wrapped with [% IF ( CAN_user_circulate ) %] yet a librarian with only CAN_user_circulate_circulate_remaining_permissions should be able to see the box, as checkins only require circulate_remaining_permissions. I would suggest we leave it the way it is for now for the sake of consistency and file a new bug to fix the issue globally. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7677] New area in subscriptions and new function when receiving
by bugzilla-daemon＠bugs.koha-community.org 29 Jan '16

29 Jan '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7677 --- Comment #78 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 47475 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47475&action=ed… Bug 7677 [QA Followup] - Replace GetItemnumberFromSerialId with use of Koha::Serial::Item(s) GetItemnumberFromSerialId has no unit tests. It would be better to start using our object system here. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13345] Choose the format when sending a basket/list by email
by bugzilla-daemon＠bugs.koha-community.org 29 Jan '16

29 Jan '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13345 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply CC| |kyle(a)bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15662] String and translatability fix to Label Creator
by bugzilla-daemon＠bugs.koha-community.org 29 Jan '16

29 Jan '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15662 --- Comment #8 from Chris Nighswonger <cnighswonger(a)foundations.edu> --- (In reply to Kyle M Hall from comment #7) > (In reply to Jonathan Druart from comment #6) > > I have let a note on bug 15573 comment 9 > > This syntax style is based on coding guideline JS4. I think we should retain > it for consistencies sake, or update the guidelines to reflect this new > stance. Now that we have the format method for strings, this style of > wording is no longer necessary. Reading over JS4, it seems that even that may not cover all cases. It is conceivable that some languages may have syntax which wants the strings at the beginning rather than the end. That said, I have no problem with it going where ever; just a preference for the original. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13618] Prevent XSS in the Staff Client and the OPAC
by bugzilla-daemon＠bugs.koha-community.org 29 Jan '16

29 Jan '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Brendan Gallagher <brendan(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #202 from Brendan Gallagher <brendan(a)bywatersolutions.com> --- Pushed to Master - Should be in the May 2016 Release. Thanks! (we'll probably have some more spots to work on this). Great job though! -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14893] Separate temporary storage per instance in Upload.pm
by bugzilla-daemon＠bugs.koha-community.org 29 Jan '16

29 Jan '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14893 Brendan Gallagher <brendan(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |brendan(a)bywatersolutions.co | |m --- Comment #11 from Brendan Gallagher <brendan(a)bywatersolutions.com> --- Pushed to Master - Should be in the May 2016 Release. Thanks! -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15662] String and translatability fix to Label Creator
by bugzilla-daemon＠bugs.koha-community.org 29 Jan '16

29 Jan '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15662 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle(a)bywatersolutions.com --- Comment #7 from Kyle M Hall <kyle(a)bywatersolutions.com> --- (In reply to Jonathan Druart from comment #6) > I have let a note on bug 15573 comment 9 This syntax style is based on coding guideline JS4. I think we should retain it for consistencies sake, or update the guidelines to reflect this new stance. Now that we have the format method for strings, this style of wording is no longer necessary. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15631] Move the cities related code to Koha::Cities - part 2
by bugzilla-daemon＠bugs.koha-community.org 29 Jan '16

29 Jan '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15631 --- Comment #5 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 47474 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47474&action=ed… Bug 15631: Koha::Cities - remove getidcity and GetCities C4::Members::getidcity and C4::Members::GetCities simply retrieved cities info from the cities table. The job done in members/memberentry.pl looked really weird and complicated. Either I have missed something, or this patch can simplify it. The expected behavior is: 1. Create a new patron => No city selected 2. Edit an existing patron => The borrowers.city value is selected 3. Add a guarantee => The borrowers.city of the guarantor is selected 4. Edit a guarantee => The borrowers.city of the guarantee is selected Test plan: Confirm that the expected behaviors are the ones before and after this patch. Signed-off-by: Natasha <tasham_8(a)hotmail.com> Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15631] Move the cities related code to Koha::Cities - part 2
by bugzilla-daemon＠bugs.koha-community.org 29 Jan '16

29 Jan '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15631 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47010|0 |1 is obsolete| | Attachment #47062|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 47473 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47473&action=ed… Bug 15631: Koha::Cities - remove getzipnamecity C4::Members::getzipnamecity was not used and can be remove safely. Test plan: git grep getzipnamecity should not return any result. Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15631] Move the cities related code to Koha::Cities - part 2
by bugzilla-daemon＠bugs.koha-community.org 29 Jan '16

29 Jan '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15631 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

1 0