January 2016 - Koha-bugs - lists.koha-community.org

[Bug 15675] Add issue_id column to accountlines and use it for updating fines
by bugzilla-daemon＠bugs.koha-community.org 29 Jan '16

29 Jan '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15675 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #19 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Per conversation with Katrin, we should make sure to clean up any multiple FU fines that haven't been closed out in a db update for this. Setting to failed qa until I get that done. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14757] Allow the use of Template Toolkit syntax for slips and notices
by bugzilla-daemon＠bugs.koha-community.org 29 Jan '16

29 Jan '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757 --- Comment #10 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Comment on attachment 47176 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47176 Bug 14757 - Allow the use of Template Toolkit syntax for slips and notices Review of attachment 47176: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=147…) ----------------------------------------------------------------- ::: C4/Letters.pm @@ +1414,5 @@ > + issues => { > + module => 'Koha::Checkouts', > + singular => 'checkout', > + plural => 'checkouts', > + fk => 'itemnumber', We should use `pk => issue_id` and update existing calls. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14930] Leaving OpacFineNoRenewals blank blocks renewals, but should disable feature
by bugzilla-daemon＠bugs.koha-community.org 29 Jan '16

29 Jan '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14930 --- Comment #9 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 47466 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47466&action=ed… Bug 14930 [QA Followup] - Allow OpacFineNoRenewals to be 0 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0

[Bug 14930] Leaving OpacFineNoRenewals blank blocks renewals, but should disable feature
by bugzilla-daemon＠bugs.koha-community.org 29 Jan '16

29 Jan '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14930 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0

[Bug 14390] Fine not updated from 'FU' to 'F' on renewal
by bugzilla-daemon＠bugs.koha-community.org 29 Jan '16

29 Jan '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14390 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47465|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14390] Fine not updated from 'FU' to 'F' on renewal
by bugzilla-daemon＠bugs.koha-community.org 29 Jan '16

29 Jan '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14390 --- Comment #25 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 47465 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47465&action=ed… Bug 14390 [QA Followup] - Allow OpacFineNoRenewals to be 0 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15675] Add issue_id column to accountlines and use it for updating fines
by bugzilla-daemon＠bugs.koha-community.org 29 Jan '16

29 Jan '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15675 --- Comment #18 from Kyle M Hall <kyle(a)bywatersolutions.com> --- (In reply to Katrin Fischer from comment #16) > I was wondering as this is no 1:1 but a 1:n if the calcuation will be > correct. If it will still add another separate line in accountlines if an > item goes overdue - renew - overdue - renew... etc. If the due date is > removed from the description or no longer used, this information will get > lost etc. You are right, it is a one to many join from issues to accountlines. One item may go overdue multiple times. However, there should only ever be one *accruing* fine for a given issue at a time, so it shouldn't be a problem. The current query already deals with that in that the FU fine will be the first selected and matched by issue_id. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15675] Add issue_id column to accountlines and use it for updating fines
by bugzilla-daemon＠bugs.koha-community.org 29 Jan '16

29 Jan '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15675 --- Comment #17 from Kyle M Hall <kyle(a)bywatersolutions.com> --- (In reply to Jonathan Druart from comment #14) > Could you please detail what do we need this new column? > 1/ There is no fk on it Right, as Katrin wrote, since the issue_id can be in issues or old_issues, we can't give it a key constraint. > 2/ can be null but C4::Overdues::UpdateFine requires it I suppose we *could* make it not null, but then how do we deal with adding an issue_id to all the already existing account lines? We can definitely update the ones that are currently accruing. Those are the only ones where it really matters. > 3/ The prototype of UpdateFine is weird, you have to pass issue_id, > itemnumber and borrowernumber. issue_id should be enough. Agreed, I should change that. I was just trying to make the smallest change possible. It would make sense for it to just take issue_id ( or an issue object if possible ). If you'd like to see that change just set the status to failed qa and let me know! -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14198] RDA: Indexing 264 field (Zebra)
by bugzilla-daemon＠bugs.koha-community.org 29 Jan '16

29 Jan '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14198 Nicole C. Engard <nengard(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15704 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15704 [Bug 15704] split up 264 index -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15298] z39.50 admin setup, options column suggested changes
by bugzilla-daemon＠bugs.koha-community.org 29 Jan '16

29 Jan '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15298 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |julian.maurice(a)biblibre.com --- Comment #7 from Julian Maurice <julian.maurice(a)biblibre.com> --- Patches pushed to 3.22.x, will be in 3.22.3 -- You are receiving this mail because: You are watching all bug changes.

1 0