October 2016 - Koha-bugs - lists.koha-community.org

[Bug 7679] Statistics wizard: circulation (new filters)
by bugzilla-daemon＠bugs.koha-community.org 26 Oct '16

26 Oct '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7679 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #56878|0 |1 is obsolete| | --- Comment #94 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 56888 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56888&action=ed… Bug 7679: Follow-up to fix group by hour Grouping by hour does not work with the collates. This patch removes them after talking to Julian on IRC. This partially reverts one of the earlier patches: Bug 7679: Display all table headers (case and accent sensitive) One could argue that this is more of a data problem, than something we should fix/'hide' with code. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7679] Statistics wizard: circulation (new filters)
by bugzilla-daemon＠bugs.koha-community.org 26 Oct '16

26 Oct '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7679 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #56877|0 |1 is obsolete| | --- Comment #93 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 56887 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56887&action=ed… Bug 7679 - Follow-up for terminology Patch changes "Library" to "Issuing library" and "Patron branch" to "Patron library". It also changes the text of the filters to match the terms and spelling on the form itself. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7679] Statistics wizard: circulation (new filters)
by bugzilla-daemon＠bugs.koha-community.org 26 Oct '16

26 Oct '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7679 --- Comment #92 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 56886 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56886&action=ed… [PASSED QA] Bug 7679: Display all table headers (case and accent sensitive) It appears that we can't assume that a lowercase word is equivalent to the same word in uppercase (or a mix of lowercase and uppercase letters). And this is also true about accented words. So display all values even if they differ only by case or by their accents. This means that: - "foobar" and "Foobar" will be in two separate rows/columns - "Etudiant" and "Étudiant" (french) will be in two separate rows/columns too Signed-off-by: Katrin Fischer <katrin.fischer(a)bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7679] Statistics wizard: circulation (new filters)
by bugzilla-daemon＠bugs.koha-community.org 26 Oct '16

26 Oct '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7679 --- Comment #91 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 56885 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56885&action=ed… [PASSED QA] Bug 7679: Various fixes for circulation statistics wizard - use SQL TRIM functions to avoid having '' and ' ' considered as different values - use Text::Unaccent to remove accents from columns or rows values when accessing %table. This is required as MySQL consider as equals two strings that differ only by their accents when using GROUP BY clause. - Exclude '' values from the list of columns or rows. Otherwise we could have a row 'UNKNOWN VALUE' and a row 'NULL' which both have the same values in their cells. Signed-off-by: Katrin Fischer <katrin.fischer(a)bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7679] Statistics wizard: circulation (new filters)
by bugzilla-daemon＠bugs.koha-community.org 26 Oct '16

26 Oct '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7679 --- Comment #90 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 56884 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56884&action=ed… [PASSED QA] Bug 7679: Fix two SQL queries when using patron attributes and remove some Perl warnings Signed-off-by: Katrin Fischer <katrin.fischer(a)bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7679] Statistics wizard: circulation (new filters)
by bugzilla-daemon＠bugs.koha-community.org 26 Oct '16

26 Oct '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7679 --- Comment #89 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 56883 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56883&action=ed… [PASSED QA] Bug 7679: Fix several bugs in circulation statistics wizard - Display values in NULL columns/rows - Display columns/rows that contain values only in NULL rows/columns - "To" filter in period row should be inclusive (YYYY-MM-DD should be YYYY-MM-DD 23:59:59) - Make it possible to use only the "To" filter in period row (actually it results in DBI error (2 bind variables instead of 1)) Signed-off-by: Katrin Fischer <katrin.fischer(a)bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7679] Statistics wizard: circulation (new filters)
by bugzilla-daemon＠bugs.koha-community.org 26 Oct '16

26 Oct '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7679 --- Comment #88 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 56882 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56882&action=ed… [PASSED QA] Bug 7679: Group different case values in the same row/column Signed-off-by: Katrin Fischer <katrin.fischer(a)bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7679] Statistics wizard: circulation (new filters)
by bugzilla-daemon＠bugs.koha-community.org 26 Oct '16

26 Oct '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7679 --- Comment #87 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 56881 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56881&action=ed… [PASSED QA] Bug 7679: Fix criteria display Signed-off-by: Katrin Fischer <katrin.fischer(a)bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7679] Statistics wizard: circulation (new filters)
by bugzilla-daemon＠bugs.koha-community.org 26 Oct '16

26 Oct '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7679 --- Comment #86 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 56880 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56880&action=ed… [PASSED QA] Bug 7679: Followup: circulation statistics wizard improvements Signed-off-by: Brendan <brendan(a)bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer(a)bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7679] Statistics wizard: circulation (new filters)
by bugzilla-daemon＠bugs.koha-community.org 26 Oct '16

26 Oct '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7679 --- Comment #85 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 56879 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56879&action=ed… [PASSED QA] Bug 7679: circulation statistics wizard improvements - Add patron branch to the list of possible rows, columns, and filters - Add extended patron attributes to the list of possible rows, columns, and filters - Allow to group period by hour - Allow to translate filter names NOTE: Removed signed off, since I believe I have dealt with the conflicts. Retesting required. Found some comments C4::Date that I missed. line prepatch 194/ postpatch 233 seems to be where the major conflict is. Signed-off-by: Katrin Fischer <katrin.fischer(a)bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.

1 0