October 2016 - Koha-bugs - lists.koha-community.org

[Bug 13321] Tax and prices calculation need to be fixed
by bugzilla-daemon＠bugs.koha-community.org 27 Oct '16

27 Oct '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13321 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #56431|0 |1 is obsolete| | --- Comment #103 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 56907 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56907&action=ed… Bug 13321: Update DBIx::Class schema files Signed-off-by: Sonia Bouis <koha(a)univ-lyon3.fr> Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13321] Tax and prices calculation need to be fixed
by bugzilla-daemon＠bugs.koha-community.org 27 Oct '16

27 Oct '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13321 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #56430|0 |1 is obsolete| | --- Comment #102 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 56906 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56906&action=ed… Bug 13321: Recalculate tax_value for partially received orders Test plan: 1. Create an order with at least 2 items 2. Receive only 1 item 3. Check that the tax value of the received order line is correct on the parcel and invoice pages 4. Check that the tax value of the original order line is correct (on the basket page for example) 5. Cancel the receipt 6. Check that the tax value of the original order line is correct Signed-off-by: Sonia Bouis <koha(a)univ-lyon3.fr> Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13321] Tax and prices calculation need to be fixed
by bugzilla-daemon＠bugs.koha-community.org 27 Oct '16

27 Oct '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13321 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #56429|0 |1 is obsolete| | --- Comment #101 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 56905 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56905&action=ed… Bug 13321: Add missing Price TT plugin in orderreceive.tt Signed-off-by: Sonia Bouis <koha(a)univ-lyon3.fr> Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13321] Tax and prices calculation need to be fixed
by bugzilla-daemon＠bugs.koha-community.org 27 Oct '16

27 Oct '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13321 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #56428|0 |1 is obsolete| | --- Comment #100 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 56904 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56904&action=ed… Bug 13321: Adds renaming of gstrate column in kohastructure.sql Signed-off-by: Sonia Bouis <koha(a)univ-lyon3.fr> Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13321] Tax and prices calculation need to be fixed
by bugzilla-daemon＠bugs.koha-community.org 27 Oct '16

27 Oct '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13321 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #56427|0 |1 is obsolete| | --- Comment #99 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 56903 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56903&action=ed… Bug 13321: Fix unitprice rounding We need to display the rounded value, but insert the exact value. The unit price can be change on receiving, so the input value can be modified. But if it's not, we must insert the exact (not rounded) unit price, which is the ecost value. Signed-off-by: Laurence Rault <laurence.rault(a)biblibre.com> Signed-off-by: Francois Charbonnier <francois.charbonnier(a)inlibro.com> Signed-off-by: Sonia Bouis <sonia.bouis(a)univ-lyon3.fr> Signed-off-by: Sonia Bouis <koha(a)univ-lyon3.fr> Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13321] Tax and prices calculation need to be fixed
by bugzilla-daemon＠bugs.koha-community.org 27 Oct '16

27 Oct '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13321 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #56426|0 |1 is obsolete| | --- Comment #98 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 56902 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56902&action=ed… Bug 13321: Csv export - Display rrp and ecost with and without taxes If a basketgroup is exported as a CSV file, both prices should be displayed to avoid confusion. Signed-off-by: Laurence Rault <laurence.rault(a)biblibre.com> Signed-off-by: Francois Charbonnier <francois.charbonnier(a)inlibro.com> Signed-off-by: Sonia Bouis <sonia.bouis(a)univ-lyon3.fr> Signed-off-by: Sonia Bouis <koha(a)univ-lyon3.fr> Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13321] Tax and prices calculation need to be fixed
by bugzilla-daemon＠bugs.koha-community.org 27 Oct '16

27 Oct '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13321 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #56425|0 |1 is obsolete| | --- Comment #97 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 56901 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56901&action=ed… Bug 13321: Tax and prices calculation - DB Changes This patch adds 7 columns to the aqorders table: * unitprice_tax_excluded * unitprice_tax_included * rrp_tax_excluded * rrp_tax_included * ecost_tax_excluded * ecost_tax_included * tax_value It also renames: * aqorders.gstrate with aqorders.tax_rate * aqbooksellers.gstrate with aqbooksellers.tax_rate The new columns are filled with the previous calculation method. Signed-off-by: Laurence Rault <laurence.rault(a)biblibre.com> Signed-off-by: Francois Charbonnier <francois.charbonnier(a)inlibro.com> Signed-off-by: Sonia Bouis <sonia.bouis(a)univ-lyon3.fr> Signed-off-by: Sonia Bouis <koha(a)univ-lyon3.fr> Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13321] Tax and prices calculation need to be fixed
by bugzilla-daemon＠bugs.koha-community.org 27 Oct '16

27 Oct '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13321 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #56424|0 |1 is obsolete| | --- Comment #96 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 56900 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56900&action=ed… Bug 13321: Fix the prices calculation method Well, we have finally arrived here \o/ The method where the prices are calculated uses the equations listed on the wiki page (http://wiki.koha-community.org/wiki/GST_Rewrite_RFC) The ecost is calculated from the rrp (using the discount and the tax rate). That's why we removed the ability to edit this value. That's why we remove the ability to edit the ecost on ordering in a previous commit (bug 12840). The total is now calculated in the scripts. That's why this patch removes lines in the test file. In C4::Acquisition::populate_order_with_prices, the calculation on receiving must depend on the 'invoiceincgst' supplier parameter, and not listincgst (which is used on ordering). It also removes the rounding errors, now we store "exact" values in DB (10^-6). The values will be displayed using the Price TT plugin it will round the values for us. Signed-off-by: Laurence Rault <laurence.rault(a)biblibre.com> Signed-off-by: Francois Charbonnier <francois.charbonnier(a)inlibro.com> Signed-off-by: Sonia Bouis <sonia.bouis(a)univ-lyon3.fr> Signed-off-by: Sonia Bouis <koha(a)univ-lyon3.fr> Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13321] Tax and prices calculation need to be fixed
by bugzilla-daemon＠bugs.koha-community.org 27 Oct '16

27 Oct '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13321 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #56423|0 |1 is obsolete| | --- Comment #95 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 56899 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56899&action=ed… Bug 13321: use the populate_with_prices where needed Now we need to calculate the prices (ecost, rrp, unitprice) and tax (tax_rate, tax_value) when the price is set for an order. This only appends in the 3 files impacted by this patch. addorder*.pl on ordering finishreceive.pl on receiving Signed-off-by: Laurence Rault <laurence.rault(a)biblibre.com> Signed-off-by: Francois Charbonnier <francois.charbonnier(a)inlibro.com> Signed-off-by: Sonia Bouis <sonia.bouis(a)univ-lyon3.fr> Signed-off-by: Sonia Bouis <koha(a)univ-lyon3.fr> Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13321] Tax and prices calculation need to be fixed
by bugzilla-daemon＠bugs.koha-community.org 27 Oct '16

27 Oct '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13321 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #56422|0 |1 is obsolete| | --- Comment #94 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 56898 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56898&action=ed… Bug 13321: Rename variables This patch renames the variable according to the new DB column names * gste => tax_excluded * gsti => tax_included * gstrate => tax_rate * gstvalue => tax_value This patch also modify the ModReceiveOrder subroutine: * Edit vendor note on receiving is not possible, so the code should not permit that. * Update ModReceiveOrder to pass a hashref And that's all! git grep on gste, gsti, gstrate and gstvalue should not return any code that can be executed. Signed-off-by: Laurence Rault <laurence.rault(a)biblibre.com> Signed-off-by: Francois Charbonnier <francois.charbonnier(a)inlibro.com> Signed-off-by: Sonia Bouis <sonia.bouis(a)univ-lyon3.fr> Signed-off-by: Sonia Bouis <koha(a)univ-lyon3.fr> Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0