October 2016 - Koha-bugs - lists.koha-community.org

[Bug 13345] Choose the format when sending a basket/list by email
by bugzilla-daemon＠bugs.koha-community.org 14 Oct '16

14 Oct '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13345 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47297|0 |1 is obsolete| | --- Comment #16 from Julian Maurice <julian.maurice(a)biblibre.com> --- Created attachment 56499 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56499&action=ed… Bug 13345: Allow patrons to choose format on sending basket/list by email It is already possible to download a basket(cart) or a list using different format. But by email, only iso2709 is possible. This patch adds the ability to select a format for the file attached to the email when sending the basket/list content. Test plan: 1/ At the OPAC, add some records to your basket and send it by email using different formats (RIS, BibTeX, MARC and the CSV profiles defined). 2/ At the OPAC, add some records to a list and send it by email using the different formats. 3/ Redo step 1 at the intranet 4/ Redo step 2 at the intranet Not that subtitles are not displayed in all these cases. Note for QA: This patch refactors 3 main things: 1/ Template side: the dropdown list to select the format is now in an include file (indeed, this list is used in 4 templates, this will make easier further changes). The include files are named 'download-export-available-formats.inc', feel free to suggest something better. The are used in: [opac-]sendbasket.tt, [opac-]sendshelf.tt, [opac-]downloadbasket.tt and [opac-]downloadshelf.tt. 2/ Build records data and the records file This job was done in 4 scripts: - opac/opac-sendbasket.pl - opac/opac-sendshelf.pl - basket/sendbasket.pl - virtualshelves/sendshelf.pl Now it's done in C4::Biblio::BuildBiblioDataForExport and tests are provided in t/db_dependent/Biblio/BuildBiblioDataForExport.t Not that a similar job is done in [opac-]downloadcart.pl and [opac-]downloadshelf.pl 3/ Build the subject and body of the email sent Same as before, the job was done at the same places. Now it's done in Koha::Email->fill_body_for_sending (feel free to suggestion a better name) and tests are provided in t/Koha_Email.t Sponsored-by: Mines Paristech Signed-off-by: Nicole C. Engard <nengard(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11217] The # in accountlines descriptions makes them un-writeoffable
by bugzilla-daemon＠bugs.koha-community.org 14 Oct '16

14 Oct '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11217 Brendan Gallagher <brendan(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |brendan(a)bywatersolutions.co | |m --- Comment #8 from Brendan Gallagher <brendan(a)bywatersolutions.com> --- Pushed to Master - Should be in the November 16.11 Release. Thanks! -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8835] Two indexes on biblioitems.issn
by bugzilla-daemon＠bugs.koha-community.org 14 Oct '16

14 Oct '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8835 Nicolas Legrand <nicolas.legrand(a)bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #56316|0 |1 is obsolete| | --- Comment #9 from Nicolas Legrand <nicolas.legrand(a)bulac.fr> --- Created attachment 56490 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56490&action=ed… Bug 8835: New db rev for issn_idx This db rev reapplies dbrev 3.15.00.049 in case that one failed due to existence of issn_idx. Test plan: If you do not have index issn_idx, recreate it: ALTER TABLE biblioitems ADD INDEX issn_idx (issn (255)) Run this db rev. You should see: Removed issn_idx. Rerun the dbrev. You should see: Everything is fine. Signed-off-by: Nicolas Legrand <nicolas.legrand(a)bulac.fr> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8835] Two indexes on biblioitems.issn
by bugzilla-daemon＠bugs.koha-community.org 14 Oct '16

14 Oct '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8835 Nicolas Legrand <nicolas.legrand(a)bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8835] Two indexes on biblioitems.issn
by bugzilla-daemon＠bugs.koha-community.org 14 Oct '16

14 Oct '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8835 Nicolas Legrand <nicolas.legrand(a)bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #56278|0 |1 is obsolete| | --- Comment #8 from Nicolas Legrand <nicolas.legrand(a)bulac.fr> --- Created attachment 56489 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56489&action=ed… Bug 8835: Drop issn_idx for completeness When dbrev 3.15.00.049 failed, the still existing issn_idx must have been the cause. This patch only adjusts the old db rev. Still thinking if we also need a new db rev to fix isbn and issn for those installs where 3.15.00.049 failed too. (In that case the fields may not have been changed to mediumtext and no indexes were added.) Test plan: Ideally, run an upgrade from something older than 3.15.00.49. But running the added sql command from the command line might convince you too. Signed-off-by: Nicolas Legrand <nicolas.legrand(a)bulac.fr> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10654] Add feature: export basket in CSV, list of custom formats for various vendors
by bugzilla-daemon＠bugs.koha-community.org 14 Oct '16

14 Oct '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10654 Silvia Simonetti <s.simonetti(a)cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|s.simonetti(a)cineca.it | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 5260] Add option to send an order by e-mail to the acquisition module
by bugzilla-daemon＠bugs.koha-community.org 14 Oct '16

14 Oct '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5260 Silvia Simonetti <s.simonetti(a)cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|s.simonetti(a)cineca.it | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 5260] Add option to send an order by e-mail to the acquisition module
by bugzilla-daemon＠bugs.koha-community.org 14 Oct '16

14 Oct '16

1 0

[Bug 5260] Add option to send an order by e-mail to the acquisition module
by bugzilla-daemon＠bugs.koha-community.org 14 Oct '16

14 Oct '16

1 0

[Bug 5260] Add option to send an order by e-mail to the acquisition module
by bugzilla-daemon＠bugs.koha-community.org 14 Oct '16

14 Oct '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5260 --- Comment #29 from Zeno Tajoli <z.tajoli(a)cineca.it> --- I take a look of code and for me is good. I undeline that we need to update the description of ClaimsBccCopy sys preference. With this patch it becames: "[... ] blind copy (BCC) to logged in user when sending an acquisition order my mail or a claim notices for serial or acquisitions.". -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.

1 0