October 2016 - Koha-bugs - lists.koha-community.org

[Bug 10858] Browse selected biblios
by bugzilla-daemon＠bugs.koha-community.org 14 Oct '16

14 Oct '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41839|0 |1 is obsolete| | --- Comment #94 from Julian Maurice <julian.maurice(a)biblibre.com> --- Created attachment 56479 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56479&action=ed… Bug 10858: Browse selected biblios After launching a search, some people would like to browse some results from several pages. This patch adds, at the OPAC, a link "Browse selected biblios >>" when at least one biblio is checked. You can choose biblios from several page, not the current one. In this way, checkboxes already checked become again checked when you come back on this results page. After clicking the link, the "Browse results" block is filled with selected biblios, not (like as the current behavior) with the classic results. Test plan: - Launch a search at the OPAC - Check some biblios - Go on another page - Check some biblios - Come back to the first page and check that already checked biblio is automatically checked. - Click on the "Browse selected biblios >>" link - Check that you are able to browse results you had checked. You can also: - check some biblios from several pages - add them to the cart - add them to a list Signed-off-by: Cedric Vita <cedric.vita(a)dracenie.com> Signed-off-by: Koha Team Amu <koha.aixmarseille(a)gmail.com> Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11700] C4::AuthoritiesMarc::merge enhancements/fixes
by bugzilla-daemon＠bugs.koha-community.org 14 Oct '16

14 Oct '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11700] C4::AuthoritiesMarc::merge enhancements/fixes
by bugzilla-daemon＠bugs.koha-community.org 14 Oct '16

14 Oct '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46402|0 |1 is obsolete| | --- Comment #65 from Julian Maurice <julian.maurice(a)biblibre.com> --- Created attachment 56474 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56474&action=ed… Bug 11700 [QA Followup] - Tidy merge a bit, fix warning triggered during unit tests Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11700] C4::AuthoritiesMarc::merge enhancements/fixes
by bugzilla-daemon＠bugs.koha-community.org 14 Oct '16

14 Oct '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46401|0 |1 is obsolete| | --- Comment #64 from Julian Maurice <julian.maurice(a)biblibre.com> --- Created attachment 56473 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56473&action=ed… Bug 11700: Add description to unit tests Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11700] C4::AuthoritiesMarc::merge enhancements/fixes
by bugzilla-daemon＠bugs.koha-community.org 14 Oct '16

14 Oct '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46400|0 |1 is obsolete| | --- Comment #63 from Julian Maurice <julian.maurice(a)biblibre.com> --- Created attachment 56472 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56472&action=ed… Bug 11700: Add unit tests for C4::AuthoritiesMarc::merge Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel(a)gmail.com> Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11700] C4::AuthoritiesMarc::merge enhancements/fixes
by bugzilla-daemon＠bugs.koha-community.org 14 Oct '16

14 Oct '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46399|0 |1 is obsolete| | --- Comment #62 from Julian Maurice <julian.maurice(a)biblibre.com> --- Created attachment 56471 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56471&action=ed… Bug 11700: Avoid to try to delete the authority twice Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel(a)gmail.com> Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11700] C4::AuthoritiesMarc::merge enhancements/fixes
by bugzilla-daemon＠bugs.koha-community.org 14 Oct '16

14 Oct '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700 --- Comment #61 from Julian Maurice <julian.maurice(a)biblibre.com> --- Created attachment 56470 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56470&action=ed… Bug 11700: C4::AuthoritiesMarc::merge enhancements/fixes - Returns the list of modified biblio records - Retrieve MARC records from DB if not given in parameters - Delete source authority if source and destination records are different Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel(a)gmail.com> Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11700] C4::AuthoritiesMarc::merge enhancements/fixes
by bugzilla-daemon＠bugs.koha-community.org 14 Oct '16

14 Oct '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46397|0 |1 is obsolete| | Attachment #46398|0 |1 is obsolete| | --- Comment #60 from Julian Maurice <julian.maurice(a)biblibre.com> --- Created attachment 56469 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56469&action=ed… Bug 11700: C4::AuthoritiesMarc::merge enhancements/fixes Indentation and whitespace fixes Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel(a)gmail.com> Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14736] AllowRenewalIfOtherItemsAvailable slows circulation down in case of a record with many items and many holds
by bugzilla-daemon＠bugs.koha-community.org 14 Oct '16

14 Oct '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14736 Jesse Maseto <jesse(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #54813|0 |1 is obsolete| | --- Comment #2 from Jesse Maseto <jesse(a)bywatersolutions.com> --- Created attachment 56463 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56463&action=ed… Bug 14736 - AllowRenewalIfOtherItemsAvailable slows circulation down in case of a record with many items and many holds If the AllowRenewalIfOtherItemsAvailable sys pref is set to allow, and a borrower has an item checked out that has many items {30+} AND many holds {70+) on it, loading the checkouts table for this borrower takes FOREVER to load. The load time takes forever, because of the factoring that happens to determine if an item is truly available for renewal. This patch swaps the use of GetMemberDetails for GetMember and reorders the subroutine calls to check each items' renewability from fastest to slowest. In a test case, the results of pre patch were: Start of loop: 2016-08-24T11:05:14 End of loop: 2016-08-24T11:05:29 Resulting in 15 seconds being spent in the loop Post patch results were: Start of loop: 2016-08-24T11:08:43 End of loop: 2016-08-24T11:08:48 Resulting in only 5 seconds being spent in the loop! Test Plan: 1) Apply this patch 2) Note there are no changes in functionality for the renewals column of the patron checkouts table. If you wish to go further and test the performance benefit: 1) Create a record with 50 items and 100 holds ( 50 waiting, 50 unfilled ) 2) Check out one of the waiting holds to a patron 3) Time the amount of time it takes for the checkouts table to load 4) Apply this patch 5) Repeat step 3, you should see an improvement in load time Signed-off-by: Jesse Maseto <jesse(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14736] AllowRenewalIfOtherItemsAvailable slows circulation down in case of a record with many items and many holds
by bugzilla-daemon＠bugs.koha-community.org 14 Oct '16

14 Oct '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14736 Jesse Maseto <jesse(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0